Field 'Selector........' (mq.inq.sel) has a conflicting entry in its value_string: 2002 is at indices 221 (MQCA_BASE_Q_NAME) and 222 (MQCA_BASE_OBJECT_NAME))
Change-Id: Ie81b58bf9c32ea38ff5d0808accdd8e9dac3b81a
Reviewed-on: https://code.wireshark.org/review/21453
Reviewed-by: Michael Mann <mmann78@netscape.net>
Field 'SAM Mode' (pn532.sam.mode) has a conflicting entry in its value_string: 3 is at indices 2 (Wired Card Mode) and 3 (Dual Card Mode))
Change-Id: I5ee07aff43e2f5ba7a2757057a0da80e2f747541
Reviewed-on: https://code.wireshark.org/review/21455
Reviewed-by: Michael Mann <mmann78@netscape.net>
Field 'Trace Kind' (nettl.kind) has a conflicting entry in its value_string: 536870912 is at indices 2 (Incoming PDU - PDUIN) and 3 (PDUIN))
Field 'Trace Kind' (nettl.kind) has a conflicting entry in its value_string: 268435456 is at indices 4 (Outgoing PDU - PDUOUT) and 5 (PDUOUT))
Change-Id: I14d47225a4ae83b6667313e5c0ca13e4d4d64831
Reviewed-on: https://code.wireshark.org/review/21452
Reviewed-by: Michael Mann <mmann78@netscape.net>
Field 'padata-type' (kerberos.padata_type) has a conflicting entry in its value_string: 1 is at indices 1 (kRB5-PADATA-TGS-REQ) and 2 (kRB5-PADATA-AP-REQ))
Field 'padata-type' (kerberos.padata_type) has a conflicting entry in its value_string: 15 is at indices 15 (kRB5-PADATA-PK-AS-REP-19) and 16 (kRB5-PADATA-PK-AS-REQ-WIN))
Field 'padata-type' (kerberos.padata_type) has a conflicting entry in its value_string: 20 is at indices 21 (kRB5-PADATA-USE-SPECIFIED-KVNO) and 22 (kRB5-PADATA-SVR-REFERRAL-INFO))
Change-Id: I504291b8eb181c9e40d54421f583755cfc4f17db
Reviewed-on: https://code.wireshark.org/review/21454
Reviewed-by: Michael Mann <mmann78@netscape.net>
Field 'Error' (qsig.error) has a conflicting entry in its value_string: 43 is at indices 12 (proceduralError) and 42 (notActivated))
Change-Id: Ic1468f32922644933a79db504a4ecfb6e2289bd2
Reviewed-on: https://code.wireshark.org/review/21457
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Bug: 13599
Change-Id: If85588099d7c6635865614f8778a903a5e971789
Reviewed-on: https://code.wireshark.org/review/21410
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Dissect the PLCP headers in a bit more detail, and use bit fields. Use
common code.
Change-Id: I8711cba71894bebf94f17fdba98b28cc7a620f81
Reviewed-on: https://code.wireshark.org/review/21448
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Also, use #defines for the PLCP type, and add some comments about the
PLCP format, and fill in the "short GI" flag from the PLCP header.
Change-Id: Ia3c44cc12feb87c181783e9dc37fe0877d1e2a81
Reviewed-on: https://code.wireshark.org/review/21441
Reviewed-by: Guy Harris <guy@alum.mit.edu>
If we're fetching a value only to use it in proto_tree_add_uint(), we
might as well just use proto_tree_add_item().
Change-Id: I504c54f972b2844f57f25c9ffc89c142c8dc495f
Reviewed-on: https://code.wireshark.org/review/21440
Reviewed-by: Guy Harris <guy@alum.mit.edu>
We're not doing any CRC stuff here - that's the job of the 802.11
dissector, which does it Just Fine - so remove what remains of the stuff
for it.
Change-Id: If6a0113dec7773b3b4daa7fa014f02c6a97eca0d
Reviewed-on: https://code.wireshark.org/review/21433
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Always set log_mode - if the command type is 3, set log_mode to 0, as
it's not supplied by the libwiretap code.
Pass log_mode and is_octo from dissect_ixveriwave() to
wlantap_dissect(). Test is_octo in wlantap_dissect(), just as we do in
dissect_ixveriwave().
Change-Id: I536ca59f01e644d55e541df6d2e119db590ae48a
Reviewed-on: https://code.wireshark.org/review/21432
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Suppress Ubuntu warning
Change-Id: Ia95e19d59b768b6842ca58051ffbd97dce84174c
Reviewed-on: https://code.wireshark.org/review/21426
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Uli Heilmeier <openid@heilmeier.eu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Change-Id: Idad8f7eeed968eeed9f553fef98d58453f328afb
Reviewed-on: https://code.wireshark.org/review/21421
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Tested-by: Michael Mann <mmann78@netscape.net>
Set its type accordingly.
Change-Id: I3f80828d9e248235db6f4b30f02ada6b6786d25a
Reviewed-on: https://code.wireshark.org/review/21419
Reviewed-by: Guy Harris <guy@alum.mit.edu>
For Ethernet, the FCS is absent; for 802.11, the Series I and II
hardware doesn't provide an FCS, but the Series III hardware appears to.
Get rid of the flag bit, and a bunch of other dead code (probably
inherited by copy-and-paste).
Change-Id: I44301c8211c25a5665eb528ac657925931d3f0b4
Reviewed-on: https://code.wireshark.org/review/21418
Reviewed-by: Guy Harris <guy@alum.mit.edu>
The "sent/received during CFP", "sent/received with fragmentation" and
"frame has padding between 802.11 header and payload" flag bits are
never set by wiretap/vwr.c, so don't test them. They're copied over
from radiotap, but this is *not* radiotap.
Also, get rid of a bunch of unused #defines, and one instance of a
duplicate #define. Again, they're copied over from radiotap, but this
is *not* radiotap.
Change-Id: I1d62e6400fb21c40512005d88cbc06d8576e8183
Reviewed-on: https://code.wireshark.org/review/21416
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Add some comments while we're at it.
Change-Id: I87f97ab640d9a02c01923867d3d3b91e755d0e40
Reviewed-on: https://code.wireshark.org/review/21413
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Change-Id: I71b4d3c8f22c32f1aaf89f147bc6a20ce54aec4d
Reviewed-on: https://code.wireshark.org/review/21409
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
To enhance the possibility for dissections, add a list
of nodes, you explicitly want to see and print an info
text in the node list for all nodes filtered
Change-Id: I08e8a7ddcfd7b78fee24431ffdae75124a8ecddd
Reviewed-on: https://code.wireshark.org/review/21383
Reviewed-by: Roland Knall <rknall@gmail.com>
Field 'Country' (dis.country) has a conflicting entry in its value_string: 107 is at indices 106 (Cote D'Ivoire (aka Ivory Coast)) and 107 (Ivory Coast (aka Cote D'Ivoire)))
Field 'Country' (dis.aggregate.country) has a conflicting entry in its value_string: 107 is at indices 106 (Cote D'Ivoire (aka Ivory Coast)) and 107 (Ivory Coast (aka Cote D'Ivoire)))
Change-Id: Iabc2fafae5d756ff0cdfb4d16a8751b573378f06
Reviewed-on: https://code.wireshark.org/review/21396
Reviewed-by: Michael Mann <mmann78@netscape.net>
Field 'Service Code' (cipm.svc.code) has a conflicting entry in its value_string: 83 is at indices 30 (Run Hookup Test) and 31 (Get Hookup Test Data))
Change-Id: I3d650b0a6aeacb8e992126a7008e0b256cf1fe94
Reviewed-on: https://code.wireshark.org/review/21395
Reviewed-by: Michael Mann <mmann78@netscape.net>
Ping-Bug: 13592
Change-Id: Ie07033972943ef38ca88bc0e82463ebccd281ce2
Reviewed-on: https://code.wireshark.org/review/21354
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Change-Id: I69e0d9abc8e2fccf2837bf7dee52480063f11193
Reviewed-on: https://code.wireshark.org/review/21366
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
It does what it says on the label. You get back TRUE or FALSE in a
gboolean.
While we're at it, remove a copied-and-pasted comment that doesn't
apply, and update another comment.
Change-Id: I117391d2ffe44124a614a7f64dad1b389c1ebc6a
Reviewed-on: https://code.wireshark.org/review/21394
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Field 'Message code' (ipdc.message_code) has a conflicting entry in its value_string: 255 is at indices 3 (SS -> GW: MRJ: Message reject.) and 32 (GW -> SS: MRJ: Message reject.))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its value_string: 17 is at indices 17 (SS -> GW: RCR: Release channel request) and 45 (GW -> SS: RCR: Release channel request))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its value_string: 18 is at indices 18 (SS -> GW: ACR: Release channel complete) and 46 (GW -> SS: ACR: Release channel complete))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its value_string: 125 is at indices 23 (SS -> GW: RTE: Request Test Echo) and 52 (GW -> SS: RTE: Request Test Echo))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its value_string: 126 is at indices 24 (SS -> GW: ARTE: Response to Request Test Echo) and 53 (GW -> SS: ARTE: Response to Request Test Echo))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its value_string: 121 is at indices 25 (SS -> GW: NATV: Native Mode Q.931 Signaling Transport) and 54 (GW -> SS: NATV: Native Mode Q.931 Signaling Transport))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its value_string: 122 is at indices 26 (SS -> GW: TUNL: Tunneled Transport of signaling protocol data units) and 55 (GW -> SS: TUNL: Tunneled Transport of signaling protocol data units))
Field 'Message code' (ipdc.message_code) has a conflicting entry in its value_string: 122 is at indices 26 (SS -> GW: TUNL: Tunneled Transport of signaling protocol data units) and 55 (GW -> SS: TUNL: Tunneled Transport of signaling protocol data units))
Change-Id: I2d679f01ff9ddb6618ebd7212d1d7789045b434c
Reviewed-on: https://code.wireshark.org/review/21378
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Bug: 13341
Change-Id: Ide9c9a08b73e97ddb716fd307800f58efb9bcb0e
Reviewed-on: https://code.wireshark.org/review/19739
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Change-Id: Ic5bd9afc2af14a64d074d598f1e185252308008b
Reviewed-on: https://code.wireshark.org/review/21357
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Field 'Positioning Method' (lcsap.pos_method) has a conflicting entry in its value_string: 15 is at indices 15 (Reserved for other location technologies) and 31 (Reserved for network specific positioning methods))
Change-Id: If0db3d7466924da82e1307717b79dd3e4c2bdf6e
Reviewed-on: https://code.wireshark.org/review/21382
Reviewed-by: Michael Mann <mmann78@netscape.net>
Field 'Type' (dsr.option.err.type) has a conflicting entry in its value_string: 129 is at indices 3 (Unknown flow) and 4 (Default flow unknown))
Change-Id: I06e31b9dd5f4887d2590a8dc0efa6d6706a5aff7
Reviewed-on: https://code.wireshark.org/review/21377
Reviewed-by: Michael Mann <mmann78@netscape.net>
Field 'H.225 Manufacturer' (h225.Manufacturer) has a conflicting entry in its value_string: 67108994 is at indices 3 (Siemens AG) and 13 (SITK Institut fuer Telekommunikation GmbH & Co KG))
Field 'H.245 Manufacturer' (h245.Manufacturer) has a conflicting entry in its value_string: 67108994 is at indices 3 (Siemens AG) and 13 (SITK Institut fuer Telekommunikation GmbH & Co KG))
Change-Id: I6b08ffce5e8335be0f31dda0a9530afef2950f09
Reviewed-on: https://code.wireshark.org/review/21379
Reviewed-by: Michael Mann <mmann78@netscape.net>
WARNING **: Field 'Rx STBC' (wlan.vht.capabilities.rxstbc) has a conflicting entry in its value_string: 2 is at indices 2 (1 to 2 Spatial Stream Supported) and 5 (160MHz and 80+80 Supported))
Change-Id: I7b94a88d8b12b3c0e485d0cade0e9918668a7342
Reviewed-on: https://code.wireshark.org/review/21380
Reviewed-by: Michael Mann <mmann78@netscape.net>
- Change title of IE subtree
- extract dissect_802154_enhanced_beacon_filter
- Adding reference to the IEEE 802.15.4 standard
- fix Typo
- Explicit case of header termination
Change-Id: Ia18d8d0345e2bac5ef16057e7c3cf08e4341060a
Reviewed-on: https://code.wireshark.org/review/21187
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Just like proto_tree_add_item_ret_uint, but with 64-bit support
Change-Id: Ie0cbfda9e63bf21e85df2d674e391a6c0abe92f7
Reviewed-on: https://code.wireshark.org/review/21355
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Make Dissector.get("m2ua"):call() work from within lua. So far
only m3ua, m2pa were exported to other dissectors.
Change-Id: I3350c3f4b2614fa07254306464c5fdffbadd4f3b
Reviewed-on: https://code.wireshark.org/review/21351
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>