Commit Graph

3183 Commits

Author SHA1 Message Date
Anders Broman 47b86c517e Bugfix: Dissect BAT ASE Signal IE properly.
svn path=/trunk/; revision=17428
2006-02-28 17:01:29 +00:00
Anders Broman 204212aeff From Peter Johansson:
fixes the following compilation warnings (and 
potential problems that may otherwise follow).

packet-per.c(796) : warning C4047: 'function' : 'struct _proto_node ** ' 
differs in levels of indirection from 'struct _proto_node *'
packet-per.c(796) : warning C4024: 'dissect_per_boolean' : different 
types for formal and actual parameter 7
packet-per.c(796) : warning C4700: local variable 'pi' used without 
having been initialized

svn path=/trunk/; revision=17427
2006-02-28 17:00:31 +00:00
Ronnie Sahlberg b47ccd7bb9 mark a few generated fields as generated using PROTO_ITEM_SET_GENERATED
svn path=/trunk/; revision=17426
2006-02-28 10:10:08 +00:00
Ronnie Sahlberg 590d27a8c0 add new dissect_ber_integer64() that can handle 8,16,24,32 and 64bit integers.
use proto_tree_add_[u]int[8,16,24,32,64]() instread of proto_tree_add_item()
since BER integers may well be encoded in less bytes than the type requires.
(i do not think the old code with proto_tree_add_item() could have handleded negative values very well    or at all.)




svn path=/trunk/; revision=17425
2006-02-28 09:39:53 +00:00
Gerald Combs 38a305bbfb Properly terminate a value string. Fixes a current Buildbot complaint.
svn path=/trunk/; revision=17422
2006-02-27 15:39:08 +00:00
Anders Broman 21a8f186bb from dieder:
packet-x11
copy and past overlooked? test with 8 but substract to 4.

svn path=/trunk/; revision=17420
2006-02-27 09:02:16 +00:00
Anders Broman d49c777b71 Add extention bit if per internal fields shown.
svn path=/trunk/; revision=17417
2006-02-27 08:35:24 +00:00
Jaap Keuter 32dfb9b404 Fix bounds error.
svn path=/trunk/; revision=17412
2006-02-25 13:54:00 +00:00
Anders Broman aeb971fa5d From Martin Mathieson:
This patch further tightens up testing for resent packets.
It now always compares the method.  I've seen examples where the called 
party hangs up, and chooses the same CSeq for the BYE as the calling 
party chose for the INVITE.

svn path=/trunk/; revision=17408
2006-02-25 09:23:10 +00:00
Jaap Keuter 83f28ac9f5 Fix bug 765. ARMBER -> AMBER
svn path=/trunk/; revision=17394
2006-02-23 22:09:54 +00:00
Ronnie Sahlberg 826f6ede9a The task management flags in FCP are very useful to display since they convey that something real bad has happened.
Therefore put them and fence them at the start of the Info column



svn path=/trunk/; revision=17393
2006-02-23 22:03:55 +00:00
Anders Broman 030c5b422e From Alejandro Vaquero:
a patch for the VoipCalls to fix a couple of issues:
- a problem with the RTP Events (RFC2833) not been handle correctly
- Display the RTP stream in time order when the setup frame is after the 
RTP stream.
- fix a init issue that caused the H245 packet to not been displayed 
correctly.

svn path=/trunk/; revision=17385
2006-02-23 20:03:42 +00:00
Anders Broman 1fd7fbdb1d From Alejandro Vaquero:
a patch for the VoipCalls to fix a couple of issues:
- a problem with the RTP Events (RFC2833) not been handle correctly
- Display the RTP stream in time order when the setup frame is after the 
RTP stream.
- fix a init issue that caused the H245 packet to not been displayed 
correctly.

svn path=/trunk/; revision=17383
2006-02-23 20:02:23 +00:00
Jaap Keuter b678c64c5a Fix for bug 762. Decode either LED function or off duration.
svn path=/trunk/; revision=17380
2006-02-23 11:56:18 +00:00
Ronnie Sahlberg 19078b5404 add an expansion to ethernet source and destination addresses
inside this expansion show
1,    eth.addr      so people can see that this field exists (i think it is futile to use "hidden" fields and expect people to search through the infinitely long list of fields,   better show everything and they will see themself what fuields they can filter on)
2,  bit 0x01 of the first byte to show if it is Multi or Uni-cast
3, bit 0x02 of the first byte to show if it is a locally administrated address or not.
I do use the (to laymen) more descriptive names  "factory default"    instead of LocallyAdminAddr in the true_false string though.




 

svn path=/trunk/; revision=17378
2006-02-23 09:54:08 +00:00
Ronnie Sahlberg ae52099756 fix for bug 718
dont play games with lnk_t
If the preference is set to unconditionally dissect everything as docsis   just call the docsis handler directly.



svn path=/trunk/; revision=17377
2006-02-23 09:11:00 +00:00
Anders Broman 34a28fae17 Add TCAP ssn
svn path=/trunk/; revision=17376
2006-02-23 06:35:45 +00:00
Anders Broman 31424b15fb Desegment DT1 messages.
svn path=/trunk/; revision=17372
2006-02-22 16:25:29 +00:00
Ronnie Sahlberg 8cf12717d5 make the old style SNMP dissector handle 64 bit integers better
fixes bug 723


svn path=/trunk/; revision=17369
2006-02-22 10:45:23 +00:00
Ronnie Sahlberg 2be120fb96 make IPP treat all fields with the name '*-time' and being 4 byte integers
as if they are unix 32 bit timestamps and display them as such.


this fixes bug 755


svn path=/trunk/; revision=17368
2006-02-22 09:53:22 +00:00
Ronnie Sahlberg 5ddde8e4fe from kirby files
ppp/bpdu update


svn path=/trunk/; revision=17367
2006-02-22 08:39:06 +00:00
Jaap Keuter f459143fb4 Fix for bug 758: Adding facility codes 12-15 according to RFC 3164
svn path=/trunk/; revision=17361
2006-02-21 21:30:27 +00:00
Jaap Keuter 335a8e2831 Fix for bug 724: DNS dissector fails in handling the sign of Altitude in LOC type response (RFC1867)
svn path=/trunk/; revision=17358
2006-02-21 08:14:11 +00:00
Anders Broman 8e03852501 From Balint Reczey (IJ/ETH)
> The included patch fixes BFD version detection in the BFD packet 
> dissector and extends it to correctly dissect version 1 packets. The 
> Authentication Section part of the packet is still not dissected.
> 

svn path=/trunk/; revision=17357
2006-02-20 17:21:47 +00:00
Anders Broman 25c4c078ad From Sake Blok:
Add a filter for X-Forwarded-For.

svn path=/trunk/; revision=17356
2006-02-20 06:25:02 +00:00
Anders Broman 74dd581db8 Remove c++ style comment.
svn path=/trunk/; revision=17352
2006-02-19 10:17:07 +00:00
Jaap Keuter 88e3b88e84 Fix for bug 752:
IEEE802.3ah-2004 (OAM) Errored Frame Seconds Summary Event TLV is not being
decoded properly.  Per IEEE802.3ah-2004 section 57.5.3.4, item g, the Error
Running Total field should be 4-octets however Ethereal is trying to decode this
field as 8-octets which results in incorrect value reported for "Error Running
Total" and "Event Running Total".

svn path=/trunk/; revision=17351
2006-02-19 09:54:37 +00:00
Anders Broman 06d6295287 From Florent.Drouin@alcatel.fr
Add the same workaround used in packet-ftam.c for the bad handling of the asn "IMPLICIT SEQUENCE", in the packet-gsm_map-template.c. This patch concerns Map V3 messages, not correctly decoded with the previous workaround "offset=offset+2".

Change a parameter for Provide Roaming Number decoding.

Add a decoding fonction for "Channel needed" parameter to avoid a decoding error for Paging messages
with a change to actually dissct channel needed.

svn path=/trunk/; revision=17350
2006-02-18 23:29:51 +00:00
Gerald Combs d3f60e495b Don't try to fill in last_dn if it doesn't exist. Fixes the current Buildbot
failure.

svn path=/trunk/; revision=17337
2006-02-17 16:35:45 +00:00
Anders Broman 7649797b88 Dissect the rest of the IE:s
svn path=/trunk/; revision=17334
2006-02-17 15:41:00 +00:00
Jörg Mayer 377e6e2e27 Paolo Abeni:
pinfo->net_src and pinfo->net_dst where used to set up conversation, but
this fields are null on eap stream. use pinfo->src and pinfo->dst
instead.
The patch also enable strict checking in the 'follow ssl stream' dialog.


svn path=/trunk/; revision=17333
2006-02-17 11:56:52 +00:00
Guy Harris c922673498 Squelch some compiler warnings.
Fix indentation.

svn path=/trunk/; revision=17331
2006-02-17 10:03:34 +00:00
Anders Broman a8a87c92b9 Add dissection of all Signals and more IE:s
svn path=/trunk/; revision=17322
2006-02-16 18:26:04 +00:00
Jörg Mayer 35e1e1abe4 Paolo Abeni:
The attached patch should fix bug 742.
The issue is (at least, I think so...) in the packet-x509af dissector
A null pointer is passes as parameter of a " %s " format string.


svn path=/trunk/; revision=17317
2006-02-16 11:47:16 +00:00
Guy Harris b13f6dcbd3 Use the new "proto_tree_add_*_format_value" routines.
svn path=/trunk/; revision=17316
2006-02-16 11:43:38 +00:00
Jörg Mayer 5a482871f3 Jerry Talkington:
Here's a tiny patch that will allow for dissecting of chunked coded HTTP
responses when there is an extension or trailing whitespace in the
Transfer-Encoding: header.


svn path=/trunk/; revision=17314
2006-02-15 23:30:41 +00:00
Gerald Combs 7353fadc50 Make sure SSL_DEBUG_USE_STDERR is always defined.
svn path=/trunk/; revision=17303
2006-02-14 18:52:26 +00:00
Jörg Mayer 461b6d35ee Paolo Abeni:
- enable the 'follow SSL stream' menu item only when a ssl packet is selected.
- when 'following' an ssl stream, show ssl decrypted data only for current conversation.
- fix a typo in ssl preference description.


svn path=/trunk/; revision=17301
2006-02-14 14:53:03 +00:00
Jörg Mayer a6d35abcae Make the files at least compile. While testing them as plugins they
caused tethereal to abort during startup.

svn path=/trunk/; revision=17288
2006-02-13 22:08:36 +00:00
Jörg Mayer 924cd79279 Add original files for oracle dissection from the ClearSight
archive.

svn path=/trunk/; revision=17287
2006-02-13 21:54:42 +00:00
Gerald Combs e455cea864 Remove a couple of unused variables.
svn path=/trunk/; revision=17283
2006-02-13 20:10:23 +00:00
Anders Broman 4621cc9150 From Mike Duigou:
- Improves ability of dissector to find conversations without seeing 
whole stream.

- Fixes some issues with dissection of data which requires reassembly.

- Adds the ability to dissect jxta conversations from SCTP streams.

- Better handling of welcome message.

- Adds direct dissection of compressed SRDI data.

- Has been run through extensive fuzz testing.

- Fixes compiler warnings with previous patch 17141

svn path=/trunk/; revision=17282
2006-02-13 19:45:38 +00:00
Jörg Mayer 36bad901af Paolo Abeni
the attached patch fix a couple of possible memory leak in the ssl
decryption code, add some indentation fix, more comments and add the
preference to select the debug output (missing in previous patch)



svn path=/trunk/; revision=17281
2006-02-13 17:06:41 +00:00
Lars Roland 3aebb783ff fuzz testing revealed that an infinite loop in the uma dissector was only partly fixed in revision 17119.
This will fix the infinite loop and bug 738.

svn path=/trunk/; revision=17273
2006-02-12 14:29:41 +00:00
Ronnie Sahlberg a1c15f7ab2 add rfc1964 stuff and (incomplete) KRB_CRED support.
KRB_CRED does not currently even try to decrypt EncKrbCredPart   but it is better than no KRB_CRED dissection at all.



svn path=/trunk/; revision=17272
2006-02-12 13:18:48 +00:00
Jörg Mayer b55002ab8d Paolo Abeni:
The attached patch cleanup the debug infrastructure for ssl dissector.
Debug messages are by default off and can be enabled via the ssl
dissector preference. Debug output can be directed to stderr or file.


svn path=/trunk/; revision=17253
2006-02-11 13:41:17 +00:00
Guy Harris 83aad499b4 Squelch some compiler warnings.
svn path=/trunk/; revision=17250
2006-02-11 09:54:10 +00:00
Guy Harris b912db17b3 Squelch some compiler warnings by declaring RADIUS AVP dissectors to
return pointers to const strings.

svn path=/trunk/; revision=17249
2006-02-11 09:50:11 +00:00
Luis Ontanon 009b5f7d29 From ENDOH Akira:
Add heuristic dissection of XML to SIP bodies with unknown media_type.


svn path=/trunk/; revision=17247
2006-02-11 00:13:23 +00:00
Ronnie Sahlberg f535b4cba1 tcp analysis
RST segments should not be checked for and not marked as
PREVIOUS_SEGMENT_LOST


svn path=/trunk/; revision=17246
2006-02-10 22:24:21 +00:00
Anders Broman e8978fda03 From Paolo Abeni:
The attached patch fix bug 732.
 The problem was in the client key dissection. On ssl v3 the encrypted
 data is the whole record data, on tls v1 the encrypted data is preceded
 by the 2 bytes length of the encrypted data itself.

svn path=/trunk/; revision=17244
2006-02-10 13:20:11 +00:00
Tim Potter 5b3f1c2030 ASF messages are in big-endian byte order, not little. From Alert
Standard Format Specification, v2.0, p.51.

svn path=/trunk/; revision=17242
2006-02-10 04:45:32 +00:00
Ulf Lamping 48c4f86c90 fix# 733: don't crash on unknown msg_types
svn path=/trunk/; revision=17235
2006-02-09 21:02:02 +00:00
Gerald Combs bed77708fe Re-enable the PacketCable RADIUS code and add a few EM updates.
Sponsored by CableLabs.

svn path=/trunk/; revision=17233
2006-02-09 20:24:57 +00:00
Gerald Combs 243fb39067 Add PacketCable Multimedia updates. Sponsored by CableLabs.
svn path=/trunk/; revision=17232
2006-02-09 19:41:20 +00:00
Gerald Combs a00e7fb4fb ntp_fmt_ts() doesn't take two arguments any more.
svn path=/trunk/; revision=17231
2006-02-09 19:22:15 +00:00
Gerald Combs 1602ca0715 Add support for PacketCable CCC-encapsulated RTP data, described in
PKT-SP-ESP1.5-I01-050128.

Sponsored by CableLabs.

svn path=/trunk/; revision=17230
2006-02-09 17:42:42 +00:00
Gerald Combs acfe071eb6 Add decryption support. For this to work, you MUST link against
the Nettle library and specify a Pluto log file in the preferences.
The Pluto log MUST include the encryption key used in each phase.

Add filters for many fields (and get rid of a lot of
proto_tree_add_text()s in the process).

Fix up whitespace.

Sponsored by CableLabs.

svn path=/trunk/; revision=17229
2006-02-09 17:32:14 +00:00
Luis Ontanon 0bb1b874ec Add heuristic dissection of XML
svn path=/trunk/; revision=17228
2006-02-09 13:05:32 +00:00
Jörg Mayer 7b5cf64016 Hannes Gredler:
attached a patch that supports filtering for
Juniper's meta information prepended
before packets (logical encapsulation, ifd index etc.)

Me:

declare juniper_ext_get_tlv_value static

svn path=/trunk/; revision=17226
2006-02-09 09:15:21 +00:00
Jörg Mayer caad611a07 Olivier Montanuy:
This is a simple patch to the Netflow v9 dissector, that let it decode
Netflow v9 MPLS-Aware, a feature of Cisco 12000 IOS 12.0.24S and above
on Cisco 12000, 7500 and 7200 that is very useful for MPLS-VPN networks.


svn path=/trunk/; revision=17225
2006-02-09 09:11:06 +00:00
Gerald Combs 6f4dd2267c Add support for PacketCable option 60/suboption 5.23. Sponsored by
CableLabs.

svn path=/trunk/; revision=17219
2006-02-08 23:09:17 +00:00
Jörg Mayer 1174fe71e7 Paolo Abeni:
the attached patch clean a bit the ssl decryption related code, removing
a macro I used when the code was still for an external plugin.


svn path=/trunk/; revision=17217
2006-02-08 12:45:14 +00:00
Ronnie Sahlberg 6fcf2d8c66 smb2:
if the secblob starts with 'NTLMSSP'   call the ntlmssp handle directly and not the gssapi one

ntlmssp:
dont change offset when dissecting a client_time,   offset will be changed properly later outside the switch.



svn path=/trunk/; revision=17215
2006-02-08 08:48:23 +00:00
Ronnie Sahlberg 3cb23ec4f8 smb2 signing
add dissection of the "Signature present" bit
and the 16 byte signature field in the header


svn path=/trunk/; revision=17206
2006-02-07 21:30:21 +00:00
Anders Broman 250a701144 Newlines in preference comments causes problems in reading the prefeerence file.
svn path=/trunk/; revision=17205
2006-02-07 19:31:54 +00:00
Anders Broman b7cff15f97 Packet-bssap.c - Dissect BCD coded IE:s
Packet-g723.c - B0 and B1 should be treated together.
packet-tipc.c - Change desgementation code to handle more than 2 segments.

svn path=/trunk/; revision=17204
2006-02-07 19:29:51 +00:00
Ronnie Sahlberg 4df342823a add the CLIENT_TIME ntlmv2 addr name type
svn path=/trunk/; revision=17203
2006-02-07 12:50:58 +00:00
Ronnie Sahlberg dd2f806e15 handmerged patch from metze it conflicted with recent P bit patch i checked in
svn path=/trunk/; revision=17202
2006-02-07 12:01:34 +00:00
Ronnie Sahlberg c35dfab4e9 rename Logoff to SessionLogoff to make it consistent with
TreeConnect/TreeDisconnect



svn path=/trunk/; revision=17201
2006-02-07 11:32:10 +00:00
Jörg Mayer 83068a9b9d Paolo Abeni:
>There is still an issue into the HAVE_LIBGNUTLS macro definition. I'm
>fixing it and cleaning a bit the windows side configuration. I hope to
>post soon the fix.


The attached patch should fix the issue. I missed to modify the
config.win32 file and I misstyped a few macros name.


svn path=/trunk/; revision=17200
2006-02-07 10:26:20 +00:00
Ronnie Sahlberg 5036c5cc54 add dissection of the P (PID Valid) bit in the header
If the P bit is NOT set, then flag the PID field as "(not valid)"
Sicne the TID might be undefined/0 in the response to a "pending" read
we cant use that solely to determine if a read was for a named/pipe (==dcerpc)
Assume that only NamedPipe reads can be STATUS_PENDING and thus have the P bit set and assume it IS dcerpc if the P bit is set.




svn path=/trunk/; revision=17197
2006-02-07 09:28:02 +00:00
Ronnie Sahlberg baed8f0888 add dissection of
SMB/SetFileInfo level 1023
SMB2/SetInfo/FILE_INFO level 0x17

FILE_PIPE_INFO   infolevel


svn path=/trunk/; revision=17195
2006-02-07 08:48:51 +00:00
Anders Broman b3adb51d07 Dissect channel needed.
svn path=/trunk/; revision=17194
2006-02-07 04:57:30 +00:00
Anders Broman 6550608ea0 Add a RFC value.
svn path=/trunk/; revision=17193
2006-02-07 04:56:37 +00:00
Ronnie Sahlberg 0c350fb5b6 prettify class/infolevel for GetInfo/SetInfo
svn path=/trunk/; revision=17186
2006-02-06 13:17:11 +00:00
Ronnie Sahlberg 4a2048a5ef dissect the TWrp chain element
svn path=/trunk/; revision=17180
2006-02-06 09:51:42 +00:00
Ronnie Sahlberg f1e686af86 add dissection of a few more create options
svn path=/trunk/; revision=17179
2006-02-06 09:37:56 +00:00
Guy Harris ad3cb359b6 From Paolo Abeni:
Set up to build on Windows if we have GNU TLS.

	Define "ssl_data_set()" regardless of whether we have GNU TLS or
	not, as it's used in either case.

	Get rid of an extra #include of epan/gnuc_format_check.h.

svn path=/trunk/; revision=17177
2006-02-06 09:09:06 +00:00
Guy Harris edc7f32956 Tag some #else/#endif to make it clearer what tests they handle.
Also, remove some trailing white space.

svn path=/trunk/; revision=17175
2006-02-06 04:12:12 +00:00
Guy Harris 6a77df11b1 No C++/C99-style comments, please.
svn path=/trunk/; revision=17171
2006-02-06 01:17:29 +00:00
Guy Harris cc823c13aa Include <epan/gnuc_format_check.h> in packet-ssl-utils.h, not
packet-ssl-utils.c; everything else that includes it is a header file.

svn path=/trunk/; revision=17170
2006-02-06 01:14:36 +00:00
Guy Harris 60419eab20 From Paolo Abeni: fix some warnings, etc..
svn path=/trunk/; revision=17169
2006-02-06 01:01:09 +00:00
Jörg Mayer 2826417ef7 Trivial warning fix (no newline at end of file)
svn path=/trunk/; revision=17164
2006-02-05 11:46:00 +00:00
Luis Ontanon a2f7c569e0 H.248 over UDP
svn path=/trunk/; revision=17163
2006-02-05 04:24:51 +00:00
Guy Harris c9c2b97498 Update from the current asn1/tcap code.
svn path=/trunk/; revision=17160
2006-02-05 03:56:29 +00:00
Jörg Mayer 2078d1bccd Change port define to something more readable
svn path=/trunk/; revision=17159
2006-02-05 03:38:50 +00:00
Ronnie Sahlberg 44263c63f7 from JBM
some more functions names of new procedures in Vista



svn path=/trunk/; revision=17158
2006-02-05 03:11:13 +00:00
Jörg Mayer 59c6c554ea Buildbot found:
- p_rem_proto_data has been renamed to p_remove_proto_data
- I forgot to commit the changes to Makefile.common

svn path=/trunk/; revision=17157
2006-02-05 02:33:06 +00:00
Jörg Mayer 9ba6da080a Paolo Abeni
I have developed an external plugin to enable ssl decryption in
ethereal.

Me

- Remove unnecessary $Id$ from acinclude.m4
- Added packet-ssl-utils.h to Makefile.common
- Fixed a few warnings

TODO

- Lots of warning fixes (see separate mail)
- Reformat function headers to read like the others do
  (return value<newline>function-name...)
- Test on Windows platform
- Review the patch to packet-ssl.c and new files packet-ssl-utils.[hc]


svn path=/trunk/; revision=17156
2006-02-04 23:44:05 +00:00
Anders Broman 3f6e2badad Add SSN:s from 3GPP TS 23.003.
svn path=/trunk/; revision=17148
2006-02-04 10:28:28 +00:00
Anders Broman e77ec7864f gsm_a: Export needed functions
bssap: Dissect most of the IE:s

svn path=/trunk/; revision=17143
2006-02-02 15:16:51 +00:00
Ronnie Sahlberg b63bc8410a fix bug 400
the choice dissector didnt sometimes use the correct next_tvb.
based on a bogus variable    'first_pass'   that was added as a qad solution to some weird CMIP problem.





svn path=/trunk/; revision=17142
2006-02-02 08:34:59 +00:00
Anders Broman cb191e08d2 packet-gsma_a.ch Use valuestrings for Number type etc and export the value_strings
packet-bssap.c Add BSSAP+ dissection. 

svn path=/trunk/; revision=17141
2006-02-01 17:39:20 +00:00
Anders Broman ac54c854d4 From Greg Morris:
epan/dissectors/ncp2222.py - Fixes the NCP group values for all NCP's. Also fixes some additional return values and cleanup.

gtk/ncp_stat.c - Fixes the NCP group values for SRT.

 gtk/service_response_time_table.c:

The SRT is broken if you hit the reload button or apply a filter. The table isn't cleared so each item in the list is duplicated and the second entries remain with initial values. This patch clears the GTK_CLIST so that the redundant entries no longer appear.


svn path=/trunk/; revision=17139
2006-02-01 06:09:55 +00:00
Anders Broman 42bf48fa74 Export dissector_handle_t get_itu_tcap_subdissector()
svn path=/trunk/; revision=17136
2006-01-31 19:39:55 +00:00
Anders Broman f22abb2933 Fix a typo
svn path=/trunk/; revision=17135
2006-01-31 18:35:36 +00:00
Anders Broman 723c5bb0e6 Display which dissector is linked to a ssn.
svn path=/trunk/; revision=17134
2006-01-31 18:33:56 +00:00
Ronnie Sahlberg 63d4b418a6 make sure we actually get the tcpd structure pointer before we pass it as a parameter to a subroutine to dereference it.
fixes bug 719




svn path=/trunk/; revision=17133
2006-01-31 10:27:30 +00:00
Anders Broman 25a7d62b92 BSSGP - Translate MCC and make MCC MNC etc vissible filters
GSMMAP - Small bugfix

svn path=/trunk/; revision=17132
2006-01-31 05:46:36 +00:00
Anders Broman c6527de2aa Fix a typo.
svn path=/trunk/; revision=17131
2006-01-31 05:42:55 +00:00
Guy Harris c831848dd5 Fix description of version0_type, now that it also supports T.38.
svn path=/trunk/; revision=17130
2006-01-31 02:31:18 +00:00
Gerald Combs edabe5ed93 Make sure a pointer isn't null before we try to use it. Fixes a current
Buildbot failure.

svn path=/trunk/; revision=17129
2006-01-30 23:29:09 +00:00
Luis Ontanon ba58e57a41 Fixes bug 717
Tag names with digits were not recognized.


svn path=/trunk/; revision=17128
2006-01-30 22:43:08 +00:00
Anders Broman c850e7a683 Use dissect_e212_mcc_mnc().
svn path=/trunk/; revision=17127
2006-01-30 05:55:46 +00:00
Anders Broman 222851585d From Martin Mathiesson:
This patch shows (as extra, generated fields) what the address and port will be after XORing again with the transaction ID. I've done IPv4, but don't have any IPv6 captures to test with...

svn path=/trunk/; revision=17126
2006-01-30 05:45:39 +00:00
Anders Broman b05b62d64a From Andrei Emeltchenko:
OMA again has changed the format of the 2 RTCP packets:

RTCP Grant and RTCP Taken

In RTCP Grant instead of spare 2 bytes there are: magic number and item_len.

In RTCP Taken there is an extra field "Number of participants" like in Grant.
http://www.openmobilealliance.org/release_program/docs/CopyrightClick.asp?pck=PoC&file=V1_0-20051104-C/OMA-TS-PoC-UserPlane-V1_0-20051104-C.pdf

svn path=/trunk/; revision=17125
2006-01-30 05:35:39 +00:00
Anders Broman ae9e7131f9 Actually use the valuestring...
svn path=/trunk/; revision=17122
2006-01-29 22:12:26 +00:00
Guy Harris 9958e6b581 Fix indentation, add a /* FALLTHRU */ comment.
svn path=/trunk/; revision=17121
2006-01-29 21:41:44 +00:00
Lars Roland eb4a79cc7a As suggested by Ilja Maslov, display values of
gsm_a.cell_lac and gsm_a.cell_ci in hex
and decimal.


svn path=/trunk/; revision=17120
2006-01-29 21:00:00 +00:00
Lars Roland de4522f70d Fix an infinite loop in gsm_a dissector and a wrong offset in uma dissector.
This fixes bug 716.

svn path=/trunk/; revision=17119
2006-01-29 15:54:10 +00:00
Guy Harris e01909c0ea Use tvb_format_text() on the message, to handle non-printable characters
(including tabs and newlines).

svn path=/trunk/; revision=17118
2006-01-29 12:57:14 +00:00
Guy Harris f9eaba6d69 Add an option to dissect purported RTP packets with a version number of
0 as T.38 rather than STUN.

svn path=/trunk/; revision=17116
2006-01-29 00:40:40 +00:00
Guy Harris b0a28a8080 Squelch a compiler warning.
svn path=/trunk/; revision=17115
2006-01-28 23:27:17 +00:00
Guy Harris 54ac396346 Expand the set of #defines in afn.h (and give a URL for the *current*
list of address families) and the list of strings in afn.c, and use them
in packet-lldp.c instead of having it define its own.

svn path=/trunk/; revision=17114
2006-01-28 23:18:19 +00:00
Guy Harris 5186e33416 Fix missing closing */ in comment.
svn path=/trunk/; revision=17113
2006-01-28 22:49:53 +00:00
Guy Harris 360b71a3ce Fix missing brackets in if statement.
svn path=/trunk/; revision=17112
2006-01-28 22:34:22 +00:00
Ronnie Sahlberg dab77d86f1 rewrite of the tcp sequence number analysis code to hopefully make it cleaner and easier to maintain and extend.
i have tested it with many captures   but this used to be fragile and delicate code  so there might be some regressions that will need to be addressed once identified.





svn path=/trunk/; revision=17107
2006-01-26 22:50:16 +00:00
Anders Broman 65530eb912 Add the abillity to translate MCC.
svn path=/trunk/; revision=17105
2006-01-26 06:54:52 +00:00
Ulf Lamping 84794a9bc3 from Gisle Vanem:
This file uses SEH which AFAIK is only available for MS Visual-C.
I build using MingW/gcc, so the attached patch is needed. 

svn path=/trunk/; revision=17102
2006-01-25 21:34:04 +00:00
Luis Ontanon aeaf2c6cf6 Bind IuUP to RTP
svn path=/trunk/; revision=17100
2006-01-25 20:49:42 +00:00
Luis Ontanon e469d2af12 Use the right tree
svn path=/trunk/; revision=17099
2006-01-25 20:48:37 +00:00
Anders Broman 33b9a9c90d - Add new IE:s
- White space and comment changes.
- IE type fixes.
- Print timezone data.

svn path=/trunk/; revision=17098
2006-01-25 17:56:27 +00:00
Ulf Lamping 3f3aae1681 minor code cleanup
svn path=/trunk/; revision=17093
2006-01-24 19:03:09 +00:00
Jaap Keuter 1fb3bc7c86 Derived some more assumptions from NLB traffic
svn path=/trunk/; revision=17091
2006-01-24 11:54:27 +00:00
Luis Ontanon 1ff8c4272f Add register_postdissector() to the API.
Dissectors registered with register_postdissector() will be called after all other dissectors have been called.

Use it to register mate.


svn path=/trunk/; revision=17089
2006-01-24 00:26:57 +00:00
Guy Harris 878a077605 Add some more sanity checking of the Radiotap header.
svn path=/trunk/; revision=17085
2006-01-23 23:21:02 +00:00
Anders Broman d31de2bdb4 Bugfix: network address not dissected correctly
svn path=/trunk/; revision=17084
2006-01-23 22:13:08 +00:00
Guy Harris 41c941b49c Call capture_radiotap() when capturing on a device supplying Radiotap
headers.

Fix capture_radiotap() to check for padding between the 802.11 header
and the 802.11 payload and to call different capture routines depending
on whether it's present or not, and create capture_ieee80211_datapad()
to handle the case where it's present.

Fix capture_radiotap() to convert the Radiotap header length from
little-endian, and to do some sanity checking of that length.

Fix capture_ieee80211_common() to use the offset supplied to it to fetch
the frame control field, as that offset isn't necessarily 0.

svn path=/trunk/; revision=17083
2006-01-23 16:56:34 +00:00
Guy Harris 2ab3f01671 Rename all the COOK_ macros to indicate the field from which they're
extracting data (except for the association ID field, where adding
ASSOC_ID would be redundant).

svn path=/trunk/; revision=17081
2006-01-23 10:17:07 +00:00
Guy Harris d269468356 From Sam Leffler:
1. Fix a bug in caclulating the 802.11 header length for QoS
	   data frames (way bad regression from previous code). 

	2. Add support for packets w/ data padding between the 802.11
	   header and the payload (as indicated in the radiotap flags).

	3. Add support for handling FCS indication in the radiotap
	   flags. 

	4. Fix display of TSF (previous code was not byte swapping).

	5. Update ieee80211_mhz2ieee in radiotap.c to handle more
	   channels. 

	6. Nuke some #if 0 code I left in radiotap.c a while back.

Also, clean up the various macros that extract stuff from 802.11 header
fields or define bitfields within those header fields:

	group them by the fields from which they extract and the values
	they extract, or the header fields to which they belong;

	get rid of some of the COOK_ in the names - COOK_ really doesn't
	indicate anything useful, such as the field from which they're
	extracting (we should get rid of the rest);

	put in some more comments explaining what they do;

	get rid of some unused macros;

	get rid of some values that aren't flag values - they're values
	to test whether something's a data frame with a particular byte
	set in the subtype field, but they're only used on data frames,
	so we only need to test the bit in question, so we define macros
	to test the bit and name them to indicate that they're for use
	on data frames.

Consistently use "CF-Ack" and "CF-Poll" in the strings for various data
frame type/subtype values, and get rid of "802.11" (it should be obvious
to one and all that this is 802.11...).

Comment out some variables used only in commented-out code.

Get rid of some unused variables.

Fix up one "proto_tree_add_text()" call where the format string didn't
match the arguments.

svn path=/trunk/; revision=17080
2006-01-23 09:20:06 +00:00
Jaap Keuter 287e228fc5 Implemention of T38 TCP defragmentation by Alejandro Vaquero
svn path=/trunk/; revision=17079
2006-01-23 07:12:26 +00:00
Anders Broman be6277f8c8 From Marc Petit-Huguenin:
This patch for the STUN dissector fixes a bug (wrong value for DATA_INDICATION attribute) and adds the decoding of IPv6 address in attributes.


svn path=/trunk/; revision=17078
2006-01-23 06:14:31 +00:00
Guy Harris f371ed6d3d Get rid of unused variables, fix indentation, don't assign NULL to
non-pointer variables.

svn path=/trunk/; revision=17077
2006-01-22 23:14:58 +00:00
Guy Harris 6967e5bef7 "size_t" can be "unsigned int" or "unsigned long", so cast it to
"unsigned long" and print it with %lu.

svn path=/trunk/; revision=17076
2006-01-22 23:08:15 +00:00
Anders Broman 1c5874e2e3 Dissect CellGlobalIdOrServiceAreaIdOrLAI and RAIdentity
svn path=/trunk/; revision=17075
2006-01-22 21:16:33 +00:00
Ulf Lamping c73ed3c6d5 add Win32 Structured Exception Handling (SEH) at the same place we're already doing the Portable Exception Handling.
This way we (hopefully) can continue dissecting with the next packet, even if a more serious exception had occured, e.g. a memory access violation or a divide by zero exception.

Obviously, not all problems solved, as SEH won't protect us from other problems, e.g. endless loops and such

svn path=/trunk/; revision=17070
2006-01-22 02:22:14 +00:00
Anders Broman fded8deafc RANAP - Dissect ProtocolExtensionField IE:s
GSM A - Service Request; Mobile identity element is LV type

svn path=/trunk/; revision=17069
2006-01-21 19:12:52 +00:00
Ulf Lamping 864edeb5ac add matched coloring rule name and string to the frame dissector output (or nothing if no coloring rule matched or none was set)
svn path=/trunk/; revision=17068
2006-01-21 17:49:00 +00:00
Jörg Mayer a052b3a98b packet-bgp.c: Fix incorrect use of g_snprintf return value
mp_addr_to_str was unnecessary 'complex' - simplified it
packet-dns.c: Fix incorrect use of g_snprintf return value
packet-dcm.c: Fix incorrect use of g_snprintf return value
        Someone who understands the protocol should look at the
        "vr, tr might be used uninitialized..." warning.
packet-x11.c: Fix incorrect use of g_snprintf return value
packet-kerberos.c: Fix incorrect use of g_snprintf return value
        Someone should take a look at the
        "longjump might clobber ..." messages
packet-diameter.c: Fix incorrect use of g_snprintf return value
        Get rid of unsigned < 0 check
packet-pgm.c: Fix incorrect use of g_snprintf return value
packet-nbns.c: Fix incorrect use of g_snprintf return value
packet-winsrepl.c: Collateral damage to packet-nbns.c fix
packet-netbios.c: Collateral damage to packet-nbns.c fix
packet-netbios.h: Collateral damage to packet-nbns.c fix
packet-kerberos.c: Collateral damage to packet-nbns.c fix
packet-nbipx.c: Collateral damage to packet-nbns.c fix


svn path=/trunk/; revision=17065
2006-01-20 21:18:18 +00:00
Anders Broman f194c9eddb Dissect:
- PDPcontext
 - GSN-Address
 - QoS

svn path=/trunk/; revision=17063
2006-01-20 19:41:31 +00:00
Anders Broman f2bc8ad4a8 Handle sgmented XUDT:s
svn path=/trunk/; revision=17060
2006-01-20 19:32:59 +00:00
Jörg Mayer 256225d73f Mike Hall:
This will add the ability to configure a .1q vlan column in ethereal.

Me:
Change 1q -> 1Q

svn path=/trunk/; revision=17058
2006-01-20 08:48:43 +00:00
Gerald Combs b3d0b97635 Make sure we don't use the ADNS version of inet_aton; it's broken.
This fixes bug 523, but exposes more of bug 658.

The TACACS and SDP dissectors don't call inet_aton(), so don't include it.

svn path=/trunk/; revision=17056
2006-01-19 23:01:24 +00:00
Anders Broman 9d6de675a4 ext_qos_subscribed was not correctly decoded in Camel and GSM MAP
Change to use proto_add_item in packet-gsm_a.c for some octets and export value strings.

svn path=/trunk/; revision=17055
2006-01-19 18:20:14 +00:00
Anders Broman 28e69752b2 Dont dissect XDT data in case of Segmentation as that will give [Malformed packet] and the Segmentation IE will n ot be dissecterd.
svn path=/trunk/; revision=17054
2006-01-19 05:51:59 +00:00
Ulf Lamping 67e90082a7 add "RPC_E_TIMEOUT" to the reject status codes
svn path=/trunk/; revision=17053
2006-01-19 02:00:28 +00:00
Jaap Keuter ac3e6ed312 Add option presentation, solving bug 697
svn path=/trunk/; revision=17052
2006-01-18 21:41:34 +00:00
Gerald Combs f816511ea9 In packet-cops.c use proto_item_append_text() instead of creating a
separate buffer.  Fixes the current Buildbot failure.

Don't let the sprint_realloc_* functions reallocate ep_allocated memory.
Add comments warning against this in the future.

In emem.c, make sure we don't use an extra 100k every stinkin' time
someone wants to allocate memory when debugging is enabled.

Fixup whitespace.

svn path=/trunk/; revision=17051
2006-01-18 20:02:19 +00:00
Anders Broman 4ecd261cfb Change some OPCODE decodes from respons to Invoke (bug fix), let gsm_a decode som IE:s.
svn path=/trunk/; revision=17050
2006-01-17 21:52:30 +00:00
Anders Broman dbf15d9e0b Add ethertypes and value_str for IEC 61850
svn path=/trunk/; revision=17049
2006-01-17 21:50:43 +00:00
Jörg Mayer 467de087cc According to 802.11e D11, 7.3.2.13, station count is a 16 bit value.
Accoding to 802.11, 7.1.1, numbers are little endian.

svn path=/trunk/; revision=17047
2006-01-17 13:13:29 +00:00
Jörg Mayer f905ad1862 packet-fcswils.c: Fix incorrect use of g_snprintf return
packet-wccp.c: Fix incorrect use of g_snprintf return
packet-cops.c: Fix incorrect use of g_snprintf return value
packet-wtp.c: Fix incorrect use of g_snprintf return value


svn path=/trunk/; revision=17046
2006-01-17 10:56:06 +00:00
Jörg Mayer be27196e0a - Replace snprintf by g_snprintf
- Beginning of incorrect g_snprintf retval ussage fixes
- Make qbss station count a byte again until we know
  whether the count is a 2 byte le value instead

svn path=/trunk/; revision=17045
2006-01-17 10:54:23 +00:00
Jaap Keuter d0c1a48a34 Fix typo, solving bug 693
svn path=/trunk/; revision=17044
2006-01-17 06:39:57 +00:00
Ulf Lamping c59c716e7a MSVC compiler warnings:
packet-ldap.c(784) : warning C4101: 'seq_len' : unreferenced local variable
packet-ldap.c(782) : warning C4101: 'length' : unreferenced local variable
packet-ldap.c(785) : warning C4101: 'header_bytes' : unreferenced local variable

svn path=/trunk/; revision=17041
2006-01-17 00:01:22 +00:00
Jörg Mayer 1900bf87fc done:
packet-ntp.c: Rather confused and incorrect use of g_snprintf return value
packet-pim.c: whitespace change
packet-icmpv6.c: g_snprintf takes trailing \0 into account, fix off by 1 error
packet-clnp.c: Fix incorrect use of g_snprintf return value
packet-isakmp.c: g_snprintf takes trailing \0 into account
packet-tr.c: Fix incorrect use of g_snprintf return value
packet-radius.c: Fix incorrect use of g_snprintf return value
packet-radius.h: constify a string variable
packet-ldap.c: The return value isn't needed, so don't use it incorrectly
packet-tcp.c: Fix incorrect use of g_snprintf return value
packet-windows-common.c: Remove unneeded DISSECTOR_ASSERT
packet-smb-sidsnooping.c: g_snprintf takes trailing \0 into account
packet-pvfs2.c: g_snprintf takes trailing \0 into account
packet-ptp.c: Remove #include snprintf
packet-ppp.c: Fix incorrect use of g_snprintf return value
packet-ospf.c: Fix incorrect use of g_snprintf return value
packet-mip6.c: snprintf -> g_snprintf
packet-bootp.c: Remove a commented out bad use of g_snprintf
packet-ber.c: snprintf -> g_snprintf, g_snprintf takes trailing \0 into account

2do:

     52 packet-ieee80211.c: 2DO
      2 packet-nfs.c: 2DO - too many side effects
     33 packet-bgp.c: 2DO
     18 packet-dns.c: 2DO
     14 packet-dcm.c: 2DO
     13 packet-x11.c: 2DO
     11 packet-kerberos.c: 2DO
     10 packet-diameter.c: 2DO
      9 packet-snmp.c: 2DO
      9 packet-pgm.c: 2DO
      7 packet-nbns.c: 2DO
      6 packet-fcswils.c: 2DO
      5 packet-wccp.c: 2DO
      5 packet-cops.c: 2DO
      4 packet-wtp.c: 2DO


svn path=/trunk/; revision=17038
2006-01-16 07:59:44 +00:00
Anders Broman c5e0d27e84 From Alejandro Vaquero:
patch to add t38 setup info for h245 packets.

- Me add /y to makefiles.

svn path=/trunk/; revision=17036
2006-01-16 06:05:25 +00:00
Jaap Keuter 815a4af69e Hi All,
Find attached a couple of changes for t38:
- Use the dissector to reassemble t30 frames
- Dissect t30 protocol
- Move the "Fax t38 analysis" to the "VoIP Calls". Now when selecting
"Statistics"->"Fax t38 analysis" option, there is a message that
redirect the user to use the "Voip calls" instead. We may keep this
option for one release, and then remove it ?
- Added in the "Voip calls" the ability to detect a t38 call if there
are not signaling associated with it. For example, when using "Decode
as.." to dissect t38 packets, it is possible to use the "Voip calls" to                                                      analyze that call.
- Display "SDP (t38)" in the "Voip calls graph" for SDP t38 sessions.

Regards
Alejandro Vaquero


svn path=/trunk/; revision=17033
2006-01-15 15:01:14 +00:00
Ulf Lamping d0dd39b277 add COTP to fragment COL_INFO message, so the user knows where the fragment is coming from
svn path=/trunk/; revision=17032
2006-01-15 13:51:58 +00:00
Jörg Mayer 122671b36c Jaap Keuter:
I'm not too fond of using pointer arithmetic in such cases. How about
this:


svn path=/trunk/; revision=17031
2006-01-14 23:09:44 +00:00
Jörg Mayer 0bfcf705cd We may not work with the length returned by g_snprintf, as this is
the number of bytes that would have been used if the buffer was long
enough.
Fixes http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=686

svn path=/trunk/; revision=17030
2006-01-14 11:29:24 +00:00
Anders Broman 6c822ae0e6 MTP3 standard in SCCP MTP3 and M3UA will be determined by Preference setting in MTP3.
svn path=/trunk/; revision=17029
2006-01-14 09:52:04 +00:00
Jörg Mayer 59bccbee5e - Change Cisco QBSS V2 to be part of the Aironet IE dissection.
- Change proto_tree_add_uint ( ...., tvb_get_guint8(...)) to
  proto_tree_add_item ( ....) for all qbss dissection code
- Change all qbss occurrences scount to be 16 bits (I may have
  gotten endianess wrong! Testers / sample captures needed)
- Change wlan_mgt.tag.aironet... filter to wlan_mgt.aironet...

svn path=/trunk/; revision=17028
2006-01-13 18:30:12 +00:00
Jaap Keuter 343b357b0e From Patrik Olsson
Attached is a patch that fixes several decoding problem is the gsm_a
dissector. The bugs are also submitted to bugzilla id #684 and #687.

svn path=/trunk/; revision=17027
2006-01-13 15:17:50 +00:00
Jörg Mayer 96576bbb3e Add code to verify the shared secret for documentation purposes.
#if 0 that code.


svn path=/trunk/; revision=17026
2006-01-13 04:35:10 +00:00
Jaap Keuter 6e80585275 Add warning when UDP length field is too large.
Patch by Graeme Hewson

svn path=/trunk/; revision=17023
2006-01-12 22:16:20 +00:00
Gerald Combs 62a3709da3 Reset h245_pi using CLEANUP_PUSH/CLEANUP_CALL_AND_POP so that we don't leave
ep_alloc()ated memory lying around.  Fixes bug 667.

Fixup whitespace.

svn path=/trunk/; revision=17022
2006-01-12 21:53:02 +00:00
Jaap Keuter 055d695edc Fixes bug 679.
The offset wasn't passed to the PDU dissector so it always started dissection
from the start of the TVB.

svn path=/trunk/; revision=17020
2006-01-12 16:17:07 +00:00
Anders Broman 3096dc2686 FromHannes Gredler
-rework the GGSN dissector to proper parse meta extensions -more graceful magic-number detection - for better (JUNOS 6.4)
   downwards compatability
-correct calculate the offset to ATM cookies when there
   are meta-extensions present

svn path=/trunk/; revision=17016
2006-01-12 06:09:48 +00:00
Gerald Combs faef737b31 Before we begin dissection, NULLify some global variables that might
contain ep_alloc()ed data from a previous dissection.  Correctly fixes
bug 651 (the previous fix was incorrect).

svn path=/trunk/; revision=17015
2006-01-12 02:06:34 +00:00
Jaap Keuter 356cbd3a5a From Thomas Sillaber
here is the Patch for:
    - AVA (Alcatel Automatic VLAN Assignment)
    - QBSS ( QOS Basic Service Set)

svn path=/trunk/; revision=17008
2006-01-11 22:05:43 +00:00
Jörg Mayer 3245c72141 set: The first 4 bytes seem to be the salt
svn path=/trunk/; revision=17003
2006-01-11 18:43:17 +00:00
Gerald Combs 2b4380fba9 If we pass a short length to unicode_to_bytes(), return an empty string
instead of clobbering a canary.  This replicates its pre-canarification
behavior (which may not be correct).

Fixup whitespace.

svn path=/trunk/; revision=17001
2006-01-11 15:39:03 +00:00
Jaap Keuter 846f069180 This patch fixes a couple of bind replies to report proper session id.
Greg Morris


svn path=/trunk/; revision=17000
2006-01-11 11:35:25 +00:00
Gerald Combs 12331f9cb4 Make sure last_dn is big enough, and set it to NULL when we're
finished with it.  This should fix the current menagerie failure
in Buildbot.

Fix up whitespace.

svn path=/trunk/; revision=16995
2006-01-10 23:28:16 +00:00
Anders Broman 496e4be980 Handle <application id="4294967295" name="Relay"/>
svn path=/trunk/; revision=16988
2006-01-10 19:57:15 +00:00
Jaap Keuter d5649bc2de Add UDP-Lite packets to the UDP statistics
svn path=/trunk/; revision=16983
2006-01-09 23:00:20 +00:00
Anders Broman c0d17b8845 Use col_set_fence(), not to owerwrite colinfo if more than one Camel pdu is in one TCAP message.
svn path=/trunk/; revision=16980
2006-01-09 21:12:22 +00:00
Gerald Combs efe2f4f563 Add more data types from tds.h. Fix unknown data skipping for some data
types. Fixup whitespace.

svn path=/trunk/; revision=16979
2006-01-09 17:44:02 +00:00
Jörg Mayer 5fb7e183fd First attempt to decode CCX type 4 IEs (QoS?)
svn path=/trunk/; revision=16978
2006-01-09 07:41:26 +00:00
Anders Broman 44784a9fe4 From Olivier Jacques,
Here is a patch that:
- Replaces the arrow labels by the beginning of the COLINFO column if available (usually containing message names/types).
- Change the comment area to be "protocol: colinfo_content"
From Anders
Added ID tag

Camel
Use col_set_str to remove TCAP info in col_info
 


svn path=/trunk/; revision=16975
2006-01-07 11:10:50 +00:00
Gerald Combs 20b00dd581 Don't dereference a null pointer. Fixes bug 651. Update the release notes
accordingly.

svn path=/trunk/; revision=16967
2006-01-06 20:03:52 +00:00
Jörg Mayer 735ba01eb1 Bill Meier: More spelling fixes
svn path=/trunk/; revision=16965
2006-01-06 03:26:45 +00:00
Jörg Mayer 368f7d87c7 Steve Karg:
I fixed fBACnetPropertyValue in the BACnet packet-bacapp.c dissector
where an optional decoding for Priority wasn't being optional.  A valid
packet with a confirmedEventNotification that did not have the optional
priority made this bug evident by indicating Malformed Packet.

Me:
Fixed some signedness warnings, #if 0'ed out unused functions.

svn path=/trunk/; revision=16957
2006-01-05 18:53:22 +00:00
Jörg Mayer f9a57f08d1 Bill Meier:
Spelling fixes.

svn path=/trunk/; revision=16956
2006-01-05 13:01:08 +00:00
Jörg Mayer 5fb7840b04 - Undo the COL_PROTOCOL misuse introduced with rev 15115.
- Start dissection of Aironet vendor specific stuff.

svn path=/trunk/; revision=16952
2006-01-05 11:28:40 +00:00
Jörg Mayer 30adb1d8f7 Fix for http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=656
Incorrect decoding of IPMI System Software IDs


svn path=/trunk/; revision=16950
2006-01-05 08:52:06 +00:00
Jörg Mayer 131241e40a Forgot to add packet-oicq.c
svn path=/trunk/; revision=16948
2006-01-05 08:31:37 +00:00
Jörg Mayer 9d62ccefea Jaap Keuter:
>From the Debian bug database this bug:
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=342588

  The rates information element with zero tag length leads to uninitialised
  memory access, presenting bogus data for the element. The attached patch
  takes care of that.

Me:
  One space in the map listing is enough.

svn path=/trunk/; revision=16947
2006-01-05 08:23:17 +00:00
Jörg Mayer 4f7175aa8b Du Bingyao:
New OICQ dissector.

Me:
        removed some not needed variables and some unneeded includes.

svn path=/trunk/; revision=16940
2006-01-03 23:59:13 +00:00
Jörg Mayer 74dc6c2d5f Jon Oberheide:
Ethereal does not take into account the protocol field of the IP header
when reassembling fragmented packets as specified in RFC791.  This can
lead to incorrect reassembly of packets with an identical src address,
dst address, and identification number, but with differing protocols.

The attached patch includes the protocol in the generation of the id
used to index into the reassembly table.


svn path=/trunk/; revision=16937
2006-01-03 23:23:46 +00:00
Guy Harris 21c0c928b7 Fix a typo in a comment.
svn path=/trunk/; revision=16935
2006-01-03 22:49:58 +00:00
Anders Broman d74d5995e2 From Martin Mathieson
I keep finding finding traces that show new problems with this code.  This patch fixes 2 problems:
- I've seen RTCP frames containing a SR and RR with identical source info and the lsr matching the current MSW/LSW timestamp of the SR.  Don't want to do calculation without real roundtrip info
- calculating the gap between the 2 frames was still wrong (sigh)

svn path=/trunk/; revision=16934
2006-01-03 16:24:56 +00:00
Anders Broman 2c144a330c From Ravi Valmikam
Over the last year or so there have been several developments in the 3GPP2 specifications. One of the areas that saw significant changes was A11 interface between PDSN and PCF. With the introduction of QoS support on this interface, the specification includes a lot of new information elements in this protocol

svn path=/trunk/; revision=16933
2006-01-03 16:20:06 +00:00
Guy Harris 35743cded8 Fix a typo.
svn path=/trunk/; revision=16931
2006-01-02 10:52:50 +00:00
Jörg Mayer 6cbffe23a9 Update from samba tree revision 12488 to 12669
============================ Samba log start ============
------------------------------------------------------------------------
r12488 | jelmer | 2005-12-26 02:37:18 +0100 (Mon, 26 Dec 2005) | 2 lines

Fix MANIFEST to match recent changes

------------------------------------------------------------------------
r12490 | jelmer | 2005-12-26 03:14:18 +0100 (Mon, 26 Dec 2005) | 2 lines

Fix --warn-compat

------------------------------------------------------------------------
r12501 | jelmer | 2005-12-26 23:47:40 +0100 (Mon, 26 Dec 2005) | 4 lines

Merge EJSHeader.pm into EJS.pm and simplify smbcalls_rpc.c a bit,
now that it is guaranteed that the smbcalls modules are always
initialized
after the EJS subsystem itself.

------------------------------------------------------------------------
r12512 | jelmer | 2005-12-27 17:22:35 +0100 (Tue, 27 Dec 2005) | 3 lines

Use GUID structs in API functions everywhere rather then converting back
and
forth between GUID structs and strings in several places.

------------------------------------------------------------------------
r12515 | jelmer | 2005-12-27 18:50:53 +0100 (Tue, 27 Dec 2005) | 2 lines

Use UUID directly rather then string containing UUID

------------------------------------------------------------------------
r12517 | jelmer | 2005-12-27 20:13:18 +0100 (Tue, 27 Dec 2005) | 2 lines

Don't generate empty init functions

------------------------------------------------------------------------
r12528 | jelmer | 2005-12-27 23:51:30 +0100 (Tue, 27 Dec 2005) | 2 lines

Add seperate proto headers for ntvfs, tdr, smb_server and nbt_server.

------------------------------------------------------------------------
r12539 | metze | 2005-12-28 10:31:43 +0100 (Wed, 28 Dec 2005) | 3 lines

fix the pidl tests

metze
------------------------------------------------------------------------
r12572 | jelmer | 2005-12-29 17:03:03 +0100 (Thu, 29 Dec 2005) | 2 lines

No longer parse coclasses as interfaces

------------------------------------------------------------------------
r12573 | jelmer | 2005-12-29 17:03:47 +0100 (Thu, 29 Dec 2005) | 2 lines

Update README to recent changes in pidls namespace

------------------------------------------------------------------------
r12574 | jelmer | 2005-12-29 17:04:34 +0100 (Thu, 29 Dec 2005) | 3 lines

Bring tables.pl back to life and move registration of interfaces
now completely to a new subsystem.

------------------------------------------------------------------------
r12651 | jelmer | 2005-12-31 15:57:43 +0100 (Sat, 31 Dec 2005) | 2 lines
Changed paths:
   M /branches/SAMBA_4_0/source/librpc/idl/idl_types.h
   M /branches/SAMBA_4_0/source/librpc/ndr/libndr.h
   M /branches/SAMBA_4_0/source/librpc/ndr/ndr_string.c

Remove STR_LARGE_SIZE as it's no longer used

------------------------------------------------------------------------
============================ Samba log end ==============


svn path=/trunk/; revision=16927
2006-01-01 23:14:44 +00:00
Luis Ontanon ada9131e3b Fixes Bug 531 (Incorrect Interpretation of Bit vector and RLE RTCP XR Blocks).
svn path=/trunk/; revision=16921
2005-12-31 02:19:24 +00:00
Luis Ontanon 5ff580e14f From: Graeme Hewson
Decryption of the RADIUS User-Password attribute is currently broken.


svn path=/trunk/; revision=16920
2005-12-30 18:41:56 +00:00
Luis Ontanon be94b45514 - Decode some more annex C fields
- Keep track of terminations (link wildcarded ones to real ones)
- Keep termination info and link aal2 terminations to alcap legs


svn path=/trunk/; revision=16914
2005-12-28 19:46:57 +00:00
Luis Ontanon 78ed00ce3a Keep a hash of call legs indexed by nsap:sugr and separate the leg tree code so that it can be called from others.
svn path=/trunk/; revision=16913
2005-12-28 19:38:33 +00:00
Jörg Mayer 93643c7992 As reported by Toralf Foerster in bug 647:
It should be "Authentication" (2x "t") not "Authenication"


svn path=/trunk/; revision=16911
2005-12-27 23:08:37 +00:00
Jörg Mayer 10c857ccfa Backup time :-)
- Add packet types: query and query response
- Add  tlv types: snmptrap, coldstarttrap, linkdowntrap, linkuptrap,
  authfailtrap
- Add comments to port settings


svn path=/trunk/; revision=16897
2005-12-26 01:04:48 +00:00
Ronnie Sahlberg 6ea1842885 remove some proto_tree_add_text and replace with proto_tree_add_item() for the TSIG dissection in dns.
create a new dissector table where MAC algorithms for dns/tsig can be registered.


register gssapi for the algorithm "gss.microsoft.com" since this is what w2k uses when performing dns updates.



svn path=/trunk/; revision=16895
2005-12-25 12:03:18 +00:00
Ronnie Sahlberg 2975ff835b microsoft does not use a confounder for spnego when using DNS/TSIG
they use an additional confounder everywhere else  (as it seems)   but not for DNS/TSIG


svn path=/trunk/; revision=16894
2005-12-25 11:43:47 +00:00
Ronnie Sahlberg cec07db2da from metze
update to tid and uid tracking


svn path=/trunk/; revision=16893
2005-12-24 10:10:04 +00:00
Ronnie Sahlberg fc97105f24 add Jaap K's extensions
also change one (of several:-( )  arrays to be accessed through accessor functions so proper bounds checking is done.


there are many other inbstances of arrays in this dissector that are accessed with no proper bounds checking and the same thing should be done for them




svn path=/trunk/; revision=16891
2005-12-23 23:54:35 +00:00
Ronnie Sahlberg c98abee7ef from jaap k
Hi list,

On the Ethereal Wiki is a CDP capture of a Broadcom BCM1100 VoIP chipset.
It has a power consumption TLV, which was not yet dissected. The attached
patch does that.




svn path=/trunk/; revision=16890
2005-12-23 21:12:40 +00:00
Ronnie Sahlberg dd19e660ba make smb2 tappable
svn path=/trunk/; revision=16886
2005-12-23 04:55:25 +00:00
Ronnie Sahlberg 80720ebcab from eric wedel
kpasswd over tcp support


svn path=/trunk/; revision=16885
2005-12-23 03:43:56 +00:00
Ronnie Sahlberg 9b61e75bb6 dunt put ACK number in COL_INFO or in the decode pane if the ACK bit is not set
svn path=/trunk/; revision=16884
2005-12-22 23:23:25 +00:00
Ronnie Sahlberg 15f441cdd6 add decoding of RFC3947 which should fix bug 513
svn path=/trunk/; revision=16883
2005-12-22 21:28:51 +00:00
Anders Broman 5b106306fd From Martin Mathieson:
there are only 1000 ms in one second

svn path=/trunk/; revision=16882
2005-12-22 16:26:26 +00:00
Ronnie Sahlberg 4e518c616d some ACEs are not used for authorization and thus do NOT contain an access mask and a SID.
make the dissection of the ACL check the type for each individual ACE and only dissect  as access mask and sid  those ACEs we know how to handle.


this prevents ethereal from dumping on w32 if we encounter any of these "special" ACE entries,   such as the ones used for storing location data for offline files.




svn path=/trunk/; revision=16881
2005-12-22 08:51:50 +00:00
Anders Broman d4e37349e7 Fix Bug 642, use col_set_fence() not to owerwrite column info if several Skinny messages are in one frame.
svn path=/trunk/; revision=16880
2005-12-22 07:11:21 +00:00
Jörg Mayer 409ea74249 As reported by Mark Millet <mmillet@cisco.com>
Add message types 13-17 for option 53 decoding.


svn path=/trunk/; revision=16879
2005-12-22 02:37:22 +00:00
Jörg Mayer 788e63c8d2 Jaap Keuter:
Add MS NLB buildin dissector

svn path=/trunk/; revision=16875
2005-12-22 01:26:04 +00:00
Jörg Mayer 25d4aaaaa4 - Add max frame size
- Add port power forwarding
- Some more field cleanups

svn path=/trunk/; revision=16873
2005-12-22 01:08:07 +00:00
Jörg Mayer 4d91380f8e - Don't use numbers when there are enum values
- Better nameing of tfs_ arrays
- Name and dissect "version" field (previously unknown)
- Name and dissect "add tag scheme" (previously unknown)
- Add lots of comments about meanings in the port data
- The first byte in the set command is probably some salt value


svn path=/trunk/; revision=16871
2005-12-21 11:21:49 +00:00
Ronnie Sahlberg 8aca1c1c52 add dissection of two more NTCreateAndX bits :
open by file id 
and
backup intent



svn path=/trunk/; revision=16869
2005-12-21 08:48:59 +00:00
Anders Broman 5a0d95fa76 From jaap Keuter:
Taking a random dissector from the list on the Wiki I picked packet-enip.c. Nothing wrong with this one, I still ememified it.

From Bart Braem:
packet-mip.c does not have support for all registration denials by the foreign agent, code 77 was left out. The attached patch fixes that.

svn path=/trunk/; revision=16868
2005-12-20 18:38:13 +00:00
Jörg Mayer e3c87533ae packet-rnsap.[hc] were added to Makefile.common but missing from svn
svn path=/trunk/; revision=16866
2005-12-20 09:23:42 +00:00
Jörg Mayer 9575877bb7 packet-radius.c, packet-xml.c:
Fix a memory leak found by valgrind:
        Although dir isn't a directory it may still use memory

packet-xml.c:
        Reformat the relevant function in packet-xml.c to be readable on systems
        where a tab is 8 spaces.

svn path=/trunk/; revision=16865
2005-12-20 08:35:53 +00:00
Anders Broman fadf4746d1 Add dissection of RNSAP, not complete yet.
svn path=/trunk/; revision=16864
2005-12-20 07:22:33 +00:00
Anders Broman f9d87c5800 Get rid of some GCC warnings about unused code.
svn path=/trunk/; revision=16861
2005-12-19 19:36:32 +00:00
Luis Ontanon b56c1ffc6f register the m3ua dissector by name
svn path=/trunk/; revision=16859
2005-12-19 19:21:32 +00:00
Luis Ontanon 0d2f2c33ff Avoid a warning if release_cause == 0
svn path=/trunk/; revision=16858
2005-12-19 19:20:31 +00:00
Luis Ontanon 5113ab4d4a Add support for Juniper GGSN generated pcap files.
svn path=/trunk/; revision=16857
2005-12-19 19:18:20 +00:00
Anders Broman 185cfdefd4 From John Sullivan:
Three patches here:

eth-ed-2.diff
-------------

1) The handling of HashSet Answer messages was wrong
2) Add dissection of some more eMule extension packets to do with
   error recovery

   
eth-bt-1.diff
-------------

New versions of the Azureus BitTorrent client implement a new extension to the protocol, which is effectively a text based encapsulation of the binary BitTorrent protocol, embedded within the BitTorrent protocol. Who knows why they thought that was a good idea, but this patch can pick apart their new headers.


eth-bt-2.diff
-------------

By registering a normal dissector as well as the heuristic one, BitTorrent shows up on the Decode As... list so you can manually override its mistake.

svn path=/trunk/; revision=16856
2005-12-19 06:48:07 +00:00
Jörg Mayer dba7a99e1d warning: C++ style comments are not allowed in ISO C90
svn path=/trunk/; revision=16853
2005-12-18 23:22:47 +00:00
Jörg Mayer b06bd208d0 warning: function declaration isn't a prototype
svn path=/trunk/; revision=16852
2005-12-18 23:18:06 +00:00
Anders Broman aec5bebc77 From Michael Rozhavsky:
In my previous patch I forgot to add a OOBResync flag to the DBD packet flags field. This patch adds this flag.

svn path=/trunk/; revision=16847
2005-12-18 19:01:46 +00:00
Anders Broman e3e3e3f5f8 From Greg Morris:
-  New Dissector Novell Cluster Services

1. Changes Dir Handle Type from Boolean to val string
2. Changes Search Mode from Boolean to val string
3. Adds a number of additional attribute definitions
4. Adds file migration state values
5. Adds missing return values
6. Adds NCP 90,150 "File Migration Request"
 

svn path=/trunk/; revision=16844
2005-12-18 18:13:05 +00:00
Guy Harris 004eb8b1c1 If we're going to use a handle for the data handle, we need to get a
handle for that dissector.  This fixes bug 637.

svn path=/trunk/; revision=16842
2005-12-18 11:19:25 +00:00
Guy Harris 9851c0aa87 Get rid of an unused variable.
svn path=/trunk/; revision=16840
2005-12-18 10:59:45 +00:00
Guy Harris e09d859591 Squelch a compiler warning.
svn path=/trunk/; revision=16839
2005-12-18 10:58:47 +00:00
Guy Harris df02403f08 Get rid of an unused variable.
svn path=/trunk/; revision=16838
2005-12-18 10:51:41 +00:00
Guy Harris bcd1cacaa7 Get rid of an unused variable.
Fix a typo in svn:keywords.

svn path=/trunk/; revision=16837
2005-12-18 10:42:29 +00:00
Luis Ontanon 0f4cc578a1 remove // comments
svn path=/trunk/; revision=16835
2005-12-17 21:17:58 +00:00
Luis Ontanon bc84ba5de6 Have tcap subdissectors registering using functions provided by tcap and tcap manage ssn registration.
In packet-sccp.c avoid not having a binding.


svn path=/trunk/; revision=16834
2005-12-17 16:55:45 +00:00
Ronnie Sahlberg 99395c7775 add work in progress srvsvc.idl.
This idl file is required by wkssvc.idl since wkssvc references Platform_id


There are still some minor changes required for pidl to prettify the output for both wkssvc and srvsvc before these two dissectors should be used.



note that this idl is significantly different from the samba4 idl since it contains all the additional functions and structures the handwritten dissector has that is lacking from s4 idl.

it is expected that s4 will take up the authorative version of this idl soon so there will only be one master copy of this idl.




svn path=/trunk/; revision=16831
2005-12-16 22:06:52 +00:00
Anders Broman 111de4ae66 A patch for packet-ospf.c is attached:
- Fix the handling of the DN-bit of options field.
 - Add a new function dissect_ospf_bitfield() to dissect a bitfield
   such as options, flags. The following functions are merged by
   using this function.
     - dissect_ospf_lls_extended_options()
     - dissect_ospf_dbd()
     - dissect_ospf_options()
     - dissect_ospf_v3_prefix_options()
 - dissect the flags and prefix-options bitfield.

svn path=/trunk/; revision=16828
2005-12-16 20:37:45 +00:00
Anders Broman fa04b29920 As per Olivier Jacques mail,
"preferences/mtp3 must be changed accordingly (it is explicitly indicated that the "network address format" is ..."
Change the text and som names.

svn path=/trunk/; revision=16827
2005-12-16 20:36:09 +00:00
Jörg Mayer 0beb951745 Some updates
svn path=/trunk/; revision=16825
2005-12-16 17:52:05 +00:00
Anders Broman 6f23144e46 From Jaap Keuter:
- Editcap 
Mikko Tiihonen filed bug 379 including a patch for editcap. This wasn't picked up so far. I've ported the patch to svn 16820 and included a documentation patch.

-packet-ieee80211.c
Radek Vokal of RedHat filed a bug found by Vladimir Kondratiev of Intel in the 802.11 dissector. Radek provided a sample capture and Vladimir a oneliner patch. I've ported the patch to svn 16820 and tested it against the provided capture. Works well.


-From Kan Sasaki
A patch for packet-ospf.c is attached:
 - Fix the handling of the DN-bit of options field.
 - Add a new function dissect_ospf_bitfield() to dissect a bitfield
   such as options, flags. The following functions are merged by
   using this function.
     - dissect_ospf_lls_extended_options()
     - dissect_ospf_dbd()


     - dissect_ospf_options()
     - dissect_ospf_v3_prefix_options()
 - dissect the flags and prefix-options bitfield.

- lldp Bugfix Bug 596  LLDP TIA Network Policy Decode is not correct 

- Camel make it possible to dissect based on OID.

svn path=/trunk/; revision=16822
2005-12-16 16:37:03 +00:00
Anders Broman 9269a3b4f2 From Jaap Keuter:
Bug 373 complains about a field type. Trivial fix attached.

svn path=/trunk/; revision=16821
2005-12-16 16:31:46 +00:00
Anders Broman 336086ca21 From Michael Rozhavsky:
This patch adds support for draft-nguyen-ospf-lls-05.txt, draft-nguyen-ospf-oob-resync-05.txt and draft-nguyen-ospf-restart-05.txt. These are an alternative way to do OSPF graceful restart.

These drafts are implemented by cisco and several other vendors that want to interoperate with cisco. My patch adds a dissectors for LLS TLVs.

I had to modify the existing ospf dissector as it assumed that all the data after IP header is OSPF packet. This is not true anymore and probably was not true before as well.

Also please find attached an example of OSPF packets with LLS data blocks.
-- 
   
   

svn path=/trunk/; revision=16818
2005-12-16 07:37:28 +00:00
Anders Broman 8d05164bec Get rid of duplicted dissector tables for MTP3 Service indicator and SCCP ssn:s
svn path=/trunk/; revision=16815
2005-12-16 07:05:50 +00:00
Anders Broman 483ec5bd05 From Graeme Lunt:
* DOP - This has now been successfully tested and so is now enabled by default and workaround code removed. 
Also now uses the correct EXPORTs from the other modules/dissectors.

* X509SAT - Most of the selected attributes are now supported in addition to the DirectoryString syntax attributes. This includes restoring the correct DirectoryString syntax and also providing the basic syntaxes (e.g. OBJECT IDENTIFIER, PrintableString). The latter requires a sed line in the Makefile which I assume should be OK? Not all the SAT can be defined in x509sat - so some have been included in x509if and x509af - though x509sat.cnf contains the master list and references the other dissectors where appropriate.

(I still prefer a syntax registration approach but I don't think that is going to be agreed in the short term.)

* X509IF - a mechanism to register some formating, based upon the hf_index, that is used in the cnf file.

* A couple of fixes identified by Stig.

svn path=/trunk/; revision=16814
2005-12-16 06:47:22 +00:00
Ronnie Sahlberg 163252a41c From Stig B
Patch for COTP reassembly.

There does not seem to be any reasonable or cleaner way to fix COTP 
reassembly than adding the frame.[ch] patch.


svn path=/trunk/; revision=16813
2005-12-16 00:32:12 +00:00