32da185ed5
Don't cast away constness.
...
svn path=/trunk/; revision=54802
2014-01-14 18:42:54 +00:00
a48d06df11
We have to cast away constness here, because C doesn't have
...
parameterized types.
svn path=/trunk/; revision=54801
2014-01-14 18:42:16 +00:00
f862fc40ba
Don't cast away constness.
...
svn path=/trunk/; revision=54800
2014-01-14 18:35:36 +00:00
d99e0b13d4
Regenerate ANSI TCAP dissector from the changes in r54499.
...
svn path=/trunk/; revision=54799
2014-01-14 18:34:01 +00:00
afc159eaf3
Don't cast away constness.
...
svn path=/trunk/; revision=54798
2014-01-14 18:19:31 +00:00
11220f625c
Don't cast away constness.
...
svn path=/trunk/; revision=54797
2014-01-14 18:16:12 +00:00
834c79a07e
Don't cast away constness.
...
svn path=/trunk/; revision=54796
2014-01-14 18:12:14 +00:00
570a36436c
Consistently use "guint8" for "8-bit byte".
...
Constify.
For routines that manipulate sequences of 8-bit bytes, have them take
guint8 pointers rather than void pointers.
Don't cast away constness.
svn path=/trunk/; revision=54795
2014-01-14 18:03:54 +00:00
7a559d2876
Don't cast away constness.
...
svn path=/trunk/; revision=54794
2014-01-14 17:49:50 +00:00
13176da15b
Don't cast away constness.
...
svn path=/trunk/; revision=54793
2014-01-14 17:47:31 +00:00
0a99ee25d5
Don't make claims of constness that can't be guaranteed in terms the C
...
compiler can verify.
svn path=/trunk/; revision=54792
2014-01-14 17:45:03 +00:00
85ab202c08
Fix -Wsometimes-uninitialized found by Clang
...
packet-pdcp-lte.c:1397:9: error: variable 'decrypted_data' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:50: note: uninitialized use occurs here
decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1353:27: note: initialize the variable 'decrypted_data' to silence this warning
packet-pdcp-lte.c:1397:9: error: variable 'payload_length' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:66: note: uninitialized use occurs here
decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1354:24: note: initialize the variable 'payload_length' to silence this warning
svn path=/trunk/; revision=54791
2014-01-14 17:44:21 +00:00
6b6d709afc
Fix unused const variable found by Clang 3.4
...
svn path=/trunk/; revision=54790
2014-01-14 17:44:07 +00:00
a48b6f4aac
Upgrade LTE RRC dissector to v11.6.0
...
svn path=/trunk/; revision=54789
2014-01-14 16:51:10 +00:00
330654baf8
SNOW3G is not available on default Wireshark
...
svn path=/trunk/; revision=54788
2014-01-14 16:48:43 +00:00
eabf15f80a
Fix dissection of 3GPP2 SMS encoded in UCS2
...
svn path=/trunk/; revision=54787
2014-01-14 16:23:38 +00:00
293f8ca247
Make sure we allocate bytes for snow3g at least rounded up to next 4 byte boundary
...
svn path=/trunk/; revision=54786
2014-01-14 16:22:44 +00:00
b948c75dfe
Update a comment
...
svn path=/trunk/; revision=54785
2014-01-14 15:11:35 +00:00
58e8800136
Add snow3g integrity (not quite working for me), but rework how integrity and ciphering functions and conditional compilation is done
...
svn path=/trunk/; revision=54784
2014-01-14 15:07:20 +00:00
b0d4e7a34b
UCS2 encoded SMS is directly read from data -> remove PROTO_ITEM_SET_GENERATED()
...
svn path=/trunk/; revision=54783
2014-01-14 14:01:03 +00:00
b01a99c385
Provide hook for calling EEA1 implementation (Snow3G). Implementation not supplied due to licensing conditions. TODO: EIA1.
...
svn path=/trunk/; revision=54782
2014-01-14 11:09:47 +00:00
e2b668efe7
Whoever in GLibland was responsible for defining the signature of
...
g_snprintf() owes the world a huge apology. They *could* have just used
size_t, or they *could* at least have, if they insisted on having GLib
types to mirror regular types, made gsize an alias for size_t and,
whatever they did with gsize, they *could* have used it as the argument
for the size of the buffer for g_snprintf(), but no, they had to use
gulong.
svn path=/trunk/; revision=54781
2014-01-14 10:50:26 +00:00
ecdc864656
Don't cast away constness.
...
svn path=/trunk/; revision=54780
2014-01-14 08:32:50 +00:00
e1b57afbc9
Don't cast away constness.
...
svn path=/trunk/; revision=54779
2014-01-14 08:30:45 +00:00
9232db14c7
But *do* cast const void * to the appropriate type.
...
svn path=/trunk/; revision=54778
2014-01-14 08:30:24 +00:00
1ec9417a43
Don't cast away constness.
...
svn path=/trunk/; revision=54777
2014-01-14 08:26:24 +00:00
6aa49e37e0
Don't assign away constness.
...
svn path=/trunk/; revision=54776
2014-01-14 08:22:38 +00:00
bd165ab19a
Don't cast away constness.
...
svn path=/trunk/; revision=54775
2014-01-14 08:14:28 +00:00
4a82c3b60b
Don't cast away constness.
...
svn path=/trunk/; revision=54774
2014-01-14 08:12:45 +00:00
dc71034565
Don't cast away constness.
...
svn path=/trunk/; revision=54773
2014-01-14 08:09:33 +00:00
382e2c895c
gsize, not gusize. Whatever.
...
svn path=/trunk/; revision=54772
2014-01-14 07:59:58 +00:00
8b2aced72c
Glib, gotta love it. No, gusize isn't the same as size_t, it's long,
...
which is Too Damn Short on Windows. (Microsoft, gotta love 'em. I
guess even more Windows programmers than UN*X programmers thought long
was 32 bits, now and forever, world without end, amen.)
svn path=/trunk/; revision=54771
2014-01-14 07:58:18 +00:00
aaeb6a467b
Don't cast away constness.
...
svn path=/trunk/; revision=54770
2014-01-14 07:56:43 +00:00
dd152d81af
Don't cast away constness.
...
svn path=/trunk/; revision=54769
2014-01-14 05:49:04 +00:00
4a7636a6f8
Don't cast away constness.
...
svn path=/trunk/; revision=54768
2014-01-14 05:47:50 +00:00
c6c1887a0b
Have ip6_to_str() and tvb_ip6_to_str() return const pointers, as the
...
ip_to_str equivalents do.
Don't cast away constness, and don't make it necessary to do so.
svn path=/trunk/; revision=54767
2014-01-14 05:39:57 +00:00
e1f6ad8387
Don't cast away constness.
...
svn path=/trunk/; revision=54766
2014-01-14 05:29:02 +00:00
0f40fd837c
Don't cast away constness.
...
svn path=/trunk/; revision=54765
2014-01-14 05:25:51 +00:00
720cfe49c8
Don't cast away constness. In one place, this requires that we use one
...
pointer while we're filling in a string and then assigning it to a const
pointer when we're done.
Don't use guint16 as a size value; it does no good (it doesn't magically
protect you againt too-long strings), it runs the potential risk of
overflow, it doesn't save time for arithmetic (32-bit or 64-bit
arithmetic may well be faster, and will at least be as fast), and it
doesn't save space (if it fits in a register, you save nothing, and if
it's on the stack, there will probably be padding.
svn path=/trunk/; revision=54764
2014-01-14 05:23:48 +00:00
547efd4dc9
Cast away constness.
...
svn path=/trunk/; revision=54763
2014-01-14 05:17:06 +00:00
1980bb74d9
Constification.
...
svn path=/trunk/; revision=54762
2014-01-14 04:09:21 +00:00
1b0cfd415c
Don't cast away constness.
...
svn path=/trunk/; revision=54761
2014-01-14 04:05:23 +00:00
6a4bd7a91e
Don't cast away constness.
...
svn path=/trunk/; revision=54760
2014-01-14 04:01:59 +00:00
6a9b99cf98
And more constification.
...
svn path=/trunk/; revision=54759
2014-01-14 04:01:34 +00:00
ccbebb0ee3
More constification.
...
svn path=/trunk/; revision=54758
2014-01-14 03:56:36 +00:00
c1b602584d
Don't make promises of constness that we can't honor.
...
svn path=/trunk/; revision=54757
2014-01-14 03:24:37 +00:00
60f06e558a
Don't cast away constness when you don't have to.
...
svn path=/trunk/; revision=54756
2014-01-14 03:16:27 +00:00
3decdd5d98
Squelch some casting-away-constness warnings.
...
svn path=/trunk/; revision=54755
2014-01-14 03:06:40 +00:00
f7b0675bc6
Clean up references to an address and squelch some warnings.
...
svn path=/trunk/; revision=54754
2014-01-14 02:30:05 +00:00
7b32b5c14a
Don't cast away constness.
...
svn path=/trunk/; revision=54753
2014-01-14 02:25:20 +00:00
Guy Harris