osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
37641 commits 23 branches 0 tags 1.3 GiB
Commit graph

110 commits

Author SHA1 Message Date
Bill Meier
794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier
126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
 2011-10-15 18:46:26 +00:00
Bill Meier
4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
 2011-10-06 03:35:44 +00:00
Bill Meier
94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Martin Mathieson
4a3d86e46c Be careful about reporting number of missing SNs when wrapping around SN range. 
svn path=/trunk/; revision=39088
 2011-09-22 15:28:46 +00:00
Bill Meier
d4a982fd1f Use '%" G_GINT64_MODIFIER "u' iso '%llu'. Fixes checkapi fail and (presumably) compile errors. 
svn path=/trunk/; revision=39083
 2011-09-21 21:07:07 +00:00
Martin Mathieson
d41594e01b Report as expert/malformed if the same SN appears as ACK and NACK in same status PDU. 
svn path=/trunk/; revision=39077
 2011-09-21 16:45:03 +00:00
Martin Mathieson
f220deb9a3 Update some comments. 
svn path=/trunk/; revision=38960
 2011-09-10 23:46:49 +00:00
Martin Mathieson
71cb9d69d2 Use correct hf item, and add reassembled length into subtree summary. 
svn path=/trunk/; revision=38896
 2011-09-06 13:18:26 +00:00
Martin Mathieson
0cd1b811af First stab at RLC re-assembly. 
svn path=/trunk/; revision=38895
 2011-09-06 12:01:28 +00:00
Martin Mathieson
ca126bace5 Don't attach sequence analysis results to control/data PDUs when not appropriate. The problem is that I use the frame number in the result hash table - I may end up adding more info (e.g. channel, SN) to further avoid attaching reports to wrong PDUs. 
svn path=/trunk/; revision=38208
 2011-07-26 10:16:02 +00:00
Martin Mathieson
7d7f7d870e Register nicer entry points for LTE RRC BCH messages, and use them in RLC, MAC, PDCP. 
svn path=/trunk/; revision=38131
 2011-07-20 12:19:22 +00:00
Martin Mathieson
049643cf28 From Pradip Biswas, bug 6127 - Added Decode for RRC BCCH (BCH and DL_SCH) messages on RLC-over-UDP. 
Add separate codes/cases for BCH-over-BCH and BCH-over-DLSCH.

svn path=/trunk/; revision=38115
 2011-07-19 16:41:56 +00:00
Martin Mathieson
3f3fde986f Add a generated field for the number of NACKs in an AM status PDU. 
svn path=/trunk/; revision=38076
 2011-07-18 10:40:57 +00:00
Martin Mathieson
5f95d18d59 Some fixes to UM sequence analysis. 
svn path=/trunk/; revision=37729
 2011-06-20 08:55:51 +00:00
Martin Mathieson
5d78458e4b Fix a typo (spotted by Pascal Quantin). 
svn path=/trunk/; revision=37622
 2011-06-08 17:10:40 +00:00
Martin Mathieson
cb78939ede Pass tap info into sequence analysis function. 
svn path=/trunk/; revision=37368
 2011-05-23 17:15:00 +00:00
Martin Mathieson
002b0e16ed Improve AM sequence analysis, check ACK looks sensible compared with latest SN received in opposite direction. 
svn path=/trunk/; revision=37272
 2011-05-19 01:05:26 +00:00
Jakub Zawadzki
ed59c450f4 Cleanup: replace se_alloc+memcpy combo with single se_memdup(). 
svn path=/trunk/; revision=36996
 2011-05-05 06:55:12 +00:00
Martin Mathieson
16cb326768 Allow signaling protocol (e.g. RRC) to set number of SN bits 
PDCP should use for DRB channels.

Not yet called by RRC.

svn path=/trunk/; revision=36692
 2011-04-17 21:34:47 +00:00
Martin Mathieson
deac0b8af4 Show Segment offset number in AM header root item. 
svn path=/trunk/; revision=36565
 2011-04-11 21:34:47 +00:00
Martin Mathieson
5344e9f3d9 Take care not to append RLC mode to proto_item twice. 
svn path=/trunk/; revision=36429
 2011-04-01 13:41:08 +00:00
Martin Mathieson
b138ffa9e7 Avoid some unnecessary assignments (as reported by clang). 
svn path=/trunk/; revision=36204
 2011-03-16 23:18:59 +00:00
Martin Mathieson
4d3d029e09 Remove some instances of _U_ where the parameter is now used. 
svn path=/trunk/; revision=36148
 2011-03-06 23:10:28 +00:00
Martin Mathieson
ee5202f2d8 When doing sequence analysis, allow for the first SN to be seen not to be 0. 
This will happen if the capture doesn't include the start of this channel.

svn path=/trunk/; revision=36091
 2011-02-28 12:26:26 +00:00
Gerald Combs
aaeca955a5 Try to fix more Clang scan-build warnings. 
svn path=/trunk/; revision=36005
 2011-02-18 21:44:06 +00:00
Martin Mathieson
6b4acef729 Allow PDCP dissector to be called for complete SDUs from UM RLC PDUs. 
svn path=/trunk/; revision=35775
 2011-02-02 23:23:07 +00:00
Bill Meier
03b57df5a0 Fix various typos and spelling errors. 
svn path=/trunk/; revision=35126
 2010-12-06 01:34:58 +00:00
Martin Mathieson
43bfcfc32a Assert was firing while working out sequence length for user plane frames. 
Treat signalling plane case separately.

svn path=/trunk/; revision=34893
 2010-11-15 23:32:34 +00:00
Martin Mathieson
76bc0e537b Pass ueid + channel-info into PDCP dissector. 
This will allow me soon to track per-channel sequence numbers...

svn path=/trunk/; revision=34793
 2010-11-05 18:00:35 +00:00
Martin Mathieson
3c5b012771 Don't allocate context struct until/unless heuristic signature string matches. 
svn path=/trunk/; revision=34752
 2010-11-02 15:17:58 +00:00
Martin Mathieson
d086e935e1 Add longer desriptions of SOStart and SOEnd fields. 
svn path=/trunk/; revision=34584
 2010-10-20 12:08:22 +00:00
Martin Mathieson
52e5567b2e Track and give link back to frame containing previous NACK. 
svn path=/trunk/; revision=34528
 2010-10-15 21:07:45 +00:00
Bill Meier
4ae8d25300 Minor code cleanup: 
- define some vars & fcns as static;
- remove an unused var;
- use tfs_set_notset in tfs.c;
- slightly simplify reg_handoff.

svn path=/trunk/; revision=34462
 2010-10-10 20:39:00 +00:00
Martin Mathieson
5d84e780d9 Fix sequence numbers reported when duplicate SN detected. 
svn path=/trunk/; revision=34161
 2010-09-20 17:01:22 +00:00
Martin Mathieson
055d654cc2 Add bandwidth figures to RLC stats (per-UE and per-channel). 
svn path=/trunk/; revision=34059
 2010-09-03 15:22:28 +00:00
Martin Mathieson
0319e1f71a Allow DRB frames to be passed to PDCP (where they may be decoded as IP). 
svn path=/trunk/; revision=33649
 2010-07-28 16:58:13 +00:00
Martin Mathieson
5a2ca22658 Minor formatting change. 
svn path=/trunk/; revision=33590
 2010-07-20 13:27:20 +00:00
Martin Mathieson
db478debbd Allocate tap structs rather than using one static struct. 
svn path=/trunk/; revision=33503
 2010-07-13 16:25:34 +00:00
Martin Mathieson
a8aeaf6986 Change a couple of format specifiers: %-nu looks better than %0nu here 
svn path=/trunk/; revision=33353
 2010-06-28 17:25:58 +00:00
Martin Mathieson
f95aed808a Further improvements to UM sequence analysis. 
svn path=/trunk/; revision=33346
 2010-06-28 10:50:03 +00:00
Martin Mathieson
b040f1ac8c Improve UM analysis - make it more like AM. 
svn path=/trunk/; revision=33328
 2010-06-25 23:04:16 +00:00
Martin Mathieson
97df849b98 Add new strings/dissector function for signalling RRC messages that will add 
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.

TODO: same for other RRC entry points...

svn path=/trunk/; revision=33251
 2010-06-18 07:07:55 +00:00
Martin Mathieson
bc020a6d63 Work out better whether RLC segment is a complete upper-layer PDU or not. 
svn path=/trunk/; revision=33242
 2010-06-17 06:36:23 +00:00
Martin Mathieson
4fcd48495f Add the direction to so expert info texts. 
svn path=/trunk/; revision=33207
 2010-06-10 15:28:41 +00:00
Martin Mathieson
5ed2e2f914 Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting 
svn path=/trunk/; revision=32611
 2010-04-30 17:15:59 +00:00
Martin Mathieson
253e2541e9 Put offset++ back in again. 
svn path=/trunk/; revision=32531
 2010-04-21 10:12:03 +00:00
Martin Mathieson
08100dc039 From Pascal Quantin: 
Don't report as an error if see non-zero padding bits.

svn path=/trunk/; revision=32524
 2010-04-20 15:41:03 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Martin Mathieson
1ef05048a3 Use val_to_str_const() where have no format is default string 
svn path=/trunk/; revision=32188
 2010-03-14 16:36:41 +00:00