Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
67ee5049d4
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_BOOLEAN
FT_IPv4
FT_EUI64
FT_GUID
FT_UINT_STRING
Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260 )
svn path=/trunk/; revision=39328
2011-10-10 00:39:31 +00:00
Bill Meier
94f36ca4ff
Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
...
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Bill Meier
e6bd9d1a8c
Whitespace cleanup:
...
Use consistent indentation;
Convert "4 space tabs" to spaces;
Remove trailing whitespace.
svn path=/trunk/; revision=39082
2011-09-21 18:55:03 +00:00
Bill Meier
781129806f
Fix ex "modeline" so it works;
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748
svn path=/trunk/; revision=39081
2011-09-21 17:49:11 +00:00
Anders Broman
5e31dc0f8c
Make dissection of AVP: 3GPP-User-Location-Info(22) l=15 f=V-- vnd=TGPP val=303231 more robust.
...
svn path=/trunk/; revision=38739
2011-08-26 06:22:20 +00:00
Anders Broman
430cd6f730
Use ENC_BIG_ENDIAN.
...
svn path=/trunk/; revision=38738
2011-08-26 05:54:00 +00:00
Stephen Fisher
d69f85cb4e
Mark length parameter as unused
...
svn path=/trunk/; revision=38714
2011-08-24 15:35:32 +00:00
Anders Broman
357767d835
Use elm_len for the length.
...
svn path=/trunk/; revision=38713
2011-08-24 15:22:29 +00:00
Anders Broman
1c9c62e1ca
Mark length as U(nsused)
...
svn path=/trunk/; revision=38618
2011-08-19 12:15:54 +00:00
Anders Broman
e56f077015
Fix MM Context for E-UTRAN SRVCC elment lengths
...
svn path=/trunk/; revision=38617
2011-08-19 12:02:49 +00:00
Bill Meier
3b627d04fd
Convert "4 space tabs" to spaces + do other whitespace cleaup.
...
svn path=/trunk/; revision=38328
2011-08-03 21:14:04 +00:00
Bill Meier
e6cb34fbac
Minor cleanup
...
[benign] Remove _U_ from param arg when param is actually used;
[benign] Use 'item' (not 'tree') arg for proto_item_append_text()
Whitespace
svn path=/trunk/; revision=38327
2011-08-03 20:31:51 +00:00
Bill Meier
a71d51d0d7
AFAICT, the item for 'hf_gtpv2_stn_sr' should be used as the parent tree-item in dissect_gtpv2_stn_sr().
...
This is a different fix for Coverity 1248 than that committed in SVN 38314.
svn path=/trunk/; revision=38323
2011-08-03 18:38:23 +00:00
Chris Maynard
e7928ce630
Fix Coverity CID 1248: unused value.
...
svn path=/trunk/; revision=38314
2011-08-02 19:29:51 +00:00
Anders Broman
00de9edf12
Add comment.
...
svn path=/trunk/; revision=38293
2011-07-31 20:20:30 +00:00
Anders Broman
e1313c5756
Add 3GPP Sv interface.
...
svn path=/trunk/; revision=38270
2011-07-30 14:05:31 +00:00
Stig Bjørlykke
ec2940333f
Fix a typo.
...
svn path=/trunk/; revision=38269
2011-07-30 09:52:40 +00:00
Anders Broman
0146079da4
CCRSI is not included in 3GPP 29.274 R8.
...
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6183
svn path=/trunk/; revision=38268
2011-07-30 09:33:10 +00:00
Bill Meier
8504d231c7
Use (what appears to be) the correct tvb for a function call: Fixes Coverity 919 [UNUSED];
...
#include <stdlib.h> not req'd.
svn path=/trunk/; revision=37336
2011-05-20 20:10:41 +00:00
Anders Broman
2ad1c8df66
VALS(& -> VALS(
...
svn path=/trunk/; revision=37009
2011-05-06 12:28:11 +00:00
Jeff Morriss
14232048bc
Avoid passing a NULL string pointer to format routines: some libc's (e.g.,
...
Solaris') will core on that.
Also clean up indentation and white space.
svn path=/trunk/; revision=36775
2011-04-21 18:09:13 +00:00
Anders Broman
8d6ca293dc
Change the signature of elem_fcn():ns to include pinfo.
...
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
5fbe65d670
Update 8.12 Indication IE to 3GPP TS 29.274 version 9.4.0 Release 9
...
svn path=/trunk/; revision=35921
2011-02-11 21:21:45 +00:00
Jeff Morriss
947ca59731
Register a couple of ett_ variables.
...
Move the declaration of all the ett_ variables after the hf_ variables
(instead of in between some of them).
svn path=/trunk/; revision=35920
2011-02-11 21:15:41 +00:00
Anders Broman
6956ad46d5
CN-Id is two bytes.
...
svn path=/trunk/; revision=35606
2011-01-21 09:24:43 +00:00
Jeff Morriss
6cfdeed280
Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
...
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().
There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.
Replace some memcpy()+tvb_get_ptr() with tvb_memcpy().
svn path=/trunk/; revision=35529
2011-01-14 03:44:58 +00:00
Anders Broman
46f62f1b49
Mark a parameter as unused.
...
svn path=/trunk/; revision=35507
2011-01-12 17:05:58 +00:00
Anders Broman
93cbda72dd
Enhance IE dissection.
...
svn path=/trunk/; revision=35506
2011-01-12 16:43:59 +00:00
Anders Broman
852c75636e
Improve dissection of UE Time Zone.
...
svn path=/trunk/; revision=35477
2011-01-11 17:06:38 +00:00
Anders Broman
275c3c8818
Shorten long winded strings.
...
svn path=/trunk/; revision=35456
2011-01-10 17:34:00 +00:00
Jeff Morriss
dc22fbfc50
Give CSID an abbreviation.
...
svn path=/trunk/; revision=35446
2011-01-10 03:02:43 +00:00
Anders Broman
5c6ab22ff3
Get rid of check_col().
...
svn path=/trunk/; revision=35432
2011-01-09 13:50:03 +00:00
Anders Broman
f23d884631
Try to fix:
...
packet-gtpv2.c:2648: warning: return type defaults to 'int'
packet-gtpv2.c: In function 'dissect_udp_s_port_nr':
packet-gtpv2.c:2690: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_fq_csid':
packet-gtpv2.c:2845: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_emlpp_pri':
packet-gtpv2.c:2927: warning: implicit declaration of function 'be_emlpp_prio'
packet-gtpv2.c: At top level:
packet-gtpv2.c:3056: warning: initialization from incompatible pointer type
svn path=/trunk/; revision=35431
2011-01-08 20:26:35 +00:00
Anders Broman
b6427b53b5
Further IE dissection updates.
...
svn path=/trunk/; revision=35430
2011-01-08 20:09:29 +00:00
Jeff Morriss
bf2796ab92
Don't try to display a string in BASE_DEC. Also delete duplicate registration of hf_gtpv2_pti.
...
svn path=/trunk/; revision=35422
2011-01-07 19:01:17 +00:00
Anders Broman
f235eadf25
** (process:23326): WARNING **: Field 'Reserved bit(s)' does not have an
...
abbreviation
** ERROR **: Field 'IPv4 Address' (gtpv2.ipv4_addr) is an FT_IPv4 but is being
displayed as BASE_DEC instead of BASE_NONE
svn path=/trunk/; revision=35420
2011-01-07 18:04:03 +00:00
Anders Broman
6d801a2052
Fix buildbot.
...
svn path=/trunk/; revision=35419
2011-01-07 16:12:01 +00:00
Anders Broman
863e3f80a6
Add dissection of more IE:s
...
svn path=/trunk/; revision=35417
2011-01-07 15:21:23 +00:00
Anders Broman
660d827706
Enhance IE dissection.
...
svn path=/trunk/; revision=35378
2011-01-05 16:46:40 +00:00
Jeff Morriss
f94b75c658
Give a couple of fields abbreviations.
...
svn path=/trunk/; revision=35362
2011-01-04 18:41:25 +00:00
Anders Broman
95397594c9
Maeke use of dissect_e212_mcc_mnc_ep_str().
...
svn path=/trunk/; revision=35361
2011-01-04 16:58:55 +00:00
Anders Broman
9eb2d42bac
Add more info to the tree.
...
svn path=/trunk/; revision=35354
2011-01-04 07:14:11 +00:00
Anders Broman
da59924551
Prettify dissection of User Location Info (ULI). (Complete)
...
svn path=/trunk/; revision=35352
2011-01-03 23:21:49 +00:00
Anders Broman
5045d66232
Prettify dissection of User Location Info (ULI).
...
svn path=/trunk/; revision=35351
2011-01-03 22:13:11 +00:00
Anders Broman
24550de720
Mark unused parameters as such.
...
svn path=/trunk/; revision=35341
2011-01-03 17:32:15 +00:00
Anders Broman
288d47d1f2
Mark unused parameters as such.
...
svn path=/trunk/; revision=35340
2011-01-03 17:30:35 +00:00
Anders Broman
56c1d1569c
Comment out a faulty line.
...
svn path=/trunk/; revision=35339
2011-01-03 17:26:12 +00:00
Anders Broman
9794ffb051
Enhance IE dissection and a number of bug fixes.
...
svn path=/trunk/; revision=35338
2011-01-03 17:22:02 +00:00
Anders Broman
f27aa6297a
Extend IE dissetcion.
...
svn path=/trunk/; revision=35307
2010-12-30 14:09:09 +00:00