osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
37641 commits 23 branches 0 tags 1.3 GiB
Commit graph

85 commits

Author SHA1 Message Date
Anders Broman
49f715f169 Remove unused hf field. 
svn path=/trunk/; revision=39238
 2011-10-03 06:24:28 +00:00
Bill Meier
e2f6d85655 Fix a 'set but not used' gcc warning; Mark param arg as _U_; 
Whitespace cleanup: trailing blanks & "4 space tabs".

svn path=/trunk/; revision=38925
 2011-09-07 19:35:55 +00:00
Anders Broman
c1e282bf9f From Lei Chen: 
Implement 'IAR Rest Octets', 'IAX Rest Octets' and
'Multislot Allocation'

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6314

svn path=/trunk/; revision=38911
 2011-09-07 07:49:20 +00:00
Anders Broman
1c4d4319ee From Lei Chen: 
Support E-UTRAN neighbor cells in Enhanced Measurement Report.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6275

svn path=/trunk/; revision=38765
 2011-08-29 05:24:10 +00:00
Anders Broman
b5740c2288 From Jeremy Quirke: 
misdecoding 3G Neighbour Cell Information Element in SI2quater message due to a coding typo

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6237

svn path=/trunk/; revision=38542
 2011-08-15 04:39:30 +00:00
Anders Broman
ce3db724c1 From Lei Chen: 
patch to support gsm rr decoding of Immediate Assignment rest octet
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6119

svn path=/trunk/; revision=38348
 2011-08-05 07:02:22 +00:00
Bill Meier
c67363e4de Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings. 
svn path=/trunk/; revision=38170
 2011-07-22 18:33:44 +00:00
Anders Broman
0a65432f96 Use ENC_BIG_ENDIAN. 
svn path=/trunk/; revision=38135
 2011-07-20 14:09:19 +00:00
Bill Meier
e69a4c6e45 Don't assign to a proto_item * if the value won't be used: Coverity 911; 
Fix bug wherein an item was apparently added to the wrong subtree: Coverity 910;
Remove unneeded #includes;
Do whitespace and indentation cleanup.

svn path=/trunk/; revision=36530
 2011-04-09 17:17:47 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00
Anders Broman
fd782e736c From Vincent Helfre: 
- added documentation in packet-csn1.h
- fixed a bug in packet-csn1.c
- fixed a BSIC description in packet-gsm_a_rr.c
- removed the "_v" suffix in packet-gsm_rlcmac element description

svn path=/trunk/; revision=36284
 2011-03-23 09:14:50 +00:00
Anders Broman
ed66081a4d From Alexis La Goutte: 
Cleanup packet-ipv6.h and dependency.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713

svn path=/trunk/; revision=36031
 2011-02-23 13:51:49 +00:00
Anders Broman
a469849210 From Pascal Quantin: 
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
 2011-02-22 11:56:10 +00:00
Anders Broman
821f91f278 - append TLLI value. 
- Whitespace changes.

svn path=/trunk/; revision=35572
 2011-01-17 21:10:54 +00:00
Anders Broman
b124071369 From Vincent Helfre: 
fixed the conversions for utran and eutran threshold which are used for Enhanced Measurement Report.

svn path=/trunk/; revision=35199
 2010-12-16 12:26:49 +00:00
Anders Broman
5a0e550686 From Vincent Helfre: 
I have fixed some issue in the measurement information decoding in packet-gsm_a_rr.c.

svn path=/trunk/; revision=35061
 2010-11-29 13:12:35 +00:00
Anders Broman
5f1b6a507b From Alex Badea: 
gsm_a_rr: System Information Type 4 / CBCH mobile allocation dissected incorrectly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5436

svn path=/trunk/; revision=35054
 2010-11-28 20:58:26 +00:00
Anders Broman
b91ed78bcc Add a value_string_ext. 
svn path=/trunk/; revision=34825
 2010-11-09 17:24:45 +00:00
Anders Broman
348e0bc54b Use value_string_ext for gsm_a_rr_rxlev_vals. 
svn path=/trunk/; revision=34818
 2010-11-09 07:28:04 +00:00
Anders Broman
5bf4fc3116 From Vincent Helfre: 
Some improvements for the presentations.

svn path=/trunk/; revision=34620
 2010-10-22 13:35:03 +00:00
Anders Broman
64d4b08a82 From Vincent Helfre: 
various bug fix and enhancement for Release 8 additionnal parameters.

svn path=/trunk/; revision=34585
 2010-10-20 12:40:13 +00:00
Anders Broman
0d4a4542ba From Vincent Helfre: 
Display the bits for 
.... .00. = PCID_Pattern: 0

svn path=/trunk/; revision=34262
 2010-09-27 12:53:42 +00:00
Anders Broman
a498b71098 Initialize subtree. 
svn path=/trunk/; revision=34261
 2010-09-27 10:11:40 +00:00
Anders Broman
415691da9d From Vincent Helfre: 
Release 8 june 2010 parameters decoding for SI2quater and Measurement Information messages.

svn path=/trunk/; revision=34260
 2010-09-27 08:45:16 +00:00
Anders Broman
14b9a4c56a From Vincent Helfre: 
Incorrect decoding of List of ARFCN in BCCH frequency list.
When the range 1024 is selected, it can happen that 2 bytes need to be read for
W1, and also for W2. In the current version, when W1 ends on a byte boundary,
W2 will get an incorrect value, since it will be truncated by 1 bit.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5214

svn path=/trunk/; revision=34113
 2010-09-14 14:24:39 +00:00
Bill Meier
dac0bf77ed Fix cases where the type of a for loop variable is smaller than the type of the "end" variable. 
In some cases the usage may have been benign since it can be seen by code inspection that the maximum value of the end variable can't exceed the maximum value of the loop variable.
However, on general principles, all the usages have been fixed.

svn path=/trunk/; revision=33692
 2010-08-02 13:09:01 +00:00
Anders Broman
f9d6b18de7 from Sylvain Munaut: 
SDCCH8 subchannel decoding error in GSM RR dissector 
Summary:  SDCCH8 subchannel decoding error in GSM RR dissector  

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4910

svn path=/trunk/; revision=33312
 2010-06-24 10:42:13 +00:00
Bill Meier
e79dddc257 Add an if-test to fix a fuzz-test crash; 
See Bug #4897: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4897

svn path=/trunk/; revision=33280
 2010-06-21 14:24:34 +00:00
Bill Meier
10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces) 
svn path=/trunk/; revision=32735
 2010-05-10 15:54:57 +00:00
Anders Broman
447faa6082 From Mike Morrin: 
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712

svn path=/trunk/; revision=32606
 2010-04-29 20:45:53 +00:00
Bill Meier
09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Gerald Combs
b3a1cd8859 Temporary (?) fix for bug 4623. 
svn path=/trunk/; revision=32327
 2010-03-30 21:12:52 +00:00
Bill Meier
de4c6ff515 Fix a number of gcc _Wshadow warnings 
svn path=/trunk/; revision=31557
 2010-01-18 21:49:47 +00:00
Gerasimos Dimitriadis
809477b66e Fix for Bug 4197: 
Neighbour Cell Description 2 decode error

svn path=/trunk/; revision=31177
 2009-12-04 20:27:16 +00:00
Gerasimos Dimitriadis
c840cdd5a0 Remove the address operator from value_string arrays fed to VALS() 
svn path=/trunk/; revision=30995
 2009-11-17 18:35:27 +00:00
Gerasimos Dimitriadis
79cf9b5f45 Erroneously ommitted from the patch of Bug 4219: 
bit_offset used instead of curr_bit_offset


svn path=/trunk/; revision=30974
 2009-11-16 16:20:49 +00:00
Gerasimos Dimitriadis
9b36fc784e From yy: 
About GSM system information type 2quater
Modified to use newly defined tvb_get_bits() in tvbuff.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4219


svn path=/trunk/; revision=30962
 2009-11-14 20:13:43 +00:00
Jaap Keuter
75f1e13c12 Cleanup header fields. 
svn path=/trunk/; revision=30394
 2009-10-07 23:08:22 +00:00
Bill Meier
6c545e0d79 Save some memory: Don't statically allocate ett[] arrays used "dynamically". 
svn path=/trunk/; revision=29929
 2009-09-15 17:37:54 +00:00
Anders Broman
d41058065f From Mike Morrin: 
The GSM L3 part of the BSSMAP CipherModeComplete message is not being decoded.
Sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3983

svn path=/trunk/; revision=29776
 2009-09-07 17:17:07 +00:00
Anders Broman
e99983ab3a From Vincent Helfre: 
Dissect_ccch does not dissect sys info content.
Me: Remove check_col.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3901

svn path=/trunk/; revision=29693
 2009-09-04 11:06:52 +00:00
Anders Broman
4e87c254f0 From Mike Morrin: 
Minor errors in gsm rr dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3889

Modified accoring to comments from Pascal Quantin(I hope I got it right).

svn path=/trunk/; revision=29549
 2009-08-25 17:22:32 +00:00
Anders Broman
7945bf1bc9 From Harald Welte : 
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919

From me try to fix missuse of pinfo.

svn path=/trunk/; revision=29482
 2009-08-20 07:26:16 +00:00
Anders Broman
87da96be52 From Jan Lübbe: 
packet-gsm_a_rr.c: flip gsm_a_rr_mv_vals, 0 means vaild.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3915

svn path=/trunk/; revision=29472
 2009-08-19 09:32:56 +00:00
Kovarththanan Rajaratnam
97fda7386c Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893

svn path=/trunk/; revision=29403
 2009-08-13 12:17:20 +00:00
Jaap Keuter
7267ec9782 Complete the fix in r29389. 
svn path=/trunk/; revision=29390
 2009-08-11 23:52:04 +00:00
Gerald Combs
4bfcd5993a Instead of calling DISSECTOR_ASSERT_NOT_REACHED, just say the subchannel 
is unknown. Fixes bug 3864.

svn path=/trunk/; revision=29389
 2009-08-11 23:44:22 +00:00
Bill Meier
3c1bc8f251 Fix some individual cases of 'if (unsigned) < 0' 
svn path=/trunk/; revision=29320
 2009-08-06 23:51:45 +00:00
Bill Meier
21d8e2d3e1 Prevent possible (benign ?) array references with an array index of -1. 
svn path=/trunk/; revision=29312
 2009-08-06 18:44:38 +00:00