4d9475e4ef
Get rid of tvb_get_faked_unicode() - tvb_get_string_enc() does the job
...
better.
We don't need eventlog_get_unicode_string_length() in the eventlog
dissector, either - tvb_unicode_strsize() does the job just as well.
svn path=/trunk/; revision=54874
2014-01-21 09:56:34 +00:00
35d0d0f1ae
From Igor Slepchin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9675 :
...
RMT LCT dissector doesn't display 48-bit TOIs and TSIs properly
svn path=/trunk/; revision=54873
2014-01-21 08:59:47 +00:00
0bc06ee3ab
- Remove unneeded #includes;
...
- "Once-only" test not needed in proto_reg_handoff..();
- Set COL_PROTOCOL, clear COL_INFO at the begining of the dissector
before fetching data from the tvb;
- Use tvb_reported_length;
- Use col_set_str/col_append_str where appropriate;
- Zigbee --> lwm;
- Fix typo;
- Reformat some whitespace for consistency.
ToDo:
- Review use of col_...() and expert...() under 'if (tree)';
- Review use of col_clear(..., COL_INFO) after text already added to COL_INFO;
- Review certain tvb fetches to ensure no fetches using a negative offset;
svn path=/trunk/; revision=54871
2014-01-21 02:32:48 +00:00
45d5b74219
Fix declaration of tvb_get_string().
...
svn path=/trunk/; revision=54870
2014-01-21 01:44:58 +00:00
c540e33c49
Add properties ....
...
svn path=/trunk/; revision=54869
2014-01-21 01:24:13 +00:00
9cdf8dd5f5
Don't do the byte-with-8th-bit-set-to-REPLACEMENT-CHARACTER mapping for
...
UTF-8 strings.
Add that mapping for null-terminated ASCII strings.
Factor out some common parts of comments about string routines, and
clean up some other comments.
svn path=/trunk/; revision=54868
2014-01-21 01:23:29 +00:00
6517e3ba4b
don't use tvb_get_string(..., len) to get exactly len raw bytes
...
from a tvbuff
svn path=/trunk/; revision=54867
2014-01-20 23:30:01 +00:00
ae82a1cafe
make MMI strings filterable
...
svn path=/trunk/; revision=54866
2014-01-20 22:06:19 +00:00
26701ed0f7
remove todo comments
...
svn path=/trunk/; revision=54865
2014-01-20 21:56:38 +00:00
933e95c8ec
tvb_get_string(): replace 8bit characters with the unicode replacement char
...
svn path=/trunk/; revision=54864
2014-01-20 21:39:00 +00:00
1d27123ab1
Longs are not guaranteed to be 64-bit. Use G_GINT64_MODIFIER to format
...
64-bit quantities.
svn path=/trunk/; revision=54863
2014-01-20 21:37:32 +00:00
3a96d94c50
From Michal Labedzki:
...
Bluetooth/Ubertooth: Improvements: Support for new btsnoop format, almost finished btle and minor fixes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9606
svn path=/trunk/; revision=54862
2014-01-20 20:36:42 +00:00
5fc0904093
packet-bootp.c: In function 'dissect_vendor_generic_suboption':
...
packet-bootp.c:3293: warning: unused parameter 'pinfo'
packet-bootp.c:3293: warning: unused parameter 'v_ti'
packet-bootp.c:3294: warning: unused parameter 'optend'
svn path=/trunk/; revision=54861
2014-01-20 20:30:41 +00:00
f0fb43a621
From alexeyv:
...
Add decryption for resumed TLS sessions with a session ticket.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5963
svn path=/trunk/; revision=54860
2014-01-20 20:26:04 +00:00
6402d8590e
Add generic dissection of unknown vendor sub options.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9594
svn path=/trunk/; revision=54859
2014-01-20 20:03:49 +00:00
77e4a2f09c
Fix 32/64 casting and add a note where the loss of precision might actually be a
...
problem for 32-bit platforms.
svn path=/trunk/; revision=54858
2014-01-20 19:32:43 +00:00
f5931c7559
From Pavel Moravec via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9612
...
AMQP 1.0 Dissector
svn path=/trunk/; revision=54857
2014-01-20 19:13:42 +00:00
d2410336b8
From Lubos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9638
...
New Dissector For Lightweight Mesh protocol
A dissector for ATMEL Lightweight Mesh protocol (lwm).
The protocol is carried on the top of 802.15.4 frame.
From me:
* Add Modelines info
* Fix indent (use 4 spaces)
* Remove trailing whitespace
svn path=/trunk/; revision=54856
2014-01-20 18:35:45 +00:00
a0df200a84
coverity 702387
...
add missing NULL check
svn path=/trunk/; revision=54848
2014-01-19 16:19:24 +00:00
bb5051e85a
[Automatic manuf, services and enterprise-numbers update for 2014-01-19]
...
svn path=/trunk/; revision=54844
2014-01-19 15:03:43 +00:00
95ed1b4977
As spotted by Joerg; make a HFILL_INIT(hf) macro and use it to init the private part of the hf structure.
...
svn path=/trunk/; revision=54843
2014-01-19 09:40:04 +00:00
6429497015
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9649 :
...
SMPP: source_telematics_id value length is 1 byte
svn path=/trunk/; revision=54837
2014-01-17 22:18:50 +00:00
f63d80c2e4
From Fabio Tarabelloni via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9650 :
...
ZigBee ZCL Appliance Identification: fix endianness of Company ID, Brand ID and Product Type ID
svn path=/trunk/; revision=54836
2014-01-17 21:52:55 +00:00
493ba3e367
Try to fix warning: initializer element is not computable at load time.
...
svn path=/trunk/; revision=54832
2014-01-17 18:58:50 +00:00
a49fee443b
Fix a bug intrduced in http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54820
...
svn path=/trunk/; revision=54831
2014-01-17 18:55:49 +00:00
62249477b6
Remove #include and make the situation with snow3g clearer in a comment. May need further removal, depending upon concensus on wireshark-dev
...
svn path=/trunk/; revision=54827
2014-01-16 12:02:30 +00:00
60045cae1c
Implement basic support for SPXII decoding (at least we get the payload offsets
...
right now).
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9552
svn path=/trunk/; revision=54823
2014-01-15 23:56:41 +00:00
1c6679c5ec
Dissect SPXII flag bits.
...
First part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9552
svn path=/trunk/; revision=54822
2014-01-15 23:09:36 +00:00
622d9cb953
Add modelines and fix one indentation issue.
...
svn path=/trunk/; revision=54821
2014-01-15 23:00:07 +00:00
efbecb3e9a
Fix a couple of
...
warning: initializer element is not computable at load time
svn path=/trunk/; revision=54820
2014-01-15 19:29:03 +00:00
9228c72ef0
Explain casting away const.
...
svn path=/trunk/; revision=54816
2014-01-15 08:35:55 +00:00
1f8d2e25d2
Update to version V12.3.0 (2013-12).
...
svn path=/trunk/; revision=54815
2014-01-15 07:13:23 +00:00
d15a6d0add
Don't cast away constness.
...
svn path=/trunk/; revision=54814
2014-01-15 03:37:06 +00:00
ada9dafdf0
Don't cast away constness.
...
svn path=/trunk/; revision=54813
2014-01-15 03:35:44 +00:00
61867d0b2f
Eliminate fvalue_set() in favor of routines that take arguments
...
appropriate for particular FT_ types. This lets us do some more type
checking and lets us use const pointers when appropriate.
Constify a bunch of stuff, and don't cast away constness.
svn path=/trunk/; revision=54811
2014-01-15 01:05:03 +00:00
32da185ed5
Don't cast away constness.
...
svn path=/trunk/; revision=54802
2014-01-14 18:42:54 +00:00
a48d06df11
We have to cast away constness here, because C doesn't have
...
parameterized types.
svn path=/trunk/; revision=54801
2014-01-14 18:42:16 +00:00
f862fc40ba
Don't cast away constness.
...
svn path=/trunk/; revision=54800
2014-01-14 18:35:36 +00:00
d99e0b13d4
Regenerate ANSI TCAP dissector from the changes in r54499.
...
svn path=/trunk/; revision=54799
2014-01-14 18:34:01 +00:00
afc159eaf3
Don't cast away constness.
...
svn path=/trunk/; revision=54798
2014-01-14 18:19:31 +00:00
11220f625c
Don't cast away constness.
...
svn path=/trunk/; revision=54797
2014-01-14 18:16:12 +00:00
834c79a07e
Don't cast away constness.
...
svn path=/trunk/; revision=54796
2014-01-14 18:12:14 +00:00
570a36436c
Consistently use "guint8" for "8-bit byte".
...
Constify.
For routines that manipulate sequences of 8-bit bytes, have them take
guint8 pointers rather than void pointers.
Don't cast away constness.
svn path=/trunk/; revision=54795
2014-01-14 18:03:54 +00:00
7a559d2876
Don't cast away constness.
...
svn path=/trunk/; revision=54794
2014-01-14 17:49:50 +00:00
13176da15b
Don't cast away constness.
...
svn path=/trunk/; revision=54793
2014-01-14 17:47:31 +00:00
0a99ee25d5
Don't make claims of constness that can't be guaranteed in terms the C
...
compiler can verify.
svn path=/trunk/; revision=54792
2014-01-14 17:45:03 +00:00
85ab202c08
Fix -Wsometimes-uninitialized found by Clang
...
packet-pdcp-lte.c:1397:9: error: variable 'decrypted_data' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:50: note: uninitialized use occurs here
decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1353:27: note: initialize the variable 'decrypted_data' to silence this warning
packet-pdcp-lte.c:1397:9: error: variable 'payload_length' is used uninitialized whenever 'if' condition is false
packet-pdcp-lte.c:1469:66: note: uninitialized use occurs here
decrypted_tvb = tvb_new_child_real_data(tvb, decrypted_data, payload_length, payload_length);
packet-pdcp-lte.c:1354:24: note: initialize the variable 'payload_length' to silence this warning
svn path=/trunk/; revision=54791
2014-01-14 17:44:21 +00:00
6b6d709afc
Fix unused const variable found by Clang 3.4
...
svn path=/trunk/; revision=54790
2014-01-14 17:44:07 +00:00
a48b6f4aac
Upgrade LTE RRC dissector to v11.6.0
...
svn path=/trunk/; revision=54789
2014-01-14 16:51:10 +00:00
330654baf8
SNOW3G is not available on default Wireshark
...
svn path=/trunk/; revision=54788
2014-01-14 16:48:43 +00:00
Guy Harris