Commit Graph

5586 Commits

Author SHA1 Message Date
Richard van der Hoff cf9760900c From Chris Maynard <christopher.maynard@gtech.com>: Incorrect display filter field naming convention.
svn path=/trunk/; revision=23087
2007-10-07 23:30:14 +00:00
Richard van der Hoff c32305f542 From Chris Maynard <christopher.maynard@gtech.com>: Incorrect display filter field naming convention.
svn path=/trunk/; revision=23086
2007-10-07 23:23:23 +00:00
Anders Broman 0de04bfc24 From Martin Peylo:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1888

There are new versions of CMP (v2) in RFC4210 and CRMF (v2) in RFC4211. The
right to exist of CRMF is bound to CMP so I don't split that into two bug
reports. 

I'll upload the new (slightly handmassaged) ASN.1 files for both protocols,
along with patches for the respective cnf files, where I also added new
#.REGISTER statements.

Additionally I had to export some definitions from pkix1explicit (Attribute,
Time, UniqueIdentifier and Version) and from pkix1implicit (KeyIdentifier).
I'll also upload a patch for that.

I uploaded a CMPv2 sample (with errors in the protocol!) to the wiki.

svn path=/trunk/; revision=23082
2007-10-07 16:02:04 +00:00
Anders Broman dd12268277 Add ethertype for IEEE 802.1ag Connectivity Fault Management (CFM) protocol
svn path=/trunk/; revision=23081
2007-10-07 15:14:27 +00:00
Stig Bjørlykke feced5f683 - Initialize address_item in MessageIdentifier to avoid a crash in handling
LocalIdentifier when problems with the GlobalDomainIdentifier.  
- Initialize global pointers to avoid potential crashes.

svn path=/trunk/; revision=23080
2007-10-06 20:37:52 +00:00
Stig Bjørlykke af2d10d5bf - Added option to use relative message id (MSID)
- Added generated entry for total missing sequence numbers
- Added expert info on invalid ack info length
- Added count of ack in info column

svn path=/trunk/; revision=23079
2007-10-06 11:28:09 +00:00
Stig Bjørlykke e63da0188c From Andrei Rubaniuk:
This patch adds support for IMPS 1.3 protocol dissection and also 
updates IMPS 1.2 protocol to approved release version.

From me:
- Updated vals_wbxml_public_ids table.
- Reindented file.

svn path=/trunk/; revision=23078
2007-10-05 23:47:37 +00:00
Jeff Morriss d3600969fb From Andrew Feren via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1606 :
1) IPFIX port (4739) should be configurable without recompiling
2) It should be possible to specify more than one port to be dissected as
   Netflow and/or IPFIX
3) Netflow should recognize UDP ports 2055 and 9996 (Both are common)

Also (from me):
- make Netflow a "new style" dissector: return 0 if it doesn't appear to be a
  valid netflow packet
- register the old preference (cflow.udp.port) as obsolete so users don't see
  warnings about it not being valid

svn path=/trunk/; revision=23075
2007-10-05 21:25:35 +00:00
Tomas Kukosa e461d0d0e8 export more types from H.225.0 and H.245 which will be necessary for H.460.x, H.323 (Annex M,R), H.501
svn path=/trunk/; revision=23069
2007-10-05 07:44:03 +00:00
Stig Bjørlykke feb0330f2d Mask out correct bits in EBIT.
svn path=/trunk/; revision=23067
2007-10-04 13:22:40 +00:00
Martin Mathieson 5382f41680 Make selected length of first line include \r\n (as header lines do).
Make 'Message Body' a proper filterable field.

svn path=/trunk/; revision=23066
2007-10-04 10:24:59 +00:00
Stig Bjørlykke f95de28c72 Updated scsi_verdesc_val from appendix D in spc-3.
Dump Inquiry Vendor Specific and Reserved fields as bytes.
(still missing dumping of Clocking/QAS/IUS bits)

svn path=/trunk/; revision=23060
2007-10-03 16:22:50 +00:00
Stig Bjørlykke 05043ca65d Use correct offset for sccs, bque and reladdr flags.
svn path=/trunk/; revision=23059
2007-10-03 15:00:58 +00:00
Sake Blok a592e6412c This patch adds two new column types:
- COL_REL_CONV_TIME which is used to display the time relative to the first frame that was seen in the conversation
- COL_DELTA_CONV_TIME which is used to display the delta time from the previous frame of the conversation

It also adds the function "col_set_time()" to "epan/column-utils.[ch]" which can be called from within a dissector to set either of these two columns to the appropiate time.

Last but not least, it lets the tcp-dissector make use of these two columns.


svn path=/trunk/; revision=23058
2007-10-03 14:02:08 +00:00
Ronnie Sahlberg 170e4f4945 bug 1872
from chris maynard  fix some filter names for ansi_a


svn path=/trunk/; revision=23056
2007-10-02 21:26:22 +00:00
Ronnie Sahlberg 6ae363197c ifdef out a function that is not yet used
svn path=/trunk/; revision=23055
2007-10-02 21:21:55 +00:00
Anders Broman 3b092feb84 Fix comments
svn path=/trunk/; revision=23054
2007-10-02 20:28:11 +00:00
Anders Broman 9c15d7eca9 Dissect more IE's
svn path=/trunk/; revision=23053
2007-10-02 20:09:15 +00:00
Stig Bjørlykke 253eb0efb3 Check return value from ptvcursor_add in an attempt to fix bug 1886.
svn path=/trunk/; revision=23052
2007-10-02 19:02:58 +00:00
Stig Bjørlykke 37dc09ec79 Use given length when decoding fhandles as unknown.
svn path=/trunk/; revision=23051
2007-10-02 16:46:49 +00:00
Stig Bjørlykke 727d42fa9b Do not indicate bogus length if inside an icmp.
svn path=/trunk/; revision=23049
2007-10-02 15:46:17 +00:00
Jeff Morriss 46d3565179 Make the CPFI dissector new style: return 0 in several cases (including if we don't have MAC addresses for the packet) to give other dissectors a chance to dissect the packet. I rearranged the code quite a bit here and don't have a sample capture to test against: hopefully I didn't break anything.
svn path=/trunk/; revision=23048
2007-10-02 14:45:20 +00:00
Tomas Kukosa bf538397a9 review and update list of TLS cipher suites
svn path=/trunk/; revision=23047
2007-10-02 09:26:28 +00:00
Ronnie Sahlberg 3c17f41224 coverity 263 check if variable is null before dereferencing it
svn path=/trunk/; revision=23046
2007-10-02 08:33:38 +00:00
Ronnie Sahlberg 880bab108c remove a test for null that we dont need since the variable can not be
null at this point


svn path=/trunk/; revision=23045
2007-10-02 08:27:39 +00:00
Ronnie Sahlberg cca87411fa get rid of a check for null we dont need
coverity 257


svn path=/trunk/; revision=23044
2007-10-02 08:21:25 +00:00
Ronnie Sahlberg b8d35143d8 change dissect_radius() to become a new-style dissector that can reject
packets that doesnt look like valid radius.

verify that a packet is radius by checking that the command code is 
known and also that the length is between 20 and 4096 bytes

move the tap data to be ep_allocated instead of a static global variable

dont use tvb_memcpy() to read a structure off the wiredata
use tvb_get_...    to unmarshall the fields explicitely



this fixes bug 1634

svn path=/trunk/; revision=23039
2007-09-30 23:14:18 +00:00
Ronnie Sahlberg 927bf43d09 update filter fields for bug 1803
svn path=/trunk/; revision=23038
2007-09-30 22:34:19 +00:00
Guy Harris 8e87bd423f "pinfo->match_string" is a "const char *"; save it into a variable of
the same type - that makes compilers much happier.

svn path=/trunk/; revision=23029
2007-09-29 02:20:17 +00:00
Mike Duigou fc975182fe Improves dissection of JXTA traffic from http connections.
Improved address display in packet summary panes.

more options for jxta pdu filtering by addresses.

svn path=/trunk/; revision=23019
2007-09-28 20:53:56 +00:00
Jaap Keuter f2bc8dd002 Why do I have to enable the Bytes View to see the (start of) data of the Data dissector?
Adding the data as a subtree to the Data dissector.

svn path=/trunk/; revision=23018
2007-09-28 19:16:05 +00:00
Martin Mathieson ba1f5676e0 Handle IPv6 addresses in ipprim headers.
svn path=/trunk/; revision=23013
2007-09-28 16:17:22 +00:00
Ronnie Sahlberg 93c5c7a70c this silly protocol uses the same port as ndmp and worse, there is
nothing really in the header to identify it reliably as silly 
vendor specific encapsulation 

10000 is actually registered by iana for ndmp   so it makes no sense for 
a lazy vendor to use it by default.

make it check if the packet is ndmp first before assuming that anything 
that goes to port 10000 must be some lazy vendor specific protocol

grrr


svn path=/trunk/; revision=23009
2007-09-28 07:34:42 +00:00
Ronnie Sahlberg b6aeeb9821 add ndmp.h to the makefile
svn path=/trunk/; revision=23008
2007-09-28 07:26:40 +00:00
Ronnie Sahlberg 651d8082c9 add a function to test if a packet is ndmp or not
svn path=/trunk/; revision=23007
2007-09-28 07:25:50 +00:00
Ronnie Sahlberg 1efa9bd6b6 ndmp and tcp encapsulation of esp both use port 10000
make ndmp a heuristic dissector so it will "win" over tcp esp  if the 
packets look like ndmp  and if "preferences/tcp/heuristic dissectors 
first has been 
chosen"



svn path=/trunk/; revision=23006
2007-09-28 07:08:52 +00:00
Ronnie Sahlberg 30b586ad61 queue the ip/eth headers for tapping before calling any subdissectors
so that they can be tapped even if the subdissectors cause an exception


this fixes bug 1527

svn path=/trunk/; revision=23004
2007-09-28 05:50:19 +00:00
Jeff Morriss 1790075951 As requested by Juan Wortley on -users: instead of allowing only 2 UDP ports to be dissected as NSIP, allow a range. Obsolete the old preferences.
svn path=/trunk/; revision=22998
2007-09-27 14:11:57 +00:00
Tomas Kukosa 706e13b44d put next few simple ASN.1 dissectors into the new makefile structure
svn path=/trunk/; revision=22994
2007-09-27 06:03:45 +00:00
Anders Broman b70af70189 Fix unused functions.
svn path=/trunk/; revision=22991
2007-09-26 21:37:57 +00:00
Anders Broman 2e73f83c7e The unused pinfo strikes back (again).
svn path=/trunk/; revision=22990
2007-09-26 19:50:53 +00:00
Anders Broman 9920652ca5 Further IE dissection.
svn path=/trunk/; revision=22989
2007-09-26 19:01:29 +00:00
Jörg Mayer 8625cb7938 Decode role on shared link
svn path=/trunk/; revision=22985
2007-09-26 08:38:43 +00:00
Jörg Mayer ec3d698c56 Beginnings of EAPS shared link packet dissection (EAPSv2)
svn path=/trunk/; revision=22984
2007-09-26 07:10:40 +00:00
Jörg Mayer 6bb9369681 "fix" some warnings about "might be used uninitialized" variables
svn path=/trunk/; revision=22983
2007-09-26 07:09:51 +00:00
Guy Harris 2d8cff8a03 Make the number of bytes just a guint, in the hopes that it'll squelch
some of the warnings.

svn path=/trunk/; revision=22982
2007-09-26 06:53:38 +00:00
Stephen Fisher 5775a1dca8 The dissector packet-dcp.c now fails to compile on MacOS X (gcc 4.0.1/Apple). Change G_INLINE_FUNC back to inline per GLib documentation (also remove recommendation in developer's guide to not use inline):
http://library.gnome.org/devel/glib/unstable/glib-Miscellaneous-Macros.html#id2571572

G_INLINE_FUNC

#define             G_INLINE_FUNC
This macro is used to export function prototypes so they can be linked with an external version when no inlining is performed. The file which implements the functions should define G_IMPLEMENTS_INLINES before including the headers which contain G_INLINE_FUNC declarations. Since inlining is very compiler-dependent using these macros correctly is very difficult. Their use is strongly discouraged.

This macro is often mistaken for a replacement for the inline keyword; inline is already declared in a portable manner in the glib headers and can be used normally.


svn path=/trunk/; revision=22980
2007-09-26 03:05:42 +00:00
Guy Harris 8a0da81237 Squelch *another* "case M ... N:".
To quote doc/README.developer:

  Don't use "inline"; not all compilers support it.  If you want to have a
  function be an inline function if the compiler supports it, use
  G_INLINE_FUNC, which is declared by <glib.h>.

svn path=/trunk/; revision=22979
2007-09-26 02:36:22 +00:00
Guy Harris 109a510696 A guint8 can never be > 255.
svn path=/trunk/; revision=22978
2007-09-26 02:21:31 +00:00
Guy Harris cd4d203af2 Don't use
case N ... M:

as that's not supported by all compilers.

Say so in the Portability section of README.developer, in the hopes of
discouraging others from using that GCCism.

svn path=/trunk/; revision=22976
2007-09-26 00:41:00 +00:00