Commit graph

41 commits

Author SHA1 Message Date
Jaap Keuter
c9e3f66d14 Optimize empty strings to NULL pointers.
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
Anders Broman
04b77f8437 APDU incorrectly dissected(BSSLAP Protocol Not Decoded In BSSMAP-LE Messages).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3711

svn path=/trunk/; revision=29077
2009-07-13 08:35:30 +00:00
Jörg Mayer
6270137b07 Fix my 'fix': guint8 > 0 is always true
svn path=/trunk/; revision=28807
2009-06-22 07:27:14 +00:00
Jörg Mayer
cf0746df92 Fix warning: always evaluates to true/false
svn path=/trunk/; revision=28805
2009-06-22 06:29:32 +00:00
Anders Broman
757a6bf29a Wrong tree used, add Codec list dissection.
svn path=/trunk/; revision=27957
2009-04-04 15:19:45 +00:00
Anders Broman
13282b7a7c Add value strings and code clenup.
svn path=/trunk/; revision=27944
2009-04-03 16:19:12 +00:00
Anders Broman
0d2fb53b74 - Fix APDU dissection.
- NAS EPS bugfixes and enhancements.

svn path=/trunk/; revision=27778
2009-03-18 19:40:54 +00:00
Jeff Morriss
ed96ef8e03 From Michael Lum via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3281 :
The LCS Client Type parameter in a BSSMAP Perform Location Request is not being
dissected (1.1 trunk).

The LCS Priority and LCS QoS are fine.

svn path=/trunk/; revision=27565
2009-02-28 04:27:43 +00:00
Anders Broman
b631b88d61 Implement TLV-E and LV-E type IE dissection (2 byte length value).
svn path=/trunk/; revision=27100
2008-12-23 20:49:15 +00:00
Guy Harris
880180dd6b Don't use fancy quote characters that don't fit in ASCII; just use
Boring Old ASCII Quotes.  That way, you don't have to worry about which
character set a program reading the file is expecting.  Fixes bug 3157.

Fix some typoes in comments while we're at it.

svn path=/trunk/; revision=27091
2008-12-23 00:22:07 +00:00
Bill Meier
ba7be20b74 Revert queueing --> queuing spelling changes made in SVN #27050
svn path=/trunk/; revision=27058
2008-12-19 04:41:54 +00:00
Bill Meier
c544c20956 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27050
2008-12-18 19:08:49 +00:00
Bill Meier
33c99f44fd Fix typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27028
2008-12-17 00:08:38 +00:00
Anders Broman
85bfdec24b Correct the bit position for a couple of hf fields.
svn path=/trunk/; revision=26968
2008-12-11 20:34:23 +00:00
Anders Broman
8957c53871 Add codec list dissection.
svn path=/trunk/; revision=26896
2008-12-01 22:30:13 +00:00
Stig Bjørlykke
14029e4803 Initialize consumed in be_speech_codec_lst().
svn path=/trunk/; revision=26858
2008-11-26 23:36:22 +00:00
Anders Broman
7c82d14ab0 Fix selected codecs list and a number of typos.
svn path=/trunk/; revision=26855
2008-11-26 21:03:53 +00:00
Anders Broman
ad41b9667f Move some of the BSSMAP LE stuff to packet-gsm_bssmap_le.c
svn path=/trunk/; revision=26832
2008-11-23 21:08:46 +00:00
Anders Broman
f42db62a55 From Johnny Mitrevski:
Add new Bssap dissectors for the Lb interface.

svn path=/trunk/; revision=26814
2008-11-20 07:57:24 +00:00
Anders Broman
05fa33881c From Pascal Quantin:
Improve 3GPP 44.018 RR dissection.

svn path=/trunk/; revision=26779
2008-11-15 11:36:49 +00:00
Bill Meier
25aee02122 From SUZUKI Shinsuke: Fix some non-ascii characters: Bug #3057
svn path=/trunk/; revision=26775
2008-11-13 22:50:05 +00:00
Anders Broman
5128a0dafe From Johnny Mitrevski:
Add dissecton of some LCS related IE:s.
( Removed C++ type comments, changed (*8 to <<3), changed some add uint's to add_item
renamed value strings etc.)

svn path=/trunk/; revision=26762
2008-11-12 17:43:32 +00:00
Stig Bjørlykke
4e9a58bd3c Removed some unused variables and fixed some true_false_string's.
svn path=/trunk/; revision=26691
2008-11-04 20:27:22 +00:00
Anders Broman
2888252e85 Update towards 48.008 8.4.0
svn path=/trunk/; revision=26689
2008-11-04 20:11:06 +00:00
Anders Broman
c83c448173 Add dissection of some IE:s
svn path=/trunk/; revision=26625
2008-10-30 19:32:35 +00:00
Anders Broman
dd18d39f92 Move dissect_geographical_description() from gsm_map to gsm_a_common to make it easier to use it in other dissectors including it from gsm_map makes in neccesarry to include asn1.h.
Fix some bugs in the code, use it from bssmap.

svn path=/trunk/; revision=26603
2008-10-28 19:16:10 +00:00
Anders Broman
38e28295cd Update towards 48.008 8.4.0
svn path=/trunk/; revision=26589
2008-10-27 21:07:52 +00:00
Anders Broman
799b8635f3 Update towards 48.008 8.4.0
svn path=/trunk/; revision=26558
2008-10-26 19:44:06 +00:00
Stephen Fisher
ede39bfe1f Take out extra */ to fix compile.
svn path=/trunk/; revision=26534
2008-10-23 21:26:19 +00:00
Anders Broman
607de79a7b Update towards 48.008 8.4.0
svn path=/trunk/; revision=26530
2008-10-23 20:39:43 +00:00
Anders Broman
6e901dc4fe Mark len as unused.
svn path=/trunk/; revision=26518
2008-10-22 21:10:45 +00:00
Anders Broman
41b70e3a96 Some further updates.
svn path=/trunk/; revision=26517
2008-10-22 20:56:26 +00:00
Stig Bjørlykke
1d5478595c Mark some unused variables.
svn path=/trunk/; revision=26516
2008-10-22 18:55:58 +00:00
Guy Harris
03a81916d8 Get rid of /* inside comment.
svn path=/trunk/; revision=26515
2008-10-22 17:50:07 +00:00
Anders Broman
a4c3055bbb Update bssap le and BSS MAP.
svn path=/trunk/; revision=26514
2008-10-22 16:32:24 +00:00
Bill Meier
97e7747d42 Small cleanup of proto_reg_handoff & etc
- 'once-only' not req'd in some cases
- use find_dissector as appropriate
- remove unneeded code

svn path=/trunk/; revision=26284
2008-09-27 13:38:59 +00:00
Anders Broman
ebc8f1f8bf From Niel Percy:
Much as I hate white space changes, I got fed up of the huge variation of styles within these files, and tried to get to a much smaller range of variation. Also a few comment tidies, and use of _U_ for unused args rather than "arg = arg" lines.

svn path=/trunk/; revision=26140
2008-09-05 05:49:39 +00:00
Bill Meier
77b81b391b #include <prefs.h> not req'd
svn path=/trunk/; revision=26089
2008-08-25 22:06:20 +00:00
Anders Broman
2226bccd44 From Neil Piercy:
1 new split file (GMM & SM in one file) and diff patches for the others. The RR, RP and BSSMAP patches are really a tidy-up: now they are split it becomes clear what was redundant code.

svn path=/trunk/; revision=26064
2008-08-24 17:42:30 +00:00
Anders Broman
bafcc127f8 From Neil Piercy:
RR has been split from DTAP, with common stuff going to the common files (plus a few minor knock-on consequences).
Fix the broken tap:
I had not realised that the register_tap call in the dissector registration actually _created_ the tap entry (not the register_tap_listener), and not just associated the tap_id returned with the tap registered by the listener. The use of separate statics by the split lead to 3 taps called "gsm_a", but only the first of which was ever found in the tap_queue_packet. Added (yet another) global for now to cope.

Also attached is a patch to tap.c which simply returns the same tap_id if the register_tap is called twice with the same name - I can't see any downside to this, can you? Anyway it seemed to work with deliberately keeping multiple calls.

svn path=/trunk/; revision=26039
2008-08-19 08:05:04 +00:00
Anders Broman
082a5aec04 From Neil Piercy:
All I've done in these is to split the 3 obviously distinct protocols (BSSMAP & RP) from the still-large (and wrongly-named) DTAP (really the whole of layer 3 - it includes RR and packet parts too).

So far I've only split in a "minimum change" manner - there is clearly some tidying and structure enhancement of how the common bits are used, removing the globals just added, and great scope for consistency of white space, improved naming etc. - but I thought it best to keep it very close to the original initially to establish the split.

With some changes to make it compile on Windows.

svn path=/trunk/; revision=25917
2008-08-04 19:44:03 +00:00