Commit graph

20 commits

Author SHA1 Message Date
Kovarththanan Rajaratnam
4b6090e576 Don't guard col_set_str (COL_INFO) with col_check
svn path=/trunk/; revision=29342
2009-08-09 07:01:26 +00:00
Kovarththanan Rajaratnam
e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Jörg Mayer
cf0746df92 Fix warning: always evaluates to true/false
svn path=/trunk/; revision=28805
2009-06-22 06:29:32 +00:00
Anders Broman
28b46231f6 Fix a typo.
svn path=/trunk/; revision=28023
2009-04-09 15:32:26 +00:00
Jörg Mayer
4c0e847d8c Starting cleanup in earnest
- get rid of some structure accesses
- use _item functions where possible

svn path=/trunk/; revision=28022
2009-04-09 13:58:20 +00:00
Jörg Mayer
8b6ae788b2 Andreas Schuler:
add framenumber, extended fixed part capabilities and higher
layer capabilities

Me;

- replace div by crc to fix a shadowed global variable
- the last argument to proto_tree_add_item is the endianess
  indicator, not the value
- replace // by /* */

svn path=/trunk/; revision=27904
2009-03-30 21:55:22 +00:00
Guy Harris
c023fe9066 Don't use sprintf() - use ep_strbufs and ep_strbuf_append_printf()
instead.

svn path=/trunk/; revision=27876
2009-03-28 17:30:31 +00:00
Jörg Mayer
46ac6b6e53 Andreas Schuler
Fix display problems with b-fields:
increase the length of the string and use sprintf.

Original German comment:

weiter hab ich festgestellt das das b-field nicht richtig dargestellt wird .
Entweder ist g_snprintf broken , oder wir sind beide zu unf\344hig die
funktion zu benutzen .
Der string wird aus 16x %.2x + leerzeichen zusammengesetzt , was nach
meinen berechnungen eine h\366chstl\344nge von 144 zeichen + nullbyte ergibt .
deshalb hab ich die stringvariable auf 145 hochgesetzt und benutze wieder
sprintf . hier der patch dazu .


svn path=/trunk/; revision=27844
2009-03-24 22:13:18 +00:00
Jörg Mayer
d50755f465 Andreas Schuler
small fix:
In a  PP packet TA=7 gets dissected as Paging tail.  In case of PP it
is really an Mt .


svn path=/trunk/; revision=27843
2009-03-24 22:09:21 +00:00
Jörg Mayer
3c9e4d5de9 Whitespace changes, missed a comment in German
svn path=/trunk/; revision=27422
2009-02-11 07:46:39 +00:00
Bill Meier
dce1390edd Replace remaining usage of sprintf ...
svn path=/trunk/; revision=27382
2009-02-05 21:16:36 +00:00
Jörg Mayer
f76ab796a6 Don't convert a const to a non-const
svn path=/trunk/; revision=27374
2009-02-05 08:25:59 +00:00
Bill Meier
0379da5147 Keep the compiler happy: revert one change....
svn path=/trunk/; revision=27373
2009-02-05 03:14:08 +00:00
Bill Meier
a2cbe9b2da Define most everything as static (fcns & global variables);
Fix one of the sprintf usages;
Use NULL instead of "" for the FIELDDESC in the hf array entries;
Minor code cleanup;

svn path=/trunk/; revision=27372
2009-02-05 02:27:33 +00:00
Bill Meier
893b439a4d #include <epan/prefs> not req'd; minor spacing changes;
next up: replace use of sprintf .....

svn path=/trunk/; revision=27371
2009-02-05 00:33:45 +00:00
Jörg Mayer
afd7fc8f66 More whitespace changes
BOOL -> gboolean

_subtree -> _ett (not because it's better but because it's what's used
  (almost) everywhere else

svn path=/trunk/; revision=27370
2009-02-04 23:17:55 +00:00
Jörg Mayer
e4885e846a Small whitespace changes
svn path=/trunk/; revision=27369
2009-02-04 22:00:31 +00:00
Bill Meier
52c567e2b2 One very minor reg_handoff change [static ... not req'd]
svn path=/trunk/; revision=27364
2009-02-04 00:12:55 +00:00
Jörg Mayer
973bd36bb0 Fix some errors I either missed or introduced:
- missing {0, NULL} at the end of a val array
- incorrect registration

Small formatting changes.

svn path=/trunk/; revision=27363
2009-02-03 23:11:13 +00:00
Jörg Mayer
f79a85e204 Andreas Schuler <krater (A) badterrorist.com>
Matthias Wenzel <dect (A) mazzoo.de>

Beginnings of a DECT dissector. This is a copy of the svn
repository at dedected.org with the following modifications:

- Change from plugin to normal dissector
- Change comments from // to /* */
- Change German comments to English
- #if-0-out unused variables
- Reorder functions to avoid forward declarations and use the normal
  Wireshark conventions
- Fix the scrt table (as by email from Andreas)
- Fix Mask for hf_dect_A_Tail_Qt_0_Cn from 0x2F -> 0x3F (as by email
  from Matthias)
- Initialize some variables because GCC isn't aware of the reduced
  value space in a switch statement that switches on (var & 7).
- Declare some function parameters as _U_
- Add GPLv2 and later header (as by emails from Andreas and Matthias).

TODO (roughly in that order)
  - Don't use structs to access the elements in the datastream.
  - Use tvb_..._item wherever possible
  - Add references to documentation (ETSI EN 300 175 parts 1-8)
    including the section.
  - Make things stateful
  - Once the capture format has stabilized, get rid of the Ethernet
    hack and use a proper capture type.


svn path=/trunk/; revision=27362
2009-02-03 21:30:36 +00:00