Commit Graph

31643 Commits

Author SHA1 Message Date
Tomas Kukosa 0c6f08e2b2 add SAPI "Q.931 packet mode communication" which is obsolete but used in some traces
svn path=/trunk/; revision=32641
2010-05-03 07:16:25 +00:00
Anders Broman 9387dab7fe Try to fix the solaris build bot.
svn path=/trunk/; revision=32640
2010-05-03 05:03:51 +00:00
Stephen Fisher 66d48120c2 Change two instances of "an Wireshark plugin" to "a Wireshark plugin".
The use of "an" must have been leftover from the Ethereal days ("an
Ethereal plugin").


svn path=/trunk/; revision=32639
2010-05-02 23:39:58 +00:00
Anders Broman fc0932168f Run deprecated-gtk-todoon all files in the gtk dir.
svn path=/trunk/; revision=32638
2010-05-02 21:42:53 +00:00
Stig Bjørlykke eb279458fa Rewrite: strcpy -> g_strlcpy.
svn path=/trunk/; revision=32637
2010-05-02 20:21:39 +00:00
Stig Bjørlykke 676a95a580 Rewrite: gtk_combo_new -> gtk_combo_box_entry_new_text.
svn path=/trunk/; revision=32636
2010-05-02 19:50:44 +00:00
Anders Broman 3c51d54e83 Fix:
packet-ip.c:1311: warning: 'field_tree' may be used uninitialized in this function

svn path=/trunk/; revision=32635
2010-05-02 17:02:11 +00:00
Anders Broman e87ddd657c From Jakub Zawadzki:
Fix copy&paste error + add support for proto_tree_add_bits API
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

svn path=/trunk/; revision=32634
2010-05-02 15:37:23 +00:00
Anders Broman d528b62777 From Jakub Zawadzki:
patch for ip.flags (using proto_tree_add_bits_item).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413

svn path=/trunk/; revision=32633
2010-05-02 15:36:44 +00:00
Gerald Combs ee535ac43c [Automatic manuf and enterprise-numbers update for 2010-05-02]
svn path=/trunk/; revision=32630
2010-05-02 15:03:30 +00:00
Stig Bjørlykke 6199e515c9 Don't type prune the data_ptr pointer for UAT.
svn path=/trunk/; revision=32629
2010-05-02 13:50:52 +00:00
Stig Bjørlykke 8ef65daa69 Don't type prune the data_ptr pointer for UAT.
svn path=/trunk/; revision=32628
2010-05-02 13:50:19 +00:00
Jaap Keuter 9b0019e3e7 From Hitoshi Irino:
The function "dissect_v9_pdu" of "epan/dissectors/packet-netflow.c" decodes
NetFlow v9 packets and IPFIX packets with same logic. But, the "scope field" is
different between NetFlow v9 and IPFIX. NetFlow v9 has only 5 kind of scopes.
On the other hand, many Information Elements can be used as scope fields in 
IPFIX packets.

svn path=/trunk/; revision=32627
2010-05-02 12:50:54 +00:00
Jaap Keuter ae400a74fa Fix for bug 4723:
Don't type prune the data_ptr pointer for UAT.

svn path=/trunk/; revision=32626
2010-05-02 12:32:52 +00:00
Stig Bjørlykke 2f5ebda0ec Added some more dissecting.
svn path=/trunk/; revision=32625
2010-05-02 10:03:08 +00:00
Stig Bjørlykke 1fc6e6d11b Disable ok button when no name entered.
svn path=/trunk/; revision=32624
2010-05-02 10:01:54 +00:00
Stig Bjørlykke a64fe86786 Added tooltips for UAT column headers.
svn path=/trunk/; revision=32623
2010-05-02 09:59:02 +00:00
Anders Broman a0f2f56ec8 Dissect 3GPP AVP 5 3GPP-GPRS Negotiated QoS profile.
svn path=/trunk/; revision=32622
2010-05-01 14:58:03 +00:00
Gerald Combs 1bf2a7c78b Replace GtkClist in uat_gui.c with GtkTreeView+GtkListStore. Pop up the
edit window when an item is double-clicked. Add a couple of convenience
routines to gui_utils.c.

svn path=/trunk/; revision=32621
2010-04-30 22:33:51 +00:00
Jeff Morriss 08045a2392 Revert rev 32519 for now: it is making the dissector bug a little too obvious. It may make sense to put the check back in once the bug (tracked via 4698) is fixed.
svn path=/trunk/; revision=32620
2010-04-30 22:00:05 +00:00
Guy Harris 06a24aaa7e Pick up other check from the almost-identical routine in
epan/dfilter/scanner.l.

(The common code should be in a utility routine.)

svn path=/trunk/; revision=32619
2010-04-30 21:55:42 +00:00
Guy Harris d57979b197 Fix comment.
svn path=/trunk/; revision=32618
2010-04-30 21:51:47 +00:00
Jeff Morriss 4a8c8e4d7f Fix up indentation a bit
svn path=/trunk/; revision=32617
2010-04-30 21:40:57 +00:00
Jeff Morriss 1b6b831daf Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1696 :
The change put in with rev 11382 meant that, on 64-bit systems, we could not
parse negative numbers into integers (since -1 taken as an unsigned 64-bit
number is (significantly) larger than G_MAX_UINT32).

To fix this, split the val_from_unparsed() routine for integers into two
routines: one for signed and one for unsigned; each routine can then do the
appropriate "is this bigger than what fits in a *32?" test.

svn path=/trunk/; revision=32616
2010-04-30 21:40:39 +00:00
Gerald Combs d13ecdea62 Add a catch-all if statement for column formats that are filled in by
dissectors. Fixes bug 4732.

svn path=/trunk/; revision=32615
2010-04-30 20:49:41 +00:00
Bill Meier 412fc3d5c5 From Chris Maynard: Fix Bug #1292: "Win32: confusing setup target warning if cl.exe is not in path"
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1292

svn path=/trunk/; revision=32614
2010-04-30 20:15:27 +00:00
Bill Meier 3cb2276f19 Fix a gcc -Wshadow warning.
svn path=/trunk/; revision=32613
2010-04-30 18:19:47 +00:00
Bill Meier 5dfcabace8 Fix a gcc -Wshadow warning.
svn path=/trunk/; revision=32612
2010-04-30 17:47:23 +00:00
Martin Mathieson 5ed2e2f914 Trivial: Update AUTHORS entry, remove out-of-date comments, minor formatting
svn path=/trunk/; revision=32611
2010-04-30 17:15:59 +00:00
Guy Harris d4010f2058 Clean up some calls to use the same offset as the call to put the parent
into the protocol tree.

Put the cases for various Radiotap data items into numerical order by
the bit number.

svn path=/trunk/; revision=32610
2010-04-30 08:26:12 +00:00
Gerald Combs 3c8db1cae5 Several dissectors fill in custom custom data in the source and
destination address columns. Don't clobber it in the new packet list.

svn path=/trunk/; revision=32609
2010-04-29 23:53:57 +00:00
Gerald Combs 8463e2e8bc Terminate a string so that strchr doesn't wander off. Hopefully fixes bugs
4725 and 4728.

svn path=/trunk/; revision=32608
2010-04-29 22:36:40 +00:00
Gerald Combs 62087e2eab Remove an unused variable.
svn path=/trunk/; revision=32607
2010-04-29 22:35:00 +00:00
Anders Broman 447faa6082 From Mike Morrin:
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712

svn path=/trunk/; revision=32606
2010-04-29 20:45:53 +00:00
Anders Broman 3f9d9a766e Forgot a //
svn path=/trunk/; revision=32605
2010-04-29 20:41:35 +00:00
Anders Broman 8e38004273 Simplify dissect_sip_authorization_item().
svn path=/trunk/; revision=32604
2010-04-29 20:02:14 +00:00
Jeff Morriss 87b32b26eb Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4308 :
Make a function that checks if the user is running as root or if npf.sys isn't
loaded (on Windows) and call it *after* showing the main window so that the
popup (if any) shows up above the main window.

svn path=/trunk/; revision=32603
2010-04-29 19:30:54 +00:00
Anders Broman 2faa2bff69 Do the header matching on lower case.
svn path=/trunk/; revision=32602
2010-04-29 19:11:48 +00:00
Jeff Morriss 0791f7beb8 Make the indentation consistent.
svn path=/trunk/; revision=32601
2010-04-29 18:17:29 +00:00
Anders Broman b5fa7b1d28 autentification info gives malformed packet if no space before "="
svn path=/trunk/; revision=32600
2010-04-29 16:08:14 +00:00
Jeff Morriss ed75cdd99c Make a variable a guint8* instead of a char* since it a) holds TVB data and b) matches what tvb_new_child_real_data() wants for its 2nd argument. This cleans up a warning from the Sun compiler.
svn path=/trunk/; revision=32599
2010-04-29 15:23:10 +00:00
Jeff Morriss 07cab74535 Make a variable a guint8* instead of a char* since it a) holds TVB data and b) matches what tvb_new_child_real_data() wants for its 2nd argument. This cleans up a warning from the Sun compiler.
svn path=/trunk/; revision=32598
2010-04-29 14:58:22 +00:00
Jeff Morriss 7e11e3ddcd Use strchr() instead of index()--Windows doesn't appear to have the latter.
svn path=/trunk/; revision=32597
2010-04-29 14:38:26 +00:00
Jeff Morriss 1dc3659de4 From Michael Speck via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4726 :
If "Help -> About Wireshark" is selected from Wireshark's main menu an error
message pops up:

Could not open file "<DevelopmentPath>\Wireshark_Source\wireshark-gtk2\COPYING":
No such file or directory


The attached patch handles this situation by looking for COPYING.txt instead of
COPYING on windows systems.

svn path=/trunk/; revision=32596
2010-04-29 13:12:54 +00:00
Ronnie Sahlberg dd9f8286cc It is becomming more common that iscsi vendors use iscsi-redirectors and redirect
initiators to a different host/port and thus often redirect to non-3260.

The heuristics to detect iscsi is quite weak since there is very little
in the average iscsi header that can be used to semi-reliably identify
something as iscsi and not random data/something else.
As such, the heuristics also use/rely on the port being 3260 in order
to reduce the otherwise massive numbver of false positives that would arise.


Add decoding of the text key/value pairs and trigger on TargetAddress.
This field would describe a address/port where we can quite reliably 
assume that this traffic is indeed iscsi and not something else.


When seeing the iscsi redirect/TargetAddress, use this as a signalling hint
and register a conversation dissector for TCP to that address/port so that 
any future packet to/from this port is sent to the iscsi dissector.


If the signalling/redirect is not in the capture, wireshark will not detect
the traffic as iscsi and the user will have to use DecodeAs.  and manually
\set it to iscsi.



svn path=/trunk/; revision=32595
2010-04-29 08:41:23 +00:00
Stephen Fisher 7364f9d94f Add snaplen to capinfos output. Idea from Chris Maynard on -dev.
svn path=/trunk/; revision=32594
2010-04-29 06:29:51 +00:00
Jeff Morriss c9247a92f1 Delay starting the resolv_update_cb until the main window has been displayed
This avoids this error:

(lt-wireshark:16779): Gdk-CRITICAL **: gdk_window_invalidate_rect: assertion `window != NULL' failed

before the main window has been drawn if you've got a personal hosts file.

svn path=/trunk/; revision=32593
2010-04-29 00:09:01 +00:00
Anders Broman c4fd1f8786 Use proto_add_item() and clean up the code a bit.
svn path=/trunk/; revision=32592
2010-04-28 21:20:57 +00:00
Bill Meier dfb88a7eec Altho no tabs, use tab-width=8 anyway.
svn path=/trunk/; revision=32591
2010-04-28 16:38:21 +00:00
Bill Meier a509e11b85 Use consistent indentation;
Altho no tabs use tab-width=8 anyway.

svn path=/trunk/; revision=32590
2010-04-28 16:37:25 +00:00