Commit Graph

35570 Commits

Author SHA1 Message Date
Michael Tüxen 487f03612f Don't print too many interface names...
svn path=/trunk/; revision=37253
2011-05-18 18:35:57 +00:00
Michael Tüxen 8b01902a02 Add support for multiple interfaces for the -L option.
svn path=/trunk/; revision=37250
2011-05-18 18:04:50 +00:00
Michael Tüxen 985c2b78fd Support multiple interfaces when used with -L option.
Show multiple interfaces when capturing from them.

svn path=/trunk/; revision=37249
2011-05-18 18:03:58 +00:00
Michael Tüxen b031b9643a Use the interface specific parameter array.
This enables the capturing from mulitple interfaces using 
tshark and wireshark (at the command line).
(tshark -i lo0 -i en0) or (wireshark -k -i lo0 -i en0)
works. You can capture from multiple remote and local
interfaces.

Based on work from Irene Ruengeler.

svn path=/trunk/; revision=37248
2011-05-18 18:02:30 +00:00
Jeff Morriss 4380cad67d Finish removing tabs and fix up some indentation.
Add a break after decoding CSData Codec Type.

svn path=/trunk/; revision=37247
2011-05-18 17:31:48 +00:00
Bill Meier 82ffa86cd3 Mark a function arg as _U_
svn path=/trunk/; revision=37246
2011-05-18 17:19:42 +00:00
Bill Meier b9a1e3fb2a Do PROTO_ITEM_SET_GENERATED for two 'proto_item *': Fixes Coverity 914 & 915 [UNUSED]
svn path=/trunk/; revision=37245
2011-05-18 17:17:08 +00:00
Jeff Morriss 7b3bd3e8a9 Add a default (else) case in the default case for cause values to avoid passing
a NULL string pointer to format routines.

While we're there, update the cause list from 48.008 v10.1.0.

svn path=/trunk/; revision=37244
2011-05-18 17:09:55 +00:00
Bill Meier 5a243ce86f Don't assign to an unused 'proto_item *': Coverity 939 [UNUSED];
Don't create a subtree which is never used: Coverity 940 [UNUSED].

svn path=/trunk/; revision=37243
2011-05-18 16:52:45 +00:00
Bill Meier 6725cd673c Use subtree rather than parent tree to add items; Fixes Coverity 973 & 974;
#include <stdlib.h> not needed;
Minor whitespace cleanup.

svn path=/trunk/; revision=37242
2011-05-18 16:19:15 +00:00
Chris Maynard 50af6e0ab2 Per destination flags is a 1-byte field. Grab it with tvb_get_guint8(), not
with tvb_get_letohs().  (Bug surfaced while trying out MESH_OVERRIDES.)

svn path=/trunk/; revision=37241
2011-05-18 15:56:46 +00:00
Alexis La Goutte 416ed742d5 From discussion in dev mailing ( http://www.wireshark.org/lists/wireshark-dev/201105/msg00235.html )
* Fix a duplicate value_string in cp_version table
* Fix a typo error (Cersion => Version)
Also fix some whitespaces/4tab-spaces (Need more work...)



svn path=/trunk/; revision=37240
2011-05-18 15:34:34 +00:00
Jeff Morriss fcac4a1d7d Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5930 :
with a variant of the patch submitted by Alexander Stein on the -dev list:

Allow FT_FRAMENUMs to be added (as base BASE_NONE).  My change from Alexander's
patch is to disallow BASE_NONE for non-framenum integers.

svn path=/trunk/; revision=37239
2011-05-18 15:33:07 +00:00
Balint Reczey 5921cd68a2 Refer to "Capture Help" as "Capture Help below" when there are no interfaces
to capture on.

svn path=/trunk/; revision=37238
2011-05-18 13:08:02 +00:00
Stig Bjørlykke 8aad87c84e Removed "Copy" from the profiles popup menu in favour of a "Create from"
dropdown in the "Create New Profile" window.

svn path=/trunk/; revision=37237
2011-05-18 08:10:37 +00:00
Guy Harris aa392a40fe You cannot just make the "len" field of a GByteArray larger, if there's
no data to back that length; you can only make it smaller.

svn path=/trunk/; revision=37236
2011-05-18 07:20:45 +00:00
Guy Harris fc65604b7e Make some more routines not used outside epan/proto.c static.
svn path=/trunk/; revision=37235
2011-05-18 03:28:26 +00:00
Bill Meier 93f7ac2c39 Convert tabs to "4 spaces" since it appears that tabs are "4 space tabs";
svn path=/trunk/; revision=37234
2011-05-18 01:37:06 +00:00
Bill Meier ae5eed6937 Remove code to generate an unuse sub-tree: Coverity: 976;
Don't assign to an unused variable: Coverity 977;
#include <stdlib.h> & <string.h> not req'd.

svn path=/trunk/; revision=37233
2011-05-18 01:29:25 +00:00
Bill Meier e357bbd68c Don't assign to unused proto_item * variables: Coverity 1015 & 1016.
svn path=/trunk/; revision=37232
2011-05-18 00:59:24 +00:00
Bill Meier c628346c1f Remove altogether code '#if 0'd in SVN #37229.
Further research shows that registering the dissector
to "tcp.port" and "udp.port" was explicitly removed in SVN #34969
and thus the code to create tcp and udp handles and the associated
dissect_reload_tcp() and dissect_reload_udp() code is no longer
needed.

svn path=/trunk/; revision=37231
2011-05-18 00:37:35 +00:00
Guy Harris 0aa46cb66c Get rid of unused function.
svn path=/trunk/; revision=37230
2011-05-18 00:29:48 +00:00
Bill Meier c46c260191 #if 0 some unused code & vars: Coverity 1018 & 1019;
Add a comment the unused code.

svn path=/trunk/; revision=37229
2011-05-18 00:07:32 +00:00
Guy Harris ff389e5a18 Squelch a narrowing warning.
svn path=/trunk/; revision=37228
2011-05-17 23:39:06 +00:00
Guy Harris 4a7f7dc6d0 Squelch a narrowing warning.
svn path=/trunk/; revision=37227
2011-05-17 23:37:27 +00:00
Guy Harris 9fcc6f5625 Make some routines static that aren't used outside the source file in
which they're defined.

svn path=/trunk/; revision=37226
2011-05-17 23:36:25 +00:00
Bill Meier 094e38ff21 Add items to subtree rather than tree: Coverity 1026;
Don't assign to an unused variable: Coverity 1027;
#include <stdlib.h> not req'd.

svn path=/trunk/; revision=37225
2011-05-17 23:36:12 +00:00
Guy Harris 17f8127d25 Fix another old-style function definition.
svn path=/trunk/; revision=37224
2011-05-17 23:35:12 +00:00
Guy Harris 8f53a5655c Make some routines static that aren't used outside the source file in
which they're defined.

Include some header files that declare functions in the source files
that define the functions.

Declare packet_list_get_type() in gtk/packet_list_store.h, as it defines
a macro that uses that function.

svn path=/trunk/; revision=37223
2011-05-17 23:33:23 +00:00
Guy Harris e902f33d18 Add -Wold-style-definition and -Wdeclaration-after-statement to the list
of warnings we enable by default; we'll move them if they break any
builds in non-fixable ways.

Add -Wmissing-prototypes and -Wmissing-declarations to the list of
things we don't enable by default, and explain why those, and
-Wstrict-prototypes can't be used.

Also explain why we check for clang before checking whether we can
enable -fexcess-precision=fast.

svn path=/trunk/; revision=37219
2011-05-17 22:24:26 +00:00
Jeff Morriss 747a964aef Always add the parameter length field to the tree; only make it visible
if the preference is set.

Add %d to the "not found" string in val_to_str() calls.

Upgrade the "ITU address format seen in ANSI" expert info from NOTE to WARN.

svn path=/trunk/; revision=37218
2011-05-17 22:21:25 +00:00
Jakub Zawadzki e21e71e46e Add generic tvb_get_bits_buf() which accepts any no_of_bits.
svn path=/trunk/; revision=37217
2011-05-17 22:20:14 +00:00
Guy Harris 1372515b02 More eradication of old-style function definitions.
svn path=/trunk/; revision=37216
2011-05-17 22:18:32 +00:00
Guy Harris 592f0ba6da Declare wtap_dump_has_name_resolution().
svn path=/trunk/; revision=37215
2011-05-17 22:17:04 +00:00
Jeff Morriss 82a8d6b153 Add a filterable item for the length of the GT digits in a subtree under the
digits.

Since we now have a subtree from which to hang things, make the generic (called
or calling) digits fields visible under this new subtree (one less hidden item).

Don't use add_string_format() to add the GT digits, let epan format it for us.
Use more descriptive field descriptions for these entries.

svn path=/trunk/; revision=37214
2011-05-17 21:59:58 +00:00
Guy Harris 4ae55217d0 This ain't C++; you have to put "void" in as the argument list of
functions that take no arguments, otherwise the function is treated as a
crufty old C function with undeclared arguments.

svn path=/trunk/; revision=37212
2011-05-17 21:28:07 +00:00
Guy Harris da1403c6dd This ain't C++; you have to put "void" in as the argument list of
functions that take no arguments, otherwise the function is treated as a
crufty old C function with undeclared arguments.

svn path=/trunk/; revision=37211
2011-05-17 21:26:25 +00:00
Gerald Combs b216f4b2ac Fix docbook errors.
svn path=/trunk/; revision=37210
2011-05-17 21:00:58 +00:00
Guy Harris 092b0120ae Don't leave the truncation flag unset in any of the info level
dissectors.

svn path=/trunk/; revision=37209
2011-05-17 20:04:22 +00:00
Jeff Morriss 99a76aca46 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5875 :
Error out if the user asked us to install dumpcap with a particular group but
we are not building dumpcap.

svn path=/trunk/; revision=37208
2011-05-17 19:59:18 +00:00
Michael Tüxen a385b7c9f3 * Don't declare a used arg as unused.
* Really clear the EOF flag. This fixes a bug where
  tshark is not able to do a live capture from a pcapng
  file.

svn path=/trunk/; revision=37207
2011-05-17 19:51:55 +00:00
Gerald Combs 11dec46275 Update the release notes for 1.7/1.8.
svn path=/trunk/; revision=37206
2011-05-17 19:26:00 +00:00
Jeff Morriss cdedb31e94 As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
NULL-return check.

Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.

Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).  A couple of these
were cases where it could not actually return NULL, but I changed it for
consistency.

Store the return value of match_strval() rather than calling it repeatedly.

svn path=/trunk/; revision=37204
2011-05-17 18:58:40 +00:00
Jeff Morriss c204df4719 Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).

svn path=/trunk/; revision=37203
2011-05-17 18:53:35 +00:00
Jeff Morriss ec460c3e99 As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
NULL-return check.

Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.

Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer).

svn path=/trunk/; revision=37202
2011-05-17 17:40:26 +00:00
Jeff Morriss 7a93fdab12 Avoid passing a NULL string pointer to format routines: some libc's (e.g.,
Solaris') will seg-fault on that.

svn path=/trunk/; revision=37201
2011-05-17 16:07:24 +00:00
Chris Maynard 568fdf18a7 All ELEM_MAND_* macros ensure curr_len > 0; no need to check again afterwards.
Resolves Coverity CIDs 381-382.

svn path=/trunk/; revision=37200
2011-05-17 14:41:01 +00:00
Anders Broman 5a0acb469e Use the correct value string and bitmasks.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5928

svn path=/trunk/; revision=37199
2011-05-17 08:23:30 +00:00
Jörg Mayer 619dad545b Update to FindGTK2 from cmake 2.8.3. Add back quartz options which
are not part of the official cmake release.

svn path=/trunk/; revision=37198
2011-05-17 04:20:35 +00:00
Guy Harris 96e2a4ffea According to MS-NLMP, the "version" field in the NTLMSSP blobs is
present only if the NTLMSSP_NEGOTIATE_VERSION flag is set in the flags
field, and that appears to be true in at least one capture I've seen.

svn path=/trunk/; revision=37197
2011-05-17 02:29:43 +00:00