Commit Graph

27 Commits

Author SHA1 Message Date
Jakub Zawadzki 1899903f69 Include <epan/to_str.h> only when needed.
svn path=/trunk/; revision=53189
2013-11-09 13:41:10 +00:00
Anders Broman 5a85b7fed2 [-Wmissing-prototypes]
Use explicit casts.

svn path=/trunk/; revision=48338
2013-03-16 08:52:09 +00:00
Guy Harris ebacca89a7 Add %option noinput to a bunch of Flex files, as we aren't using the
input() routine and thus don't need to have it generated - and as it
produces warnings of a routine defined but not used, we don't want to
have it generated.

Squelch a casting-const-away warning.

svn path=/trunk/; revision=47613
2013-02-10 19:13:07 +00:00
Guy Harris 1df459c415 Constify the return value of append_to_buffer(), to squelch some
warnings.

svn path=/trunk/; revision=47559
2013-02-08 09:00:03 +00:00
Bill Meier 7cd0417af5 Fix numerous instances of a variable/parameter name "shadowing" a library function name;
(At least some (gcc ?) compilers give a "shadow" warning for these).

svn path=/trunk/; revision=46402
2012-12-05 15:56:36 +00:00
Guy Harris 2ea9adc0de In the include processing code, if ddict_open() fails, bail out
*regardless* of whether errno is non-zero, so we at least report the
failure.

In the standalone test program built if TEST_DIAM_DICT_STANDALONE is
defined, check for ddict_scan() failing.

Part of fix for bug 7824.

svn path=/trunk/; revision=45452
2012-10-10 19:06:34 +00:00
Jeff Morriss 3729335973 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45016
2012-09-20 01:48:30 +00:00
Stig Bjørlykke 8443bbbf75 Replace all strerror() with g_strerror().
Remove our local strerror implementation.
Mark strerror as locale unsafe API.

This fixes bug 5715.

svn path=/trunk/; revision=37812
2011-06-28 09:00:11 +00:00
Gerald Combs 8908485246 Huzaifa Sidhpurwala of Red Hat Security Response Team discovered that we
could dereferene a NULL pointer if we had a corrupted Diameter
dictionary.

Additionally, it was possible to push an invalid input buffer onto the
include stack.

svn path=/trunk/; revision=37011
2011-05-06 19:39:47 +00:00
Jeff Morriss d201b3d873 From Tamas Regos via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4760 :
Harmless typo bug in diam_dict.l

applictation_start <-> application_start

svn path=/trunk/; revision=32783
2010-05-13 13:29:13 +00:00
Stig Bjørlykke a9a836af98 From Eric Sesterhenn via bug 4175:
Use g_strdup to allocate filename.

svn path=/trunk/; revision=30755
2009-10-29 11:16:22 +00:00
Guy Harris a86f743807 Just use g_strdup_printf() to construct a pathname - and use
G_DIR_SEPARATOR_S as the pathname component separator.

svn path=/trunk/; revision=28013
2009-04-08 22:32:44 +00:00
Gerald Combs 15f33eecbf Disable warnings-as-errors for Flex-generated output. Add a couple of gsize
casts.

svn path=/trunk/; revision=28002
2009-04-08 18:08:25 +00:00
Bill Meier 42d8daee19 #include <epan/emem.h> not req'd ...
svn path=/trunk/; revision=27391
2009-02-07 15:17:54 +00:00
Luis Ontanon 42c3239a1a luis.ontanon@gmail.com => luis@ontanon.org
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Jeff Morriss a5cee04fad Move the file utility functions from wiretap to libwsutil so that
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Bill Meier 0d4b874b44 Bug 2493: Fix (Part 2):
To prevent Windows compiler errors when using flex 2.5.35.
 Fixes "missing unistd.h" and yywrap "mismatched parameter" warnings
 [Upcoming Part 3: ignore 'signed /unsigned mismatch' errors]

svn path=/trunk/; revision=25173
2008-04-25 17:40:29 +00:00
Jeff Morriss 853e791444 Change more fopen() to eth_fopen() to finish fixing bug 1827:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1827

Update README.developer to tell developers not to use fopen() and friends
directly.

svn path=/trunk/; revision=23206
2007-10-16 15:43:18 +00:00
Guy Harris 5be4499ad1 Add a script as a front-end for Flex, to work around various problems,
such as the fact that Flex strips all but the last component of the "-o"
argument, and that it doesn't generate a header file to declare routines
the generated lexical analyzer defines.  Use that script when building
lexical analyzers, and, for each lexical analyzer, include the generated
header file in the generated analyzer.

svn path=/trunk/; revision=22446
2007-08-04 02:13:52 +00:00
Guy Harris 968d363f11 Add comments to various %option items to explain what they're doing.
Move the %options to the beginning if they weren't already there, and
put them in the same order in all files.

Add "prefix=" options to .l files that don't already have them, so we
don't have to pass a "-P" option.

Add "never-interactive" and "noyywrap" options to our lexical analyzers,
to remove extra isatty() checks and to eliminate the need for yywrap()
from the Flex library.

Get rid of %option nostdinit - that's the default.

Add .l.c: rules to Makefile.am files, replacing the rules for specific
.l files.  Have those rules all check that $(LEX) is set.

Update the address for the FSF.

svn path=/trunk/; revision=22424
2007-07-30 20:22:37 +00:00
Luis Ontanon 5e290061f2 - <?avp-proto and <?type-proto to instruct about which dissector to use for a given type or avp
- dissect timestamps
- add all the avps that were commented out in the dictionary


svn path=/trunk/; revision=22360
2007-07-20 00:15:17 +00:00
Martin Mathieson b0d92aeb98 Initialise description field to avoid crash when dumping dictionary.
svn path=/trunk/; revision=22351
2007-07-18 13:22:11 +00:00
Michael Tüxen 06ff527c5b Make debugging static.
svn path=/trunk/; revision=22347
2007-07-18 07:06:46 +00:00
Luis Ontanon e27b40f589 Add Address decoding, two debug environment variables (WIRESHARK_DEBUG_DIAM_DICT_PARSER and WIRESHARK_DUMP_DIAM_DICT) and fix some issues pointed out by Martin
svn path=/trunk/; revision=22345
2007-07-17 22:19:54 +00:00
Gerald Combs 01567eb9f4 If we can't find dictionary.xml, fail instead of trying to read from
stdin (which makes distcheck unhappy).  Fixup whitespace.

svn path=/trunk/; revision=22338
2007-07-17 21:29:18 +00:00
Luis Ontanon 81d168b14c Glibize diam_dict.l (should fix windows config)
svn path=/trunk/; revision=22323
2007-07-16 17:27:51 +00:00
Luis Ontanon b0bd83c868 Rewrite of the diameter dissector to use the dictionary for creating hfids, drop libxml dependency.
The work is still incomplete (anything but strings and numbers appears as bytes) but I want others to start testing it.

TODO:
builders and decoders for:
- (ntp) timestamps
- addresses
- diameteruris
- diameteridentities
- ipfilterrules
- qosfilterrules
- mipregistrationrequests


svn path=/trunk/; revision=22318
2007-07-16 05:41:58 +00:00