osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
29061 commits 23 branches 0 tags 1.3 GiB
Commit graph

115 commits

Author SHA1 Message Date
Anders Broman
219ac9ebdd Add a more verbose error printout. 
svn path=/trunk/; revision=30031
 2009-09-21 09:25:48 +00:00
Anders Broman
4ac9d6b8c5 Try to fix(take II): 
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened: 
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed 
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

svn path=/trunk/; revision=30027
 2009-09-20 21:41:02 +00:00
Kovarththanan Rajaratnam
f76fe1b808 From Jim Young via bug 4033: 
With the "old" list if keyboard focus was initially in the details pane, the
use of the <F7>/<F8> keys will restore focus to details pane after the
prev/next move.   Without this patch "new" packet list prev/next moves simply
moves focus to summary pane.

svn path=/trunk/; revision=30025
 2009-09-20 19:39:54 +00:00
Anders Broman
0474a38cc4 Add myself and Kovarththanan Rajaratnam as co authors. 
svn path=/trunk/; revision=30006
 2009-09-20 09:12:56 +00:00
Kovarththanan Rajaratnam
8767b75876 Use G_STRLOC 
svn path=/trunk/; revision=29991
 2009-09-20 07:46:12 +00:00
Anders Broman
b809359c65 Try to fix: 
Fedora 11/Gtk2.16.6: Get two Gtk-Critical messages each time a capture fie is opened: 
(lt-wireshark:15705): Gtk-CRITICAL **: gtk_tree_view_column_set_fixed_width: assertion `fixed_width > 0' failed 
gtk_tree_view_column_set_fixed_width is incompatible with variable width columns.

svn path=/trunk/; revision=29989
 2009-09-20 07:35:55 +00:00
Guy Harris
3e9738ac89 Add support for opening separate packet window when you double-click on 
a row in the packet list.

svn path=/trunk/; revision=29987
 2009-09-19 22:51:42 +00:00
Anders Broman
6e56815095 Set focus to packet list when a row is selected. 
svn path=/trunk/; revision=29981
 2009-09-18 14:01:10 +00:00
Gerald Combs
988b882948 Remove a cast. 
svn path=/trunk/; revision=29974
 2009-09-17 16:52:42 +00:00
Gerald Combs
3dbbc4cc4e svn path=/trunk/; revision=29868 2009-09-11 20:36:01 +00:00
Gerald Combs
05519b323a Reduce the spacing between new packet list items from 2 pixels to 1. If 
we want the new packet list to look like the old packet list we'll have
to adjust the behavior of the cell renderer.

svn path=/trunk/; revision=29867
 2009-09-11 19:13:39 +00:00
Anders Broman
1e137770e6 Allocate col_text and col_text_len when the fdata struct is allocated. 
svn path=/trunk/; revision=29817
 2009-09-09 08:50:06 +00:00
Kovarththanan Rajaratnam
de23d92163 Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter. 
svn path=/trunk/; revision=29806
 2009-09-08 19:00:54 +00:00
Kovarththanan Rajaratnam
8d909ba79e Rename new_packet_list_set_time_width() -> new_packet_list_resize_column() because it contains no time format specific code. Further this change also ensures that new_packet_list_resize_columns() uses the newly introduced new_packet_list_resize_column() 
svn path=/trunk/; revision=29782
 2009-09-07 20:45:32 +00:00
Kovarththanan Rajaratnam
4662b8c326 Rename packet_list_dissect_and_cache => packet_list_dissect_and_cache_iter 
svn path=/trunk/; revision=29781
 2009-09-07 19:50:19 +00:00
Kovarththanan Rajaratnam
1ce02f035d Add progress bar while constructing columns (which is time consuming) 
svn path=/trunk/; revision=29777
 2009-09-07 17:45:37 +00:00
Kovarththanan Rajaratnam
4fbc99e411 Auto resize non frame_data based columns 
svn path=/trunk/; revision=29766
 2009-09-07 13:10:59 +00:00
Kovarththanan Rajaratnam
0a09528611 Add initial implementation of new_packet_list_resize_columns() which just sets the column width according to the column format (work in progress) 
svn path=/trunk/; revision=29762
 2009-09-07 12:04:59 +00:00
Anders Broman
5cc8d3e71d col_fmt not needed. 
svn path=/trunk/; revision=29760
 2009-09-07 11:50:08 +00:00
Anders Broman
7473e1e04c Automatically adjust the time column width when time format changes. 
svn path=/trunk/; revision=29758
 2009-09-07 10:03:55 +00:00
Kovarththanan Rajaratnam
2ab0685d8a Make sure that we can enable/disable color filtering. 
Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=11&rev2=12

svn path=/trunk/; revision=29728
 2009-09-06 05:49:00 +00:00
Kovarththanan Rajaratnam
e1eaab161d Move new_packet_list_dissect() to packet_list_store.c. We need to have it there in order to dissect columns on the fly when we have to sort 
svn path=/trunk/; revision=29717
 2009-09-05 15:46:47 +00:00
Kovarththanan Rajaratnam
583d41904c Inline cache_columns() 
svn path=/trunk/; revision=29716
 2009-09-05 15:30:34 +00:00
Kovarththanan Rajaratnam
4aa6c8baef Remove dead code. We dont construct columns while reading the file. We do that when we have to display the frame 
svn path=/trunk/; revision=29715
 2009-09-05 15:25:53 +00:00
Stig Bjørlykke
5a7d9922c1 Fetch old column width values if we have not initialized the packet list, 
so we don't write zero width values if closing before loading a capture.

svn path=/trunk/; revision=29714
 2009-09-05 14:37:02 +00:00
Kovarththanan Rajaratnam
fcf25fe42b Get rid of row_data_t 
svn path=/trunk/; revision=29711
 2009-09-05 13:27:34 +00:00
Kovarththanan Rajaratnam
a71f9bbde3 Sort out some of the confusion r29706 introduced (visible vs. physical rows). We choose the wrong packet in the packet view because we used the physical row instead of the visible. I suspect there a couple more of these lurking. 
svn path=/trunk/; revision=29708
 2009-09-05 12:42:44 +00:00
Kovarththanan Rajaratnam
95ddec4d07 Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible. 
svn path=/trunk/; revision=29705
 2009-09-05 10:36:29 +00:00
Kovarththanan Rajaratnam
314b693828 Rename new_packet_list_reset_dissected to packet_list_reset_dissected 
svn path=/trunk/; revision=29699
 2009-09-04 17:42:03 +00:00
Kovarththanan Rajaratnam
4930802fa1 Only store the last column as G_TYPE_POINTER. Hopefully this will soon make us able to sort again 
svn path=/trunk/; revision=29690
 2009-09-03 17:56:57 +00:00
Kovarththanan Rajaratnam
5a8df08491 Add packet_list_visible_record() to avoid poking PacketListRecord in new_packet_list.c 
svn path=/trunk/; revision=29689
 2009-09-03 17:39:42 +00:00
Kovarththanan Rajaratnam
8a33ec23bb Allocate and use an extra column at the end of the column list to indicate the 'magic' column which contains the _entire_ PacketListRecord 
svn path=/trunk/; revision=29688
 2009-09-03 17:00:17 +00:00
Kovarththanan Rajaratnam
bd69669e1d Make sure that we stop auto scroll if we start scrolling manually. 
Caveat: we jump to first frame when auto scroll is stopped

svn path=/trunk/; revision=29685
 2009-09-03 14:32:11 +00:00
Stig Bjørlykke
7d2c55dc47 Adjusted int/uint check and fixed a comment in right justify check. 
svn path=/trunk/; revision=29683
 2009-09-03 10:50:30 +00:00
Stig Bjørlykke
b462cace92 Right justify "Packet length", "Cumulative bytes" and custom columns 
displaying numerical values.

svn path=/trunk/; revision=29682
 2009-09-03 10:40:06 +00:00
Anders Broman
865d14c43f Right align COL_NUMBER. 
svn path=/trunk/; revision=29681
 2009-09-03 05:35:21 +00:00
Anders Broman
7b916257bd Don't set the minimum column width to the computed or stored value, 
use a fixed minimum value and use the other as the size used to display the column.

svn path=/trunk/; revision=29680
 2009-09-03 05:03:57 +00:00
Kovarththanan Rajaratnam
47b766a998 Only try and select the last row if not already selected. This fix doesn't seem to work. Any suggestions? 
svn path=/trunk/; revision=29677
 2009-09-02 19:31:56 +00:00
Michael Tüxen
283a4997ba Mark unused parameter as such. 
svn path=/trunk/; revision=29675
 2009-09-02 19:15:02 +00:00
Anders Broman
d96beaaecb Trying to fix: 
packets without color are randomly colorized.

svn path=/trunk/; revision=29673
 2009-09-02 17:59:56 +00:00
Anders Broman
cdd2959aa5 Adding new color rules should work now. 
svn path=/trunk/; revision=29671
 2009-09-02 17:51:48 +00:00
Kovarththanan Rajaratnam
bc36849a9e Add seperate new_packet_list_moveto_end() which scrolls to the end _without_ selecting the last packet. 
svn path=/trunk/; revision=29670
 2009-09-02 17:29:52 +00:00
Kovarththanan Rajaratnam
6149d4be35 Make sure that we select the last row if autoscroll is enabled. The scrolling is still very jumpy. It seems that we always select the first packet before moving to the end. 
svn path=/trunk/; revision=29668
 2009-09-02 17:15:20 +00:00
Anders Broman
1858d86612 Prepare abillity to add color filters with new packet list. 
(Packets not recolored yet).

svn path=/trunk/; revision=29664
 2009-09-02 15:07:03 +00:00
Anders Broman
c5c569597b In new_packet_list_append() all we need is in fdata. 
svn path=/trunk/; revision=29657
 2009-09-01 18:29:11 +00:00
Kovarththanan Rajaratnam
5b3f74f9d5 We no longer store the column text in our record, so don't ever dereference the record column text pointer. In fact, remove it completely. This could cause a crash. 
While there, throw in a few g_assert()'s.

svn path=/trunk/; revision=29653
 2009-09-01 16:00:56 +00:00
Bill Meier
1bc9f19f05 Add #include <stdio.h> in a few more places for Solaris. 
svn path=/trunk/; revision=29577
 2009-08-27 03:54:57 +00:00
Anders Broman
2dd60e1b66 Custom columnfication: 
* Deprecate COL_BSSGP_TLLI (GPRS BSSGP IE TLLI). Use bssgp.tlli

svn path=/trunk/; revision=29546
 2009-08-25 05:42:14 +00:00
Kovarththanan Rajaratnam
23d4eba3b1 Custom columnfication: 
* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta

svn path=/trunk/; revision=29524
 2009-08-23 12:30:48 +00:00
Kovarththanan Rajaratnam
b9cbd15469 Custom columnfication: 
* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative

svn path=/trunk/; revision=29523
 2009-08-23 12:24:14 +00:00