osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
34,805 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

34805 Commits

Author SHA1 Message Date
Chris Maynard 10928bc0cc Don't use prohibited strncpy(). Use g_strlcpy() instead. Ensures that "orig" 
will be NULL-terminated, even if len >= SCS_HUGE_SIZE.

svn path=/trunk/; revision=36383
 2011-03-28 17:04:58 +00:00
Chris Maynard 15503bf4aa Don't use prohibited strncpy(). In this case, use g_strlcat() instead. 
svn path=/trunk/; revision=36382
 2011-03-28 16:42:25 +00:00
Jeff Morriss c977007591 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5522 : 
Fix a Clang warning, add email address, and add some stuff to COL_INFO.

svn path=/trunk/; revision=36381
 2011-03-28 15:28:03 +00:00
Jeff Morriss c39c25ce9c From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 : 
Register the reload-framing dissector by name.  Needed when RELOAD is not used
over udp/tcp (but tls, for example)

svn path=/trunk/; revision=36380
 2011-03-28 15:23:27 +00:00
Jeff Morriss 569c3d9014 From Alexis La Goutte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5768 : 
Patch 5

Enchance MySQL : 
* Add expert info of when undecoded data 
* Fix some white space

svn path=/trunk/; revision=36379
 2011-03-28 15:20:16 +00:00
Chris Maynard ba9dc9f45f Make ip.fragments an FT_BYTES field so a PDML Export will display the bytes in 
the value="..." attribute.  Fixes bug 1520.

svn path=/trunk/; revision=36378
 2011-03-28 14:53:35 +00:00
Stig Bjørlykke b95c4cb6a2 Added payload, header and trailer information to the DLT tree entry. 
svn path=/trunk/; revision=36377
 2011-03-28 14:18:29 +00:00
Anders Broman 08f71f1232 Update a comment. 
svn path=/trunk/; revision=36376
 2011-03-28 13:09:47 +00:00
Guy Harris 5749270c56 If there are more than 4 billion characters in the printable form of a 
network address, we have bigger problems.  Cast the result of strlen()
to int to squelch a compiler warning with MSVC++.

svn path=/trunk/; revision=36375
 2011-03-27 17:26:21 +00:00
Bill Meier 0da2042447 Fix Coverity 393: "DEADCODE"; Add an XXX comment 
svn path=/trunk/; revision=36373
 2011-03-27 16:15:19 +00:00
Gerald Combs 941666d525 Add "-z hosts", which dumps name resolution information in hosts format. 
svn path=/trunk/; revision=36372
 2011-03-27 16:06:03 +00:00
Gerald Combs 8cc32fd535 Add the IPv4 address, not the first 4 bytes of its name, to the 
resolution table.

svn path=/trunk/; revision=36370
 2011-03-27 15:58:52 +00:00
Bill Meier 7a77cdf0f1 1. Fix bug in dissection of a field; Add two missing lines of code. 
2. #if 0 if test "which will never be true"; Add XXX comment

svn path=/trunk/; revision=36369
 2011-03-27 15:39:06 +00:00
Gerald Combs a4f03a1101 [Automatic manuf, services and enterprise-numbers update for 2011-03-27] 
svn path=/trunk/; revision=36368
 2011-03-27 15:03:43 +00:00
Bill Meier 7c41d527fd Removed uneeded 'continue'. 
Fixes Coverity 815 ("UNREACHABLE").

svn path=/trunk/; revision=36367
 2011-03-27 14:34:19 +00:00
Stig Bjørlykke e43c9a35e4 Added a FALLTHRU comment to avoid a "missing break" warning. 
Coverity 472.

svn path=/trunk/; revision=36366
 2011-03-27 14:11:40 +00:00
Anders Broman 129f07a949 Added FALLTHRU comment to avoid a "missing break" warning. 
svn path=/trunk/; revision=36365
 2011-03-27 14:02:42 +00:00
Stig Bjørlykke 3c533baf45 Added a missing break. 
Coverity 452.

svn path=/trunk/; revision=36364
 2011-03-27 13:56:53 +00:00
Stig Bjørlykke 71c369611a Added a missing break. 
Coverity 461.

svn path=/trunk/; revision=36363
 2011-03-27 13:54:53 +00:00
Stig Bjørlykke 473b25301e Added some missing breaks. 
Coverity 462 & 463.

svn path=/trunk/; revision=36362
 2011-03-27 13:51:47 +00:00
Stig Bjørlykke c9468a80be Added some missing breaks. 
Coverity 443 & 444.

svn path=/trunk/; revision=36361
 2011-03-27 13:40:54 +00:00
Stig Bjørlykke 8ce65d5dee Added some missing breaks. 
Coverity 447.

svn path=/trunk/; revision=36360
 2011-03-27 13:35:30 +00:00
Stig Bjørlykke 31b37eec2d Added a FALLTHRU comment to avoid a "missing break" warning. 
Coverity 458.

svn path=/trunk/; revision=36359
 2011-03-27 13:33:28 +00:00
Stig Bjørlykke d79ac3d6b8 Added some missing breaks. 
Coverity 466.

svn path=/trunk/; revision=36358
 2011-03-27 13:30:39 +00:00
Stig Bjørlykke 58df865db5 Added a missing break. 
Coverity 491.

svn path=/trunk/; revision=36357
 2011-03-27 13:16:50 +00:00
Stig Bjørlykke a39c0d9577 Added a missing break. 
Coverity 492.

svn path=/trunk/; revision=36356
 2011-03-27 13:15:14 +00:00
Bill Meier 21d34d05b9 Don't assign to a proto_item* if the value won't be used: Coverity 895-897 
Also: Fix some indentation & whitespace.

svn path=/trunk/; revision=36355
 2011-03-26 16:39:30 +00:00
Jaap Keuter 391b328a6b From Alexis La Goutte: 
A patch to add ATM over TCP Dissector.
The dissector dissect only the ATMTCP header (VCI, VPI, Payload Length) 
The data are not yet dissect, it is necessary to add a "UAT" (As with the K12
dissector) to indicate the type (ILMI, AAL, ATM...) of data (based on VCI/VPI)

svn path=/trunk/; revision=36354
 2011-03-26 16:07:30 +00:00
Stig Bjørlykke ff40ab2174 Added a sanity check to remove a coverity warning. 
Coverity 537.

svn path=/trunk/; revision=36353
 2011-03-26 15:59:57 +00:00
Stig Bjørlykke cfd583a6be Added sanity checks for preferences. 
Coverity 551 & 553.

svn path=/trunk/; revision=36352
 2011-03-26 15:53:55 +00:00
Stig Bjørlykke 2e4ae4108f Added a sanity check in output_fields_set_option. 
Coverity 552.

svn path=/trunk/; revision=36351
 2011-03-26 15:39:35 +00:00
Stig Bjørlykke 33814e3b39 Added a FALLTHRU comment to avoid a coverity warning. 
Coverity 480.

svn path=/trunk/; revision=36350
 2011-03-26 15:24:36 +00:00
Stig Bjørlykke 4c7f1096db Added a missing break in graph_select_segment. 
Coverity 482.

svn path=/trunk/; revision=36349
 2011-03-26 15:20:37 +00:00
Stig Bjørlykke 43cba80324 Added a missing break in hostlist_get_filter_name. 
Coverity 481.

svn path=/trunk/; revision=36348
 2011-03-26 15:16:40 +00:00
Jaap Keuter ab3fbb4d31 From Hadar Shoham: 
Add support to correlation ID under DHCPv6 according to 
"CL-SP-CANN-DHCP-Reg-I06-110210" 
DHCPv6 option 17 Vendor-specific Information, sub option 2172 (paragraph 5.4.3)

svn path=/trunk/; revision=36347
 2011-03-26 11:23:46 +00:00
Ronnie Sahlberg aa01f6e0f6 remove a proto_item variable we never use 
coverity 866

svn path=/trunk/; revision=36346
 2011-03-26 05:39:45 +00:00
Ronnie Sahlberg f00cc53adb remove a proto_item variable we dont need 
coverity 1046


svn path=/trunk/; revision=36345
 2011-03-26 05:18:09 +00:00
Jeff Morriss 3161977bf8 Introduce ep_strconcat (copied from the glib version) 
svn path=/trunk/; revision=36344
 2011-03-26 02:39:04 +00:00
Jeff Morriss b838995e60 Remove some duplicated string manipulation code. 
svn path=/trunk/; revision=36343
 2011-03-26 02:11:42 +00:00
Jeff Morriss 28939cef5c Simplify the generation of the 'name' passed to tick_stat_node(). 
svn path=/trunk/; revision=36342
 2011-03-26 01:22:31 +00:00
Jeff Morriss dd9f86c38d The 'name's passed to tick_stat_node() do not need to be static. 
svn path=/trunk/; revision=36341
 2011-03-26 01:21:43 +00:00
Gerald Combs 4ee10e769e Fix Coverity CIDs 810 & 811: uninitialized variables. 
svn path=/trunk/; revision=36340
 2011-03-25 23:45:48 +00:00
Stephen Fisher 321149bcd7 Fix Coverity 331, 332, 333: Wrap the three remaining 
gtk_tree_selection_get_selected() calls with if(!..) return;
like the rest of them.  These functions shouldn't be called
unless a packet was selected, so this call should always return
TRUE for success.


svn path=/trunk/; revision=36339
 2011-03-25 22:35:29 +00:00
Jeff Morriss 5e1b6cf408 Reword the comments from rev 36304. 
Replace the tabs in the file (mostly added by me) with spaces (for consistency).

svn path=/trunk/; revision=36338
 2011-03-25 22:20:27 +00:00
Stephen Fisher 3a8bd554fe Fix coverity 268, 269, 546, 547, 548, 549 by checking for null return 
from p_get_proto_data() since it should have been set already by the
calling function.  Any other case would be a bug, so call
DISSECTOR_ASSERT in those cases.  Hopefully Coverity realizes that this
is a null return value check.


svn path=/trunk/; revision=36337
 2011-03-25 22:16:23 +00:00
Bill Meier 23eaca915b Don't assign to a proto_item* if the value won't be used: Coverity 941 
svn path=/trunk/; revision=36336
 2011-03-25 22:13:33 +00:00
Bill Meier ea10c028b1 Don't assign to a proto_item* if the value won't be used: Coverity 958-961. 
svn path=/trunk/; revision=36335
 2011-03-25 21:52:56 +00:00
Bill Meier 7d8633af66 Don't assign to a proto_item* if the value won't be used: Coverity 852,854; 
Add a hidden item to the correct subtree: Coverity 853.

svn path=/trunk/; revision=36334
 2011-03-25 21:09:28 +00:00
Jeff Morriss 38b9f1cfbd As suggested by Didier in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 : 
Apply rev 25869 to some more dissectors.

svn path=/trunk/; revision=36333
 2011-03-25 20:04:54 +00:00
Jeff Morriss cc6fc23812 From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 : 
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors.
(The SSL dissector was already updated in one of two spots with bug 4535/rev
32456.)

A couple of the patches had to be manually applied.

From me: Fix the comments to match the change (including in the TCP and SSL
dissectors.)

svn path=/trunk/; revision=36332
 2011-03-25 19:02:18 +00:00