Commit Graph

5473 Commits

Author SHA1 Message Date
Anders Broman 84553b468c From cyrille colin:
PATCH : SNDCP reassembly fails / overlaps when same NPDU number in another call
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1755

svn path=/trunk/; revision=22846
2007-09-11 16:59:57 +00:00
Anders Broman 0d0799c306 Update valuestrings and comments.
svn path=/trunk/; revision=22845
2007-09-11 16:58:25 +00:00
Ulf Lamping 070cf8b006 add a dissectors project, so MSVC "jump to error" works
svn path=/trunk/; revision=22833
2007-09-09 14:58:56 +00:00
Jörg Mayer 75ac707c29 - Slightly improved dissection of Cisco's fragmented ISAKMP.
- Corrected misdetection of CISCO-UNITY VID.

svn path=/trunk/; revision=22828
2007-09-08 13:22:27 +00:00
Guy Harris 0366304ac9 Change the long protocol name dissectors for various DFS protocols to
indicate that they're for DFS; update comments as well.

Rename packet-dcerpc-afs4int.c to packet-dcerpc-fileexp.c, and change
the short and filter names for the protocol, and the names for the
filterable fields, to reflect the fact that it's for the File Exporter
protocol in DFS.  ("AFS 4" = DCE DFS.)

svn path=/trunk/; revision=22827
2007-09-07 22:11:01 +00:00
Jeff Morriss c360b112a1 If the whole packet was not captured (e.g., due to the snapshot length), do not attempt to verify the checksum of the packet. Rather, inform the user that we didn't/couldn't verify the checksum.
svn path=/trunk/; revision=22826
2007-09-07 21:46:31 +00:00
Stig Bjørlykke f725ed8b6a From Todd J Martin:
The attached patch to packet-bfd.c adds the following enhancements to BFD
decoding:
- The Authentication Section is now decoded.  All of the authentication methods
are supported.  Verification of checksums is not implemented.
- BFD flags are now shown in a tree
- Added support for the M flag
- Added a display filter for the message length
- For the Desired Min TX Interval, Required Min RX Interval, and Required Min
Echo RX Interval fields, the time value is now printed in both milliseconds and
microseconds.  (Previously, only milliseconds was being shown.)  The PDU
represents the time in microseconds, but most implementations deal in
milliseconds.
- Added a warning to flag the packet if the Authentication bit is set, but the
full Authentication Section is not present.
- Added descriptions for most of the fields
- Fix the name of the protocol.  BFD stands for Bidirectional Forwarding
Detection and not Bi-directional Fault Detection.
- Register the protocol on the UDP multihop port (4784).
- Change the filter name for the protocol from bfdcontrol to bfd since all of
the other display filters started with bfd.


Removed unused hf_bfd_auth_checksum.
Modified printing of the ':' at the end of the Authentication tree.

svn path=/trunk/; revision=22825
2007-09-07 19:05:55 +00:00
Stig Bjørlykke 49b3a6ff45 Argh! Used the wrong length modifier for size_t.
svn path=/trunk/; revision=22822
2007-09-07 15:21:08 +00:00
Stig Bjørlykke b44fe5fa90 Hm. Not so clean on all compilers...
svn path=/trunk/; revision=22821
2007-09-07 15:04:31 +00:00
Stig Bjørlykke 958259df05 Fixed compiler warnings.
svn path=/trunk/; revision=22820
2007-09-07 14:02:32 +00:00
Stig Bjørlykke c616fb0c2d Moved packet-imf.c and packet-tnef.c from ASN_DISSECTOR_SRC to CLEAN_DISSECTOR_SRC, as they are not generated from ASN1.
svn path=/trunk/; revision=22817
2007-09-06 23:32:46 +00:00
Stig Bjørlykke 9ad9f9edb7 Corrected some types, instead of adding a cast (from r21142).
Reindented file.

svn path=/trunk/; revision=22816
2007-09-06 22:29:04 +00:00
Stig Bjørlykke 2fc59fcc43 Fixed a warning: 'j' may be used uninitialized in this function.
svn path=/trunk/; revision=22815
2007-09-06 22:26:09 +00:00
Jeff Morriss 3f52508caf Count the number of TSNs gap-acked in a SACK. Warn the user (with an Expert info) if the number is greater than, say, 100. Also reindent large portions of the sack dissector function to make it readable.
svn path=/trunk/; revision=22814
2007-09-06 21:57:56 +00:00
Anders Broman 83f7ac9f95 Add A11 RRQ-CVSE-Active Start Airlink Record-Subtype 108 is expressed to Subnet.
Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun.

svn path=/trunk/; revision=22812
2007-09-06 21:25:41 +00:00
Gerald Combs 3120e42f6e Fix problems found by Beyond Security:
Instead of overflowing an unsigned int when determining the number of
items in a range, use a signed int and check for a negative value.  Make
sure our offset increments as we step through each item.  This should 
avoid large/inifinite loops.

Fix the size of hf_dnp3_al_range_stop32.

svn path=/trunk/; revision=22811
2007-09-06 18:26:04 +00:00
Anders Broman 64bafc6a18 Remove debug code and a "lost" line.
svn path=/trunk/; revision=22808
2007-09-06 16:28:08 +00:00
Anders Broman 10f5c61bf3 Get rid of get_ber_last_reated_item() and fix dissection of wIN-TriggerList.
svn path=/trunk/; revision=22807
2007-09-06 16:27:17 +00:00
Martin Mathieson 54a21f0df5 Map "wimax" -> "wimaxasncp"
svn path=/trunk/; revision=22802
2007-09-06 10:50:17 +00:00
Guy Harris 8aa23ad121 Fix indentation.
svn path=/trunk/; revision=22797
2007-09-05 22:43:51 +00:00
Anders Broman 108f4f347c Fix the asn1 code for WIN-TriggerList and systemMyTypeCode plus
a copy-paste error in the hf fields.

svn path=/trunk/; revision=22796
2007-09-05 22:24:40 +00:00
Stig Bjørlykke ad1b52310a Check object_identifier_id before use.
svn path=/trunk/; revision=22794
2007-09-05 07:35:59 +00:00
Jaap Keuter 02e0c97eed From Munenori Ohuchi:
packet-netflow.c is lack of the capability to decode ipv6 address related fields in netflow v9.

This patch enables dissecting the following fields:
 Type 27 IPV6_SRC_ADDR,
 Type 28 IPV6_DST_ADDR,
 Type 29 IPV6_SRC_MASK,
 Type 30 IPV6_DST_MASK and
 Type 62 IPV6_NEXT_HOP.

svn path=/trunk/; revision=22793
2007-09-05 06:59:24 +00:00
Anders Broman 6fd46f0788 Include expert.h and while at it change to use -X and -T options for asn2wrs.
svn path=/trunk/; revision=22792
2007-09-05 05:48:44 +00:00
Ronnie Sahlberg 622f19843c start prettifying nfsv4
svn path=/trunk/; revision=22791
2007-09-05 00:29:31 +00:00
Ronnie Sahlberg befaad153b we dont have g_hash_table_new_full() on gtk1
use g_hash_table_new() on gtk1 and leak memory instead


this should actually a be using an se_tree instead of hashtables


svn path=/trunk/; revision=22789
2007-09-04 23:27:34 +00:00
Stig Bjørlykke f1cf7ee6bf Fixed compiler warnings to get the buildbot going.
svn path=/trunk/; revision=22787
2007-09-04 21:49:14 +00:00
Stig Bjørlykke 6e94835848 Rewrote handling of parameters to get rid of "funky" oid strings.
Added expert info for unknown binding-parameters.

svn path=/trunk/; revision=22786
2007-09-04 21:46:41 +00:00
Anders Broman b3521c5975 value_tvb=out_tvb, remove unused variables.
svn path=/trunk/; revision=22785
2007-09-04 19:36:07 +00:00
Anders Broman a76efadf0c Get correct value for bitstrings.
svn path=/trunk/; revision=22784
2007-09-04 16:57:07 +00:00
Anders Broman f7bed80d57 ANSI MAP systemMyTypeCode should be OPTIONAL
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1820

svn path=/trunk/; revision=22783
2007-09-04 16:55:48 +00:00
Jaap Keuter 970f34a557 From Munenori Ohuchi:
This patch adds a new feature to dissect HSRPv2 packets.

One of the main features of HSRPv2 can enable using HSRP on IPv6. In order to
achieve this new feature, HSRPv2 packet format is totally different from
HSRPv1. HSRPv2 introduces new TLV formats.

This patch can decode these new formats of HSPRv2.

svn path=/trunk/; revision=22781
2007-09-04 06:55:52 +00:00
Anders Broman 8f1d357618 From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

svn path=/trunk/; revision=22780
2007-09-04 05:22:43 +00:00
Anders Broman 654554a507 Wireshark packet-gtp.c error in decoding IMEI.
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1536

svn path=/trunk/; revision=22779
2007-09-03 16:42:28 +00:00
Anders Broman 4e0cf23472 Incorrectly decoded IMSI in RANAP prot./id-CommonID procedure
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1713

svn path=/trunk/; revision=22778
2007-09-03 16:40:51 +00:00
Anders Broman 8f3a0cb862 BSSGP.TLLI is not recognized properly in filter
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1384

svn path=/trunk/; revision=22777
2007-09-03 16:39:07 +00:00
Guy Harris 8084fb9e82 guint8, not gchar, is the appropriate type for a byte.
svn path=/trunk/; revision=22776
2007-09-03 06:44:54 +00:00
Jaap Keuter bd56b304c6 Fix for bug 1816:
Add status value to LSSU info column.

svn path=/trunk/; revision=22775
2007-09-03 05:56:48 +00:00
Guy Harris 522053f04b tvb_reported_length() returns a gint, so assign its value to a gint.
svn path=/trunk/; revision=22773
2007-09-02 23:51:51 +00:00
Guy Harris 6b45c4179d The actual length of the PPPoE payload is returned by
tvb_reported_length_remaining(), not by tvb_length_remaining() -
tvb_length_remaining() shows only the amount of *captured* data
remaining, but the capture might have been done with a snapshot length
that cut the packet data short.

The payload length from the PPPoE header could legitimately be different
from the actual length of the PPPoE payload if there's not enough PPPoE
payload to avoid padding at the E(thernet) level.  Only complain if
there shouldn't have been any padding.

Report an "expert" warning if the payload length looks wrong.

Update a comment to reflect current reality (as of many many years ago,
when we went all-tvbuff).

svn path=/trunk/; revision=22770
2007-09-02 22:49:56 +00:00
Guy Harris 0e09d21936 Fix indentation.
svn path=/trunk/; revision=22768
2007-09-02 20:37:39 +00:00
Jaap Keuter 770034f1d0 From Steve Karg:
Fix for bug 1807. This patch corrects the decoding of the NotificationParameters. 
I fuzz tested with these and other captures (Pass > 100).

svn path=/trunk/; revision=22766
2007-09-01 11:47:59 +00:00
Guy Harris 81f968f748 Show unsigned quantities with %u, not %d.
svn path=/trunk/; revision=22764
2007-08-31 23:56:07 +00:00
Sake Blok 2ef69333db When doing TCP_SEQ analysis, if the packet is a SYN, then it's
not a lost packet but the tcp ports are being reused. This is often 
seen in load-balanced environments where client ports are preserved 
on the server-side.

We only want to report port reusage once, so the SYN/ACK is excluded 
from TCP_SEQ analysis.

svn path=/trunk/; revision=22762
2007-08-31 15:06:27 +00:00
Jaap Keuter 1a8fb7a459 Fix for bug 1244:
hf_isup_event_ind contains incorrect fieldbase.

svn path=/trunk/; revision=22760
2007-08-31 05:37:43 +00:00
Anders Broman 51460c5a5f fix dissect_per_bit_string() for unaligned PER, values ar still not correctly displayed.
svn path=/trunk/; revision=22758
2007-08-30 19:44:22 +00:00
Stig Bjørlykke 6d9c82338d Fixed a brace placement to enable the default case
svn path=/trunk/; revision=22751
2007-08-30 11:37:49 +00:00
Greg Morris 1506ed6fcc Test to see if packet is actually a request by verifying the one byte function code is a non-zero value.
svn path=/trunk/; revision=22749
2007-08-30 10:33:24 +00:00
Greg Morris a6aab98d1e Fix attribute *Print Checkpoint"
Fix Printer State Reasons in extended error codes.

svn path=/trunk/; revision=22747
2007-08-30 10:23:58 +00:00
Greg Morris c8be509d6a Add eDirectory iteration verb 0x6e.
Fix eDirectory timestamps to display correctly.

svn path=/trunk/; revision=22746
2007-08-30 10:18:29 +00:00