of Visual C++. (How did this "feature" ever see the light of day?) Make
sure we use LOCAL_CFLAGS *everywhere*. This should fix problems with
building a usable installer under Visual Studio 2008 SP1.
Add comments with links to Visual C++'s idiotic handling of assemblies
and deployment using xcopy. Move to c-ares 1.5.3. Make sure we remove
all of our manifests in epan and packaging/u3/tools.
svn path=/trunk/; revision=26219
bug 2791.
Don't use "-o" in the PortAudio compilation flags. If we're running Visual
C++ 2008, don't use "/Zd" when compiling packet-rrc.c. Fixes bug 2795.
svn path=/trunk/; revision=26023
Get rid of an extra g_strdup() (get_if_name() doesn't mangle its
argument and doesn't modify prefs.capture_device).
If there's no interface on which to capture, pop up a dialog to indicate
that.
svn path=/trunk/; revision=25997
Start Wireshark without a preference file saved. Open the capture options dialog,
then click "Start" button without selecting any interface. Wireshark segfaults while
dereferencing NULL pointer in get_if_name() called from capture_start_cb().
svn path=/trunk/; revision=25987
Windows build. Add support for async IPv6 lookups. Update the ADNS
code slightly.
This is not supported (yet) on the UNIX side.
svn path=/trunk/; revision=25953
- makes (much) more sense to me
- makes the GUI's default behavior the same as mergecap's
For whatever reason the default behavior was to append the new file
/if transport resolution was enabled/ (not sure what those two things have to
do with each other).
svn path=/trunk/; revision=25947
unprotect_thread_critical_region() in every module in gtk/: instead have those
modules include main.h (which has the properly extern'd prototype).
This should fix the link error on HP-UX described in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2702
svn path=/trunk/; revision=25933
From me:
Instead of adding adns_config.h, place it a custom adns package in
wireshark-win32-libs. Update tools/win32-setup.sh accordingly.
Split the MSVC2008EE variant into MSVC2008 and MSVC2008EE, similar to
MSVC2005 and MSVC2005EE. We have to worry about vcredist_x86.exe in
both cases.
Add Pascal to AUTHORS.
Update the Developer's Guide.
svn path=/trunk/; revision=25921
Follow-up from SVN 25825 check in
The g_slist_free() is really needed in export_object.c, otherwise, the export
list has false (repetitive) entries in it, that cause a crash when selecting
them.
Whether false entries are in the list, only depends on the speed of the export
processing, since this tap is
Replaced all guchar with gchar. This should eliminate the warnings on solaris.
I guess I used the wrong reference.
Added patch for 'Authors' in case I need to add myself to the list.
svn path=/trunk/; revision=25834
There are still display filter controls where this isn't being used
yet, but I'm committing it now so hopefully people can report any
problems.
Some commenting and formatting was done by myself.
svn path=/trunk/; revision=25788
Attached is a patch for:
- PW Associated Channel Header dissection as per RFC 4385
- PW MPLS Control Word dissection as per RFC 4385
- mpls subdissector table indexed by label value
- enhanced "what's past last mpls label?" heuristic
- Ethernet PW (w/o CW) support as per RFC 4448
svn path=/trunk/; revision=25730
capinfos and dumpcap don't need to depend on libwireshark nor directly pull
in those modules). Because capinfos and editcap were only being linked with
privileges.c if we had plugins, this allows those programs to be linked when
someone is compiling --without-plugins.
svn path=/trunk/; revision=25640
GTK+ since version 2.8, when its name was changed to the "GTK MS
Windows-Engine."
Simplify the Windows installer by removing the GTK-Wimp option (which
means the "Wireshark" item can be an entry instead of a group). Move
Rawshark to the "Tools" group.
(If anyone wants to disable the MS Windows Engine they can still do so
after installation by disabling or removing libwimp.dll.)
svn path=/trunk/; revision=25611
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.
Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).
Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().
Clean up some indentation.
svn path=/trunk/; revision=25601
capture callbacks the capture_options * as its second argument in all
cases. This makes it a bit clearer what arguments callbacks take, and
means we can get rid of all global_capture_opts references in
gtk/main_statusbar.c.
Put the interface between gtk/main.c and gtk/main_statusbar.c into a
private header.
svn path=/trunk/; revision=25576
don't need global_capture_opts don't need to have it declared and thus
don't need capture_options defined.
Include gtk/capture_globals in the files in question.
Change some more capture_opts references to refer to
global_capture_opts.
Change some global_capture_opts references in routines with a
capture_opts argument to refer to capture_opts.
The structure type is capture_options, not capture_opts; fix some
references.
Include <sys/types.h>, if it's present, in capture_opts.h, so we get
gid_t defined.
Clean up indentation.
svn path=/trunk/; revision=25574
now-defult global capture_opts pointer; we eventually should try to
minimize the use of global variables.
Export global_capture_opts from gtk/main.h.
Clean up indentation.
svn path=/trunk/; revision=25571
the capture_opts structure as an argument, rather than just a pointer to
the interface name.
Don't declare a global "capture_opts" pointer, as we don't define it any
more.
svn path=/trunk/; revision=25570
for getting things as right as possible.
gnome_url_show() is run by gnome-open, so just running gnome-open - or
xdg-open, which runs gnome-open on GNOME - will suffice.
svn path=/trunk/; revision=25533
the Web browser setting; that should honor the user's *real* preferred
Web browser setting (i.e., the one they've selected in their desktop
environment).
Don't bother defining HTML_VIEWER as "xdg-open" if we have xdg-open - we
don't need it.
svn path=/trunk/; revision=25514
in "Use multiple files". Also default to storage-based if not time-based.
This fixes the initial problem in bug #2599.
svn path=/trunk/; revision=25489
packet_list to ensure it's created before we set it.
Applying filter from the packet list still doesn't work correctly.
svn path=/trunk/; revision=25454
Not implemented for conversation relative and delta time yet, because this
will need a reload as they are set by the dissectors and does not exist in
the frame data.
svn path=/trunk/; revision=25452
is signed; make the flags field in "struct magnify" unsigned, and make
the flags unsigned, so we shift 1U rather than 1.
svn path=/trunk/; revision=25421
Fixed a bug where a one character comment would skip the interface.
If syntax error in the comment just skip the comment instead of the interface.
svn path=/trunk/; revision=25413
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.
While doing that, rename the eth_* functions to ws_*.
svn path=/trunk/; revision=25354
Switched columns for percent text and percent value.
Fixed generated filter for BSSID and/or SSID.
Fix for merging elements with only BSSID or SSID.
svn path=/trunk/; revision=25319
- Use the common function for applying a selected filter.
- Put a frame around the two tables.
- Enhanced the percent columns to show a progress bar.
svn path=/trunk/; revision=25316
Added a new checkbox for the RTP player to use the RTP timing instead of the
arriving time of the packets. This is useful when the RTP is being tunneled
(e.g. EtherIP), so the original timing is missing.
In some cases when encapsulating the original IP/RTP over EtherIP, the
encapsulated data comes in chunks of 1sec, so it is useful to use the RTP
timing to play it. In these cases we can not simulate jitter buffer, so this is
disabled when checking the new "Use RTP timestamp" option.
svn path=/trunk/; revision=25293
- Added details for each network
- Added context menu for adding a filter
- Keep the selected network when capturing
- Show probe requests with broadcast ssid
- Print '.' for non-printable characters in ssid
svn path=/trunk/; revision=25226
Since this leads to a compilation failure (Warning C4819: unexpected character
in the current code page) on non-european Windows, I'd like you to avoid using
non-ASCII characters in Wireshark code (even in comment).
svn path=/trunk/; revision=25214
Small patch to gtk/expert_dlg.c to test for the existance of the etd->label
before use. This patch stops GTK assertion on Linux.
svn path=/trunk/; revision=25160
"Tap" is a term likely only to be known to developers, and
"Statistics" matches the Menu item under which all of the affected
windows are launched.
svn path=/trunk/; revision=25151
- rename rtp_player config group to taps/statistics
- will rename prefs_rtp_player files later
(svn didn't seem keen to rename with changes present,
and output says its just a copy/delete anyway...)
svn path=/trunk/; revision=25133
from Jim Young:
The attached patch simply tests for a non-NULL
welcome_file_panel_vb before attempting to get the
child_list.
svn path=/trunk/; revision=25120
where there's an openable file and a directory with the same pathname
except for the extension, but at least it prevents us from trying to open
the file.
svn path=/trunk/; revision=25103
as it shouldn't be modifying the strings, but it's "gchar **", so we
can't make argv an array of "const gchar *" - which means that you can't
put a "{g}char *" into it without a cast.
Clean up white space.
svn path=/trunk/; revision=25100
Add a routine "filemanager_open_directory()", which takes a pathname
(presumed to be UTF-8 in Windows and Mac OS X; this might need work for
other UN*Xes) and attempts to open a file manager window for it, using
ShellExecute on Windows, Launch Services on OS X, and, for now, running
xdg-open on other OSes if we have it (should we have a preference for
the file manaager, just as we have one for the Web browser?).
(For that matter, if we have xdg-open, do we need a preference for the
Web browser, or should we just have xdg-open open the Web browser?)
svn path=/trunk/; revision=25097
just our initialization routine for low-level GTK+ stuff, such as
getting the system colormap and the "black" and "white" colors; we have
to call it before calling get_color().
svn path=/trunk/; revision=25090
"Bytes".
"Interface description" vs. "interface name" isn't Windows vs. UN*X,
it's "has a description" vs. "doesn't have a description" - the lack of
descriptions in UN*X is a result of
1) lack of a mechanism to supply descriptions in some UN*Xes
and
2) lack of code in libpcap to get those descriptions in some
other UN*Xes
and I need to work on fixing 2) (I think it can be dredged out of
FreeBSD 6 and 7, I seem to remember current OpenBSD supplying them, and
for OS X we might as well cheat the way the network preference pane does
and just call en0 the main Ethernet and en1 the AirPort interface).
Use an adverb rather than an adjective to modify a noun, as per Chris
Maynard's suggestion.
svn path=/trunk/; revision=25089
in case a file has more than 2^32 megabytes of data :-); we already
require 64-bit support for calculations and formatting.
svn path=/trunk/; revision=25088
this will also prevent us from showing different stock icons for "our" xpm stock icons and the "system defaults". GTK (for Windows?) changed the icon theme somewhere around V2.10 (or later?) and/or the user might use a different icon theme, so this isn't an esoteric case ;-)
svn path=/trunk/; revision=25075
Balint Reczey