998ee3a2e0
Make some of the check_XXX functions accept the length/reported length of the tvbuff as arguments instead the tvbuff. We'll need this feature in order to remove the non-thread usage of the 'last_tvb' variable in tvb_new_subset()
...
svn path=/trunk/; revision=29442
2009-08-16 08:18:17 +00:00
01abc372e6
Remove a non thread-safe usage (useful when/if we ever support threading) of a static tvbuff in tvb_new_real_data(). The current version uses a static 'last_tvb' to keep track of the last allocated tvbuff. This is needed because some of the function we call can throw an exception. This patch improves this strategy by throwing an exception (if needed) before we try to allocate the tvbuff. This way we avoid a memleak _and_ we don't have to track the 'last_tvb' tvbuff.
...
svn path=/trunk/; revision=29441
2009-08-16 07:29:11 +00:00
7cb17ecec0
Use the slice allocator if GLIB >= 2,10,0
...
svn path=/trunk/; revision=29440
2009-08-16 04:54:33 +00:00
c28b654f20
Switch over to using GPtrArray instead of manually g_renew'ing. This switch has some benefits:
...
1) We don't have to manually resize
2) GPtrArray uses a sligtly more efficient allocation scheme. It increases the size of the array exponentially which reduces the amount of memcpy's we have to do when we resize the array
svn path=/trunk/; revision=29439
2009-08-16 04:08:00 +00:00
8b00ed7674
Mark function paramter as unused with _U_ to please gcc.
...
svn path=/trunk/; revision=29438
2009-08-16 02:35:44 +00:00
408b658647
Try to please build bot
...
svn path=/trunk/; revision=29437
2009-08-15 21:59:03 +00:00
23dc20f6bf
Prepare for storing column data in packet list store.
...
svn path=/trunk/; revision=29436
2009-08-15 21:12:56 +00:00
d4ba2208ec
Inline a few checks in the add_packet_to_packet_list() function since it's called in tight loop. This will help us to avoid calling functions that simply returns. This is especially the case when we're dealing with the new packet list due to its dissect-on-demand nature where colour/column construction is delayed until the row becomes visible.
...
svn path=/trunk/; revision=29435
2009-08-15 14:13:36 +00:00
aed905a6c9
Use the slice allocator if GLIB >= 2,10,0 as suggested by Anders Broman
...
svn path=/trunk/; revision=29434
2009-08-15 13:24:59 +00:00
623db2e71e
Add a missing DISSECTOR_ASSERT in tvb_init()
...
svn path=/trunk/; revision=29433
2009-08-15 12:41:24 +00:00
ef68d63745
Make mem chunk static
...
svn path=/trunk/; revision=29432
2009-08-15 12:29:25 +00:00
197d30a3b8
Use HFILL instead of hard coding the values
...
svn path=/trunk/; revision=29431
2009-08-15 11:21:36 +00:00
154de60393
Switch over to using GLib's g_malloc/g_free in the name of consistency.
...
svn path=/trunk/; revision=29430
2009-08-15 09:13:16 +00:00
da97c3e2b6
This should have been part of r29428. This patch forces proto_field_is_referenced() to respect the fake_protocols flag set by Protocol Hierarchy stats tap.
...
svn path=/trunk/; revision=29429
2009-08-15 08:38:50 +00:00
96b2c411dd
The frame dissector contains a kludge to workaround the fact that the Protocol Hierarchy stats tap always needs the protocol node to appear even though no color, display filter etc. reference it. This is no longer needed due to r29380.
...
svn path=/trunk/; revision=29428
2009-08-15 08:05:10 +00:00
7d44262406
This patch introduces packet_add_new_data_source() which effectively deprecates add_new_data_source(). This is based on the following observation:
...
1) The tvb + name (aka. data_source) is only used when the protocol tree is visible
The current implementation of add_new_data_source() doesn't take this into account and simply allocates a data_source regardless. This is what packet_add_new_data_source() tries to rectify.
A couple of dissectors have already been switched over to the new packet_add_new_data_source(). Many are still missing. Help appreciated!
svn path=/trunk/; revision=29427
2009-08-15 06:38:10 +00:00
3beae5944f
Micro optimize by storing PACKET_LIST(tree_model) into a local variable and using that instead of computing PACKET_LIST(tree_model) each time.
...
svn path=/trunk/; revision=29426
2009-08-15 05:26:02 +00:00
68e07573bf
Avoid superfluous g_strdup()
...
svn path=/trunk/; revision=29425
2009-08-15 05:06:27 +00:00
efa7710fdf
Enable 'Mark Packet' in the Edit menu
...
svn path=/trunk/; revision=29424
2009-08-15 04:24:43 +00:00
6b556d4039
Add support for mark/unmark all frames in our new packet list
...
svn path=/trunk/; revision=29423
2009-08-15 04:19:45 +00:00
e15fef4355
Find next/previous mark is also supported so don't exclude it
...
svn path=/trunk/; revision=29422
2009-08-15 04:05:04 +00:00
2a7add22c2
Don't exclude functionality we already support
...
svn path=/trunk/; revision=29421
2009-08-15 03:57:14 +00:00
8760a6b49d
Allow s1ap not to be dissected (to avoid seeing errors, possibly due to proprietary variants).
...
svn path=/trunk/; revision=29420
2009-08-15 01:29:29 +00:00
af00c3e6da
Make 'Apply as filter'/'Prepare filter' work for new packet list.
...
svn path=/trunk/; revision=29419
2009-08-14 19:35:01 +00:00
4d5d306372
Remove the hacky row_from_iter() function and use new_packet_list_get_record() instead. Alas, new_packet_list_get_record() is also somewhat hacky in its nature, but hey at least we're using one less hacky thing.
...
svn path=/trunk/; revision=29418
2009-08-14 18:59:15 +00:00
b266cb731e
Make mark/unmark frame work with the new filter model
...
svn path=/trunk/; revision=29417
2009-08-14 18:49:48 +00:00
b43f8f5e5a
Remove unused functions/prototypes
...
svn path=/trunk/; revision=29416
2009-08-14 18:32:44 +00:00
e9004b22b1
New packet list: right clicking on a row now selects the given row.
...
svn path=/trunk/; revision=29415
2009-08-14 18:29:32 +00:00
0e710239dc
Make first/last frame work again with the new filter model.
...
svn path=/trunk/; revision=29414
2009-08-14 15:56:23 +00:00
2c07d7ad80
Make next/previous frame work again with the new filter model.
...
svn path=/trunk/; revision=29413
2009-08-14 15:44:57 +00:00
d5a9e092f3
Typos.
...
Fixes:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3878
svn path=/trunk/; revision=29412
2009-08-14 15:31:59 +00:00
9efecb181a
Don't attach our original packet list model in new_packet_list_thaw(). It's pointless because we override it in filter_function().
...
svn path=/trunk/; revision=29411
2009-08-14 13:33:17 +00:00
2dfa5ccebe
From Artem Tamazov via. 3899:
...
Remove superfluous /MP
svn path=/trunk/; revision=29410
2009-08-14 10:17:13 +00:00
81c7e34905
Make display filtering work for NEW_PACKET_LIST. This didn't work previously because we would simply append the new filtered packets onto the existing ones.
...
svn path=/trunk/; revision=29409
2009-08-14 05:49:57 +00:00
68e75a961b
Always add packet to the new packet list regardless of whether the packet passed the display filter test or not. We do this because we do the filtering inside the new packet list.
...
svn path=/trunk/; revision=29408
2009-08-14 05:22:12 +00:00
df97e60d27
Start to implement display filtering.
...
svn path=/trunk/; revision=29407
2009-08-13 21:46:00 +00:00
96907a7180
Get the pointer to the packet list record and use the data directly.
...
svn path=/trunk/; revision=29406
2009-08-13 21:36:01 +00:00
71291d0d17
Add needed header due to stack allocated 'edt' structure
...
svn path=/trunk/; revision=29405
2009-08-13 20:00:36 +00:00
80a6d3fbcf
Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic.
...
svn path=/trunk/; revision=29404
2009-08-13 19:42:46 +00:00
97fda7386c
Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893
svn path=/trunk/; revision=29403
2009-08-13 12:17:20 +00:00
e7ed279da9
fix build failure without GnuTLS
...
svn path=/trunk/; revision=29402
2009-08-13 11:12:35 +00:00
ae5e82dc11
use G_GSIZE_MODIFIER instead of %zd which is not supported by MSVC
...
svn path=/trunk/; revision=29401
2009-08-13 10:36:53 +00:00
ebc78f0a07
Fix SSL decryption failure if client and server have the same TCP port
...
svn path=/trunk/; revision=29400
2009-08-13 09:07:03 +00:00
6aed88fadc
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3 (R7 and R8)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3891
svn path=/trunk/; revision=29399
2009-08-13 07:56:13 +00:00
088110624e
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3 (R6).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3886
svn path=/trunk/; revision=29398
2009-08-12 22:40:13 +00:00
8fd6301ddc
White space changes
...
svn path=/trunk/; revision=29397
2009-08-12 19:32:54 +00:00
9eec025c49
DISSECTOR_ASSERT on FT_PCRE in construct_match_selected_string().
...
svn path=/trunk/; revision=29396
2009-08-12 18:24:49 +00:00
3a5270f542
Temporarily disable dissector bug checking. Fixing the ones we've found
...
so far will take a while and in the meantime looking for dissector
assertions is keeping us from finding more serious bugs.
svn path=/trunk/; revision=29395
2009-08-12 17:08:08 +00:00
5bd6d8eaaf
From William Preston via. 3549:
...
A typo in 2 of the field names causes the apn not to be displayed.
svn path=/trunk/; revision=29394
2009-08-12 15:12:19 +00:00
181f4c8364
Fix COL_INFO and COL_PROTOCOL for Teredo Direct IPv6 Connectivity Test
...
svn path=/trunk/; revision=29393
2009-08-12 12:55:27 +00:00
Kovarththanan Rajaratnam