Commit Graph

32241 Commits

Author SHA1 Message Date
Bill Meier 9427f9f2c3 Hack to prevent checkAPIs.pl from complaining about missing const in
'static value_string syntax_names[...]' 

svn path=/trunk/; revision=33365
2010-06-29 03:43:17 +00:00
Bill Meier 14a209b03a Rework ethernet address resolution: step 2:
- Use a new hashwka_t struct (instead of hashether_t) for 
   "well-known-address" hash entries (saves some space);
- Remove unused variable from hashether_t;
- Reorder variables within hashether_t and hashmanuf_t to minimize padding in the structures;
- Rename some variables for clarity;
- Misc whitespace changes.

svn path=/trunk/; revision=33364
2010-06-29 02:53:17 +00:00
Gerald Combs a9650cd851 Don't try to use a NULL tvb in call_ber_oid_callback(). Fixes bug 4950.
svn path=/trunk/; revision=33363
2010-06-29 00:44:41 +00:00
Gerald Combs 9afeb63b49 Make sure we don't dereference an invalid function pointer. Fixes bug 4949.
svn path=/trunk/; revision=33362
2010-06-29 00:08:24 +00:00
Gerald Combs a514fe61c3 tvb_get_ptr() may not return a valid string. Must I break out the
picture of the cow again?

svn path=/trunk/; revision=33361
2010-06-28 23:11:48 +00:00
Bill Meier 0a785ddea8 (Trivial): Whitespace revisions.
svn path=/trunk/; revision=33360
2010-06-28 22:43:13 +00:00
Bill Meier 3af757c875 Rework ethernet address resolution: step 1: simplify 'get_ether_name_if_known()'
svn path=/trunk/; revision=33359
2010-06-28 22:29:49 +00:00
Gerald Combs dd4e194304 Make sure dissect_ber_integer() always sets a value.
svn path=/trunk/; revision=33358
2010-06-28 22:13:53 +00:00
Stig Bjørlykke 51ef439176 Mark an unused argument.
svn path=/trunk/; revision=33357
2010-06-28 21:05:31 +00:00
Stig Bjørlykke 6aba36dcc2 Add the missing packet-s1ap.h
svn path=/trunk/; revision=33356
2010-06-28 21:04:56 +00:00
Stig Bjørlykke 1c81c60477 Search in user defined oid syntax table before built-in oid table in
call_ber_oid_callback(), so the user can override the defaults in the
"OID Tables".

svn path=/trunk/; revision=33355
2010-06-28 19:06:16 +00:00
Gerald Combs e2c79ddfd0 It looks like dissect_ber_octet_string() is called with the expectation
that out_tvb will always be set (the H.248 dissector does this, at
least). Make sure we do so. Do the same for
dissect_ber_constrained_octet_string().

svn path=/trunk/; revision=33354
2010-06-28 17:26:07 +00:00
Martin Mathieson a8aeaf6986 Change a couple of format specifiers: %-nu looks better than %0nu here
svn path=/trunk/; revision=33353
2010-06-28 17:25:58 +00:00
Gerald Combs 9020bfc38d Replace ASCII arrows with their equivalent character entities.
svn path=/trunk/; revision=33352
2010-06-28 16:50:07 +00:00
Anders Broman 7ba4ce1983 Dissect more GTPV2 IE's
svn path=/trunk/; revision=33351
2010-06-28 15:31:41 +00:00
Graeme Lunt 1d8014fab4 Removal of various warnings, mainly by not emitting functions for ASN.1 types that are only used for COMPONENTS OF.
svn path=/trunk/; revision=33350
2010-06-28 14:24:32 +00:00
Stig Bjørlykke 1a4a7a718d From Jan Šafránek via bug 4945:
Remove any '%<interface>' from default filter.

Wireshark prepares unparseable default filter when it's started under
'ssh <link-local ipv6 address>%<interface name>' - '%' in SSH_CONNECTION
is not allowed filter. Let's cut the '%<interface name>' from any IP
addresses in default filters. 

svn path=/trunk/; revision=33349
2010-06-28 13:58:00 +00:00
Stig Bjørlykke 9c20c7b510 From Hitoshi Irino via bug 4942:
1. fix the bug in dissect_v9_pdu.
(The bug is introduced in r32627, It's my fault, I'm sorry.)
When option data record is decoded, unpatched dissect_v9_pdu decode only scope
fields, it does not decode following data fields. And it runs in endless loop
when length of a scope filed is 0. This patch solve these problem.
2. defines some value_strings for some fields.
3. updates URLs in comment.

svn path=/trunk/; revision=33348
2010-06-28 12:42:40 +00:00
Graeme Lunt 9708f46c8c Remove documentation of Object Identifier configuration files, as a UAT is now used.
svn path=/trunk/; revision=33347
2010-06-28 11:15:11 +00:00
Martin Mathieson f95aed808a Further improvements to UM sequence analysis.
svn path=/trunk/; revision=33346
2010-06-28 10:50:03 +00:00
Stig Bjørlykke 8246e87432 Moved register_ber_syntax_dissector() and register_ber_oid_syntax() from
proto_reg_handoff_* to proto_register_*.

svn path=/trunk/; revision=33345
2010-06-28 10:34:15 +00:00
Graeme Lunt 342fc4cfb4 After a nudge from Stig (thanks Stig), convert the OID configuration from
GKeyFile (which is not available on Sparc Solaris) to a User Accessible 
Table(UAT). 
This also allows the user to manage the configuration from the Wireshark GUI 
and select the associated syntax from a drop down list.


svn path=/trunk/; revision=33344
2010-06-28 09:33:04 +00:00
Graeme Lunt 812274918a Introduce an Object Identifier field macro, together with an appropriate field
check routine.
Also, a field type which is an enumerated string value.


svn path=/trunk/; revision=33343
2010-06-28 09:30:15 +00:00
Graeme Lunt 0d9ad5016e Remove the -R flag (used to generate syntax registrations) and replace with a
packet-<proto>-syn-reg.c output file. This is more generic and allows the 
syntax registrations to the directed from the template file.


svn path=/trunk/; revision=33342
2010-06-28 09:26:41 +00:00
Gerald Combs 6d60493b8a Initialize attributedesc_string in a couple of places so that we
don't end up trying to use an invalid pointer.

svn path=/trunk/; revision=33341
2010-06-27 22:38:28 +00:00
Gerald Combs 01568c1709 Make sure some variables are initialized.
svn path=/trunk/; revision=33340
2010-06-27 21:47:06 +00:00
Gerald Combs 2e05cc68c0 [Automatic manuf and enterprise-numbers update for 2010-06-27]
svn path=/trunk/; revision=33336
2010-06-27 15:03:39 +00:00
Anders Broman dfc1f80e70 From KATAOKA Toshihiro:
MIPv6 Heartbeat

svn path=/trunk/; revision=33335
2010-06-27 08:22:50 +00:00
Stig Bjørlykke abb629c4f8 Fixed removing a Time Reference from a column not matching the display filter.
svn path=/trunk/; revision=33334
2010-06-26 22:53:36 +00:00
Stig Bjørlykke 2ae635a51a Cleanup some whitespace.
svn path=/trunk/; revision=33333
2010-06-26 21:42:12 +00:00
Stig Bjørlykke 59e35b0fbc Always show packets with Time Reference (as in the old packet list).
Recreate visible rows when removing a Time Reference which has not passed
the display filter.

svn path=/trunk/; revision=33332
2010-06-26 21:30:36 +00:00
Stig Bjørlykke b444bd6eb2 Increase the displayed_count before we add the packet to the packet list,
because we update the the packets bar when adding the packet.

This fixes bug 4896.

svn path=/trunk/; revision=33331
2010-06-26 21:03:01 +00:00
Anders Broman f4c87595c9 From KATAOKA Toshihiro:
3GPP S1AP Transparent Container.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4913

svn path=/trunk/; revision=33330
2010-06-26 16:39:18 +00:00
Stig Bjørlykke 3f9a94d773 Avoid crash when adding SNMP Users.
This fixes bug 4926.

svn path=/trunk/; revision=33329
2010-06-26 12:00:08 +00:00
Martin Mathieson b040f1ac8c Improve UM analysis - make it more like AM.
svn path=/trunk/; revision=33328
2010-06-25 23:04:16 +00:00
Gerald Combs 0b9c5b9248 r32715 fixed bug 4708 (zlib-1.2.5 cause wireshark to stop live capture)
for Wireshark but not TShark. Apply the fix to TShark as well. Fixes bug
4916.

svn path=/trunk/; revision=33327
2010-06-25 22:24:26 +00:00
Gerald Combs 96558700c1 UTF-8-ize a bunch more arrows. If IE6 on XP can render them then they
*must* be safe to use, right?

svn path=/trunk/; revision=33326
2010-06-25 22:09:34 +00:00
Gerald Combs ca6d2031cd Try replacing "-->" with the UTF-8 byte sequence for "RIGHTWARDS ARROW".
If this works we can replace ASCII arrows elsewhere in the UI.

svn path=/trunk/; revision=33325
2010-06-25 21:01:42 +00:00
Stig Bjørlykke 1fdc2a2428 Initialize recent.gui_fileopen_remembered_dir correctly.
Set last open dir when changing profile.

svn path=/trunk/; revision=33324
2010-06-25 19:33:18 +00:00
Stig Bjørlykke 86d55f9a13 Fall back to get_persdatafile_dir() if recent.gui_fileopen_remembered_dir
does not exist or is no directory.

svn path=/trunk/; revision=33323
2010-06-25 19:22:32 +00:00
Stig Bjørlykke 7608a89820 From Cal Turney via bug 4849:
Save the folder path of the last capture selected in the Open dialog in recent.

svn path=/trunk/; revision=33322
2010-06-25 18:55:09 +00:00
Gerald Combs 5f932275b0 Make sure our addresses are modulo 2^16 in a lot of places. Fixes a
crash found while fuzzing, and hopefully fixes bug 4867.

In sigcomp_init_udvm() initialize the first 8 bytes of our buffers,
which squelches a valgrind complaint.

svn path=/trunk/; revision=33321
2010-06-25 17:14:41 +00:00
Stig Bjørlykke 5a69e41f6e Enable "Show Resolved" for custom OID columns.
svn path=/trunk/; revision=33320
2010-06-25 10:44:12 +00:00
Stig Bjørlykke b1a75e6aae Run uat->post_update_cb() in uat_load().
svn path=/trunk/; revision=33319
2010-06-25 09:58:25 +00:00
Stig Bjørlykke d74c9aa2d0 Added get_column_resolved and set_column_resolved.
svn path=/trunk/; revision=33318
2010-06-25 07:35:52 +00:00
Stig Bjørlykke beb4314276 Introduce "Show Resolved" as an option in custom columns. This will determine
if we show the value or the string representing the value.

This setting is not stored in the preferences file yet, and the option is
not available in the columns preferences window.

svn path=/trunk/; revision=33317
2010-06-25 06:42:34 +00:00
Jeff Morriss 64ebe8caae Lua is now enabled by default. Capitalize Lua in a few places. Call protocol dissectors 'protocol dissectors' instead of protocols.
svn path=/trunk/; revision=33316
2010-06-24 19:58:20 +00:00
Stig Bjørlykke 4a34cf5892 Ensure we use the numeric value when creating a filter from a custom column
entry displaying a integer value.  The resolved string can contain a space,
and our routines does not quote integer values, and A DEC_HEX/HEX_DEC
combination will never match.

svn path=/trunk/; revision=33315
2010-06-24 18:07:40 +00:00
Stig Bjørlykke 7a44c166ba Build dependency to x411.
svn path=/trunk/; revision=33314
2010-06-24 13:40:47 +00:00
Stig Bjørlykke 8aaa5b8ec7 Added description of ECT and ECN-CE, added TFS for the bit values
and some item cleanup.

svn path=/trunk/; revision=33313
2010-06-24 11:37:03 +00:00