Commit Graph

32241 Commits

Author SHA1 Message Date
Bill Meier 40de4ed2b0 ws_combo_box_text_and_pointer: allow setting entries as "insensitive".
svn path=/trunk/; revision=33494
2010-07-13 00:17:08 +00:00
Gerald Combs df14866685 WinPcap 4.1.1 -> 4.1.2.
svn path=/trunk/; revision=33493
2010-07-12 23:52:35 +00:00
Gerald Combs cfe9b05691 Add length checks.
svn path=/trunk/; revision=33488
2010-07-12 17:30:14 +00:00
Gerald Combs 55d68ba4bc [Automatic manuf and enterprise-numbers update for 2010-07-11]
svn path=/trunk/; revision=33484
2010-07-11 15:03:33 +00:00
Jaap Keuter f33d886525 Fix for bug 4993:
Mac support flags are little endian too.

svn path=/trunk/; revision=33483
2010-07-10 09:47:20 +00:00
Guy Harris 75ffa6bb71 The only reason to escape "%" in a string is if you are, incorrectly,
passing a string directly to a routine that expects a format string. 
The correct way to handle that is to pass "%s" as the string.

As long as you're escaping non-printable characters, just let
tvb_format_string() handle that.

For null-terminated strings, get the length of the string with
tvb_strsize(), and then just put the string into the protocol tree as a
regular item.

svn path=/trunk/; revision=33482
2010-07-09 21:27:08 +00:00
Gerald Combs b4a8226906 Check our field lengths. Should fix the recent randpkt errors.
svn path=/trunk/; revision=33481
2010-07-09 20:27:02 +00:00
Gerald Combs edb7f000dc Assume that if we have more than 500 levels of nested indefinite lengths
we have a malformed packet.

svn path=/trunk/; revision=33480
2010-07-09 17:07:34 +00:00
Bill Meier 05b7c16830 Implement a separate pref for enabling tracking of tcp window scaling
(instead of including this pref as part of enabling tcp relative sequence numbers).

svn path=/trunk/; revision=33479
2010-07-09 01:46:11 +00:00
Bill Meier 40c1c5b28b From Ian Schorr: "NFSv4 COMMIT Calls not decoding"
NFSv4 COMMIT Requests are not decoded.  NFS "malformed packet" logic is
tripped.

This was a bug introduced with the changes in bug 4975.  The dissector
erroneously tries to decode 4 bytes past the end of the packet.

A patch is attached that fixes that, as well as adds "Offset" info in the Info
column for COMMIT calls.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4990

svn path=/trunk/; revision=33478
2010-07-09 00:23:27 +00:00
Jörg Mayer bd09fbef8a Add dissector_tables_dlg.c
svn path=/trunk/; revision=33477
2010-07-08 14:19:32 +00:00
Stig Bjørlykke e64762a0d8 From Thomas Dreibholz via bug 4989:
Extend the SSP dissector to support the SSP Environment message type.

svn path=/trunk/; revision=33476
2010-07-08 14:14:11 +00:00
Anders Broman 7f90713b6e from Tarjei Knapstad.
Minor cleanups in packet-xml dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4987

svn path=/trunk/; revision=33475
2010-07-08 12:55:03 +00:00
Anders Broman ab2eaa1001 Add "WS internal" to the menues this can be used to display internal information like the curren "entry" dissector tables. Emem statistics
could be another item to add.

Add dissector tables treview. This cab be used to find which UDP ports are registered for example.

svn path=/trunk/; revision=33474
2010-07-08 11:05:16 +00:00
Stig Bjørlykke 8846a92d9c Update the services file from IANA's port-numbers.
svn path=/trunk/; revision=33473
2010-07-08 10:04:06 +00:00
Jeff Morriss b0cf38c06c Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4854 (crash when adding
2nd info column):

Duplicate col_do_append_sep_va_fstr()'s code into col_append_fstr() and
col_append_sep_fstr() (and remove col_do_append_sep_va_fstr()) because we need
to call va_start() and va_end() after each call to g_vsnprintf().  (This is a
followon to rev 32961.)

svn path=/trunk/; revision=33472
2010-07-08 02:54:26 +00:00
Jeff Morriss 4e76ef92cb For: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4984#c4 : In try_get_ber_length() don't let a negative length make us go backwards. This should eliminate a possible infinite loop and appears to /help/ limit the depth of recursion.
svn path=/trunk/; revision=33471
2010-07-07 22:00:44 +00:00
Gerald Combs 820be405e2 Fix a buffer overflow found by recent randpkt testing. Replace raw data
pointer access with tvb_memcpy() and tvb_get_ntohs().

svn path=/trunk/; revision=33470
2010-07-07 21:27:13 +00:00
Guy Harris e1d0087af9 NEW_FILTER_COMBO_BOX no longer does anything - it's not checked for - so
there's no need to define it.

svn path=/trunk/; revision=33469
2010-07-07 20:33:19 +00:00
Gerald Combs 6a49671fa2 Make sure we use the "randpkt-" prefix everywhere.
svn path=/trunk/; revision=33468
2010-07-07 19:53:40 +00:00
Martin Mathieson 28681e2200 From Pascal Quantin: Add offset of 1 to FMS.
svn path=/trunk/; revision=33467
2010-07-07 17:13:53 +00:00
Gerald Combs 3bc24f2d98 Try limiting our stack size.
svn path=/trunk/; revision=33466
2010-07-07 16:55:42 +00:00
Anders Broman 3d431c8258 Remove the #ifdefs and code related to the switch to gtk_combo_box().
svn path=/trunk/; revision=33465
2010-07-07 16:07:09 +00:00
Jeff Morriss c24f16ad44 Fix infinite recursion reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4984 : In try_get_ber_length() make sure we move forward before recursing.
svn path=/trunk/; revision=33464
2010-07-07 15:52:09 +00:00
Jörg Mayer 359bd13cc9 Some dissectors are added in dissectors/dcerpc/CMakeLists.txt
Remove them here.

svn path=/trunk/; revision=33463
2010-07-07 13:46:08 +00:00
Jörg Mayer eb686a2146 Synchronize dissector lists between CMakeLists.txt and
dissectors/Makefile.common:

The following dissectors were missing from CM:
  dissectors/packet-dcerpc-budb.c
  dissectors/packet-dcerpc-butc.c
  dissectors/packet-dcerpc-drsuapi.c
  dissectors/packet-gsmtap.c

Both: Whitespace fixes and reordering.

svn path=/trunk/; revision=33462
2010-07-07 13:25:36 +00:00
Guy Harris ba77133cbb I added PCAP_NETMASK_UNKNOWN in libpcap 1.1.0; it's not present in
1.0.0.  You're supposed to just use 0 in releases prior to 1.1.0 - in
1.1.0 and later, a netmask of PCAP_NETMASK_UNKNOWN will cause errors if
you try to use "ip broadcast" (as you need the netmask to check for
local broadcasts), but, prior to that, the netmask value is blindly used
even if the filter will always fail.

svn path=/trunk/; revision=33461
2010-07-07 01:55:34 +00:00
Gerald Combs f4bb9209ae Add a target which creates a zip file containing our .pdb files.
svn path=/trunk/; revision=33460
2010-07-06 22:35:33 +00:00
Jaap Keuter b87d82d0b4 Add button to look at compiled BPF.
This allows to test and experiment with BPF expressions, before launching
the capture itself. 

svn path=/trunk/; revision=33459
2010-07-06 21:02:19 +00:00
Guy Harris 8ce7b20cf3 Don't set SDKROOT - which SDK we want depends on which OS we want this
to run on, and not setting it should default to the OS on which we're
building it (as opposed to an OS for which we might not *have* an SDK).

svn path=/trunk/; revision=33458
2010-07-06 19:37:17 +00:00
Jaap Keuter 0494e951b8 Fix for bug 4982:
Handle concatenated Status and other message.

svn path=/trunk/; revision=33457
2010-07-06 17:22:12 +00:00
Jeff Morriss 4522f9b0a4 Limit the number of operations to 128 (arbitrary number) to keep us from attempting to mallocate way too much memory. This fixes the fuzz failure reported in bug 4976.
svn path=/trunk/; revision=33456
2010-07-06 14:57:54 +00:00
Anders Broman c5ddd5a253 Add miising else handling a zero msg_auth_code.
svn path=/trunk/; revision=33455
2010-07-06 13:21:34 +00:00
Guy Harris 80c8a18da7 Use G_GINT64_CONSTANT() to make a 64-bit all-bits-set constant.
svn path=/trunk/; revision=33454
2010-07-06 09:51:28 +00:00
Guy Harris 39f85d188c No need to add a fake field with the opcode as a string - you can just
compare the real opcode field against a string.

svn path=/trunk/; revision=33452
2010-07-06 08:43:07 +00:00
Stig Bjørlykke 8f686e8af0 Try checking for G_MAXUINT64 instead of 0xffffffffffffffff.
svn path=/trunk/; revision=33451
2010-07-06 07:45:38 +00:00
Stig Bjørlykke c7f2634f52 Removed non-ASCII characters.
svn path=/trunk/; revision=33450
2010-07-06 06:54:51 +00:00
Stig Bjørlykke 22056542a8 Fix the build on OSX.
svn path=/trunk/; revision=33449
2010-07-06 06:40:34 +00:00
Anders Broman 4a16e04cc0 Fix:
packet-nfs.c:699: warning: type defaults to 'int' in declaration of 'nfsv4_operation_tiers'

packet-nfs.c:9583: warning: unused variable 'saved_fh_hash'
packet-nfs.c:9580: warning: unused variable 'name'

svn path=/trunk/; revision=33448
2010-07-06 05:53:18 +00:00
Anders Broman 7bded303a4 Fix "checked api failed"
svn path=/trunk/; revision=33447
2010-07-06 05:46:52 +00:00
Anders Broman 0b0db7e0d7 From Brett Kuskie:
Enhancement of the dcerpc-svcctl dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4858

svn path=/trunk/; revision=33446
2010-07-06 04:43:45 +00:00
Anders Broman 36f5046490 From Frank Schorr:
The packet-nbns.c dissector picks random data as the NBSS PDU length in certain situations.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4914

svn path=/trunk/; revision=33445
2010-07-06 04:32:21 +00:00
Anders Broman 85a9a2cd21 From Sven Eckelmann:
Dissector/packet-batadv: Add support for icmp rr.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4922

svn path=/trunk/; revision=33444
2010-07-06 04:27:01 +00:00
Anders Broman 8d917e7bca From Andrew Feren:
Several small fixes to NetFlow decoding.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4962

svn path=/trunk/; revision=33443
2010-07-06 04:20:27 +00:00
Anders Broman a13bf525a8 From Ian Schorr:
NFSv4 usability enhancements (Info column summaries, filterable fields).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4975

svn path=/trunk/; revision=33442
2010-07-06 04:13:54 +00:00
Jörg Mayer 3bef8584a4 So many people who love to use easy to remember ports.
Improve heuristics to exclude cases where the traffic
definitely isn't Cisco's IPSEC inside TCP.

Does this obsolete the NDMP protocol check?

svn path=/trunk/; revision=33441
2010-07-05 23:21:58 +00:00
Anders Broman b722b193a6 - Show droped packets counter after stopping a live capture.
- Don't show "Load time" during live capture.
- Fix indentation and minor changes to comments.
Should ignored packets be shown also when drops is known?

svn path=/trunk/; revision=33440
2010-07-05 22:09:10 +00:00
Anders Broman 7e2f42090d From Jouni Malinen:
Add dissecting for IEEE 802.11u GAS frames.

svn path=/trunk/; revision=33439
2010-07-05 20:04:46 +00:00
Martin Mathieson 8bf9b7a3b3 Change type back to 16-bit to fix buildbot.
Will change subframe numbers to 8-bit later.

svn path=/trunk/; revision=33438
2010-07-05 17:28:28 +00:00
Martin Mathieson b2a872cd9f Show grant-subframe from context info.
svn path=/trunk/; revision=33437
2010-07-05 16:45:36 +00:00