Commit Graph

21 Commits

Author SHA1 Message Date
Brian Sipos 9866cf3bad BPv7: Add conversation and endpoint tracking
This adds BPv7 source and destination as first-class text addresses for the packet.
This fixes proto-data used for decode-as table editing outside of a layer.
2022-12-14 15:44:36 +00:00
Brian Sipos 80c95b26d0 COSE: Cleanup custom dissector keys with new API 2022-10-07 06:36:21 +00:00
Brian Sipos f9aba04431 BPv7: Add guard to avoid crash when no identity could be read 2022-10-05 17:06:49 +00:00
Patricia Lindner ddf0d35516 BPv7: Enhance block data and payload data handling
This change improves sequence analysis and subdissector interfaces, adds
payload Decode As support for DTN and IPN services, and add heuristic
dissection for BTSD.
2022-10-03 20:02:43 +00:00
Jaap Keuter b092fa05da Replace the last of PROTO_ITEM_ macro calls with function calls 2022-09-29 05:59:12 +00:00
Alexis La Goutte 1ca19b3c38 Fix -Wmissing-prototypes found by Clang
ftype-double.c:89:1: warning: no previous prototype for function 'val_unary_minus'
ftype-double.c:96:1: warning: no previous prototype for function 'val_add'
ftype-double.c:103:1: warning: no previous prototype for function 'val_subtract'
ftype-double.c:110:1: warning: no previous prototype for function 'val_multiply'
ftype-double.c:117:1: warning: no previous prototype for function 'val_divide'
ftype-integer.c:670:1: warning: no previous prototype for function 'uint_bitwise_and'
ftype-integer.c:677:1: warning: no previous prototype for function 'uint_is_zero'
ftype-integer.c:683:1: warning: no previous prototype for function 'uint_is_negative'
ftype-integer.c:689:1: warning: no previous prototype for function 'uint_unary_minus'
ftype-integer.c:704:1: warning: no previous prototype for function 'uint64_bitwise_and'
ftype-integer.c:711:1: warning: no previous prototype for function 'uint64_is_zero'
ftype-integer.c:717:1: warning: no previous prototype for function 'uint64_is_negative'
ftype-integer.c:723:1: warning: no previous prototype for function 'uint64_unary_minus'
ftype-integer.c:738:1: warning: no previous prototype for function 'sint_bitwise_and'
ftype-integer.c:745:1: warning: no previous prototype for function 'sint_is_zero'
ftype-integer.c:751:1: warning: no previous prototype for function 'sint_is_negative'
ftype-integer.c:757:1: warning: no previous prototype for function 'sint_unary_minus
ftype-integer.c:764:1: warning: no previous prototype for function 'sint64_bitwise_and'
ftype-integer.c:771:1: warning: no previous prototype for function 'sint64_is_zero'
ftype-integer.c:777:1: warning: no previous prototype for function 'sint64_is_negative'
ftype-integer.c:783:1: warning: no previous prototype for function 'sint64_unary_minus'
packet-bpv6.c:2182:1: warning: no previous prototype for function 'proto_register_bpv6'
packet-bpv6.c:2766:1: warning: no previous prototype for function 'proto_reg_handoff_bpv6'
packet-bpv7.c:1978:6: warning: no previous prototype for function 'proto_register_bpv7'
packet-bpv7.c:2037:6: warning: no previous prototype for function 'proto_reg_handoff_bpv7'
packet-realtek.c:349:1: warning: no previous prototype for function 'proto_register_realtek'
packet-realtek.c:436:1: warning: no previous prototype for function 'proto_reg_handoff_realtek'
packet-tcpcl.c:2147:1: warning: no previous prototype for function 'proto_register_tcpclv3'
packet-tcpcl.c:2211:1: warning: no previous prototype for function 'proto_reg_handoff_tcpclv3'
2022-07-15 13:45:52 +00:00
Alexis La Goutte 134809fd80 bpv7: fix -Wdocumentation
packet-bpv7.c:483:11: warning: parameter 'obj' not found in the function declaration
2022-07-14 15:45:14 +00:00
Martin Mathieson 17322b0cc2 Make a couple of functions static. 2022-05-28 20:35:58 +01:00
Brian Sipos e47ab95e46 BPv7 and TCPCL: Update references to published RFCs 2022-05-19 20:15:59 -04:00
lindnerp 7079d881fa Update bpv7 and bpsec dissectors to resolve ticket 17727 2022-05-18 12:48:41 -04:00
João Valverde fbd32cf853 Replace g_log() calls with ws_log() 2022-04-04 01:33:58 +00:00
João Valverde 22ee2764a7 Replace g_snprintf() with snprintf() (dissectors)
Use macros from inttypes.h with format strings.
2021-12-19 20:25:11 +00:00
Jaap Keuter adbaced04c Dissectors should not include stdio.h, unless needed 2021-12-05 12:45:46 +00:00
João Valverde 19dcb725b6 epan: Remove STR_ASCII and STR_UNICODE
These display bases work to replace unprintable characters so the
name is a misnomer. In addition they are the same option and this
display behaviour is not something that is configurable.

This does not affect encodings because all our internal text strings
need to be valid UTF-8 and the source encoding is specified using
ENC_*.

Remove the assertion for valid UTF-8 in proto.c because
tvb_get_*_string() must return a valid UTF-8 string, always, and we
don't need to assert that, it is expensive.
2021-12-03 04:35:56 +00:00
João Valverde b30a2112e8 regex: Prefer C99/POSIX types
Replace 'gssize' with 'ssize_t'.

Add a CMake configure check for ssize_t.

Fix missing "config.h" includes.
2021-11-15 02:41:59 +00:00
Brian Sipos 1e42357d19 BPv7: Add proper heuristic block/payload dissection.
This also touches up the INFO column display of bundle src/dst EID.
2021-10-23 16:26:47 +00:00
Alexis La Goutte aa0eb732b1 bpv7: Fix warning found by Clang Analyzer
packet-bpv7.c:1646:13: warning: Value stored to 'sep' is never read [deadcode.DeadStores]
2021-10-20 21:51:40 +00:00
Martin Mathieson abcadce44f BPV7: Address check_static.py issues
epan/dissectors/packet-bpv7.c (00000000000010d0 T bp_block_canonical_free) is not referred to so could be static?
epan/dissectors/packet-bpv7.c (0000000000000e50 T bp_creation_ts_new) is not referred to so could be static?

One function was not called at all - the other only in this dissector so could be static.
2021-10-13 04:21:31 +00:00
Brian Sipos 01e858e0a3 BP: Fix crashes on invalid fuzzed inputs 2021-10-12 23:15:50 +00:00
Dr. Lars Völker 7f9b8874b5 BPSEC, BPv7, COSE: Bugfix MacOS build
The usage of PRIi64 and PRIu64 may lead to failed builds on MacOS - at
least it did for me.

This patch fixes this.
2021-10-11 11:58:23 +02:00
Brian Sipos ce0592514c BPv7: Add Bundle Protocol version 7 and BPSec dissectors from dtn-wireshark 2021-10-10 13:27:17 +00:00