Commit graph

65 commits

Author SHA1 Message Date
Martin Kaiser
3ec1ec1caf do a plausibility check for interaction channel data
in the linkage descriptor

Change-Id: I7ebca539076b2b881e82fd6baec5bb223e778a52
Reviewed-on: https://code.wireshark.org/review/1896
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-31 13:32:06 +00:00
Martin Kaiser
877f38b46d make population id filterable
Change-Id: I3381e1c35795ac33331cdddb8cefa8b0a16907cc
Reviewed-on: https://code.wireshark.org/review/1894
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-31 09:03:57 +00:00
Martin Kaiser
419ea28960 make terrestrial centre frequency filterable
Change-Id: I007ff5215f52f80f25622cab6980128eabd39c5f
Reviewed-on: https://code.wireshark.org/review/1888
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-30 17:21:32 +00:00
Martin Kaiser
bc3ab61dda make next time offset filterable
Change-Id: I18c2b7992b237eaaacbec04d504fc293b03558a3
Reviewed-on: https://code.wireshark.org/review/1887
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-30 16:31:44 +00:00
Martin Kaiser
9f0419d376 make local time offset filterable
Change-Id: Icccc07706287df4b6a7481108f9921b939aae2d5
Reviewed-on: https://code.wireshark.org/review/1886
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-30 16:31:28 +00:00
Martin Kaiser
7aecd47be7 convert cable freq, symbol rate into doubles
Change-Id: Iaddd3c4847e803af855c847212ae822b2529ff06
Reviewed-on: https://code.wireshark.org/review/1860
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-29 17:30:57 +00:00
Martin Kaiser
91dac2771b conver sat freq and symbol rate into doubles in order to make the
filtering work, fix typos

Change-Id: I7ed989807826d1322dab00d13d998488caaf73ff
Reviewed-on: https://code.wireshark.org/review/1859
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-29 17:30:26 +00:00
Martin Kaiser
b4fb165ef3 use proto_tree_add_float_format_value() correctly
Change-Id: I927a2f32aa0016b5b0c476fa4c16fc1dbe0aebb0
Reviewed-on: https://code.wireshark.org/review/1825
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27 21:42:33 +00:00
Martin Kaiser
b3008f31ec make cable symbol rate filterable
Change-Id: I034b351d4bc12f6c00a0224a5c5b9f85496657b6
Reviewed-on: https://code.wireshark.org/review/1824
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27 21:42:15 +00:00
Martin Kaiser
9c98f9fdbd make cable frequency filterable
Change-Id: I8464fb8e98e485523127dd95948a717554b6aee4
Reviewed-on: https://code.wireshark.org/review/1823
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27 21:21:44 +00:00
Martin Kaiser
0911ce12ff make the satellite symbol rate filterable
Change-Id: I301d0804e097c62cd8bf7b27003918eedab9616a
Reviewed-on: https://code.wireshark.org/review/1816
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27 15:13:33 +00:00
Martin Kaiser
75272241a1 make satellite orbital position filterable
Change-Id: Ibd4edd30eca969699fea1971e1885299e4d3e552
Reviewed-on: https://code.wireshark.org/review/1813
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-27 09:45:17 +00:00
Roman Volkov
adb3f70f92 Wrong length of Modulation Type and Modulation System fields in Satellite Delivery Descriptor
According EN300468 in Satellite Delivery Descriptor 'Modulation System' field has 1 bit length. 'Modulation Type' has 2 bits length.
But in my Wireshark 'Modulation System' is 2 bit long and 'Modulation Type' is 1 bit long.

bug: 10119
Change-Id: I762145418bbfc9c0621ee7ca1a07d35afb6d7d92
Reviewed-on: https://code.wireshark.org/review/1718
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-05-22 03:29:01 +00:00
Martin Kaiser
42220913c3 change the satellite frequency into a float (freq in GHz)
and make it filterable

Change-Id: I0644e5c69ff58301c00ea3d37e80f25b856168e4
Reviewed-on: https://code.wireshark.org/review/1689
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-05-19 09:14:20 +00:00
Martin Kaiser
36a2ba2ce6 display LCNs as decimal number
this makes them easier to compare with your TVs channel list

Change-Id: Ie78d1a7df8aa83455ff723fa523b84a067231e5f
Reviewed-on: https://code.wireshark.org/review/1063
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-04-10 21:04:03 +00:00
Martin Kaiser
b6cbf2374e use the CI+ value string for CI+ descriptor tags
Change-Id: I48f3304f74263672a65a74f523f14ebb7950d2d6
Reviewed-on: https://code.wireshark.org/review/1062
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-04-10 21:03:46 +00:00
Alexis La Goutte
296591399f Remove all $Id$ from top of file
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')

Fix manually some typo (in export_object_dicom.c and crc16-plain.c)

Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
Martin Kaiser
e6d241597e skip empty service provider name and empty service name
Change-Id: I355600320865a9c7c17093d37fc693b02f0a7f0c
Reviewed-on: https://code.wireshark.org/review/457
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03 15:24:11 +00:00
Martin Kaiser
0156add5e9 service provider name is a DVB-SI string
Change-Id: Idea44f0e4678f738336215f4a250b9e9d9a60fbc
Reviewed-on: https://code.wireshark.org/review/456
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03 15:23:29 +00:00
Martin Kaiser
070ae30842 service name is a DVB-SI string
Change-Id: I81ef4cd363acf6cff99fd0f75b135962c4c22f53
Reviewed-on: https://code.wireshark.org/review/455
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03 15:22:10 +00:00
Martin Kaiser
57c4d97664 use a DVB string for the text field in the extended event descriptor
check for text length 0 while we're at it

svn path=/trunk/; revision=54666
2014-01-08 18:42:26 +00:00
Martin Kaiser
2ddfebb63c use a DVB string for the event text in the short evt descriptor
svn path=/trunk/; revision=54599
2014-01-05 12:17:52 +00:00
Anders Broman
e8b935ad6e Fix [-Wmissing-prototypes]
svn path=/trunk/; revision=54209
2013-12-18 06:51:09 +00:00
Jakub Zawadzki
c45475ab45 Fix [-Wmissing-prototypes]
svn path=/trunk/; revision=54135
2013-12-15 23:44:12 +00:00
Martin Kaiser
9f22d3a558 improve DVB-SI string handling
new function dvb_add_chartbl() adds a tree entry for an encoding
use FT_BTYES as type for encoding hfs
string hfs for DVB-SI strings must have STR_UNICODE, not BASE_NONE
make dvb_string_encoding_vals[] internal to dvb_chartbl.c

svn path=/trunk/; revision=54128
2013-12-15 18:38:35 +00:00
Martin Kaiser
db1b70f168 as requested, move the functions/defines for DVB character tables
to separate files

svn path=/trunk/; revision=54113
2013-12-15 12:05:50 +00:00
Martin Kaiser
20c7414c71 use large positve values for illegal DVB-SI string encodings
interpret encoding fields as UINT32 so that the displayed value matches
the actual bytes in the packet

svn path=/trunk/; revision=53927
2013-12-10 22:08:07 +00:00
Martin Kaiser
b369351d2f ignore empty texts
svn path=/trunk/; revision=53892
2013-12-09 21:14:45 +00:00
Martin Kaiser
17cb36a233 use the DVB-SI string hadling for the short event descriptor
svn path=/trunk/; revision=53891
2013-12-09 21:06:58 +00:00
Martin Kaiser
7226846846 share Data Broadcast IDs between MPEG descriptor and DVB-CI
svn path=/trunk/; revision=53323
2013-11-14 21:49:23 +00:00
Martin Kaiser
c333b6f1f5 add Data Broadcast ID for CI+ and HbbTV
svn path=/trunk/; revision=53321
2013-11-14 21:42:00 +00:00
Martin Kaiser
329873cf97 share service type descriptions between MPEG descriptor and DVB-CI
svn path=/trunk/; revision=53307
2013-11-13 23:10:01 +00:00
Martin Kaiser
63325bdab8 add one more private data specifier
svn path=/trunk/; revision=52986
2013-10-30 22:18:55 +00:00
Bill Meier
9874da2fcb #if 0 numerous "unused const variables" (mostly value-string-arrays);
Also; fix a few "set but not used" warnings.

svn path=/trunk/; revision=52780
2013-10-23 06:29:11 +00:00
Martin Kaiser
daba11a478 dissect mpeg registration descriptor
svn path=/trunk/; revision=52437
2013-10-07 15:22:08 +00:00
Michael Mann
e5846873f4 Convert proto_tree_add_time_format to either proto_tree_add_time or proto_tree_add_time_format_value.
Only proto_tree_add_time_format calls remaining are in packet-ncp2222.inc, which may just need some additional filters.

svn path=/trunk/; revision=52269
2013-09-29 16:40:01 +00:00
Michael Mann
b38ee917b1 Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
The script didn't catch as many as I would have liked, but it's a start.

The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.

svn path=/trunk/; revision=52045
2013-09-15 01:48:30 +00:00
Alexis La Goutte
1d1a4825a6 Fix warning found by fix-encoding-args tools
svn path=/trunk/; revision=51684
2013-09-02 23:16:10 +00:00
Alexis La Goutte
f16b33e78e Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=51670
2013-09-02 23:13:36 +00:00
Martin Kaiser
9ca8ee6c06 dissect CI+ Protection Descriptor
svn path=/trunk/; revision=48651
2013-03-30 10:59:30 +00:00
Evan Huus
37600a157b Rename value string (and similar) functions to use a consistent pattern. This
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Bill Meier
77376a2363 Change "4 space tabs" indentation to use "4 spaces" indentation.
Also:
- remove some unneeded initializers;
- remove several unneeded 'col_clear()' calls;
- guint8 --> guint to prevent a possible overflow;
- reformat for style in some cases.


svn path=/trunk/; revision=48297
2013-03-14 14:42:12 +00:00
Martin Kaiser
f58e2cc90a dissect Application Signalling Descriptor
svn path=/trunk/; revision=48273
2013-03-12 22:04:09 +00:00
Martin Kaiser
24fe8f7fb2 correctly mark the payload for unknown extension tags
(fixes a bug introduced by my previous commit)

svn path=/trunk/; revision=48181
2013-03-07 22:06:18 +00:00
Martin Kaiser
d96c8ee09d dissect Supplementary Audio Descriptor as defined in EN300468
svn path=/trunk/; revision=48176
2013-03-07 19:14:11 +00:00
Martin Kaiser
faed099b43 use defines for extension tags
svn path=/trunk/; revision=48175
2013-03-07 19:05:45 +00:00
Jeff Morriss
2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Martin Kaiser
03993d6e0e add private data specifier for NorDig
trivial whitespace cleanup

svn path=/trunk/; revision=44858
2012-09-10 21:22:01 +00:00
Martin Kaiser
4e2268aaa4 function to dissect a sequence of mpeg/dvb descriptors
(such descriptor loops are part of all psi and si tables)

take into account that a private data specifier descriptor may set the
 context for interpretation of subsequent descriptors in the loop

as a first example, add the private descriptors defined by CI+ LLP


svn path=/trunk/; revision=44856
2012-09-10 21:09:34 +00:00
Martin Kaiser
2558013747 fix a typo in dvb service descriptor
svn path=/trunk/; revision=44760
2012-09-03 21:11:01 +00:00