osmith/wireshark
1
0
Fork 0
forked from osmocom/wireshark
Code Pull requests Releases Wiki Activity
53533 commits 23 branches 0 tags 1.3 GiB
Commit graph

62 commits

Author SHA1 Message Date
Michael Mann
73217d9f3f tvb_new_subset -> tvb_new_subset_length when length parameters are equal. 
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is.

Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d
Reviewed-on: https://code.wireshark.org/review/1999
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-06-07 15:41:07 +00:00
Pascal Quantin
c5de173edc MBIM: do not access to hash map when it is not initialized yet 
Change-Id: I560941115316ead5a85b9e0b55be693217fddff2
Reviewed-on: https://code.wireshark.org/review/1940
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-06-03 18:01:51 +00:00
Pascal Quantin
4d55a12c0e MBIM: dissect MBIM_SET_STK_PAC and MBIM_STK_PAC_INFO messages 
Change-Id: Ib58dece7ce7278e292d88f68368c238695c32394
Reviewed-on: https://code.wireshark.org/review/1463
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-05-01 19:04:24 +00:00
Pascal Quantin
3116cf4add MBIM: use hash map instead of red/black tree for UUID extension table 
Change-Id: Iaab9ff66e94bfe38fc875ad312b8e795b80814f4
Reviewed-on: https://code.wireshark.org/review/1438
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-04-30 10:15:12 +00:00
Pascal Quantin
484b183e3f MBIM: make the backward compatibility function static 
Change-Id: I51bbdf9c0dbb80a8350ec7762e588ca3182dce63
Reviewed-on: https://code.wireshark.org/review/1408
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-04-28 09:18:46 +00:00
Pascal Quantin
3b1903c394 MBIM: fix compilation with GLib versions < 2.22.0 
Change-Id: I27e794347dc0988f0f34798cb62f08a11a217176
Reviewed-on: https://code.wireshark.org/review/1400
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-04-27 21:42:52 +00:00
Pascal Quantin
7ddf2b4540 MBIM: use wmem hash map functions for request/response tracking 
Change-Id: Ie550b0ef2b57827f610c4c6a83ff14868e853125
Reviewed-on: https://code.wireshark.org/review/1399
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-04-27 21:21:37 +00:00
Pascal Quantin
cd4d4acdbc MBIM: fix dissection of GSM SMS messages 
Change-Id: I07e753e50a42513daa704e56ee5c9b399a91fec9
Reviewed-on: https://code.wireshark.org/review/1305
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-04-23 17:45:25 +00:00
Pascal Quantin
f532fb94fc MBIM: fix dissection of ENVELOPE Sim Toolkit messages 
Change-Id: I3e6567e8ebfe83f12a0e2cbb2998b2e43ad2277a
Reviewed-on: https://code.wireshark.org/review/1092
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-04-13 20:55:32 +00:00
Pascal Quantin
f6dfda3a33 MBIM: add decoding of text based CDMA SMS 
Change-Id: Id2497597660bffeff2d98087d6511b91bfd93b1a
Reviewed-on: https://code.wireshark.org/review/1091
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-04-13 20:53:44 +00:00
Pascal Quantin
3dd4ef59bb MBIM: fix identification of DSS streams and add a way to register an external dissector for DSS 
Change-Id: Ic7f5708b60ee5846d95725dbbd14d8958d43372e
Reviewed-on: https://code.wireshark.org/review/843
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-03-27 10:12:27 +00:00
Pascal Quantin
38b5efd5cf MBIM: fix dissection of control packets when capturing with usbmon 
Change-Id: Ie20fcb8d393a85d47ba78f6cb70de77fedda2587
Reviewed-on: https://code.wireshark.org/review/829
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-03-25 22:04:23 +00:00
Pascal Quantin
2f794e95d1 MBIM: fix 3GPP SMS PDU record dissection 
Change-Id: I232a12eb7f7ee49464bb45c6f284ca3a3825909c
Reviewed-on: https://code.wireshark.org/review/644
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-03-13 21:59:12 +00:00
Pascal Quantin
af36d776c4 MBIM: add sanity checks to bulk packets 
Change-Id: I425f4ecd03f5ae0ec27b77b1437366d66107342f
Reviewed-on: https://code.wireshark.org/review/579
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-03-10 09:49:14 +00:00
Pascal Quantin
1678b0a825 Remove deprecated TVB APIs 
Change-Id: I87216c3bd2061c12ce486c752d4381ab722db95e
Reviewed-on: https://code.wireshark.org/review/328
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
 2014-02-23 22:28:40 +00:00
Pascal Quantin
d8c15b8d91 Add ability to register new UUID and CIDs 
svn path=/trunk/; revision=54944
 2014-01-24 18:53:06 +00:00
Pascal Quantin
944db5d447 Set explicitly P2P direction for received SMS 
svn path=/trunk/; revision=54682
 2014-01-09 21:29:07 +00:00
Pascal Quantin
6ebc058f47 Add proto_tree_add_ts_23_038_7bits_item() / tvb_get_ts_23_038_7bits_string() functions and update dissectors to use it. 
Remove gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions.
Update documentation a bit.

svn path=/trunk/; revision=54534
 2014-01-01 14:33:19 +00:00
Guy Harris
0d7a48a8bf Add a ENC_3GPP_TS_23_038 encoding, for the standard SMS alphabet in a 
bit-packed string, and use it in some places.

svn path=/trunk/; revision=54428
 2013-12-24 00:20:09 +00:00
Pascal Quantin
ee0ea80d07 Fix dissection of GSM SMS PDU 
svn path=/trunk/; revision=54368
 2013-12-22 19:26:58 +00:00
Pascal Quantin
302a4cf1c0 Fix copy/paste error 
svn path=/trunk/; revision=54366
 2013-12-22 17:27:53 +00:00
Pascal Quantin
3fba8ea2fe proto_tree_add_text -> proto_tree_add_item 
svn path=/trunk/; revision=54365
 2013-12-22 16:27:21 +00:00
Guy Harris
5084f58ce2 We support ENC_UCS_2, so use that in proto_tree_add_item() and 
tvb_get_string_enc() rather than using iconv to convert it to UTF-8.

svn path=/trunk/; revision=54350
 2013-12-22 02:12:32 +00:00
Jakub Zawadzki
deb2b236f2 Add missing includes 
svn path=/trunk/; revision=54332
 2013-12-21 17:23:17 +00:00
Evan Huus
2ae8edccea Rename more to_str functions to have ep_ in the name if they return ephemeral 
buffers. Remove two unused functions.

svn path=/trunk/; revision=54250
 2013-12-19 16:28:39 +00:00
Pascal Quantin
2f3a943f0a Fix a typo and check that handle exists before calling call_dissector() 
svn path=/trunk/; revision=54175
 2013-12-17 11:34:45 +00:00
Jakub Zawadzki
715e2d6699 Fix [-Wmissing-prototypes] 
svn path=/trunk/; revision=54095
 2013-12-14 16:09:57 +00:00
Jakub Zawadzki
4d92f6079b Remove not needed ';' 
svn path=/trunk/; revision=54088
 2013-12-14 11:12:20 +00:00
Pascal Quantin
293e390c61 Use an item for USSD text 
svn path=/trunk/; revision=53879
 2013-12-09 08:56:06 +00:00
Pascal Quantin
8b3f82def1 Add request / response tracking to MBIM_FUNCTION_ERROR_MSG messages 
svn path=/trunk/; revision=53762
 2013-12-03 19:44:32 +00:00
Pascal Quantin
2d49720de6 Add Qualcomm proprietary UUID 
svn path=/trunk/; revision=53760
 2013-12-03 19:32:10 +00:00
Pascal Quantin
9a48c7e8da Improve request / response tracking in case you have several open / close commands in the capture 
svn path=/trunk/; revision=53644
 2013-11-29 10:38:00 +00:00
Pascal Quantin
12618aadcd Add command type to info column 
svn path=/trunk/; revision=53575
 2013-11-25 18:04:07 +00:00
Pascal Quantin
9150571bf3 Check the packet length when using the "Force decoding of unknown USB control data as MBIM" option to reduce false positives. 
Align text in info column.

svn path=/trunk/; revision=53521
 2013-11-23 12:30:19 +00:00
Pascal Quantin
3894de27f3 Indicate fragments in info column 
svn path=/trunk/; revision=53472
 2013-11-21 11:20:06 +00:00
Pascal Quantin
5064834661 Fix a typo 
svn path=/trunk/; revision=53433
 2013-11-19 18:18:52 +00:00
Pascal Quantin
70b9ce2b48 Dissect USB Com Network Control Model requests 
svn path=/trunk/; revision=53349
 2013-11-15 23:16:25 +00:00
Pascal Quantin
488cf801a2 Fix dissection of MBIM Extended Functional Descriptor MTU 
svn path=/trunk/; revision=53312
 2013-11-14 09:43:32 +00:00
Michael Mann
76bfa2ce1a Remove usb_conv_info_t from packet_info and pass the data directly into the subdissectors. Bug 9413 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9413) 
svn path=/trunk/; revision=53274
 2013-11-12 13:46:51 +00:00
Pascal Quantin
8f112c0390 Fix dissection of MBIM data packets when using 32-bits NDPs 
svn path=/trunk/; revision=53142
 2013-11-07 16:53:59 +00:00
Bill Meier
0ad98563a2 From didier gautheron: remove redundant or use faster col_xxx functions 
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for  replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
    + before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set

   https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344


svn path=/trunk/; revision=52948
 2013-10-29 14:09:20 +00:00
Alexis La Goutte
70b52fc4f5 Fix Dead Store (Dead assignement/Dead increment) warning found by Clang 
svn path=/trunk/; revision=52873
 2013-10-26 17:17:53 +00:00
Bill Meier
9874da2fcb #if 0 numerous "unused const variables" (mostly value-string-arrays); 
Also; fix a few "set but not used" warnings.

svn path=/trunk/; revision=52780
 2013-10-23 06:29:11 +00:00
Pascal Quantin
f5decf57f1 Fix dissection of Home Provider CID and fix a typo error 
svn path=/trunk/; revision=52579
 2013-10-13 08:47:05 +00:00
Pascal Quantin
a37a217653 Fix another fuzz failure 
svn path=/trunk/; revision=52537
 2013-10-11 10:32:05 +00:00
Pascal Quantin
dea61da3f6 Fix an infinite loop detected during fuzz testing 
svn path=/trunk/; revision=52510
 2013-10-10 20:19:27 +00:00
Pascal Quantin
a77e3754c9 Slightly change heuristics 
svn path=/trunk/; revision=52487
 2013-10-10 08:15:55 +00:00
Pascal Quantin
ee0fc35c09 Add fragmentation support 
svn path=/trunk/; revision=52486
 2013-10-10 07:30:57 +00:00
Pascal Quantin
a56818ad87 Add an option (off by default) to force decoding of unknown USB control data as MBIM 
svn path=/trunk/; revision=52461
 2013-10-09 09:53:48 +00:00
Pascal Quantin
f9da278d6c MBIM data is transferred over CDC-Data interface class. Remove useless code. 
svn path=/trunk/; revision=52436
 2013-10-07 12:16:30 +00:00