3f26a0fc52
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9333 :
...
USB: Decode CDC subclasses and protocols
svn path=/trunk/; revision=52901
2013-10-27 20:59:43 +00:00
8ab858ef99
Mark unused parameters.
...
svn path=/trunk/; revision=52900
2013-10-27 20:58:00 +00:00
8c64c5da89
Remove iplen and iphdrlen from struct _packet_info.
...
Dissectors should just use (reported) tvb length and taps have other ways to get the data.
svn path=/trunk/; revision=52899
2013-10-27 20:38:42 +00:00
d8bbe9bda2
Do not reset pinfo->curr_layer_num in packet-frame.c
...
Before this change, curr_layer_num could be off by 1 depending on whether we
generated items for Frame protocol or not, leading to a failure to get the
UDP heuristic dissector identified during first pass
svn path=/trunk/; revision=52897
2013-10-27 19:33:55 +00:00
471f21181b
Have X.25 dissector pass boolean q_bit_set value through dissector data rather than pinfo->private_data.
...
Other "related" dissectors weren't manipulating pinfo->private_data, so it doesn't make sense for them to bother saving/restore it (now that q_bit_set isn't being used)
svn path=/trunk/; revision=52894
2013-10-27 16:03:11 +00:00
394f67c1b7
Allow "circuit dissectors" to pass data between dissectors. Not sure if this is immediately useful (ie remove need for packet_info (private_)data), but opens the possibility.
...
svn path=/trunk/; revision=52893
2013-10-27 15:00:11 +00:00
469fc864e6
[Automatic manuf, services and enterprise-numbers update for 2013-10-27]
...
svn path=/trunk/; revision=52890
2013-10-27 14:03:42 +00:00
21aa62a20c
From Zoltán Lajos Kis:
...
dissect flow_removed and port_status messages
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283
svn path=/trunk/; revision=52889
2013-10-27 13:02:05 +00:00
b57038a2ee
From Zoltán Lajos Kis:
...
dissect experimenter, get/set config, packet in and packet out messages
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283
svn path=/trunk/; revision=52888
2013-10-27 12:55:56 +00:00
eb560aa56a
Various updates - go into a little depth now.
...
svn path=/trunk/; revision=52887
2013-10-27 02:18:57 +00:00
3392cb4772
Treat IE 173 (symbol proprietary) like we treat the vendor IE
...
svn path=/trunk/; revision=52886
2013-10-27 02:18:00 +00:00
09bd9ad788
Have ANSI TCAP dissector pass data through subdissector parameter instead of using struct _packet_info.
...
svn path=/trunk/; revision=52885
2013-10-27 02:00:18 +00:00
bb36a25089
Remove use of pinfo->private_data and just pass the data around through function parameters
...
Remove g_pinfo from packet-ansi_637.c and add packet_info* as a function parameter while we're at it.
svn path=/trunk/; revision=52883
2013-10-27 01:06:44 +00:00
01c2eecc35
Updates to radiotap-iter licensing terms. The upstream version has a COPYING
...
file containing what is actually the ISC license (BSD-like), so add that to the
header for licensecheck's sake (and remove the confusing reference to the BSD
license). This makes the code actually your choice of ISC
and GPL2 (since it is used in the Linux kernel which is GPL2-only). ISC is
already acceptable for us, so ISC \union * must be also, so add ISC+GPL2 to
checlicenses' list.
Upstream COPYING file, for reference:
http://git.sipsolutions.net/?p=radiotap.git;a=blob;f=COPYING;hb=97478c8467ce7ab56b7c9e8fd7cdc0f4e2cb22ed
svn path=/trunk/; revision=52879
2013-10-26 20:57:38 +00:00
99c75b2295
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9330 :
...
Add OID tests for adding named arcs
svn path=/trunk/; revision=52878
2013-10-26 20:50:51 +00:00
9804a7b332
Don't use private_data for pwatm_private_data_t and instead pass it into the dissectors.
...
svn path=/trunk/; revision=52877
2013-10-26 19:18:12 +00:00
3a1041c084
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
...
svn path=/trunk/; revision=52875
2013-10-26 17:18:24 +00:00
39f4eb2edd
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
...
svn path=/trunk/; revision=52874
2013-10-26 17:18:12 +00:00
70b52fc4f5
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
...
svn path=/trunk/; revision=52873
2013-10-26 17:17:53 +00:00
6895d1f63d
Remove unused variable
...
svn path=/trunk/; revision=52872
2013-10-26 17:17:38 +00:00
8bcefa0f42
Fix indent and add modelines info
...
svn path=/trunk/; revision=52871
2013-10-26 17:17:17 +00:00
3342e3bc89
Convert some emem to wmem. It took some manual flow analysis, but they are only
...
used during actual packet dissection.
svn path=/trunk/; revision=52870
2013-10-26 16:04:21 +00:00
df5a9be3db
Bluetooth: SDP: Decode custom 128bit UUIDs and minor fixes. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52869
2013-10-26 13:28:47 +00:00
e154ac38f8
Bluetooth: OBEX: PBAP: Fix Filter parameter. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52868
2013-10-26 13:18:21 +00:00
24164080b1
Convert to value_str_ext in a couple of places.
...
svn path=/trunk/; revision=52867
2013-10-26 09:37:47 +00:00
21bed98150
Fix several [-Wunused-const-variable] warnings (using '#if 0').
...
svn path=/trunk/; revision=52866
2013-10-26 03:16:57 +00:00
70cf133bf5
Cleanups to the TPNCP database parser/loader:
...
- use and free glib memory instead of ep_ memory - another dissector down
- propogate errors correctly
- produce a warning if an error occurs loading the DB
- add XXX comments about realloc handling that may or may not be a memory leak
in failure cases
svn path=/trunk/; revision=52865
2013-10-26 02:54:58 +00:00
2ebf40a1c2
Bluetooth: SDP: Decode all types of UUIDs. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 ).
...
From Michal Labedzki
svn path=/trunk/; revision=52864
2013-10-26 02:36:56 +00:00
3cc6957fa8
Bluetooth: Use items for logical block objects. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
Bluetooth protocols use items, so dissect it to improve filtering and better user experience - text object cannot be filterable or comparable.
From Michal Labedzki
svn path=/trunk/; revision=52863
2013-10-26 02:24:04 +00:00
6dd42b581a
Fix some [-Wunused-const-variable] warnings (using '#if 0')
...
svn path=/trunk/; revision=52862
2013-10-26 02:09:14 +00:00
63869c4037
Bluetooth: SDP: Add MultiProfile UUIDs. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52861
2013-10-26 00:53:23 +00:00
d8f1af511f
Mark a bunch of no-longer-used parameters as unused. Remove a couple of
...
unused parameters.
svn path=/trunk/; revision=52860
2013-10-26 00:41:54 +00:00
250568ca91
Bluetooth: SDP: Fix PBAP features presentation. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52859
2013-10-26 00:36:16 +00:00
68a5e46e9d
OBEX: Fix Presentation of Reserved Fields. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52858
2013-10-26 00:31:42 +00:00
5030e21822
Replace tabs by spaces. Bug 9327 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9327 )
...
From Michal Labedzki
svn path=/trunk/; revision=52857
2013-10-26 00:26:41 +00:00
1e0405a3a3
Remove SMB's use of private_data and just pass the data through all of the dissection functions
...
svn path=/trunk/; revision=52856
2013-10-25 23:59:30 +00:00
95f484a91e
Add a very small hack to make the UAT update callback error string freeable, and
...
convert all existing UAT update callbacks to use glib memory instead of
ephemeral memory for that string.
UAT code paths are entirely distinct from packet dissection, so using ephemeral
memory was the wrong choice, because there was no guarantees about when it would
be freed.
The move away from emem still needs to be propogated deeper into the UAT code
itself at some point.
Net effect: remove another bunch of emem calls from dissectors, where replacing
with wmem would have caused assertions.
svn path=/trunk/; revision=52854
2013-10-25 22:14:25 +00:00
b190de385a
Fix CID 281375 (dead code) while hopefully fixing detection of Class-2 ERR
...
messages.
Also fix a couple of incorrect MTP3 standard detections that I found.
svn path=/trunk/; revision=52850
2013-10-25 20:38:50 +00:00
274596eaab
Fix up some formatting and white space.
...
svn path=/trunk/; revision=52848
2013-10-25 15:25:46 +00:00
ce23d50028
Fix CID 715143: assert that the preference we were looking for was found. It
...
should be which is why this is an assertion not a NULL check.
svn path=/trunk/; revision=52847
2013-10-25 15:00:00 +00:00
81b0681c12
Fix CID 715144: assert that the preference we were looking for was found. It
...
should be which is why this is an assertion not a NULL check.
svn path=/trunk/; revision=52846
2013-10-25 14:57:55 +00:00
4cfc0f27cb
Kafka's CRC is 4 bytes long and is added with ENC_BIG_ENDIAN. Make the hf
...
FT_UINT32 instead of FT_BYTES to match.
svn path=/trunk/; revision=52845
2013-10-25 14:41:12 +00:00
3440dd73f2
Fix CID 1080758: be prepared for tvb_child_uncompress() failing (and returning
...
NULL).
svn path=/trunk/; revision=52844
2013-10-25 14:38:39 +00:00
2aae7bc4a6
Fix CID 280081: ENC_NULL can't be used as an array index into ciphers[], rather
...
ENC_NULL-0x30 needs to be used.
(This could probably use some cleanup...)
svn path=/trunk/; revision=52843
2013-10-25 14:15:28 +00:00
ab97b9d50b
Fix CID 1111806: it's not safe to check if "tag < sizeof(tag_to_type)" before
...
accessing tag_to_type[tag]: while the array is made of enums and the values of
the enum will fit in a guint8 (making the conditional safe) compilers don't
*have* to "right size" the storage for the enum. They very well could be lazy
and store the enum in int's.
Replace it with a macro that tells us the size of the array.
svn path=/trunk/; revision=52842
2013-10-25 14:04:22 +00:00
02784747f7
Make sure "mp2t-dsmcc" dissector is registered by name so it can be picked up by etv dissector.
...
svn path=/trunk/; revision=52841
2013-10-25 13:37:10 +00:00
3e4c954fd8
Fix checkAPIs: don't add hf_zbee_beacon_protocol with
...
proto_tree_add_uint(..., ENC_NA); use proto_tree_add_item() as it appears
was intended.
svn path=/trunk/; revision=52840
2013-10-25 13:24:29 +00:00
86b6659210
Fix CID 1111814: segment_item is set but not used (in one conditional).
...
Move a URL from in the middle of the copyright notice to up where it (appears
to) belong.
svn path=/trunk/; revision=52839
2013-10-25 13:23:17 +00:00
cf1f098afb
Improvements for the KDSP dissector. Bug 8891 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8891 )
...
From Yuri Schaeffer
svn path=/trunk/; revision=52837
2013-10-25 02:41:47 +00:00
c09b328e13
Pass ieee802154_packet data into the heuristic check instead of using private_data.
...
svn path=/trunk/; revision=52836
2013-10-25 02:02:02 +00:00
Pascal Quantin