99c24a8eb4
From Mike Morrin:
...
Patch adding BSSMAP dissectors MSC Invoke Trace and BSS Invoke Trace.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3985
svn path=/trunk/; revision=29774
2009-09-07 17:08:34 +00:00
c629dde8b6
Constify some functions
...
svn path=/trunk/; revision=29773
2009-09-07 16:17:58 +00:00
98d18343c8
Whitespace changes
...
svn path=/trunk/; revision=29772
2009-09-07 16:07:04 +00:00
72c9662da6
ntroduce some seasonal address name lookup functions which we use when NEW_PACKET_LIST is defined. This change partially reverts some parts of r29768, which didn't seem to work because it assumed that get_addr_name() would always return a seasonal string. This wasn't the case if the adddress type was AT_STRINGZ.
...
svn path=/trunk/; revision=29771
2009-09-07 16:05:37 +00:00
ea0ab046e0
Tigthen scope of local variables
...
svn path=/trunk/; revision=29770
2009-09-07 15:49:14 +00:00
2fe83ebaed
mark unused parameter.
...
svn path=/trunk/; revision=29769
2009-09-07 15:01:51 +00:00
3abd049a9b
Use constant strings for Addresses saves some memory.
...
svn path=/trunk/; revision=29768
2009-09-07 14:03:05 +00:00
a65d590002
Store the packet encapsulation type as gint8. Saves 3 bytes per packet
...
svn path=/trunk/; revision=29767
2009-09-07 13:54:46 +00:00
cd8831c72d
Track length of columns strings. We'll need this in order to resize columns quickly
...
svn path=/trunk/; revision=29759
2009-09-07 11:33:38 +00:00
9500e97cb3
- Undo the PACKAGELIST WSWIN32 stuff in CMakeLists.txt:
...
That's what the packages are for, so instead of creating
WSWIN32, the stuff should probably go into the GLIB2
package.
- libwireshark now compiles - no time to add linking with
it until tonight
svn path=/trunk/; revision=29756
2009-09-07 07:26:43 +00:00
7a413a615a
Don't pass length 0 to a FT_UINT.
...
Fixed some uint types with length 2.
svn path=/trunk/; revision=29755
2009-09-07 01:19:26 +00:00
0e5cef61be
Split a bunch of init routines into init() and cleanup(). This allows us to free memory properly on shutdown.
...
This is an initial step. There's still some work to do.
svn path=/trunk/; revision=29754
2009-09-06 18:25:23 +00:00
d6122ad422
Reorder file to group related functionality
...
svn path=/trunk/; revision=29753
2009-09-06 15:06:41 +00:00
aed021a72d
[Automatic manuf and enterprise-numbers update for 2009-09-06]
...
svn path=/trunk/; revision=29750
2009-09-06 15:03:28 +00:00
a4ce0d3d69
Put back
...
http://anonsvn.wireshark.org/viewvc?view=rev&revision=29656
http://anonsvn.wireshark.org/viewvc?view=rev&revision=29658
http://anonsvn.wireshark.org/viewvc?view=rev&revision=29661
Reverted by my previous checkin.
svn path=/trunk/; revision=29749
2009-09-06 14:53:21 +00:00
f641693bf4
Change se_address_to_str() to call address_to_str_buf() directly
...
svn path=/trunk/; revision=29748
2009-09-06 14:39:53 +00:00
8c48c6835f
Rename address_to_str() to ep_address_to_str() because:
...
1) This indicates that the string has ephemeral lifetime
2) More consistent with its existing seasonal counterpart, se_address_to_str().
svn path=/trunk/; revision=29747
2009-09-06 14:25:47 +00:00
c7eb52b086
Remove already #if 0'ed code that was made redundant due to COL_CIRCUIT_ID custom column deprecation
...
svn path=/trunk/; revision=29745
2009-09-06 13:35:27 +00:00
bfe9f61a7c
Remove static custom column variable which is no longer used
...
svn path=/trunk/; revision=29744
2009-09-06 13:25:31 +00:00
571e69fdfa
We don't currently fake fields if they are referenced indirectly through some other fields (currently only FT_PROTOCOL's can be indirectly referenced) . However, there doesn't seem to be any reason for this restriction. We already have proto_tree_set_fake_protocols() to disable 'faking' if any clients requires this. So, this changelist removes this restriction on indirectly referenced fields.
...
svn path=/trunk/; revision=29742
2009-09-06 11:30:41 +00:00
ba14c67566
Use correct field types for variable length fields.
...
Fixed types by adding new types for "undissected" blocks:
- Replace Bridge Address
- Multicast With Response
- Confirm Network Encryption Key
- Host Tag
svn path=/trunk/; revision=29741
2009-09-06 11:24:56 +00:00
09237c27f9
Inline col_has_time_fmt() into col_based_on_frame_data()
...
svn path=/trunk/; revision=29739
2009-09-06 10:03:06 +00:00
474f5930db
Macrofy have_custom_cols() -> HAVE_CUSTOM_COLS() internally in columns-utils.c
...
svn path=/trunk/; revision=29737
2009-09-06 09:11:17 +00:00
22077a8eb1
Macrofy check_col() -> CHECK_COL() internally in columns-utils.c
...
svn path=/trunk/; revision=29736
2009-09-06 09:03:15 +00:00
137b886960
From Didier Gautheron:
...
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize address handling.
The address hash should be possible to use from the new_packet_list.
svn path=/trunk/; revision=29735
2009-09-06 08:59:30 +00:00
b91827f5a0
Avoid calling emem_create_chunk() needlessly
...
svn path=/trunk/; revision=29734
2009-09-06 08:10:12 +00:00
b3b9be09c7
We track all protocols that appear in each packet in the frame dissector. This is an expensive operation because we:
...
* Disable the TRY_TO_FAKE_THIS_ITEM optimization
* Use GString to store the protocols
We should only do this if the 'hf_frame_protocols' is referenced (unlikely)
svn path=/trunk/; revision=29733
2009-09-06 07:55:17 +00:00
820ce62af5
This fix was supposed to be in r29731 which some how only contained whitespace changes.
...
svn path=/trunk/; revision=29732
2009-09-06 07:33:07 +00:00
9c512f7cb4
Introduce TRY_TO_FAKE_THIS_REPR which is an optimization similar to the existing TRY_TO_FAKE_THIS_ITEM. The purpose of TRY_TO_FAKE_THIS_REPR is to avoid generating the string representation for the protocol item. There is no point in doing this if the protocol tree isn't visible. In this case the result will be discarded any way.
...
svn path=/trunk/; revision=29731
2009-09-06 07:24:54 +00:00
4df25480b7
The frame dissector disables the TRY_TO_FAKE_THIS_ITEM() optimization by marking the protocol tree as permamently visible. It only needs to disable the optimization temporarily while it creates the protocol item it intends to use proto_item_append_string() on
...
svn path=/trunk/; revision=29730
2009-09-06 06:33:13 +00:00
f352fa6d90
s/col_add_fstr/col_add_str
...
svn path=/trunk/; revision=29727
2009-09-06 05:29:51 +00:00
6fe1060cd1
Don't pass ep_alloc()'ed strings to col_set_str().
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984
svn path=/trunk/; revision=29726
2009-09-06 04:26:50 +00:00
a9e644f382
Changed type for "Wireless data" to FT_BYTES.
...
svn path=/trunk/; revision=29725
2009-09-05 22:12:51 +00:00
7d4cf0b966
col_custom_set_fstr() is unused. Remove it
...
svn path=/trunk/; revision=29722
2009-09-05 18:45:55 +00:00
a108023b2a
COL_BSSGP_TLLI is deprecated
...
svn path=/trunk/; revision=29721
2009-09-05 18:39:46 +00:00
7e8455ff63
Reorder col_fill_in()
...
svn path=/trunk/; revision=29720
2009-09-05 18:28:06 +00:00
e275d24c39
Ignore preferences for deleted protocols "etheric" and "isup_thin".
...
svn path=/trunk/; revision=29709
2009-09-05 13:06:45 +00:00
b7bdf3efc1
A few minor revisions:
...
- if (check_col ...) no longer required;
- Use match_strval when verifying the fcn code;
- Add a missing #ifdef;
- Make a global variable static;
- Fix indentation to be consistent in a few places.
svn path=/trunk/; revision=29701
2009-09-04 18:40:02 +00:00
3ab20de02b
From Rob Casey: Fix for: Incorrect station identifier parsing in Kingfisher dissector
...
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3946
svn path=/trunk/; revision=29700
2009-09-04 18:18:34 +00:00
a3c38e1057
Include "proto.h" instead of <proto.h>
...
svn path=/trunk/; revision=29694
2009-09-04 11:48:04 +00:00
e99983ab3a
From Vincent Helfre:
...
Dissect_ccch does not dissect sys info content.
Me: Remove check_col.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3901
svn path=/trunk/; revision=29693
2009-09-04 11:06:52 +00:00
f0ea776605
From : Didier Gautheron
...
Addresse hash is slow on little endian CPU.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3973
svn path=/trunk/; revision=29692
2009-09-04 10:53:37 +00:00
efd2ed4b51
Show UEId in info column for UL-SCH / DL-SCH frames.
...
svn path=/trunk/; revision=29687
2009-09-03 16:42:16 +00:00
06d5136beb
Add initial support to decode the ADIP and PhysicalInformation for MMC
...
media
svn path=/trunk/; revision=29669
2009-09-02 17:24:52 +00:00
2ef4429761
Add Semi-Persistent Scheduling (SPS) RNTI.
...
svn path=/trunk/; revision=29667
2009-09-02 16:39:39 +00:00
d26cdc30ea
Beginnings of getting cmake to build stuff in epan.
...
It's only beginnings, so epan is commented out in
the subdirs statement.
This is more a synch to avoid duplicate work and creating
conflicting patches to the cmake stuff.
svn path=/trunk/; revision=29666
2009-09-02 16:33:01 +00:00
822d0a2242
No need to include packet-frame.h
...
svn path=/trunk/; revision=29665
2009-09-02 15:52:11 +00:00
5dd678f0a7
Check whether "size" points to something positive, not whether "size"
...
itself is positive (which makes no sense for a pointer).
svn path=/trunk/; revision=29661
2009-09-01 19:31:41 +00:00
f8f4f0fb6b
Remove superfluous NULL pointer checks wrt. g_malloc() and g_realloc()
...
svn path=/trunk/; revision=29658
2009-09-01 18:44:08 +00:00
17f010119a
From Jakub Zawadzki via. Bug 3330:
...
* Fix memleak (df->deprecated in dfilter_free())
* Free protocol hash tables on cleanup.
* Free protocols list on cleanup.
* Free memory allocated by fgetline() in parse_services_file()
From me:
* proto.c: set gmc_hfinfo to NULL after free
* proto.c: switch order of g_free() and g_list_remove() in proto_cleanup()
svn path=/trunk/; revision=29656
2009-09-01 18:16:55 +00:00
95bf560727
Misc cleanup;
...
- Remove no longer needed usage of check_col();
- Add some defensive coding;
- Change a few guints to gints;
- Add parentheses to a few expressions;
- Use consistent indentation.
svn path=/trunk/; revision=29655
2009-09-01 17:17:14 +00:00
8cba530c81
From Richard Brodie via. Bug 3913:
...
Free ptr array allocated through proto_find_finfo()
svn path=/trunk/; revision=29654
2009-09-01 17:09:36 +00:00
8bd7ebc6a1
- Fix for bug 3965 as reported by Ivan Sy <ivan_jr@yahoo.com>
...
mDNS and LLMNR also deviate from the TTL=1 for 224.0.0.0/24
- Fix two warnings about removing const by casting.
svn path=/trunk/; revision=29644
2009-08-31 22:34:25 +00:00
174c2047b1
From Gerasimos Dimitriadis:
...
DTAP decoding of Cause Diagnostics.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3968
svn path=/trunk/; revision=29637
2009-08-31 18:37:15 +00:00
1cadaa2590
[Automatic manuf and enterprise-numbers update for 2009-08-30]
...
svn path=/trunk/; revision=29627
2009-08-30 15:03:26 +00:00
cd49063473
Revert r29614 until I figure out why buildbot doesn't like it
...
svn path=/trunk/; revision=29615
2009-08-29 07:53:48 +00:00
cc948586bf
Use G_STRINGIFY/G_PASTE
...
svn path=/trunk/; revision=29614
2009-08-29 06:42:23 +00:00
bb0108cf25
Use NB_RTPMUX as protocol short name
...
svn path=/trunk/; revision=29610
2009-08-29 04:47:28 +00:00
e0c4b20c86
We need to handoff even when we don't have a tree
...
svn path=/trunk/; revision=29609
2009-08-29 04:43:52 +00:00
a87c4885b8
Indent comments
...
svn path=/trunk/; revision=29608
2009-08-29 04:39:59 +00:00
c960781f5e
Note what the 3GPP spec is for this protocol.
...
Suggest a possible less-weak heuristic.
Note that we're not checking the T bit and handling RTP header
compression.
At least as I read TS 29.414, the length indicator isn't supposed to be
zero; however, a length indicator of 0 doesn't keep us from dissecting
further, so just don't bother dissecting the payload. We should,
perhaps, add an expert info for this.
We should perhaps also catch exceptions thrown when dissecting the RTP
packet, so a malformed RTP packet will still let us continue dissecting
the rest of the Nb packet.
svn path=/trunk/; revision=29607
2009-08-29 02:32:33 +00:00
8fda47d5b2
Replace "repeated blurb" by NULL in two cases;
...
Reformat a long line.
svn path=/trunk/; revision=29606
2009-08-29 02:25:04 +00:00
d53a1eaf73
Replace "" by NULL in blurbs; Cleanup indentation.
...
svn path=/trunk/; revision=29605
2009-08-29 02:22:28 +00:00
79428f30cb
Cleanup:
...
- proto_reg_handoff: 'if (!inited)' not req'd;
- Remove unneeded #includes;
- Use NULL instead of " for 'blurbs';
- Remove unneeded foward reference.
svn path=/trunk/; revision=29604
2009-08-29 01:46:42 +00:00
a340788eb2
Note that the "heuristic" is fatally weak, and must be strengthened or
...
eliminated.
Fix indentation.
Use tvb_reported_length(), so we throw an exception for packets cut
short by a snapshot length.
Don't bother showing or dissecting the payload if there isn't any.
Don't show an item with a zero-length payload as going to the end of the
packet.
svn path=/trunk/; revision=29603
2009-08-29 01:08:31 +00:00
988a595e79
From Neil Piercy:
...
Add new protocol for 3GPP 29.414 (Nb interface RTP Mux).
- Don't use C++-style comments (comments beginning with "//")
- Don't declare variables in the middle of executable code; not all C
compilers support that.
- Dont register preferences when none present.
- Removed CHECK_COL
svn path=/trunk/; revision=29602
2009-08-28 21:34:59 +00:00
29e52f7fd2
Fix code which could access uninitialized variables and display incorrect text in COL_INFO.
...
(Found by clang scan-build).
svn path=/trunk/; revision=29601
2009-08-28 19:15:43 +00:00
7279fbf6c0
Fix if test in fcn rs11():
...
return if either (as opposed to both) of the required sparameters is not present;
(Found by clang scan-build).
svn path=/trunk/; revision=29600
2009-08-28 18:37:53 +00:00
56eec34f80
Fix possible memmove with a NULL poiunter.
...
svn path=/trunk/; revision=29599
2009-08-28 16:52:05 +00:00
c680dc89a3
Don't coerce a possibly unaligned ptr to a (guint32 *);
...
Also: Calculate the same template hash whether on a LE or BE machine.
svn path=/trunk/; revision=29598
2009-08-28 16:36:24 +00:00
46fcebf274
Validate a function parameter
...
svn path=/trunk/; revision=29595
2009-08-28 13:52:52 +00:00
4d8506486f
After asking on the list and receiving no feedback, I'll
...
just commit this:
Change the checks for type FT_IPv6 to no longer require
a lenght of exaclty 16 bytes, but something between
0 and 16 bytes. That way, we can filter on prefixes
that do not provide the whole length of 16 bytes.
svn path=/trunk/; revision=29594
2009-08-28 09:38:34 +00:00
5417edcfdc
Windows: remove all references to ICONV_DIR, because we use the statically linked win-iconv instead
...
svn path=/trunk/; revision=29580
2009-08-27 05:04:29 +00:00
1826a02933
Add #include <stdio.h> in a few places for Solaris
...
svn path=/trunk/; revision=29576
2009-08-27 02:53:13 +00:00
b076f98b46
Show correct time value for "Time since previous displayed frame".
...
svn path=/trunk/; revision=29572
2009-08-26 22:31:06 +00:00
7081039a23
Reformat some long lines for readability....
...
svn path=/trunk/; revision=29570
2009-08-26 19:30:44 +00:00
94f28dd8f9
(FWIW) One step towards including stdio.h & stdlib.h only when req'd.
...
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
9e282cf141
export t38_add_address, prefer destination port for T.38 conversation searching
...
svn path=/trunk/; revision=29564
2009-08-26 15:10:31 +00:00
8437debcb6
Make UL grant size a (generated) field of its own (for easier use as a custom column or IO graph filter).
...
svn path=/trunk/; revision=29562
2009-08-26 09:13:14 +00:00
a1fc889259
From Thierry Andry via bug 3941:
...
Added preference to set radius request TTL.
svn path=/trunk/; revision=29561
2009-08-26 07:26:17 +00:00
57ec611fa1
From dragonlinux:
...
Add QNX OS VER 6's qnet ethernet protocol number.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3934
svn path=/trunk/; revision=29558
2009-08-26 05:10:12 +00:00
eeb1f0df18
From swapnil:
...
Bug in Traffic Aggregate Description (TAD) IE in Packet-gtpv2.c fixed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3940
svn path=/trunk/; revision=29556
2009-08-26 04:36:14 +00:00
bd5202c051
Add missing prototype ....
...
svn path=/trunk/; revision=29555
2009-08-26 02:06:39 +00:00
8e1021f0c2
Rework code slightly to prevent several GCC "breaking strict-aliasing rules" warnings
...
svn path=/trunk/; revision=29554
2009-08-25 23:03:10 +00:00
232747f501
Add missing semicolon.
...
svn path=/trunk/; revision=29553
2009-08-25 23:01:03 +00:00
14a35a650f
Init two struct members so gcc 4.1.4 doesn't complain about "may be used uninitialized";
...
Also: use gboolean for a true/false variable.
svn path=/trunk/; revision=29552
2009-08-25 21:54:12 +00:00
32e7cddf70
From Didier Gautheron:
...
move custom col set from proto_tree_set_xxx() to
epan_dissect_fill_in_columns().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3930
I'v added the new functions to the .h files.
svn path=/trunk/; revision=29551
2009-08-25 21:10:35 +00:00
4e87c254f0
From Mike Morrin:
...
Minor errors in gsm rr dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3889
Modified accoring to comments from Pascal Quantin(I hope I got it right).
svn path=/trunk/; revision=29549
2009-08-25 17:22:32 +00:00
5560cb61c0
Show CRC errors for RARs.
...
svn path=/trunk/; revision=29548
2009-08-25 11:01:51 +00:00
6899bdc299
Note in dlist[] that COL_BSSGP_TLLI is deprecated.
...
svn path=/trunk/; revision=29547
2009-08-25 06:11:57 +00:00
2dd60e1b66
Custom columnfication:
...
* Deprecate COL_BSSGP_TLLI (GPRS BSSGP IE TLLI). Use bssgp.tlli
svn path=/trunk/; revision=29546
2009-08-25 05:42:14 +00:00
f8a37ac1d6
Make it possible to use bssgp.tlli as custom column.
...
Remove COL_BSSGP_TLLI and CHECK_COL.
svn path=/trunk/; revision=29543
2009-08-24 20:54:25 +00:00
75e727697f
Remove unneeded #includes; Clean up indentation; Comment a few "closing braces".
...
svn path=/trunk/; revision=29538
2009-08-24 15:17:58 +00:00
ce829a0f94
packet-tcp.c:1551: warning: 'cleared_writable' may be used uninitialized in this function
...
svn path=/trunk/; revision=29536
2009-08-24 09:29:05 +00:00
553ef57224
From: : " Michael"
...
packet-tcp marks a row as unwritable if there is more
than 1 PDU in a packet to prevent overwriting of the
protocol column.
However this breaks the proto,colinfo tap which checks
rows are writable or dies EVEN if it doesn't alter anything.
Suggested patch attached to restore the initial value
after all PDUs have been processed.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3675
svn path=/trunk/; revision=29535
2009-08-24 09:05:23 +00:00
60022bc5f2
Expert info for undecoded Q.932 and H.450 operations
...
svn path=/trunk/; revision=29534
2009-08-24 09:05:15 +00:00
ca5995f532
From Ivan Sy via bug 3931:
...
Added ND Proxy Flag for IPv6 RA flag.
svn path=/trunk/; revision=29533
2009-08-24 08:00:39 +00:00
c66f265dda
Rework code slightly to prevent a GCC 'strict-aliasing' warning.
...
svn path=/trunk/; revision=29532
2009-08-23 23:52:40 +00:00
58dedc3872
From kahou:
...
Add Fibre Channel Delimiter Dissector for Fibre Channel FC2.
svn path=/trunk/; revision=29531
2009-08-23 19:16:35 +00:00
60a30e223e
From Didier gautheron via bug 3929:
...
* Expert Info / Expert Info Composite requires a full protocol tree.
* Delay tree NULL pointer check in bootp dissector
svn path=/trunk/; revision=29530
2009-08-23 18:32:29 +00:00
1711f5899b
From Ivan Sy:
...
Per RFC 3810 - Multicast Listener Discovery Version 2 (MLDv2) for IPv6,
Add Number of Sources. Also to show Record Type's numeric value and not
just its equivalent.
Cleaned up presentation and included record number as well.
svn path=/trunk/; revision=29528
2009-08-23 17:18:29 +00:00
db09d3f88c
[Automatic manuf and enterprise-numbers update for 2009-08-23]
...
svn path=/trunk/; revision=29525
2009-08-23 15:03:28 +00:00
23d4eba3b1
Custom columnfication:
...
* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta
svn path=/trunk/; revision=29524
2009-08-23 12:30:48 +00:00
b9cbd15469
Custom columnfication:
...
* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative
svn path=/trunk/; revision=29523
2009-08-23 12:24:14 +00:00
55cf35e3a0
Custom columnfication:
...
* Deprecate COL_FR_DLCI (Frame Relay DLCI). Use fr.dlci
svn path=/trunk/; revision=29522
2009-08-23 12:16:10 +00:00
ea8296ab26
Avoid signed/unsigned comparison
...
svn path=/trunk/; revision=29521
2009-08-23 11:35:53 +00:00
375f355046
Update list of PPIDs.
...
This fixes bug 3928.
svn path=/trunk/; revision=29520
2009-08-23 11:30:54 +00:00
1a7b6733cd
#if 0 col_set_circuit_id(). It isn't being used
...
svn path=/trunk/; revision=29519
2009-08-23 11:13:53 +00:00
51ca1739ae
Custom columfication:
...
* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield
svn path=/trunk/; revision=29518
2009-08-23 11:12:12 +00:00
00670c55c6
Custom columfication:
...
* Deprecate COL_HPUX_DEVID (HP-UX Device ID). Use nettl.devid
svn path=/trunk/; revision=29517
2009-08-23 10:25:51 +00:00
205129d25c
Custom columfication:
...
* Deprecate COL_HPUX_SUBSYS (HP-UX Nettl Subsystem). Use nettl.subsys
svn path=/trunk/; revision=29516
2009-08-23 10:20:42 +00:00
56369978ae
Custom columfication:
...
* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call
svn path=/trunk/; revision=29515
2009-08-23 09:52:57 +00:00
53586615aa
Add initial code to handle the migration to custom columns by mapping the deprecated columns into their custom column counterparts when we read the preference file.
...
There are still many todos in this area:
1) We need to either warn the user that he/she needs to click "Save" in the preference dialog so we can "flush" the old predefined column or apply this change ourself silently.
2) The predefined columns need to be removed from the "Columns" UI.
3) ....
svn path=/trunk/; revision=29514
2009-08-23 09:16:58 +00:00
6b89de8393
Custom columfication:
...
* Deprecate COL_COS_VALUE (L2 COS Value (802.1p)). Use vlan.priority
svn path=/trunk/; revision=29513
2009-08-23 09:07:54 +00:00
dfac9e4091
Get rid of a bunch of "warning: redundant redeclaration of" messages.
...
In that process, include the contents of packet-fmp_notify.h directly
in packet-fmp_notify.c - it wasn't used anywhere else.
svn path=/trunk/; revision=29512
2009-08-23 06:57:16 +00:00
6444abbf7e
Avoid 'cast to pointer from integer of different size'
...
svn path=/trunk/; revision=29511
2009-08-23 05:20:30 +00:00
035231b534
From Frederic Peters (made endian-aware by me):
...
fixed segfault with some GIOP packets
svn path=/trunk/; revision=29509
2009-08-22 22:46:41 +00:00
602e3a09e0
Remove col_check() guard wrt. COL_REL_CONV_TIME/COL_DELTA_CONV_TIME
...
svn path=/trunk/; revision=29508
2009-08-22 19:53:54 +00:00
3d740a490f
We initialize col_expr and col_expr_val in col_init() so there's no need to initialize them again in col_set_xxx()
...
svn path=/trunk/; revision=29507
2009-08-22 19:29:44 +00:00
fdf21357fc
From Ivan Sy:
...
NSEC3PARAM RR (RFC 5155), APL RR (RFC 3123), PX RR (RFC 2163), GPOS RR (RFC 1712),
NSAP RR (RFC 1706), NSAP-PTR RR (RFC 1348), AFSDB, RP, X25, ISDN, RT, RR (RFC 1183).
Also cleanup of protocol tree dependancies.
svn path=/trunk/; revision=29506
2009-08-22 17:28:54 +00:00
2d91ad03f9
Additional validation of 'len' for crc32_ccitt_tvb... fcns;
...
(-1 is not a valid length);
First of 2 fixes for crash reported in Bug #3925 .
svn path=/trunk/; revision=29505
2009-08-22 17:12:33 +00:00
da1e555499
Don't dereference pointer before checking for NULL
...
svn path=/trunk/; revision=29503
2009-08-21 23:02:59 +00:00
2046b144d9
Sanitize epan includes
...
svn path=/trunk/; revision=29502
2009-08-21 20:51:13 +00:00
66afe84075
Use <gcrypt.h> instead of 'gcrypt.h'
...
svn path=/trunk/; revision=29501
2009-08-21 20:40:49 +00:00
17c9803cac
Sanitize epan includes
...
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
9661baf237
Remove unneeded #includes
...
svn path=/trunk/; revision=29497
2009-08-21 19:48:11 +00:00
8a3f4f53eb
Delay TRY_TO_FAKE_THIS_ITEM() in proto_tree_add_bits_ret_val() until we know it is safe.
...
Thanks to Martin for pointing this out in r29493.
svn path=/trunk/; revision=29494
2009-08-21 17:11:02 +00:00
044aabb9ea
Don't try TRY_TO_FAKE_THIS_ITEM in proto_tree_add_bits_ret_val(), as otherwise
...
the side effect 'return_value' getting set doesn't happen.
svn path=/trunk/; revision=29493
2009-08-21 15:16:27 +00:00
2afdee256c
Handle a text NULL pointer more gracefully
...
svn path=/trunk/; revision=29491
2009-08-21 11:31:21 +00:00
27f7d88c84
Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere.
...
svn path=/trunk/; revision=29490
2009-08-21 11:03:30 +00:00
1108352f00
Use col_text in frame data.
...
- colum-utils needs more work, based on
Didier Gautherons optimizations patch http://wiki.wireshark.org/Development/Optimization
svn path=/trunk/; revision=29489
2009-08-21 10:12:47 +00:00
55597ea161
List the new DOCSIS dissector file here as well.
...
svn path=/trunk/; revision=29488
2009-08-21 05:37:33 +00:00
0819c36d3a
Prepare to store column text in frame data directly.
...
svn path=/trunk/; revision=29483
2009-08-20 09:49:32 +00:00
7945bf1bc9
From Harald Welte :
...
Connect RRLP to GSM A DTAP application info message.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919
From me try to fix missuse of pinfo.
svn path=/trunk/; revision=29482
2009-08-20 07:26:16 +00:00
0f6b75b7ea
Move TRY_TO_FAKE_THIS_ITEM to all public proto_xxx methods. Currently we rely on our internal (static) helper functions to do the faking. However, when they fake a protocol tree, they usually return a valid tree (although a dummy tree it is still a valid one). This means that we end up calling proto_tree_set_representation + friends on it for no reason. By moving TRY_TO_FAKE_THIS_ITEM to the public proto_xxx methods we're able to bail immediately (when we're allowed to do so).
...
svn path=/trunk/; revision=29480
2009-08-19 19:08:34 +00:00
7ec476b88a
From Didier Gautheron:
...
Part 2
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Optimize expert info.
Slightly changed by me.
svn path=/trunk/; revision=29478
2009-08-19 18:37:13 +00:00
283dbb4414
As pointed out by Alexis La Goutte via PM, r29474 didn't
...
support the different MAC formats (eui48 and eui64) properly.
Now, eui48 is printed as mac, the rest is still handled as
blob.
svn path=/trunk/; revision=29476
2009-08-19 15:42:24 +00:00
69069395df
Add support for Radio Mac/Wireless Specific Information optional
...
header fields. This patch lacks handling of padding since a) I don't
have a trace containing padding and b) I don't understand the
wording in the rfc (it's to ambigous for my liking).
svn path=/trunk/; revision=29474
2009-08-19 12:25:40 +00:00
8e00a20710
From Jochen Bartl:
...
EIGRP dissector enhancements (IPv6, Stub routing, Authentication TLVs)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3907
svn path=/trunk/; revision=29473
2009-08-19 11:34:40 +00:00
87da96be52
From Jan Lübbe:
...
packet-gsm_a_rr.c: flip gsm_a_rr_mv_vals, 0 means vaild.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3915
svn path=/trunk/; revision=29472
2009-08-19 09:32:56 +00:00
100aeddafe
From Didier Gautheron:
...
Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization
Make col_expr const gchar.
svn path=/trunk/; revision=29471
2009-08-19 07:55:11 +00:00
43cbf13ad4
Minor clean up.
...
svn path=/trunk/; revision=29466
2009-08-18 14:39:32 +00:00
b62e6545b9
Add an expert info noting that an ANSI message with the national indicator set to 0 (international) is unusual.
...
svn path=/trunk/; revision=29464
2009-08-18 13:25:49 +00:00
c8ec27c000
Make build bot happy?
...
svn path=/trunk/; revision=29463
2009-08-18 12:15:36 +00:00
a4109274e2
Typo: parameter_tvb to be used.
...
svn path=/trunk/; revision=29462
2009-08-18 11:39:55 +00:00
a4e174b7f8
From Swapnil Barai:
...
Minor Bug in Bearer Context in Packet-gtpv2.c fixed.
svn path=/trunk/; revision=29460
2009-08-18 06:41:12 +00:00
d777d1dfed
Display Microsoft's Remote Desktop Protocol (RDP) extension to the X.224
...
connection request that shows the session load balancing information. There
appears to be more dissecting that can be done for this field, but I don't
have any sample captures to test this.
svn path=/trunk/; revision=29459
2009-08-18 00:32:11 +00:00
5417a21bac
As pointed out by Guy, we should probably explain why the gulong -> size_t cast is 'safe'
...
svn path=/trunk/; revision=29458
2009-08-17 20:14:59 +00:00
8de8a1cb6e
setbit() is (AFAIK) defined in <sys/param.h> (OpenBSD) so rename to dect_setbit() to avoid clash. getbit() is also renamed for consistency.
...
Fixes the issue reported by Stan: http://www.wireshark.org/lists/wireshark-users/200908/msg00128.html
svn path=/trunk/; revision=29456
2009-08-17 17:19:31 +00:00
a1a129abb5
Prepare to store column data from pinfo.
...
svn path=/trunk/; revision=29454
2009-08-17 15:05:43 +00:00
460eacaae1
Move the NULL pointer 'tree' check under TRY_TO_FAKE_THIS_ITEMs umbrella
...
svn path=/trunk/; revision=29453
2009-08-17 11:21:33 +00:00
69babcb4a6
Don't do PROTO_REGISTRAR_GET_NTH twice.
...
svn path=/trunk/; revision=29452
2009-08-17 11:13:36 +00:00
e4e9b91275
Add proper type cast.
...
Thanks to Martin for reporting this.
svn path=/trunk/; revision=29451
2009-08-17 04:23:47 +00:00
79c49bfe54
[Automatic manuf and enterprise-numbers update for 2009-08-16]
...
svn path=/trunk/; revision=29447
2009-08-16 15:03:26 +00:00
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
fe6f8b92c7
Add a new function, tvb_new_subset_remaining(), which is a sligtly optimized version of tvb_new_subset(). The latter can be mapped to the former by tvb_new_subset(tvb, offset, -1 /* backing_length */, -1 /* reported_length */). We can disable some bounds checking because 'backing_length' and 'reported_length' are hardcoded to -1.
...
The current implementation of tvb_new_subset_remaining() only has the THROW_ON(reported_length < 1) check removed when compared to tvb_new_subset(). So there's room for improvement in this function. We should be able to disable some more (redundant) bounds checking.
svn path=/trunk/; revision=29445
2009-08-16 10:53:47 +00:00
c795851beb
Remove unused parameters
...
svn path=/trunk/; revision=29444
2009-08-16 09:48:25 +00:00
6cd59f3799
Remove the non-thread safe usage of 'last_tvb' variable in tvb_new_subset()
...
svn path=/trunk/; revision=29443
2009-08-16 09:18:17 +00:00
998ee3a2e0
Make some of the check_XXX functions accept the length/reported length of the tvbuff as arguments instead the tvbuff. We'll need this feature in order to remove the non-thread usage of the 'last_tvb' variable in tvb_new_subset()
...
svn path=/trunk/; revision=29442
2009-08-16 08:18:17 +00:00
01abc372e6
Remove a non thread-safe usage (useful when/if we ever support threading) of a static tvbuff in tvb_new_real_data(). The current version uses a static 'last_tvb' to keep track of the last allocated tvbuff. This is needed because some of the function we call can throw an exception. This patch improves this strategy by throwing an exception (if needed) before we try to allocate the tvbuff. This way we avoid a memleak _and_ we don't have to track the 'last_tvb' tvbuff.
...
svn path=/trunk/; revision=29441
2009-08-16 07:29:11 +00:00
7cb17ecec0
Use the slice allocator if GLIB >= 2,10,0
...
svn path=/trunk/; revision=29440
2009-08-16 04:54:33 +00:00
aed905a6c9
Use the slice allocator if GLIB >= 2,10,0 as suggested by Anders Broman
...
svn path=/trunk/; revision=29434
2009-08-15 13:24:59 +00:00
623db2e71e
Add a missing DISSECTOR_ASSERT in tvb_init()
...
svn path=/trunk/; revision=29433
2009-08-15 12:41:24 +00:00
ef68d63745
Make mem chunk static
...
svn path=/trunk/; revision=29432
2009-08-15 12:29:25 +00:00
154de60393
Switch over to using GLib's g_malloc/g_free in the name of consistency.
...
svn path=/trunk/; revision=29430
2009-08-15 09:13:16 +00:00
da97c3e2b6
This should have been part of r29428. This patch forces proto_field_is_referenced() to respect the fake_protocols flag set by Protocol Hierarchy stats tap.
...
svn path=/trunk/; revision=29429
2009-08-15 08:38:50 +00:00
96b2c411dd
The frame dissector contains a kludge to workaround the fact that the Protocol Hierarchy stats tap always needs the protocol node to appear even though no color, display filter etc. reference it. This is no longer needed due to r29380.
...
svn path=/trunk/; revision=29428
2009-08-15 08:05:10 +00:00
7d44262406
This patch introduces packet_add_new_data_source() which effectively deprecates add_new_data_source(). This is based on the following observation:
...
1) The tvb + name (aka. data_source) is only used when the protocol tree is visible
The current implementation of add_new_data_source() doesn't take this into account and simply allocates a data_source regardless. This is what packet_add_new_data_source() tries to rectify.
A couple of dissectors have already been switched over to the new packet_add_new_data_source(). Many are still missing. Help appreciated!
svn path=/trunk/; revision=29427
2009-08-15 06:38:10 +00:00
8760a6b49d
Allow s1ap not to be dissected (to avoid seeing errors, possibly due to proprietary variants).
...
svn path=/trunk/; revision=29420
2009-08-15 01:29:29 +00:00
80a6d3fbcf
Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic.
...
svn path=/trunk/; revision=29404
2009-08-13 19:42:46 +00:00
97fda7386c
Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893
svn path=/trunk/; revision=29403
2009-08-13 12:17:20 +00:00
e7ed279da9
fix build failure without GnuTLS
...
svn path=/trunk/; revision=29402
2009-08-13 11:12:35 +00:00
ae5e82dc11
use G_GSIZE_MODIFIER instead of %zd which is not supported by MSVC
...
svn path=/trunk/; revision=29401
2009-08-13 10:36:53 +00:00
ebc78f0a07
Fix SSL decryption failure if client and server have the same TCP port
...
svn path=/trunk/; revision=29400
2009-08-13 09:07:03 +00:00
6aed88fadc
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3 (R7 and R8)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3891
svn path=/trunk/; revision=29399
2009-08-13 07:56:13 +00:00
088110624e
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3 (R6).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3886
svn path=/trunk/; revision=29398
2009-08-12 22:40:13 +00:00
8fd6301ddc
White space changes
...
svn path=/trunk/; revision=29397
2009-08-12 19:32:54 +00:00
9eec025c49
DISSECTOR_ASSERT on FT_PCRE in construct_match_selected_string().
...
svn path=/trunk/; revision=29396
2009-08-12 18:24:49 +00:00
5bd6d8eaaf
From William Preston via. 3549:
...
A typo in 2 of the field names causes the apn not to be displayed.
svn path=/trunk/; revision=29394
2009-08-12 15:12:19 +00:00
181f4c8364
Fix COL_INFO and COL_PROTOCOL for Teredo Direct IPv6 Connectivity Test
...
svn path=/trunk/; revision=29393
2009-08-12 12:55:27 +00:00
cb5415d399
fix memoryleak causing crash with long SSL traces
...
svn path=/trunk/; revision=29392
2009-08-12 06:10:08 +00:00
7267ec9782
Complete the fix in r29389.
...
svn path=/trunk/; revision=29390
2009-08-11 23:52:04 +00:00
4bfcd5993a
Instead of calling DISSECTOR_ASSERT_NOT_REACHED, just say the subchannel
...
is unknown. Fixes bug 3864.
svn path=/trunk/; revision=29389
2009-08-11 23:44:22 +00:00
1f3776bf8b
Add some length checks.
...
svn path=/trunk/; revision=29388
2009-08-11 23:29:21 +00:00
80fbe4959a
From Ivan Sy (with minor modifications):
...
Show Teredo Connectivity tests.
Fix offset of ICMPv6 sequence number.
svn path=/trunk/; revision=29387
2009-08-11 23:20:03 +00:00
07900e7a1a
From swapnil:
...
Small Bug in TFT (Flow label) and ULI.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3876
svn path=/trunk/; revision=29386
2009-08-11 21:27:36 +00:00
f625c7131d
Use the right size for FT_UINT16.
...
svn path=/trunk/; revision=29385
2009-08-11 21:11:12 +00:00
809fb769b4
Add some length checks. Fixes a few recent fuzz bugs.
...
svn path=/trunk/; revision=29384
2009-08-11 20:58:36 +00:00
0ff1dd7142
Add a bunch of length checks. Fixes bug 3826.
...
svn path=/trunk/; revision=29383
2009-08-11 18:37:59 +00:00
e1c5ffd553
(Trivial change) move ensure_contiguous() to reflect call hierarchy
...
svn path=/trunk/; revision=29382
2009-08-11 18:28:10 +00:00
158827a5e7
Turn a comment in fast_ensure_contiguous() into a DISSECTOR_ASSERT() to make the implied requirement explicit.
...
svn path=/trunk/; revision=29381
2009-08-11 18:16:55 +00:00
261a8406bc
TRY_TO_FAKE_THIS_ITEM now fakes FT_PROTOCOL per default. If there are any users (e.g. proto_hier_stats.c, others?) that relies on FT_PROTOCOL nodes being created they'll now need to call the newly introduced epan_dissect_fake_protocols() to disable this optimization.
...
Also make use of TRY_TO_FAKE_THIS_ITEM in proto_tree_add_text_node(), proto_tree_add_none_format() and proto_tree_add_protocol_format().
svn path=/trunk/; revision=29380
2009-08-11 18:08:03 +00:00
8b9d2f7490
Be a little more explicit in our description of tvb_get_ptr.
...
svn path=/trunk/; revision=29379
2009-08-11 17:53:39 +00:00
ca1cba6f30
Don't coerce a (void *) to a (guint32 *).
...
The (void *) pointer in this case may point to
"unaligned" data.
svn path=/trunk/; revision=29378
2009-08-11 13:44:35 +00:00
6c2c08c082
From Gerasimos Dimitriadis:
...
DTAP decoding of Mobile Station Classmark 3 (R4 and R5).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3866
svn path=/trunk/; revision=29377
2009-08-11 12:22:00 +00:00
bae780d14b
From swapnil:
...
Bugs Fixed in ULI in packet-gtpv2.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3860
svn path=/trunk/; revision=29376
2009-08-11 10:32:46 +00:00
e0e33ca74b
We now expose the following environment variables:
...
* WIRESHARK_DEBUG_EP_NO_CHUNKS
* WIRESHARK_DEBUG_SE_NO_CHUNKS
* WIRESHARK_DEBUG_EP_NO_CANARY
* WIRESHARK_DEBUG_SE_NO_CANARY
This allows us to enable/disable memory chunks and canaries at runtime _without_ needing to recompile.
svn path=/trunk/; revision=29375
2009-08-11 09:24:56 +00:00
a8fbd4577f
From swapnil:
...
Another Minor Bug for ULI in Packet-gtpv2.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3862
svn path=/trunk/; revision=29374
2009-08-11 07:41:46 +00:00
c6893212f1
For TLV items that are a single integral value and thus must have a
...
certain length:
attach the expert item to the length field if we're showing it,
otherwise put in a text item for the malformed TLV and attach
the expert item to that;
don't give up, as we'll just skip the bad item and move on to
the next item.
svn path=/trunk/; revision=29373
2009-08-10 22:15:22 +00:00
a8533d84e5
Initialize a variable to keep GCC happy ....
...
svn path=/trunk/; revision=29372
2009-08-10 21:46:30 +00:00
Anders Broman