Commit Graph

39 Commits

Author SHA1 Message Date
Gerald Combs 367bcb7abd Clean up the last two DIRTY_DISSECTOR_SRC entries.
svn path=/trunk/; revision=29321
2009-08-07 00:15:35 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings)
svn path=/trunk/; revision=27037
2008-12-17 17:23:37 +00:00
Bill Meier 77b81b391b #include <prefs.h> not req'd
svn path=/trunk/; revision=26089
2008-08-25 22:06:20 +00:00
Jaap Keuter 14e0b8f792 From Dan Messinger:
The OSD APPEND command does not use the sort order field. Wireshark is decoding it.

svn path=/trunk/; revision=24627
2008-03-14 07:45:30 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Guy Harris 1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Sebastien Tandel a7615a1afb another attempt to let windows buildbot becoming green
fix rev21398 (gcc warning fix)

svn path=/trunk/; revision=21412
2007-04-13 17:16:24 +00:00
Sebastien Tandel 7be3171467 miss some volatile qualifiers in scsi-osd
svn path=/trunk/; revision=21411
2007-04-13 15:52:04 +00:00
Bill Meier 103bf29730 Continuing the tradition: squelch some compiler warnings ....
svn path=/trunk/; revision=20866
2007-02-19 22:29:23 +00:00
Ronnie Sahlberg f6f95ea6a0 remove the revision number from the spc symbols
change all spc2 and spc3 to spc



svn path=/trunk/; revision=20779
2007-02-11 00:45:15 +00:00
Ronnie Sahlberg e04e99427b some compilers dont like unnamed unions and structs
svn path=/trunk/; revision=19817
2006-11-06 09:30:15 +00:00
Ronnie Sahlberg 06eaa14930 we used the wrong offset for attribute lists, fixed
add decoding for attribute lists for another instance where these blobs appear in the data in/out buffers


svn path=/trunk/; revision=19809
2006-11-05 11:19:46 +00:00
Ronnie Sahlberg 92b9545f85 add a framework to manage dissection of osd attribute pages, attribute number and name and dissectors for them.
implement the dissector for attribute page 1 (user object info) number 82 (logical length) as an example.





svn path=/trunk/; revision=19808
2006-11-05 10:48:53 +00:00
Ronnie Sahlberg ebf95252d0 dissect the Get Attributes List Offset according to the really weird encoding in 4.12.5
svn path=/trunk/; revision=19807
2006-11-05 07:59:20 +00:00
Ronnie Sahlberg c0cccf43c2 start splitting the monolitic scsi dissector up into commandset dissectors
split the MMC commandset out of the main scsi dissector



svn path=/trunk/; revision=19738
2006-10-30 12:18:29 +00:00
Ronnie Sahlberg c56d0ab3af more serviceactions
svn path=/trunk/; revision=19537
2006-10-15 02:54:08 +00:00
Ronnie Sahlberg ba6507c460 some more service actions
svn path=/trunk/; revision=19536
2006-10-14 22:45:07 +00:00
Ronnie Sahlberg 187454bf8a dissect some more osd service actions
svn path=/trunk/; revision=19535
2006-10-14 22:31:27 +00:00
Ronnie Sahlberg 3d0788951a add dissection of FLUSH and FLUSH COLLECTION
svn path=/trunk/; revision=19529
2006-10-14 11:25:38 +00:00
Ronnie Sahlberg ebfc131d81 implement WRITE and CREATE COLLECTION
svn path=/trunk/; revision=19528
2006-10-14 10:52:50 +00:00
Ronnie Sahlberg 15d3176063 wireshark does not yet consume enough memory for me to be happy
pass conversation form the transports up to the scsi layer

add tracking of conversation specific info to scsi osd
add tracking of conversation+lun specific info to scsi osd

for scsi osd   add tracking of PARTITIONS and display in which frame they were created/removed



svn path=/trunk/; revision=19505
2006-10-12 10:54:36 +00:00
Ronnie Sahlberg 494e873eb0 move the ITL and the ITLQ structure to packet-scsi.h where it belongs
svn path=/trunk/; revision=19492
2006-10-11 10:38:59 +00:00
Ronnie Sahlberg 01b065893e From Joe Breher
dissect the permission bits in the capability blob



svn path=/trunk/; revision=19462
2006-10-09 19:35:36 +00:00
Ronnie Sahlberg dfc0a65002 from Joe Breher
This patch fixes a transposition of the orders of
Set Attribute Number
Set Attribute Length
In the page oriented get and set attributes CDB parameters format
Ref SCSI-OSD T10/1355-D Revision 10 section 5.2.2.2





svn path=/trunk/; revision=19460
2006-10-09 08:31:04 +00:00
Ronnie Sahlberg daed1f10cd add some more SCSI OSD command dissectors
REMOVE
REMOVE PARTITION
REMOVE COLELCTION
SET KEY


svn path=/trunk/; revision=19453
2006-10-08 19:54:01 +00:00
Ronnie Sahlberg 0eb3023c5f dissect attribute get/set data in data in/out blobs and display them for now as a blob.
svn path=/trunk/; revision=19452
2006-10-08 19:11:39 +00:00
Ronnie Sahlberg 08421ffc74 scsi osd
collapse attripute parameters, capability and security parameters into subtrees to make the display easier to read


svn path=/trunk/; revision=19450
2006-10-08 04:48:24 +00:00
Ronnie Sahlberg 4d6a65270b scsi: unusual scsi protocols can request multiple AHS fields for iscsi so decode the AHS properly instead of assuming at most one field is present
scsi-osd   add dissection of  LIST data pdus  and  CREATE cdb


svn path=/trunk/; revision=19449
2006-10-08 04:13:18 +00:00
Ronnie Sahlberg 61ac971e2c add dissection of the cdb for service action LIST
(but no decoding of the data in yet)



svn path=/trunk/; revision=19388
2006-09-30 21:08:27 +00:00
Ronnie Sahlberg c2b08c79d2 add dissection of SCSI OSD CREATE PARTITION
svn path=/trunk/; revision=19379
2006-09-30 10:24:23 +00:00
Ronnie Sahlberg cadbe48610 finish off the remainder of FORMAT OSD for scsi osd dissector
svn path=/trunk/; revision=19378
2006-09-30 10:08:43 +00:00
Ronnie Sahlberg bedacc2bc2 scsi osd updates
iscsi: when iscsi transfers a cdb that is alrger than 16 bytes,  the first 16 bytes are transferred in the normal place in the header and ther remainder of the cdb is transported inside the AHS.

reassemble these cdb into a proper tvb before passing it to the scsi dissector



svn path=/trunk/; revision=19376
2006-09-30 09:34:58 +00:00
Ulf Lamping 4e79f8f307 remove a warning
svn path=/trunk/; revision=19375
2006-09-30 09:15:15 +00:00
Ronnie Sahlberg 62290c9cc5 add an extra_data pointer to the itlq structure where specific commandsets/cdbs can hang additional data that are unique to that commandset/cdb
make the scsi osd service action and getsetattributetype use this facility

furhter enhancements to scsi osd


svn path=/trunk/; revision=19374
2006-09-30 04:10:28 +00:00
Ronnie Sahlberg 0afdb9be78 scsi osd additions
we also need to track the serviceaction in the itlq structure so we can decode the data in/out properly


svn path=/trunk/; revision=19371
2006-09-30 00:31:36 +00:00
Ulf Lamping d6f0ae689c MSVC doesn't like empty array inits
svn path=/trunk/; revision=19368
2006-09-29 21:53:54 +00:00
Ronnie Sahlberg e2a851e18d add initial scsi osd dissector but only dissect sdbs that are impoerted from SPC
various changes to the existing scsi dissector to start allowing different commandsets to be implemented in their own dissector files to prevent the scsi dissector to become as huge as the parlay dissector




svn path=/trunk/; revision=19360
2006-09-29 10:40:51 +00:00