Commit graph

20504 commits

Author SHA1 Message Date
Jörg Mayer
a00dc2564e strncmp(NULL, ...) isn't such a good idea.
svn path=/trunk/; revision=21033
2007-03-14 22:58:09 +00:00
Guy Harris
082282b6f4 Don't enable "Save As" if you don't have an unsaved live capture file
and there are no formats in which the file can be saved by some means
other than copying the raw data; "Save As" isn't a very useful function
in that case, and that prevents us from having an empty list of formats
in which the file can be saved.

svn path=/trunk/; revision=21032
2007-03-14 19:30:19 +00:00
Guy Harris
50bb064108 Get rid of some #if-ed out includes, which aren't needed.
svn path=/trunk/; revision=21031
2007-03-14 19:29:42 +00:00
Guy Harris
a0fecf54bd Correctly return the item value through the pointer.
svn path=/trunk/; revision=21030
2007-03-14 18:25:19 +00:00
Guy Harris
78b8245bcc "dissect_tapa_static()" is a new-style dissector; register it as such.
svn path=/trunk/; revision=21029
2007-03-14 18:23:19 +00:00
Guy Harris
2e8fa7557e Include <ctype.h> to define "isspace()".
Clean up indentation.

svn path=/trunk/; revision=21028
2007-03-14 18:22:28 +00:00
Guy Harris
8a3ea1a6f7 Fix indentation.
svn path=/trunk/; revision=21027
2007-03-14 18:19:13 +00:00
Graeme Lunt
c05709dc70 "When X.264/ISO 11570 default identification is being used, there is no user data field in the
CALL REQUEST packet.  This is for X.225/ISO 8073 COTP."

Added this default handling.


svn path=/trunk/; revision=21026
2007-03-14 17:28:55 +00:00
Jörg Mayer
e2c6534c5e Improve the heuristic for the tapa discovery classification.
This should fix bug 1437.

svn path=/trunk/; revision=21025
2007-03-14 15:40:44 +00:00
Anders Broman
96838a7064 Use the latest GTK packages for Windows.
svn path=/trunk/; revision=21024
2007-03-14 07:12:55 +00:00
Anders Broman
8f92a66a89 Add comments about 3gpp AVP:s
svn path=/trunk/; revision=21023
2007-03-14 06:29:14 +00:00
Ulf Lamping
7366ae37a0 as requested by "John T. Haller" for PortableApps.com:
add new WS command line option -P to be able to change some of the path settings

this is experimental, please report bugs

svn path=/trunk/; revision=21022
2007-03-14 02:55:54 +00:00
Stephen Fisher
eeea95ccbe HTTP Export Object updates:
- Split the HTTP tap into two taps: one for the HTTP statistics
   and the other for the export object function.  This allows the
   HTTP statistics to work again (they seem to have been
   partially broken since SVN rev 18901).
 - Pass the conversation data (conv_data) between functions now
   instead of using the global variable stat_info (now only used
   for the HTTP stats)
 - Pass only pointers from the HTTP dissector to the Export Object
   tap, where we'll then copy the values and insert into the slist.
 - Make sure we free all memory allocated by this feature when
   we're done with it.
 - Various other minor improvements


svn path=/trunk/; revision=21021
2007-03-13 20:42:04 +00:00
Martin Mathieson
e14e7fe455 Make m2pa dissector findable by name.
svn path=/trunk/; revision=21020
2007-03-12 11:21:02 +00:00
Ulf Lamping
c3bf838051 as Jeff made empty field names "illegal", he changed the way PN-IO and PN-PTCP showed their blocks in an unwanted way - fix it
svn path=/trunk/; revision=21019
2007-03-11 12:07:43 +00:00
Jeff Morriss
62596bffb3 Fix bug 552:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552

by enforcing that header fields have names of length > 0.  This should fix
the display of those fields and also make them filterable (which was the
subject of the bug).  Abbreviations are (still) optional: if they are empty
then the field is not filterable.

Update README.developer with this information.

Add header field names in several dissectors where they were missing.

In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.

Also remove trailing white space from all the files checked in.

svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00
Jeff Morriss
44328ec205 From David Buechi:
- don't show EPL src- and dst-address of SoC frame (same as SoA)
- show SoA requested service only if it's not "NO_SERVICE"
- NMT state in StatusResponse in words, not numbers
- don't show MC and PS flags in SoC (it's now configurable via "Preferences")

Furthermore I extended the value_string struct for the NMT-Command-IDs
(asnd_cid_vals). This change is used to fully decode the NMTRequest frames.

svn path=/trunk/; revision=21017
2007-03-10 15:06:11 +00:00
Jeff Morriss
e9ca912aab From Joost Yervante Damad via bug 1383: support for Erlang Port Mapper Daemon
message dissection.

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1383

svn path=/trunk/; revision=21016
2007-03-10 08:36:24 +00:00
Luis Ontanon
0c8d5247b6 Make sure ENDTRY is evaluated.
On windows if ENDTRY is not evaluated after a exception is being thrown wireshark will crash in dissect_packet() while attempting to pop the last frame of the exception stack.

svn path=/trunk/; revision=21015
2007-03-10 02:13:00 +00:00
Luis Ontanon
403fa20bf1 Make sure ENDTRY is evaluated.
On windows if ENDTRY is not evaluated after a exception is being thrown wireshark will crash in dissect_packet() while attempting to pop the last frame of the exception stack.

svn path=/trunk/; revision=21014
2007-03-10 02:11:51 +00:00
Luis Ontanon
9be42ac4dc Major cleanup of debug code and whitespace changes.
svn path=/trunk/; revision=21013
2007-03-10 02:04:57 +00:00
Ronnie Sahlberg
10588355f9 move some variable declarations to the start of the block.
many compilers do not support the nonstandard feature to declare variables in the middle of a block.



svn path=/trunk/; revision=21012
2007-03-09 20:02:25 +00:00
Jörg Mayer
fb820f0a07 GCC warning fixes
epan/dissectors/
packet-bctp.c:
	no newline at end of file
packet-epl.c:
	C++ style comments are not allowed in ISO C90
packet-sccp.c:
	missing initializer
packet-sccp.h:
	comma at end of enumerator list
packet-sctp.c:
	suggest parentheses around assignment used as truth value
packet-vnc.c:
	control reaches end of non-void function
	pointer targets in passing argument 1 of 'g_strtod' differ in
		signedness
	pointer targets in passing argument 3 of 'vnc_client_to_server'
		differ in signedness
gtk/
main.c:
	C++ style comments are not allowed in ISO C90
u3.h:
	function declaration isn't a prototype

Other (trivial) stuff
packet-sccp.h:
	Add svn properties


svn path=/trunk/; revision=21011
2007-03-09 13:14:09 +00:00
Jörg Mayer
147d66441e dcerpc_procedure_name is actually a const char*, not just char*
svn path=/trunk/; revision=21010
2007-03-09 13:13:44 +00:00
Jörg Mayer
f9560b982a Regenerated with current pidl compiler
svn path=/trunk/; revision=21009
2007-03-09 13:11:33 +00:00
Michael Tüxen
da56836f74 Add HMAC Algo constants.
svn path=/trunk/; revision=21008
2007-03-09 10:49:23 +00:00
Gerald Combs
0e181d05c8 Fix for bug 1264 from Julian Cable:
I've refactored the offending code branch and added some comments so
  hopefully the intent is a bit clearer. The loop termination conditions
  are now obviously independent of the content on the wire (they were
  meant to be before, but I admit it was obscure). I've tried using the
  ephemeral memory routines.

Add a check for a maximum fragment count, and bail out of reassembly instead
of triggering an ep_alloc exception.  Add Julian to AUTHORS.  Update the 
release notes.

svn path=/trunk/; revision=21007
2007-03-09 01:40:30 +00:00
Ulf Lamping
3810cc0891 remove the separator above the "Export Selected Packet Bytes" context menu item
svn path=/trunk/; revision=21006
2007-03-08 23:48:59 +00:00
Ulf Lamping
acefba187a from Sake Blok:
I have changed the patch according to your suggestions and also changed
the doc[book] files accordingly. I tested the patch and it does seem to
work fine on my test-system.

ULFL: In addition, I've added the en-/disabling to the other (already existing) Copy menu items - some just did nothing, some crashed if nothing was selected.
I've also sligthly changed the menu seperators and made both context menus look a bit more identical.

svn path=/trunk/; revision=21005
2007-03-08 23:37:55 +00:00
Luis Ontanon
78028f02b5 fix Bug 1370
LUA function all_field_infos() causes wire shark to terminate.

svn path=/trunk/; revision=21004
2007-03-08 23:00:28 +00:00
Luis Ontanon
7f413f1325 actually compile H.248.7
svn path=/trunk/; revision=21003
2007-03-08 22:59:44 +00:00
Jörg Mayer
736e5fdfef Whitespace changes
svn path=/trunk/; revision=21002
2007-03-08 14:49:14 +00:00
Luis Ontanon
a3099a387c Yet another H.248 package: H.248.7 Gateway control protocol: Generic Announcement package
svn path=/trunk/; revision=21001
2007-03-08 09:59:16 +00:00
Luis Ontanon
b6ab56f26d fix a syntax error on the last check-in...
svn path=/trunk/; revision=21000
2007-03-08 00:43:08 +00:00
Luis Ontanon
8c8595e496 avoid using an "uninitialized" start variable on gap blocks
svn path=/trunk/; revision=20999
2007-03-08 00:37:07 +00:00
Luis Ontanon
cf0379278b in TSN tracking: handle the TSN rollover.
I'll keep TSN tracking disabled by default, as it slows down dissection significantly and eats tons of memory!

svn path=/trunk/; revision=20998
2007-03-08 00:18:25 +00:00
Stephen Fisher
7389b3fabd Add a "Bits/Tick" option to the IO Stats dialog to complement the
"Bytes/Tick" option.


svn path=/trunk/; revision=20997
2007-03-07 23:39:45 +00:00
Michael Tüxen
af7bdd06db Add support for draft-ietf-rserpool-policies-04.txt.
svn path=/trunk/; revision=20996
2007-03-07 20:28:48 +00:00
Michael Tüxen
0204c1dc93 Fix a crash: You can not combine unsinged types like FT_INT32 and BASE_HEX.
svn path=/trunk/; revision=20995
2007-03-07 18:37:56 +00:00
Luis Ontanon
99f6a7feef props
svn path=/trunk/; revision=20994
2007-03-07 14:17:08 +00:00
Luis Ontanon
28764c409b another (very small) H.248 package, H.248.10 : Media gateway resource congestion handling package
svn path=/trunk/; revision=20993
2007-03-07 14:13:56 +00:00
Jörg Mayer
d4ead590a1 Update from samba tree revision 21565 to 21739
============================ Samba log start ============
------------------------------------------------------------------------
r21567 | jelmer | 2007-02-27 21:35:56 +0100 (Tue, 27 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/tests/wireshark-ndr.pl

Add some more wireshark tests.
------------------------------------------------------------------------
r21568 | jelmer | 2007-02-27 22:37:31 +0100 (Tue, 27 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/tests/wireshark-ndr.pl

More tests.
------------------------------------------------------------------------
r21572 | jelmer | 2007-02-28 00:47:07 +0100 (Wed, 28 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm
   M /branches/SAMBA_4_0/source/pidl/tests/ndr.pl
   M /branches/SAMBA_4_0/source/pidl/tests/ndr_tagtype.pl
   M /branches/SAMBA_4_0/source/pidl/tests/typelist.pl

More work towards supporting tagged types.
------------------------------------------------------------------------
r21573 | jelmer | 2007-02-28 01:19:57 +0100 (Wed, 28 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm
   M /branches/SAMBA_4_0/source/pidl/tests/ndr.pl
   M /branches/SAMBA_4_0/source/pidl/tests/typelist.pl

Remove more code that assumed all types are typedefs.
------------------------------------------------------------------------
r21574 | jelmer | 2007-02-28 01:28:14 +0100 (Wed, 28 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm
   M /branches/SAMBA_4_0/source/pidl/tests/ndr.pl

Fix handling of DECLARE.
------------------------------------------------------------------------
r21575 | jelmer | 2007-02-28 01:35:21 +0100 (Wed, 28 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Typelist.pm
   M /branches/SAMBA_4_0/source/pidl/tests/typelist.pl

Fix handling of is_scalar() for declares.
------------------------------------------------------------------------
r21578 | jelmer | 2007-02-28 02:51:37 +0100 (Wed, 28 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/README
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   M /branches/SAMBA_4_0/source/pidl/tests/ndr_tagtype.pl
   M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl

Use utility function for naming pull/push/print functions.
------------------------------------------------------------------------
r21579 | jelmer | 2007-02-28 03:01:58 +0100 (Wed, 28 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
   M /branches/SAMBA_4_0/source/pidl/tests/samba-ejs.pl

Use utility function to determine function names in ejs code.
------------------------------------------------------------------------
r21584 | jelmer | 2007-02-28 14:25:53 +0100 (Wed, 28 Feb 2007) | 6 lines
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/librpc/idl/echo.idl
   M /branches/SAMBA_4_0/source/pidl/README
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/EJS.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/Header.pm
   M /branches/SAMBA_4_0/source/pidl/tests/header.pl
   M /branches/SAMBA_4_0/source/pidl/tests/ndr.pl
   M /branches/SAMBA_4_0/source/pidl/tests/typelist.pl

Support for tagged types has landed!

It's now possible to use "struct foo" without a typedef in IDL files.

echo_info4 is the first type that's been converted.

------------------------------------------------------------------------
r21586 | jelmer | 2007-02-28 15:56:46 +0100 (Wed, 28 Feb 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/MANIFEST

update manifest
------------------------------------------------------------------------
r21654 | jelmer | 2007-03-02 15:05:52 +0100 (Fri, 02 Mar 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   M /branches/SAMBA_4_0/source/pidl/tests/samba-ndr.pl

Add simple test for print functions.
------------------------------------------------------------------------
r21656 | jelmer | 2007-03-02 15:53:09 +0100 (Fri, 02 Mar 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   A /branches/SAMBA_4_0/source/lib/registry/tests
   A /branches/SAMBA_4_0/source/lib/registry/tests/generic.c (from /branches/SAMBA_4_0/source/torture/local/registry.c:21654)
   A /branches/SAMBA_4_0/source/lib/socket/testsuite.c (from /branches/SAMBA_4_0/source/torture/local/socket.c:21654)
   A /branches/SAMBA_4_0/source/lib/tdr/testsuite.c (from /branches/SAMBA_4_0/source/torture/local/tdr.c:21654)
   A /branches/SAMBA_4_0/source/lib/util/tests
   A /branches/SAMBA_4_0/source/lib/util/tests/file.c (from /branches/SAMBA_4_0/source/torture/local/util_file.c:21654)
   A /branches/SAMBA_4_0/source/lib/util/tests/idtree.c (from /branches/SAMBA_4_0/source/torture/local/idtree.c:21654)
   A /branches/SAMBA_4_0/source/lib/util/tests/strlist.c (from /branches/SAMBA_4_0/source/torture/local/util_strlist.c:21654)
   A /branches/SAMBA_4_0/source/librpc/tests
   A /branches/SAMBA_4_0/source/librpc/tests/binding_string.c (from /branches/SAMBA_4_0/source/torture/local/binding_string.c:21654)
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm
   D /branches/SAMBA_4_0/source/torture/local/binding_string.c
   M /branches/SAMBA_4_0/source/torture/local/config.mk
   D /branches/SAMBA_4_0/source/torture/local/idtree.c
   D /branches/SAMBA_4_0/source/torture/local/registry.c
   D /branches/SAMBA_4_0/source/torture/local/socket.c
   D /branches/SAMBA_4_0/source/torture/local/tdr.c
   D /branches/SAMBA_4_0/source/torture/local/util_file.c
   D /branches/SAMBA_4_0/source/torture/local/util_strlist.c

Move tests a bit closer to the things they test, should make syncing with samba3 easier.
------------------------------------------------------------------------
r21681 | jelmer | 2007-03-04 15:16:52 +0100 (Sun, 04 Mar 2007) | 5 lines
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/TODO
   M /branches/SAMBA_4_0/source/pidl/idl.yp
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/IDL.pm
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
   M /branches/SAMBA_4_0/source/pidl/tests/header.pl
   M /branches/SAMBA_4_0/source/pidl/tests/parse_idl.pl

Fix bug in the parsing code that parsed "struct foo;" the same as 
"struct foo {};". 

Reported by one of the OpenChange folks, thanks!

------------------------------------------------------------------------
r21682 | jelmer | 2007-03-04 15:31:18 +0100 (Sun, 04 Mar 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm

Remove accidently committed debug command.
------------------------------------------------------------------------
r21690 | jelmer | 2007-03-05 01:03:44 +0100 (Mon, 05 Mar 2007) | 1 line
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/tests/header.pl
   M /branches/SAMBA_4_0/source/pidl/tests/parse_idl.pl

Test use of typedef /and/ struct name
------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

svn path=/trunk/; revision=20992
2007-03-07 07:55:00 +00:00
Jörg Mayer
83ee2dbcfa Update manuf and faq
svn path=/trunk/; revision=20991
2007-03-07 07:50:48 +00:00
Gerald Combs
b7d30175c0 Fix a couple of off-by-one overflows reported in bug 1415. Update the
release notes accordingly.

svn path=/trunk/; revision=20990
2007-03-07 01:17:24 +00:00
Gerald Combs
773cd3dee8 Under Windows, try to use the first interface that looks like Ethernet
as the capture interface.  This should fix the capture test failures on
the Windows builder.

svn path=/trunk/; revision=20989
2007-03-06 23:55:00 +00:00
Luis Ontanon
7a213ffb15 two inverted value_strings
svn path=/trunk/; revision=20988
2007-03-06 23:23:59 +00:00
Luis Ontanon
170386ac5b terminate an array!
svn path=/trunk/; revision=20987
2007-03-06 23:16:59 +00:00
Luis Ontanon
37802e5e21 Pubate Satienpoch keeps finding typos and incongruences in H.248 packages:
- for Q.1950 I used the value_string for GB events as the value_string for the parameters of BNC change.

> In observed event descriptor, it is called “eventName”, but in event descriptor,
> it is called “pkgdName”. It should be “eventName” in both cases.

svn path=/trunk/; revision=20986
2007-03-06 22:13:12 +00:00
Ulf Lamping
e30640be45 PROFINET RT frames can also be transported over UDP Port 0x8892 - to be routable
svn path=/trunk/; revision=20985
2007-03-06 21:54:53 +00:00
Anders Broman
ecbf96d04e From Stig Bjørlykke:
When dumping elements in a constructor in dissect_unknown_ber the last element is not put in the correct subtree, because the while- loop does not include the header length when checking for the end.

svn path=/trunk/; revision=20984
2007-03-06 21:03:27 +00:00