Commit Graph

17298 Commits

Author SHA1 Message Date
Gerald Combs 99a14bf9f1 From Jeff Morriss:
emem.c wouldn't compile with EP_DEBUG_FREE and SE_DEBUG_FREE defined.

  The attached patch fixes that and cleans up some warnings that showed
  up with those two were defined, too.  (In fact 95% of the patch is
  for warnings.)

Fix up whitespace.

svn path=/trunk/; revision=17500
2006-03-07 16:31:47 +00:00
Gerald Combs ac32d8875f Initialize a return value. Found by Coverity.
Fix up whitespace.

svn path=/trunk/; revision=17499
2006-03-07 16:28:25 +00:00
Jaap Keuter 3b2760d2df Catch negative return value, leading to near infinite loop.
Filed as coverity bug 136.

svn path=/trunk/; revision=17498
2006-03-07 15:22:57 +00:00
Lars Roland 1816f28559 Fix a possible NULL pointer dereference (coverity bug id 32)
svn path=/trunk/; revision=17497
2006-03-07 14:44:25 +00:00
Luis Ontanon 65f5262bb6 Rename set_string_hash... into se_tree_xxx_string as proposed by ronnie for consistency whith its real nature.
svn path=/trunk/; revision=17496
2006-03-07 14:10:30 +00:00
Luis Ontanon 14c4d6fad9 From Jeff Morris,
Avoid an off by one error in dissect_fields_dnsea() and dissect_fields_onsea()

Fixes Bug 794


svn path=/trunk/; revision=17495
2006-03-07 14:02:25 +00:00
Lars Roland 307ba63d48 Fix a possible NULL pointer dereference discovered by coverity.
I'm not sure, if it is possible to get a NULL pointer here, but it is safer to fix it.

svn path=/trunk/; revision=17494
2006-03-07 13:48:54 +00:00
Lars Roland b51d8f3f89 Use g_assert to save us from dereferencing a NULL pointer. g_warning is not strong enough. This should fix a defect discovered by coverity.
svn path=/trunk/; revision=17493
2006-03-07 13:11:08 +00:00
Ronnie Sahlberg 7fc017a5c4 rewrite of some hairy code
fixes (hopefully) coverity bug 137


svn path=/trunk/; revision=17492
2006-03-07 10:25:42 +00:00
Luis Ontanon 888fc30d27 use an elaborated key for the string keyed "hash table"
svn path=/trunk/; revision=17491
2006-03-07 06:33:47 +00:00
Anders Broman 84b00c55d1 Fix a bug reported by coverity.
svn path=/trunk/; revision=17490
2006-03-07 06:15:06 +00:00
Luis Ontanon 95b2d64a36 ep_strdup stack buffer before returning it.
fixes coverity error 109.


svn path=/trunk/; revision=17489
2006-03-07 05:24:02 +00:00
Luis Ontanon e83301935d Remove strhash test code from lua...
svn path=/trunk/; revision=17488
2006-03-07 04:40:57 +00:00
Luis Ontanon 0cfdbc3676 - contsify a variable in packet-alcap.c to see if a fake bug reported by coverty goes away.
- fix an off by one error in packet-telnet.c reported by coverty


svn path=/trunk/; revision=17487
2006-03-07 04:33:46 +00:00
Luis Ontanon 6e04b0aadb - merge SubTree, ProtoTree and ProtoItem into a single TreeItem class.
- By the same token get rid of ProtoFieldArray having Proto.fields attribute been a lua "Array" containing fields.

(still untested, and probably broken)


svn path=/trunk/; revision=17486
2006-03-07 01:25:14 +00:00
Luis Ontanon 8dbad83e5c Add a hash table with string keys based on the red/black tree.
svn path=/trunk/; revision=17485
2006-03-07 01:15:29 +00:00
Anders Broman 0c8b1090f4 From Ming Zhang:
Update on dissector packet-scsi

* modepage processing for MMC
* support cmd Get Event Status Notification
* support cmd start stop unit for mmc

svn path=/trunk/; revision=17484
2006-03-06 20:06:05 +00:00
Gerald Combs f99ad2e895 Handle a null pointer. Fixes bugs 778 and 787.
svn path=/trunk/; revision=17483
2006-03-06 19:49:34 +00:00
Jörg Mayer 334048d3ce Update manuf, FAQ, help/faq.txt
svn path=/trunk/; revision=17482
2006-03-06 17:00:33 +00:00
Gerald Combs 705e454915 Remove the test-splint target. Splint never did work on the Ethereal sources
and it doesn't look like that will change any time soon.

svn path=/trunk/; revision=17481
2006-03-06 16:30:45 +00:00
Ronnie Sahlberg 07c2845fe7 get rid of another slow hashtable and one global variable and
replace it with a better and memleak free se_tree



svn path=/trunk/; revision=17480
2006-03-06 14:30:34 +00:00
Ronnie Sahlberg 51f8a228f6 replace one hashtable storing filehandles with a new se tree
this should make it quite a bit faster than before.



svn path=/trunk/; revision=17479
2006-03-06 13:45:30 +00:00
Ronnie Sahlberg 4caa47a1ac replace a g_malloc()/g_free() pair with ep_alloc() instead
svn path=/trunk/; revision=17478
2006-03-06 10:39:31 +00:00
Ronnie Sahlberg 745994c364 add helper to build (red/black) trees from a key that is a vector of guin32 arrays.
test this functionality by calling these vector insert/lookup tree functions from the nfs dissector for when filehandles are used as a key.

these vector functions could also be used to efficiently store conversations :
se_tree_key_t[6] = {
	{ addr_len/4,   &src_addr },
	{ addr_len/4,	&dst_addr },
	{ 1,		&src_port32 },
	{ 1,		&dst_port32 },
	{ 1,		&protocol32 },
	{ 0, NULL }
}


(the nfs dissector needs a LOT of work. It is very painful to work with 
very large nfs traces with all the memory it wastes (and eats) as well as how slow all the tables make it)



svn path=/trunk/; revision=17477
2006-03-06 10:25:19 +00:00
Anders Broman 7f2bd47f5e From Jeff Morriss:
The M3UA I-G and -bis specify a couple of registration result codes that 
the M3UA dissector doesn't currently understand.  The attached patch fixes that.

svn path=/trunk/; revision=17476
2006-03-06 06:21:01 +00:00
Anders Broman 07ca040c73 From Jhon Sullivan:
Version 0.47a of eMule extends the eDonkey protocol to support files up to 256GB in length. This patch adds support for the new packet types, and changes to existing packets, used to support this.

In addition, it seems to be getting more common to use compression on the index server connection. The packets used are just like the uncompressed versions, except transmitted as a zlib compressed stream, so I've added dissection for the contents of those too.

Plus a couple of bugfixes to the UDP packet dissection.

svn path=/trunk/; revision=17475
2006-03-06 06:19:11 +00:00
Anders Broman d19c901b52 Make a new PER function dissect_per_enumerated() and use it for the two places in RANAP where
extensions has been made to enumerations. asn2eth should be updated to use it.

svn path=/trunk/; revision=17474
2006-03-05 20:21:19 +00:00
Anders Broman 226a976d88 Add the actual dissector, win makefile and update the asn1 makefile.
svn path=/trunk/; revision=17473
2006-03-05 18:39:53 +00:00
Jörg Mayer 90a396fa1c propset ...
svn path=/trunk/; revision=17472
2006-03-05 18:38:41 +00:00
Graeme Lunt 77cf86d3d6 ACP133 attribute syntaxes and attribute definitions used by the DAP, DSP and DISP dissectors. Also includes X.402 definitions and OID registrations for object classes.
svn path=/trunk/; revision=17471
2006-03-05 11:28:13 +00:00
Ronnie Sahlberg 8ed89ff326 convert another hashtable for tcp into se_tree
svn path=/trunk/; revision=17470
2006-03-05 05:36:46 +00:00
Guy Harris 949c591a9d Add in a variable we need on Windows.
svn path=/trunk/; revision=17469
2006-03-05 04:17:07 +00:00
Guy Harris 6f5916eb36 In the capture_loop.c code, open the capture device for input before
doing anything with the output file, so that

	1) if the attempt to open the capture device fails, we don't
	   bother creating any output files;

	2) we could relinquish privileges permanently as soon as we
	   finish opening the capture device, so we don't have to give
	   them up temporarily when opening the output file, reclaim
	   them to open the input device, and then give them up
	   permanently;

(we already do that in Tethereal).

While we're at it, set the capture filter immediately after opening the
capture device, so we quit before opening capture devices if that fails.

svn path=/trunk/; revision=17468
2006-03-05 04:11:57 +00:00
Ronnie Sahlberg 0881211a12 initial implementation of binary tree support with se allocation scope
this is to test out a basic implementation of binary trees and the api required for the helpers


svn path=/trunk/; revision=17467
2006-03-05 04:01:34 +00:00
Guy Harris 49de5e663e Make some routines not used outside capture_loop.c static.
svn path=/trunk/; revision=17466
2006-03-05 03:26:21 +00:00
Guy Harris cbe69401cc Pass two strings in capture child messages, so the child can send
primary and secondary error messages and let the parent worry about how
to display them.  This means dumpcap doesn't need stub routines for
generating the formatting tags for the primary and secondary messages.

Have a separate message for capture filter errors, so that the parent
can check whether the capture filter looks like a display filter and
report the appropriate message.  This means that dumpcap doesn't need a
stub routine for compiling display filters (a stub routine also means
that Ethereal won't do the check for capture filters that look like
display filters!).

svn path=/trunk/; revision=17465
2006-03-05 03:14:16 +00:00
Luis Ontanon fd39d0ebed wrong name.
svn path=/trunk/; revision=17464
2006-03-05 02:47:00 +00:00
Luis Ontanon 7bbd2a14f0 + retap_packets()
svn path=/trunk/; revision=17463
2006-03-05 02:03:51 +00:00
Luis Ontanon 568ad6c34e + retap_packets()
+ complete gtk TextWindow
+ fix elua_dumper
+ fix elua_proto


svn path=/trunk/; revision=17462
2006-03-05 02:01:16 +00:00
Guy Harris e6886d90ce When capturing, we only support writing to libpcap files. Given that,
bypass Wiretap; that means we don't have to run the packet through
wtap_process_pcap_packet() and then undo that conversion in Wiretap if
we're just going to write it out, shortening the code path.

svn path=/trunk/; revision=17461
2006-03-04 22:33:04 +00:00
Anders Broman a8b8b3d9ff From Ming Zhang:
Updated dissector packet-scsi to

* decode the device configuration mode page;
* decode the request sense response;
* fix a wrong lens print in several writeX(). this happens when one packet contains several iscsi pdu. one write data pdu will be explained as request with LEN extracted (but it is not a cdb so it was wrong).
* split the dissect_scsi_snsinfo() into 2 parts so the sense data decode part can be a subroutine shared by requestsense() and maybe more places.


svn path=/trunk/; revision=17460
2006-03-04 10:10:48 +00:00
Anders Broman d552e217a4 From Florent Drouin:
Just a little correction.
In the last patch for gtk/gsm_map_stat.c applied, the variable "j" was changed to "i" .

svn path=/trunk/; revision=17459
2006-03-04 10:09:47 +00:00
Anders Broman ee72a05d9c Fix bug 786
There is error when ethereal dissects UMTS AMR codec info.
The "Initial Codec Mode" does not exist in 3GPP TS 26.103(v4.a.0)
but OM(Optimization Mode) is correct parameter.

svn path=/trunk/; revision=17458
2006-03-04 10:07:19 +00:00
Gerald Combs 2eadd89e0f Use intptr_t for int-to-pointer conversions.
svn path=/trunk/; revision=17457
2006-03-03 20:44:53 +00:00
Guy Harris 39ab0e77d7 Clean up white space.
Don't warn about a live capture format other than libpcap format if
you're not capturing to a file.

Do warn about a maximum capture file specification if you're not
capturing to a file.

svn path=/trunk/; revision=17456
2006-03-03 10:17:04 +00:00
Guy Harris 11d6f896b8 Squelch a compiler warning.
svn path=/trunk/; revision=17455
2006-03-03 10:14:27 +00:00
Jaap Keuter b812a6b0c5 ethereal-tut.mgp has a few problems:
* Written almost 6 years ago, some of the information is outdated.
* The referenced images are missing, so the presentation won't run.
The author agrees to remove it

svn path=/trunk/; revision=17454
2006-03-03 07:12:51 +00:00
Luis Ontanon 5380cea747 - make them work as the got broken while docommenting them.
svn path=/trunk/; revision=17453
2006-03-02 22:55:14 +00:00
Anders Broman 8d2bc60b91 The attached patch adds support for LAPD frames captured using vISDN thru
libpcap. The support has already been included in libpcap.

The patch adds a new wiretap encapsulation, the necessary glue to decode 
SLL-encapsulated frames, and some minor change in the LAPD dissector in order 
to support the remote-to-remote frames captured on the ISDN E-Channel.

Please apply ethereal-encap-table.diff before, as it fixes a misalignment in 
the encapsulation names table.

svn path=/trunk/; revision=17452
2006-03-02 21:31:33 +00:00
Anders Broman 9951fc2cff from Daniele Orlandi:
The attached patch adds support for LAPD frames captured using vISDN thru 
libpcap. The support has already been included in libpcap.

The patch adds a new wiretap encapsulation, the necessary glue to decode 
SLL-encapsulated frames, and some minor change in the LAPD dissector in order 
to support the remote-to-remote frames captured on the ISDN E-Channel.

Please apply ethereal-encap-table.diff before, as it fixes a misalignment in 
the encapsulation names table.

svn path=/trunk/; revision=17451
2006-03-02 21:29:15 +00:00