wireshark

osmith

wireshark

forked from osmocom/wireshark

Fork 0

Commit Graph

Author	SHA1	Message	Date
Guy Harris	db27fb777a	exceptions: make the exception handler stack per-thread. This prevents the weird failures I saw on macOS in #17856; instead, it should fail on all platforms with Unhandled exception ("epan/proto.c:8800: failed assertion "DISSECTOR_ASSERT_NOT_REACHED"", group=1, code=6) (which it does on macOS 11.6/Xcode 12.5.1 and Windows 10/VS 2019 16.11.8; according to https://en.wikipedia.org/w/index.php?title=Thread-local_storage&oldid=1064900318#C_and_C++ the major UNX C compilers support __thread and the major Windows C compilers support __declspec(thread).). @jvalverde: on branches that require C11/C++11 support, we could perhaps just use _Thread_local for C and thread_local for C++. Note that <thread.h> is optional in C11, and macOS 11.6/Xcode 12.5.1 does not appear to include it.) This does not fix* the aforementioned issue; to do that we need to do TRY in the register-dissectors thread code. I'm committing this separately because it fixes a bug in our exception package that could cause all sorts of randomness now and in the future - what we're doing now is Just Wrong. (Yes, there's code to support per-thread exception handler stacks on platforms with pthreads, but this is simpler and also works on Windows.)	2022-01-11 05:00:42 +00:00
João Valverde	d443197097	Prefer the portable _Noreturn attribute (C11) Use _Noreturn, available with C11, instead of vendor specific attributes. It's not compatible with C++ so we we must keep the old code for now.	2021-12-18 18:54:08 +00:00
João Valverde	ca06d7e4fe	Add an include sub-directory to the tree Blind attempt to fix Debian package brokenness managing headers separately from install rules. Global public headers that don't fit any of the Wireshark libraries should be placed in include/. Eventually the C files in the root dir should be placed somewhere else as well (like src/) but this is not a priority. Fixes #17726.	2021-11-12 17:33:13 +00:00

Author

SHA1

Message

Date

Guy Harris

db27fb777a

exceptions: make the exception handler stack per-thread.

This prevents the weird failures I saw on macOS in #17856; instead, it
should fail on *all* platforms with

    Unhandled exception ("epan/proto.c:8800: failed assertion "DISSECTOR_ASSERT_NOT_REACHED"", group=1, code=6)

(which it does on macOS 11.6/Xcode 12.5.1 and Windows 10/VS 2019
16.11.8; according to

https://en.wikipedia.org/w/index.php?title=Thread-local_storage&oldid=1064900318#C_and_C++

the major UN*X C compilers support __thread and the major Windows C
compilers support __declspec(thread).).

@jvalverde: on branches that require C11/C++11 support, we could perhaps
just use _Thread_local for C and thread_local for C++.  Note that
<thread.h> is optional in C11, and macOS 11.6/Xcode 12.5.1 does not
appear to include it.)

This does not *fix* the aforementioned issue; to do *that* we need to do
TRY in the register-dissectors thread code.  I'm committing this
separately because it fixes a bug in our exception package that could
cause all sorts of randomness now and in the future - what we're doing
now is Just Wrong.

(Yes, there's code to support per-thread exception handler stacks *on
platforms with pthreads*, but this is simpler *and* also works on
Windows.)

2022-01-11 05:00:42 +00:00

João Valverde

d443197097

Prefer the portable _Noreturn attribute (C11)

Use _Noreturn, available with C11, instead of vendor specific
attributes. It's not compatible with C++ so we we must keep
the old code for now.

2021-12-18 18:54:08 +00:00

João Valverde

ca06d7e4fe

Add an include sub-directory to the tree

Blind attempt to fix Debian package brokenness managing
headers separately from install rules.

Global public headers that don't fit any of the Wireshark
libraries should be placed in include/.

Eventually the C files in the root dir should be placed somewhere
else as well (like src/) but this is not a priority.

Fixes #17726.

2021-11-12 17:33:13 +00:00

3 Commits