Commit Graph

2923 Commits

Author SHA1 Message Date
Jörg Mayer 38d1c38e99 Include .h into .c to make sure declarations match.
Fix a copy/paste in the .h surrounding ifndef.
One char -> const char fix.

svn path=/trunk/; revision=15157
2005-07-30 16:28:00 +00:00
Jörg Mayer 44cbbf1039 Stefan Rompf:
Fix warnings of type:
proto.c:2219: warning: ISO C forbids conditional expr with only one void side


svn path=/trunk/; revision=15156
2005-07-30 16:15:23 +00:00
Jörg Mayer 54861853a8 More char -> const char warning fixes
svn path=/trunk/; revision=15155
2005-07-30 07:13:27 +00:00
Jörg Mayer bff3a762ca Create packet-dcom-cba-acco.h
svn path=/trunk/; revision=15154
2005-07-30 07:08:04 +00:00
Guy Harris 09b54bab84 Make dissect_CBA_Connection_Data again available for plugins (although
it should be declared in a header file, so that the plugins can #include
the header file rather than using a possibly-out-of-date private
declaration, and so that it's clearer that it shouldn't be static).

svn path=/trunk/; revision=15153
2005-07-30 02:44:20 +00:00
Jörg Mayer 54c470762a Fix 'isn't prototype' warning
svn path=/trunk/; revision=15152
2005-07-30 02:30:05 +00:00
Guy Harris e965cb849c Clean up some more const issues.
svn path=/trunk/; revision=15151
2005-07-30 02:22:22 +00:00
Guy Harris 8a78d60fd1 Get rid of another unused variable.
svn path=/trunk/; revision=15150
2005-07-30 02:20:59 +00:00
Guy Harris 5c78208855 Widen a variable, as a guint16 value is assigned to it; the upper 8 bits
might be irrelevant in this case, but we might as well not throw them
out.

Clean up some code that sets "cdata->flags".

svn path=/trunk/; revision=15149
2005-07-30 02:09:59 +00:00
Guy Harris e87d4d257b Get rid of some unused variables.
svn path=/trunk/; revision=15148
2005-07-30 02:07:36 +00:00
Guy Harris 0e69aab43b Declare the value_string tables as arrays of value_strings, not of
pointers to same, and make them "const" while we're at it.

svn path=/trunk/; revision=15147
2005-07-30 02:06:13 +00:00
Jörg Mayer 5602f5bb83 Make some funtions static. More char -> const char warning fixes
svn path=/trunk/; revision=15146
2005-07-30 01:01:02 +00:00
Jörg Mayer 29060b1082 Remove packet-fcse.h
svn path=/trunk/; revision=15145
2005-07-30 00:59:08 +00:00
Jörg Mayer cac3ee248a Declare many functions static, move the #defines from packet-fcse.h to
packet-fcse.c and remove packet-fcse.h


svn path=/trunk/; revision=15144
2005-07-30 00:55:30 +00:00
Gerald Combs 200ff9dc52 Pick up some fixes and enhancements from
http://cvs.fedora.redhat.com/viewcvs/rpms/ethereal/FC-4/:

In the LPD dissector, make lpd_client_code a value_string so that we
don't segfault.  Do the same for lpd_server_code, although it's not
strictly necessary.

Check to see if htmlview is installed, and use it as our HTML viewer.

The Fedora RPM has other patches, but I'm not sure if they should
be applied.


svn path=/trunk/; revision=15143
2005-07-29 21:55:45 +00:00
Ronnie Sahlberg e51caa85fb some more ememification of tvb_get_string()
svn path=/trunk/; revision=15142
2005-07-29 10:00:37 +00:00
Guy Harris 9055696e2b Suggest that perhaps displaying chunks in the chunked encoding with the
data dissector might be overkill, as it causes each of those chunks to
be dumped in hex in Tethereal output - along with whatever's done with
the data reassembled from those chunks.

svn path=/trunk/; revision=15141
2005-07-29 07:35:43 +00:00
Guy Harris 66a2801dfa Use "PROTO_ITEM_SET_GENERATED()" to mark generated items as such; it
takes care of the square brackets, etc..

svn path=/trunk/; revision=15140
2005-07-29 07:28:07 +00:00
Guy Harris 0c5af0dde6 If we do reassembly and hand the packet to the dissector, and the
dissector says "sorry, I need even more data in this packet", don't flag
that packet as being reassembled in that frame.  Indicate that we should
perhaps do all the "partial reassembly" stuff in
"fragment_set_partial_assembly()", which would obviate the need for the
hack in the TCP dissector.

Clean up indentation.

svn path=/trunk/; revision=15139
2005-07-29 07:14:32 +00:00
Guy Harris 70fb017866 Constify some variables, functions, and structure members to squelch
compiler warnings.

svn path=/trunk/; revision=15138
2005-07-29 03:49:23 +00:00
Guy Harris 8a44823f03 Constify some variables and arguments to squelch compiler warnings.
svn path=/trunk/; revision=15137
2005-07-29 03:48:03 +00:00
Guy Harris ce7154c78a Include <epan/emem.h> to declare ep_alloc().
svn path=/trunk/; revision=15136
2005-07-29 03:47:12 +00:00
Guy Harris c8fc6a8e76 Cast away some (otherwise unremovable, and harmless, in this case)
warnings.

svn path=/trunk/; revision=15135
2005-07-29 03:27:59 +00:00
Ronnie Sahlberg a2142fd8f1 more emeification of tvb_get_string()
svn path=/trunk/; revision=15133
2005-07-28 10:05:37 +00:00
Ronnie Sahlberg df2d1d3f22 ememify some more calls to tvb_get_string()
this fixes an obvious memleak in ms-mms


svn path=/trunk/; revision=15132
2005-07-28 09:56:19 +00:00
Ronnie Sahlberg 0d7a2abbc7 some more memification of tvb_get_string() no obvious memleaks fixed this time :-(
svn path=/trunk/; revision=15131
2005-07-28 09:47:28 +00:00
Ronnie Sahlberg 7035a45c8f ememify some more tvb_get_string() calls
one memleak in vnc related to tvb_get_string() closed.


svn path=/trunk/; revision=15130
2005-07-28 09:35:27 +00:00
Ronnie Sahlberg 69a6b59949 ememify the tvb_get_string() and tvb_fake_unicode() calls in tds
svn path=/trunk/; revision=15129
2005-07-28 09:20:56 +00:00
Ronnie Sahlberg 93c4543207 add an ep version of tvb_fake_unicode()
svn path=/trunk/; revision=15128
2005-07-28 08:55:11 +00:00
Ronnie Sahlberg 34c10c4c7e packet_ber has for some time been doing sanity checking of the BER Length fields
that they are not longer than the reported length of the tvb.

this triggers some bugs since in packet-ber we are a bit too lax in setting reported_length of the tvb_new_subset() tvb.

this cause short kerberos packets to not be decoded at all and the same for other short asn based packets as well.


fix some of these instances.


svn path=/trunk/; revision=15127
2005-07-28 08:18:18 +00:00
Jörg Mayer 34493e8f9e char -> const char warning fixes
svn path=/trunk/; revision=15126
2005-07-28 07:53:38 +00:00
Jörg Mayer f5b39c3ef9 Warning fixes
svn path=/trunk/; revision=15125
2005-07-28 07:51:52 +00:00
Guy Harris 3607e8299d Squelch another qualifier warning.
svn path=/trunk/; revision=15122
2005-07-27 18:38:35 +00:00
Jörg Mayer af5a9d1845 As Guy mentioned: last patch replaced one occurrence too many,
thus the dictionary keyword encrypt was changed from encrypt
to encrypted too. Undo this.

svn path=/trunk/; revision=15121
2005-07-27 18:15:07 +00:00
Jörg Mayer 575c75e5c1 The variable encrypt collides with the declaration in <unistd.h> on
some platforms. Rename encrypt to encrypted.

svn path=/trunk/; revision=15120
2005-07-27 17:52:51 +00:00
Gerald Combs fcd6156423 Move preference initialization to its own routine and make sure it gets run
when we pass "-G defaultprefs" on the command line.

svn path=/trunk/; revision=15119
2005-07-27 16:25:44 +00:00
Jörg Mayer 1fbacc90d3 Revert my previous patch - something else was seriously screwed up
svn path=/trunk/; revision=15118
2005-07-27 16:05:41 +00:00
Jörg Mayer 1a3afc844f gcc-4.0 (GCC) 4.0.2 20050720 (prerelease) (SUSE Linux)
fails when trying to use varargs. Due to a missing include
config.h we were using varargs with proto.h


svn path=/trunk/; revision=15117
2005-07-27 15:08:22 +00:00
Jörg Mayer e46478848e The latest patch used the fields
hf_qos_buf_ac, hf_qos_buf_load and hf_qos_buf_state
but failed to add them to the hf_ array. Commented out their
use for now.

svn path=/trunk/; revision=15116
2005-07-27 13:10:57 +00:00
Jörg Mayer f841f266ec Ankur Aggarwal:
IEEE 802.11 QoS decoding


svn path=/trunk/; revision=15115
2005-07-27 08:28:27 +00:00
Jörg Mayer b8d33c4add Fix >2600 warnings by doing char -> const char changes.
Additionally in dissectors/packet-ansi_map.c:
        Flag unused parameters as such and remove dummy
        param = param;
        statements.

svn path=/trunk/; revision=15114
2005-07-27 07:57:01 +00:00
Guy Harris d05a356383 Squelch another const warning.
svn path=/trunk/; revision=15111
2005-07-27 01:12:44 +00:00
Guy Harris 9b56028ade *Removing* an include is usally not the right way of removing warnings;
if some function takes, for example, a "char *" as an argument, but
you're passing it an "unsigned char *", you don't squelch the warning by
removing the include of the header that declares that function (you then
get warnings about the function not being declared, at least with some
compilers), you put in a cast (if the signedness doesn't matter) or
arrange that you pass a "char *".

svn path=/trunk/; revision=15110
2005-07-27 01:02:03 +00:00
Luis Ontanon 10844226cf Remove two warnings
svn path=/trunk/; revision=15109
2005-07-27 00:45:02 +00:00
Anders Broman bfdffc2c80 Rewrite of MAP_dialouge asn1 code, export and use of functions from gsm_map.
svn path=/trunk/; revision=15106
2005-07-26 20:42:07 +00:00
Gerald Combs 681825d9e9 Fixes from Gisle Vanem.
svn path=/trunk/; revision=15101
2005-07-26 19:11:31 +00:00
Luis Ontanon c5688891a1 new functions:
ep_tvb_memdup()
ep_alloc0()
ep_strsplit()

add all of the ep_ allocators to libethereal.def

svn path=/trunk/; revision=15100
2005-07-26 18:32:12 +00:00
Ulf Lamping 03fb862945 add "BadOutOfService" quality code
svn path=/trunk/; revision=15095
2005-07-26 18:02:42 +00:00
Gerald Combs de2803bc52 Don't add a new data source if we don't have any data.
svn path=/trunk/; revision=15089
2005-07-26 15:59:54 +00:00
Ronnie Sahlberg 9ed0d80bfc add iFCP ELS UNBIND dissection
svn path=/trunk/; revision=15087
2005-07-26 10:01:42 +00:00