Commit Graph

2733 Commits

Author SHA1 Message Date
Guy Harris e2d750eab5 Add a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness"
warnings.  Use SET_ADDRESS in the VOIP calls code, rather than
explicitly filling in "pstn_add".

svn path=/trunk/; revision=14867
2005-07-07 04:03:35 +00:00
Ulf Lamping 2f2ab41ea4 fix *several* dissector bugs, found by private fuzz-tests
svn path=/trunk/; revision=14861
2005-07-05 22:33:22 +00:00
Gerald Combs 8434647836 Call proto_tree_add_guid_hidden() for an FT_GUID value. Fixes bugs 274,
276, and 277.

svn path=/trunk/; revision=14859
2005-07-05 20:20:15 +00:00
Gerald Combs 276f179b0b Don't crash if we're handed a zero-length fragment. Fixes bug 272. Although
we don't crash now, we still don't handle zero-length fragments correctly.

svn path=/trunk/; revision=14858
2005-07-05 20:04:03 +00:00
Tomas Kukosa b579d77b9a GUID lowercase form seems to be preferred
svn path=/trunk/; revision=14855
2005-07-05 18:55:17 +00:00
Anders Broman 02a57cdfcc Add application/vnd.wv.csp.xml
svn path=/trunk/; revision=14854
2005-07-05 17:10:09 +00:00
Anders Broman 623f9057c1 From : David Frascone
These minor changes fix some errors, and add some messages to the LWAPP dissector.

svn path=/trunk/; revision=14851
2005-07-05 04:32:32 +00:00
Anders Broman 96389d268c Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again.
svn path=/trunk/; revision=14848
2005-07-04 19:07:02 +00:00
Tomas Kukosa cdb09b497a usage of FT_GUID field type in H.225 dissector
svn path=/trunk/; revision=14847
2005-07-04 13:19:58 +00:00
Tomas Kukosa b9703d0919 export of proto_tree_add_guid...() functions
svn path=/trunk/; revision=14846
2005-07-04 13:13:07 +00:00
Tomas Kukosa bab34b522b new field type FT_GUID
svn path=/trunk/; revision=14845
2005-07-04 13:04:53 +00:00
Tomas Kukosa 5f2fd433ab - use tvb instead of offset and length in dissect_per_octet_string() for value returning
- asn2eth: #.FN_PARS support for OCTET STRING
- usage of #.FN_PARS in h225 and h245
- h225: ParallelH245Control support
- h245: better support of NonStandardParameter
- usage of MAX_OID_STR_LEN constant
- all PER dissectors regenerated

svn path=/trunk/; revision=14844
2005-07-04 09:35:25 +00:00
Guy Harris 828641b2ad Mark stub data as such if no dissector claims it.
svn path=/trunk/; revision=14842
2005-07-04 03:45:29 +00:00
Anders Broman 8a448fade7 Add an exported value string
svn path=/trunk/; revision=14840
2005-07-03 21:20:27 +00:00
Anders Broman 2d264e4314 Add an exported value string
svn path=/trunk/; revision=14839
2005-07-03 21:19:49 +00:00
Anders Broman 6671c5b15d Change gsm_a.c to use value strings in some places in preparation to use it from packet-uma.c and gsm_map.
Some bug fixes to packet-uma.c

svn path=/trunk/; revision=14838
2005-07-03 20:33:06 +00:00
Anders Broman efc7044f35 Add packet-mms.h
svn path=/trunk/; revision=14837
2005-07-03 12:01:11 +00:00
Ronnie Sahlberg 3440ba76fc New protocol :
MMS    Manufacturing Message Specification


svn path=/trunk/; revision=14836
2005-07-03 06:08:53 +00:00
Ronnie Sahlberg 50f4e721ce export a few more symbols from acse
svn path=/trunk/; revision=14835
2005-07-03 05:28:12 +00:00
Guy Harris 8b8f22ec94 Note that the MPLS extension dissector will misdissect ICMP packets that
contain more than 128 bytes of the original datagram.  (Yes, RFC 1812
and the ICMP Extensions for MPLS draft collide here, as the draft in
question notes.)

svn path=/trunk/; revision=14834
2005-07-03 00:52:08 +00:00
Michael Tüxen 3b62802faa Use brackets instead of parentheses for the checksum info, which is generated.
svn path=/trunk/; revision=14833
2005-07-02 21:16:17 +00:00
Guy Harris a42c4bc656 Have separate fields for NFSv2, NFSv3, and NFSv4 return statuses, using
the names in the v2, v3, and v4 specs for values, so that they display
correctly and can be filtered on correctly.

Have "nfs.status" as a hidden field, with a name table giving just "OK"
and "ERR_" values, and having items for v2, v3, and v4 status values
(the only collision is that the v3 JUKEBOX error is the v4 DELAY error),
so that filters on "nfs.status" will still work, but will now be able to
filter symbolically on values from v2, v3, and v4.

Show 33 status values in the Info column and the summary entry using the
table of v3 status values and names, not the table of v2 status values
and names.

Fix some v3 dissectors to use the v3 return status field rather than the
v2 return status field.

svn path=/trunk/; revision=14831
2005-07-02 08:18:17 +00:00
Ulf Lamping 2ce8d2a30f fixed various issues (two serious ones) found by "private" fuzz-testing
svn path=/trunk/; revision=14830
2005-07-01 21:04:13 +00:00
Tomas Kukosa abc732f855 beter displaying of true/false strings in dissect_ber_bitstring()
svn path=/trunk/; revision=14828
2005-07-01 13:48:52 +00:00
Ulf Lamping dd1287fc71 add some more information to the DCE/RPC packet details summary line
svn path=/trunk/; revision=14827
2005-06-30 22:51:17 +00:00
Ulf Lamping 3d831f4bfb add a new DCE/RPC related column, which contains the call_id for connection oriented packets or the sequence number for connectionless (datagram) packets.
This is extremely useful, to keep track of the corresponding request/response packets of a DCE/RPC call (which can be quite a lot packets if fragmentation is used).

svn path=/trunk/; revision=14826
2005-06-30 22:46:19 +00:00
Ronnie Sahlberg 19409dc44f fix a bug in the conformance file for CMIP to make it compile again
(semi-recent changes to asn2eth and PARAM handling makes us have to use double %% in some BODY statements)

at the same time, regenerate it so it also benefit from bugfixes to handling of indefinite length



svn path=/trunk/; revision=14823
2005-06-30 07:48:25 +00:00
Guy Harris 324bed3029 If only part of an entry in an object fits in the object, don't report
the stuff that didn't fit as a negative number of junk bytes.

The difference between two pointers isn't guaranteed to have a
particular size; cast it to "long" and display it with "%ld".

svn path=/trunk/; revision=14821
2005-06-29 23:19:21 +00:00
Ronnie Sahlberg c7c28d5112 from
Maria-Luiza Crivat and
Brice Augustin

ICMP MPLS extensions


svn path=/trunk/; revision=14818
2005-06-29 10:39:09 +00:00
Ronnie Sahlberg 54b0d37892 fix a typo for the name of a bit
svn path=/trunk/; revision=14817
2005-06-29 08:11:23 +00:00
Ulf Lamping 1c13be2c9c make dissect_CBA_Connection_Data available for plugins
svn path=/trunk/; revision=14816
2005-06-29 08:06:07 +00:00
Ulf Lamping 2cecaba970 add references to the corresponding request of datagram ping and ack packets
svn path=/trunk/; revision=14815
2005-06-29 08:03:06 +00:00
Ronnie Sahlberg 226c5a56ab be more careful when attempting to dissect an unknown ber field not to read beyond the end and triggering a [malformed packet]
also prettify the error when finding "unknown" entries inside a SEQUENCE to make it easier to track down what went wrong.



svn path=/trunk/; revision=14814
2005-06-29 08:00:55 +00:00
Guy Harris 6e1081bf45 Squelch a compiler warning.
svn path=/trunk/; revision=14813
2005-06-28 22:39:56 +00:00
Guy Harris 7556ea3783 Declare "decrypt_krb5_data()" for use by the KINK dissector.
svn path=/trunk/; revision=14809
2005-06-28 21:25:56 +00:00
Anders Broman 359ada1199 Fix to SendAuthenticationInfoRes
svn path=/trunk/; revision=14808
2005-06-28 21:14:59 +00:00
Gerald Combs 7f2a239179 Add missing commas.
svn path=/trunk/; revision=14804
2005-06-28 14:46:47 +00:00
Gerald Combs 4c6c39effd Terminate a bunch of value_strings.
svn path=/trunk/; revision=14803
2005-06-28 14:02:21 +00:00
Ronnie Sahlberg 12c3955d1f addition of NBS9
and bugfix for FTAM where we sometimes forgot to check if the tag was implicit.


svn path=/trunk/; revision=14802
2005-06-28 11:23:56 +00:00
Ronnie Sahlberg 52b8c407c7 regenerate FTAM with the bugfix for GraphicString in asn2eth
svn path=/trunk/; revision=14801
2005-06-27 20:45:02 +00:00
Ronnie Sahlberg 05f9375d55 fix two bugs when updating offset incorrectly that could lead to an infinite loop when trying to decode an unknown ber structure
svn path=/trunk/; revision=14799
2005-06-27 11:43:18 +00:00
Ronnie Sahlberg 6838ce2807 remove a \n in the preference string to prevent it from creating a garbage/invalid preference file entry.
svn path=/trunk/; revision=14798
2005-06-27 11:06:40 +00:00
Anders Broman fa7c5d4aac Missed from previous commit.
svn path=/trunk/; revision=14797
2005-06-27 08:55:39 +00:00
Ronnie Sahlberg 77823f61bc some implementations do provide a CRC in the FCIP frame so skip the
'test for zero' check.
the heuristics are probably strong enough even without this check.



svn path=/trunk/; revision=14796
2005-06-27 08:27:49 +00:00
Ronnie Sahlberg b913b8f3bf From Chris Bontje
DNP3 Application Layer Object dissection


svn path=/trunk/; revision=14794
2005-06-27 08:12:55 +00:00
Guy Harris 81466a539e The name returned by "get_dns_name()" (and thus by
"get_dns_name_type_class()") is null-terminated - and the length
returned is *NOT* the length of the string, it's the length of the chunk
of DNS data extracted by "get_dns_name()", and that chunk could just
point to a later chunk as part of DNS compression.  When running the
name through "format_text()", just use "strlen()" to get the length, so
you don't get a value that's too large *OR* too small (both are
possible - "too large" if it's uncompressed and includes length
informatioin, "too small" if it contains a pointer to a string longer
than the pointer).

When adding a string value to the protocol tree, add the *raw* name, not
the formatted name - the Ethereal display code will format the string's
value as necessary.

Add formatting code for DNS names in replies.

svn path=/trunk/; revision=14793
2005-06-27 07:50:11 +00:00
Anders Broman e37467eb29 From Alejandro Vaquero
new dissector for the AudioCodes trunk trace protocol. 
This protocol is used to debug the trunk protocol in AudioCodes 
gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, 
etc...) trunk protocols. It also add these protocols in the "Voip Calls 
Graph..."

svn path=/trunk/; revision=14790
2005-06-27 06:21:51 +00:00
Guy Harris 89e823ea4f Yet more constification.
svn path=/trunk/; revision=14788
2005-06-26 21:11:22 +00:00
Guy Harris b50dd72e2a More constification.
svn path=/trunk/; revision=14787
2005-06-26 20:39:21 +00:00
Guy Harris ab797734dd Get rid of the private "my_match_strval()" routine in many dissectors;
add a "match_strval_idx()" routine that does the same thing, and have
"match_strval()" call it.

Make those routines, and "val_to_str()", return a "const" pointer. 
Update dissectors as necessary to squelch compiler warnings produced by
that.

Use "val_to_str()" rather than using "match_strval()" and then, if the
result is null, substituting a specific string.  Clean up some other
"match_strval()"/"val_to_str()" usages.

Add a null pointer check in the NDPS dissector's "attribute_value()"
routine, as it's not clear that "global_attribute_name" won't be null at
that point.

Make some global variables in the AFS4INT dissector local.

Make some routines not used outside the module they're in static.

Make some tables "static const".

Clean up white space.

Fix Gerald's address in some files.

svn path=/trunk/; revision=14786
2005-06-26 19:56:52 +00:00