Commit graph

4952 commits

Author SHA1 Message Date
Jaap Keuter
846331e8a6 Fix Ethereal bug 1004. Make UDP dissector work on top of IPv6 by filling in pinfo fields correctly.
svn path=/trunk/; revision=18574
2006-06-25 12:15:35 +00:00
Ronnie Sahlberg
139b870383 restore display of optional field names when the optional bit is displayed in the tree
svn path=/trunk/; revision=18573
2006-06-24 12:03:24 +00:00
Ronnie Sahlberg
c72123bf4b coverity 197 dead code
svn path=/trunk/; revision=18572
2006-06-24 11:50:47 +00:00
Ronnie Sahlberg
ee469dc8ea coverity 149 dead code
svn path=/trunk/; revision=18571
2006-06-24 05:45:06 +00:00
Ronnie Sahlberg
0911f08cb2 change a parenthesis
svn path=/trunk/; revision=18570
2006-06-24 05:39:38 +00:00
Ronnie Sahlberg
b945d54c9f remove some dead code coverity 17
svn path=/trunk/; revision=18567
2006-06-24 00:01:33 +00:00
Ronnie Sahlberg
617227fe2a change a comment to #if to make it clearer the code is disabled
svn path=/trunk/; revision=18566
2006-06-23 23:51:55 +00:00
Ronnie Sahlberg
2258dfd5a9 coverity 172
remove a dead code condition


svn path=/trunk/; revision=18565
2006-06-23 23:44:17 +00:00
Ulf Lamping
f62e617029 fix the reading of UUID's from the Win32 registry, it was broken as we switched to UNICODE compilation
I thought there was a bugzilla entry about this, but couldn't find it

svn path=/trunk/; revision=18561
2006-06-23 18:06:54 +00:00
Ronnie Sahlberg
142763b216 coverity 174
ifdef out a few lines of dead code for a feature that is not yet finished

remove two compiler warnings about uninitialized variables (they are not uninitialized, just gcc being dumb)



svn path=/trunk/; revision=18558
2006-06-23 12:04:00 +00:00
Ronnie Sahlberg
cd65440deb coverity 190
remove some dead code


svn path=/trunk/; revision=18557
2006-06-23 09:27:17 +00:00
Ronnie Sahlberg
143f429c61 remove some dead code
coverity 191

svn path=/trunk/; revision=18556
2006-06-23 09:15:20 +00:00
Ronnie Sahlberg
332df10d7e coverity warning 177 deadcode
replace overly convoluted code with much simpler code.

stateid is a simple 16 byte structure and there is no need to make it more complex than it is.



svn path=/trunk/; revision=18555
2006-06-23 09:02:54 +00:00
Guy Harris
f6f7bd756d The joys of the C switch statement - you have to remember to use
"break;" between cases except in those rare situations where you *want*
fallthrough.

svn path=/trunk/; revision=18550
2006-06-22 21:55:24 +00:00
Ulf Lamping
efb558955d add another PROFINET specific subtype (5:CHASSIS_MAC)
svn path=/trunk/; revision=18549
2006-06-22 19:19:41 +00:00
Ronnie Sahlberg
946a39d4fc the dissector for AssertionValue that is implemented in the template file
did not check the implicit_tag flag and caused extensiblematch filters to show up as malformed packets.




svn path=/trunk/; revision=18540
2006-06-22 10:29:49 +00:00
Jaap Keuter
a41dc5d874 Initial fix for bug 974. It does implement RSP header decoding, it lacks RSP trailer decoding. ASF 2.0 messages added to ASF decoder .
svn path=/trunk/; revision=18539
2006-06-22 00:07:46 +00:00
Anders Broman
67f84666c1 Put the correct IE names in GTPv1 messages.
svn path=/trunk/; revision=18538
2006-06-21 20:51:55 +00:00
Ulf Lamping
5e62ced7e3 comment out the "catapult_dct2000_board_ports_only" part, so the Win32 buildbot has at least a chance to compile again
This is really not the preferred solution, but the current situation is even more ugly.

svn path=/trunk/; revision=18537
2006-06-21 20:34:28 +00:00
Jaap Keuter
036661ed3d Somewhat improve heuristic when SIP is encapsulated in another protocol.
svn path=/trunk/; revision=18531
2006-06-21 17:57:10 +00:00
Ronnie Sahlberg
f27bb044dd two things have irritated me immensly with nfs filehandles
1, (minor) the heuristics are too weak and everyting is always decoded either as netapp filehandles or one of the others   even when just capturing ibetween say two classic unix boxens
2, (major) you can not filter on specific subfields of the filehandle


observation: 5 people or less in the world care about implementation specific storage of data inside an opaque blob.


remove the too weak heuristics for nfs filehandles.
make decoding of filehandles accorrding to specific implementations controlled by a preference setting.
default this setting to "unknown"

display unknown filehandles using proto_tree_add_item()  FT_BYTES/BASE_HEX to make it fitlerable instead of a useless proto_tree_add_text()


wiki needs to be updated tomorrow


svn path=/trunk/; revision=18530
2006-06-21 09:45:50 +00:00
Ulf Lamping
53a3dd33e7 update PROFINET port2/3 status text
svn path=/trunk/; revision=18529
2006-06-21 07:30:11 +00:00
Ulf Lamping
df377ffcc5 fix a comment
svn path=/trunk/; revision=18527
2006-06-21 07:26:39 +00:00
Gerald Combs
f7e38bd5e6 Change ETH_VAR_IMPORT to WS_VAR_IMPORT. Try to fix a duplicate variable
definition in the Catapult DCT2000 code.

svn path=/trunk/; revision=18524
2006-06-20 18:30:54 +00:00
Ronnie Sahlberg
797bb2d5d7 for iscsi traces where there is a lot of packetloss the dissector frequently gets out of sync
and the weak heuristics often cause wireshark to mistake some segment containing read/write data to be iscsi.


make the heuristics to check that a packet really is iscsi much stronger


svn path=/trunk/; revision=18523
2006-06-20 13:16:50 +00:00
Anders Broman
0e1b053f82 From Albert Chin:
This fixes a redefine of AF_INET6 on AIX 4.3.3. We pull in <sys/socket.h> so the OS can define it first, nullifying the #define in epan/inet_v6defs.h.

svn path=/trunk/; revision=18522
2006-06-20 05:59:55 +00:00
Anders Broman
c72d4e8f2e From Albert Chin:
Fix some C++ comments in C source files and fixes some non-constant initializations.

svn path=/trunk/; revision=18521
2006-06-20 05:57:29 +00:00
Anders Broman
d327d37e82 Fix Ethereal bug 994 in Wireshark:
MIP Advertisement reverse tunneling flag not dissected

svn path=/trunk/; revision=18520
2006-06-19 15:54:13 +00:00
Anders Broman
764e3ac167 New rutine tvb_format_text_wsp() which will change "whiite space" characters to space
before output.

svn path=/trunk/; revision=18519
2006-06-19 15:53:03 +00:00
Ronnie Sahlberg
c71d5ef7cb coverity 195
remove a redundant check for str==NULL
since str can never be NULL here


svn path=/trunk/; revision=18517
2006-06-19 10:18:42 +00:00
Ronnie Sahlberg
75030295d1 add tracking of TID -> sharenames
reuse the recent structure for fid->filename mappings since the problemspace is virtually the same


(go to tired of trying to find the sharename in 10mpacket traces with 1000s of shares)



svn path=/trunk/; revision=18516
2006-06-19 09:44:15 +00:00
Ronnie Sahlberg
15c935b535 make fid->filename tracking work for files opened with NTCreateAndX
This needs to be done for all other Create/Open calls as well but would notmally just be 6 lines tyo add.

I rarely see older methods to open files   so others using older clients are encoraged to use these 6 lines to the other places where needed.




svn path=/trunk/; revision=18515
2006-06-19 07:41:09 +00:00
Ronnie Sahlberg
986085204d add infrastructure to make tracking of fid->filename easy to implement and use
svn path=/trunk/; revision=18514
2006-06-19 07:39:19 +00:00
Ronnie Sahlberg
d76b58cbfb track smb FIDFs when tehy are opened and closed.
add an expansion to the fid that display which frame itr was opened in and when it was closed.



someone may want to add tracking of actual filenames here as well.   i am not sure i need that feature myself   so ...



svn path=/trunk/; revision=18512
2006-06-18 05:45:40 +00:00
Ronnie Sahlberg
ab54bfdf50 include emem.h
svn path=/trunk/; revision=18508
2006-06-18 05:15:55 +00:00
Ronnie Sahlberg
533be475fc include emem.h
svn path=/trunk/; revision=18507
2006-06-18 05:14:45 +00:00
Ronnie Sahlberg
a5db166102 rename add_fid() to dissect_smb_fid() as a firsdt step towards adding tracking of filename/openedframe/closedframe tracking for smb fids
svn path=/trunk/; revision=18506
2006-06-18 01:58:34 +00:00
Ronnie Sahlberg
9b67217fb5 ethereal to wireshark changes
svn path=/trunk/; revision=18499
2006-06-17 12:04:30 +00:00
Ronnie Sahlberg
0c222fdbd0 ethereal to wireshark change
svn path=/trunk/; revision=18498
2006-06-17 12:00:41 +00:00
Ronnie Sahlberg
9647ea21f8 ethereal to wireshark change
svn path=/trunk/; revision=18497
2006-06-17 11:57:26 +00:00
Ronnie Sahlberg
85f49f1d49 fix for coverity 182
this bug can not currently trigger    but if someone would rename the module
in the future then this could potentially cause a null dereference.



svn path=/trunk/; revision=18494
2006-06-17 11:11:34 +00:00
Ronnie Sahlberg
847090fe54 fix coverity 188
at the same time, get rid of some unused parameter compiler warnings


svn path=/trunk/; revision=18493
2006-06-17 10:47:10 +00:00
Ronnie Sahlberg
d8e1827401 allocate the correct size of buffer to store the itlq structure for scsi
we used the wrong size which caused emem to complain that the canary value had been stomped upon.

another win for the canary feature.  thanks gerald


svn path=/trunk/; revision=18491
2006-06-17 08:40:14 +00:00
Ronnie Sahlberg
2849771e3d make ndmp track itl structures
everytime a ndmp_[scsi|tape]_open is seen   create a new itl

we need an itl structure to be able to know what commandset a certain device is using.




svn path=/trunk/; revision=18490
2006-06-17 08:22:03 +00:00
Ronnie Sahlberg
cea0653059 we need a itl structure to decode a scsi cdb properly.
make dissect_scsi_cdb abort with an assert if called with a null pointer for itl.

This means scsi over ndmp will be aborted by an assert sicne ndmp passes a null pointer here always but at least is better than a segv since some cdb's require itl to decode properly.


next checkin will fix ndmp in this regard.



svn path=/trunk/; revision=18489
2006-06-17 05:42:55 +00:00
Guy Harris
535a8bd006 Not all UN*Xes have MAP_ANONYMOUS; some have MAP_ANON instead, and some
have neither.  For those with MAP_ANON but not MAP_ANONYMOUS, use
MAP_ANON; for those with neither, add some code to use "/dev/zero".

svn path=/trunk/; revision=18488
2006-06-17 02:31:56 +00:00
Jaap Keuter
2288c8590d From Albert Chin
HP-UX doesn't have MAP_ANON but it does have MAP_ANONYMOUS. Moreoever,
according to mmap(2) on RHEL:
       MAP_ANONYMOUS
              The mapping is not backed by any file; the fd and offset argu-
              ments are ignored.  This flag in conjunction with MAP_SHARED is
              implemented since Linux 2.4.

       MAP_ANON
              Alias for MAP_ANONYMOUS. Deprecated.


svn path=/trunk/; revision=18486
2006-06-16 21:30:58 +00:00
Guy Harris
2d20359c26 Include <epan/dissectors/packet-tcp.h> to declare tcp_dissect_pdus().
svn path=/trunk/; revision=18483
2006-06-16 07:18:25 +00:00
Guy Harris
753aa36dbf "proto_tree_add_text()" supports printf-style formats; there's no need
to format into a buffer and then pass that buffer.

Make a count an "int" rather than a "size_t" to squelch a (valid)
compiler warning.

svn path=/trunk/; revision=18482
2006-06-16 07:17:00 +00:00
Anders Broman
c19f6b2d97 gsm_a: Dissect LLC
Q.931: Add Bit 8 first in Bearer Cap IE

svn path=/trunk/; revision=18477
2006-06-15 21:14:26 +00:00