osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
37,305 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

113 Commits

Author SHA1 Message Date
Anders Broman 6eae60aa2f From Yaniv Kaul: 
Fix 'set but not used' errors that GCC 4.6 emits.

svn path=/trunk/; revision=36874
 2011-04-26 20:24:53 +00:00
Bill Meier 91991145de Don't assign to a proto_item * if the value won't be used: Coverity 858; 
Fix two cases where items appear to be added to the wrong tree: Coverioty 856 & 857.
Also: remove some unneeded #includes& do some whitespace cleanup.

svn path=/trunk/; revision=36473
 2011-04-05 15:33:56 +00:00
Anders Broman aaf0d277b8 Get rid of gsm_a_dtap_pinfo. 
svn path=/trunk/; revision=36444
 2011-04-04 14:49:14 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman 72b69aeaf5 Change the msg_fcn() signature to include pinfo. 
svn path=/trunk/; revision=36441
 2011-04-04 07:45:34 +00:00
Stig Bjørlykke c9468a80be Added some missing breaks. 
Coverity 443 & 444.

svn path=/trunk/; revision=36361
 2011-03-27 13:40:54 +00:00
Anders Broman 23400cd7a3 Add dissection of 
- MBMS-SESSION-STOP-REQUEST
- MBMS-SESSION-STOP-RESPONSE
- MBMS-SESSION-UPDATE-REQUEST
- MBMS-SESSION-UPDATE-RESPONSE
- PS-HANDOVER-COMPLETE
- PS-HANDOVER-CANCEL
- PS-HANDOVER-COMPLETE-ACK

svn path=/trunk/; revision=36195
 2011-03-15 06:03:58 +00:00
Anders Broman 338f238746 Add dissection of 
- MBMS-SESSION-START-REQUEST
- MBMS-SESSION-START-RESPONSE

svn path=/trunk/; revision=36186
 2011-03-14 07:15:25 +00:00
Anders Broman 840b816f05 Remove more obsolete code. 
svn path=/trunk/; revision=36154
 2011-03-07 11:56:21 +00:00
Anders Broman 6c47c809ef Fix packet-bssgp.c:125: warning: 'hf_bssgp_tmsi_ptmsi' defined but not used 
svn path=/trunk/; revision=36153
 2011-03-07 10:01:24 +00:00
Anders Broman a7e379499d Remove the old code. 
svn path=/trunk/; revision=36152
 2011-03-07 09:36:24 +00:00
Anders Broman b4941ca580 Prepare to remove old bssgp code by changing exports. 
svn path=/trunk/; revision=36142
 2011-03-06 09:42:41 +00:00
Anders Broman 7e17176c39 All messages converted to the "GSM style" dissection. 
svn path=/trunk/; revision=36137
 2011-03-04 12:57:55 +00:00
Anders Broman a469849210 From Pascal Quantin: 
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
 2011-02-22 11:56:10 +00:00
Jeff Morriss 34dc101fcb #if out some (currently) unused functions. 
svn path=/trunk/; revision=36000
 2011-02-18 17:38:46 +00:00
Anders Broman 29ddaec6a6 Add more MSG dissection. 
svn path=/trunk/; revision=35998
 2011-02-18 07:00:03 +00:00
Gerald Combs dae5200002 Fix some Visual C++ analysis warnings. 
svn path=/trunk/; revision=35988
 2011-02-17 23:00:34 +00:00
Anders Broman daf631cce8 packet-bssgp.c:10020: warning: 'bssgp_perform_loc_response' defined but not used 
svn path=/trunk/; revision=35738
 2011-01-31 23:00:11 +00:00
Anders Broman 882874e91c More IE dissection. 
svn path=/trunk/; revision=35736
 2011-01-31 22:25:19 +00:00
Anders Broman 7a78a180c7 Dissect more IE's in PERFORM-LOCATION-REQUEST. 
svn path=/trunk/; revision=35721
 2011-01-31 15:16:45 +00:00
Guy Harris 0e2361fdb8 Clean up white space. 
Use the bssgp_perform_loc_request() routine for PERFORM-LOCATION-REQUEST
(fixes a "defined, but not used" warning).

svn path=/trunk/; revision=35714
 2011-01-31 00:12:21 +00:00
Anders Broman f4fad72618 Add more MSG dissection. 
svn path=/trunk/; revision=35707
 2011-01-30 22:08:22 +00:00
Anders Broman 7e77c162b0 Fix a typo and prettify some printouts. 
svn path=/trunk/; revision=35677
 2011-01-27 11:23:22 +00:00
Stephen Fisher 53fec4ae34 Fix compilation errors 
svn path=/trunk/; revision=35673
 2011-01-26 23:11:08 +00:00
Anders Broman 68f4f61017 Dissect PS-HANDOVER-REQUEST. 
svn path=/trunk/; revision=35666
 2011-01-26 19:44:23 +00:00
Gerald Combs 73a08a9b17 Fix gcc compilation. 
svn path=/trunk/; revision=35650
 2011-01-25 18:43:43 +00:00
Anders Broman 43ba2ecef7 Switch more messages over to the "gsm dissector style". 
svn path=/trunk/; revision=35649
 2011-01-25 16:41:59 +00:00
Anders Broman feea97e6aa packet-bssgp.c:6916: warning: 'bssgp_tree' may be used uninitialized in this function 
svn path=/trunk/; revision=35581
 2011-01-19 09:49:36 +00:00
Anders Broman 3c491eee6b Cleaned up splitt between old and new dissection style. 
A lot of conversion still needed.

svn path=/trunk/; revision=35580
 2011-01-19 09:35:34 +00:00
Bill Meier 8d272fb165 (Until Anders comletes work): use #if 0 instead of //; init a variable; 
svn path=/trunk/; revision=35571
 2011-01-17 16:51:31 +00:00
Jeff Morriss b2c0cfa9dd Move assignment of 'oct' outside of if(tree)--it is used outside of the if block. 
svn path=/trunk/; revision=35550
 2011-01-16 04:38:59 +00:00
Anders Broman 1f19cd8f1b Comitting work in progress to fix the linking problem. 
>Linking fails now:
>epan/.libs/libwireshark.so: undefined reference to `hf_bssgp_elem_id'
>epan/.libs/libwireshark.so: undefined reference to `bssgp_elem_fcn'
>epan/.libs/libwireshark.so: undefined reference to `ett_bssgp_elem'
>epan/.libs/libwireshark.so: undefined reference to >`bssgp_elem_strings'
>Did you miss packet-bssgp.c in that commit?

I'll try to clean this up in the next few days.

svn path=/trunk/; revision=35544
 2011-01-15 23:13:28 +00:00
Anders Broman f01cbcd296 Add cause values. 
svn path=/trunk/; revision=34685
 2010-10-29 15:19:47 +00:00
Bill Meier 05168e614f Access several large value-string arrays via extended value-string functions. 
svn path=/trunk/; revision=34501
 2010-10-13 18:51:23 +00:00
Bill Meier e7568712ef Define some fcns & vars as static; 
Minor whitespace and comments cleanup.

svn path=/trunk/; revision=34477
 2010-10-11 19:00:55 +00:00
Anders Broman d7e6928096 Add PDUs to value_string. 
svn path=/trunk/; revision=34266
 2010-09-27 20:09:08 +00:00
Anders Broman 21aa009150 From Holger Freyther: 
Cosmetic patch to fix Optional/Conditional mismatch.

svn path=/trunk/; revision=33226
 2010-06-15 13:36:11 +00:00
Guy Harris 1b444c55fd Refer to the endianness arguments as "encoding" rather than 
"representation" - we already use "representation" to refer to the text
representation of fields.

Change some routines with an endianness argument to make it a
representation argument instead; 

svn path=/trunk/; revision=32929
 2010-05-24 06:06:17 +00:00
Guy Harris 67c095e188 Use REP_BIG_ENDIAN for integral data types not already using REP_ 
(they're one-byte, so the byte order is irrelevant, but it's probably a
bit cleaner to use REP_*_ENDIAN for all integral data types), and REP_NA
for the top-level protocol item.

svn path=/trunk/; revision=32924
 2010-05-24 02:54:08 +00:00
Guy Harris 313b3edf0a Get rid of private byte-order definition. The definition didn't match 
the name - a non-zero last argument to proto_tree_add_item(), such as
TRUE or REP_LITTLE_ENDIAN, means "little-endian", and a zero argument,
such as FALSE or REP_BIG_ENDIAN, means "big-endian"; at least as I read
the spec, little-endian is correct, but the wrong definition's been used
for a while, so we'll use REP_BIG_ENDIAN.

svn path=/trunk/; revision=32923
 2010-05-24 02:28:16 +00:00
Anders Broman 447faa6082 From Mike Morrin: 
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712

svn path=/trunk/; revision=32606
 2010-04-29 20:45:53 +00:00
Bill Meier 055dd62063 #include <string.h> not needed. 
svn path=/trunk/; revision=32410
 2010-04-06 21:14:01 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h> 
svn path=/trunk/; revision=32367
 2010-04-03 21:55:23 +00:00
Stig Bjørlykke 86a6a0c2a4 Use a more correct length for hf_bssgp_ie_type and hf_bssgp_bvci, 
to try fixing a buildbot run-randpkt failure.

svn path=/trunk/; revision=31509
 2010-01-12 21:25:35 +00:00
Gerasimos Dimitriadis 18d299b758 - Replaced get_start_octet() with a right shift 
- Deleted function bssgp_tvb_get_bits8(), uses tvbuff counterpart now
- guint32 vars should be enough for bit offsets

svn path=/trunk/; revision=30963
 2009-11-14 21:15:38 +00:00
Anders Broman f8a37ac1d6 Make it possible to use bssgp.tlli as custom column. 
Remove COL_BSSGP_TLLI and CHECK_COL.

svn path=/trunk/; revision=29543
 2009-08-24 20:54:25 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining() 
svn path=/trunk/; revision=29446
 2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check 
svn path=/trunk/; revision=29344
 2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548: 
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
 2009-06-18 21:30:42 +00:00