Commit graph

996 commits

Author SHA1 Message Date
Ronnie Sahlberg
349c5a8699 from metze
various bugfixes and enhancements to decryption of secure ldap


svn path=/trunk/; revision=13710
2005-03-11 09:31:11 +00:00
Guy Harris
009de7a662 From Alexandro Vaquero:
fix the call to "rtp_add_address()" to match the new signature;

	fix a problem with the codec displayed in the "Voip Graph"
	for H245 "RequestMode" messages.

svn path=/trunk/; revision=13709
2005-03-11 03:05:57 +00:00
Guy Harris
6db3fe1e96 Just use "tvb_format_text()" to handle strings - don't roll our own
routine to handle that.
 
Don't format the value text into a buffer; just use
"proto_item_append_text()", so we don't run the risk of overflowing the
buffer.

Use "ip_to_str()" to format an IP address - don't roll our own code to
handle that.

Don't make "is_fhss" global - that causes its value to depend on the
last packet dissected, which isn't necessarily the right value for the
packet being dissected.

svn path=/trunk/; revision=13707
2005-03-11 01:35:02 +00:00
Jörg Mayer
0f764ba58a Warning fix: no newline at end of file
svn path=/trunk/; revision=13701
2005-03-10 21:04:34 +00:00
Luis Ontanon
008054453b From Alejandro Vaquero:
- Automatic dissection of RTP events (RFC2833) set in SDP sessions.
- Add RTP events (RFC2833) to the Voip Graph


svn path=/trunk/; revision=13697
2005-03-10 19:32:22 +00:00
Ronnie Sahlberg
8700645d54 add support to decrypt and dissect sign-and-sealed traffic.
(cifs: dc's talking to eachother   and when longhorn comes out: anyone wanting to talk dce to a dc!)

((this is an incredibly advanced feature well worthy of mentioning in NEWS))


svn path=/trunk/; revision=13690
2005-03-10 10:16:49 +00:00
Ronnie Sahlberg
1564a2d2d3 add two nice defines for how to decrypt a GSSKRB tvb
dce has slightly different padding and checksumming so we have to tell decrypt_arcfour() about it.



svn path=/trunk/; revision=13689
2005-03-10 08:52:59 +00:00
Ronnie Sahlberg
0180d280fe change the signature for the functions to decrypt data for the
dcerpc_auth_subdissector_fns structure.

the SignAndSeal decryption (which works really well) needs this.



svn path=/trunk/; revision=13688
2005-03-10 08:50:18 +00:00
Ulf Lamping
2f73c1d242 removed some MSVC compiler warnings, mostly I've casted "downsized function parameters"
svn path=/trunk/; revision=13684
2005-03-09 23:00:21 +00:00
Gerald Combs
aa8bea0559 Add a couple of definitions not present in MIT Kerberos. Fix a compiler
warning.

svn path=/trunk/; revision=13682
2005-03-09 19:43:29 +00:00
Ronnie Sahlberg
6626c6aac2 refactor the code to not use heimdal functions to decrypt and unwrap the blob.
use builtin functrions instead  which will make it trivial to add this support to mit later


svn path=/trunk/; revision=13680
2005-03-09 11:59:40 +00:00
Guy Harris
56f04fe686 Set the eol-style and keywords properties.
Use "tvb_reported_length_remaining()", not "tvb_length_remaining()", in
the loop parsing the packet contents, so we throw an exception on a
short frame (to mark that it *is* a short frame).

Use "tvb_format_text()" for text strings, so we don't have a problem
with non-printable characters.

Use "ether_to_str()" to turn MAC addresses into strings.

Clean up indentation.

svn path=/trunk/; revision=13679
2005-03-09 10:57:58 +00:00
Guy Harris
87c16299db From Vladimir Kondratiev:
- better parsing for TIM info element: it parses 'bitmap control' byte
and provides list of AID for stations having power saving traffic.
- separate names for TIM elements. It helps to higlight beacons with
some properties, for example DTIM ones (dtim_count==0).

svn path=/trunk/; revision=13678
2005-03-09 10:43:34 +00:00
Guy Harris
85dc6331eb Comment out a routine that's not currently being used.
svn path=/trunk/; revision=13677
2005-03-09 10:29:59 +00:00
Guy Harris
8d34b8cacd From Ricardo Muggli: decode the voice VLAN field in CDP packets.
svn path=/trunk/; revision=13676
2005-03-09 10:24:34 +00:00
Guy Harris
3ca7500032 Updates from Abhijit Menon-Sen.
svn path=/trunk/; revision=13672
2005-03-09 03:15:59 +00:00
Guy Harris
d7855a3c4d Fix the properties.
svn path=/trunk/; revision=13671
2005-03-09 03:04:46 +00:00
Guy Harris
33006e7f92 Squelch some compiler warnings if we don't have Kerberos.
svn path=/trunk/; revision=13670
2005-03-09 03:03:10 +00:00
Guy Harris
77780b3697 "time_t", not "timer_t".
svn path=/trunk/; revision=13669
2005-03-09 02:39:31 +00:00
Ronnie Sahlberg
0aad06dea5 use the rc4 functions from epan/crypt-rc4 instead of those in heimdal
so that we dont have to include <rc4.h> from heimdal

hopefully the build on freebsd will succeed now


svn path=/trunk/; revision=13668
2005-03-08 23:47:29 +00:00
Ronnie Sahlberg
0f5bac2858 New protocol : KINK
From Taekshi Nakashima   the KINK protocol


svn path=/trunk/; revision=13667
2005-03-08 22:32:43 +00:00
Ronnie Sahlberg
176c87d3dd remove some dependencies of libgssapi
svn path=/trunk/; revision=13665
2005-03-08 21:13:14 +00:00
Ronnie Sahlberg
95532c9493 remove the need to include <gssapi.h> from heimdal
svn path=/trunk/; revision=13664
2005-03-08 20:22:07 +00:00
Ronnie Sahlberg
5cfb848064 If ethereal is linked with HEIMDAL
and Kerberos decryption is enabled in preferences
and if we have the keytab file available

then attempt to decrypt Secure LDAP



svn path=/trunk/; revision=13660
2005-03-08 09:46:24 +00:00
Ronnie Sahlberg
6e6e082d34 when HEIMDAL is linked with :
make spnego able to decrypt data wrapped inside
 GSSAPI/SPNEGO/KRB5 arcfour-hmac

This code will be more etherealified and evolve into being able to link with MIT as well.



svn path=/trunk/; revision=13659
2005-03-08 09:45:19 +00:00
Lars Roland
9a1a762922 remove remnants of the old plugin api from dissectors and plugins
svn path=/trunk/; revision=13656
2005-03-07 21:40:29 +00:00
Anders Broman
d8d583a587 Add a g723 dissector to dissect the first byte to find the rate and if speech is pressent or not.
svn path=/trunk/; revision=13652
2005-03-07 20:11:03 +00:00
Luis Ontanon
8b481b2ab9 From Florian Lohoff:
Add Netscreen vendor specific attributes


svn path=/trunk/; revision=13650
2005-03-07 11:35:52 +00:00
Jörg Mayer
8de6e67f08 Fix a small typo that would prevent compilation with MIT Kerberos
svn path=/trunk/; revision=13647
2005-03-07 10:15:03 +00:00
Ronnie Sahlberg
31a9522aa2 export some symbols we will need later.
svn path=/trunk/; revision=13646
2005-03-07 09:02:33 +00:00
Jörg Mayer
f2bab830dc Make packet-kerberos.c compile again:
Replace the use of the undefined type krb5_keyusage (at least with heimdal)
in decrypt_krb5_data with the old int. The change wasn't complete anyway
as the .h file wasn't changed and the third implemenitation of
decrypt_krb5_data was left out also.

Disclaimer: I only made sure it compiles again, I don't know whether the
  change has any side effects.


svn path=/trunk/; revision=13645
2005-03-07 08:47:48 +00:00
Guy Harris
ab32b090b7 Back out the BACnet application layer dissectin code - its use of
recursion instead of iteration means that packets with sufficiently
large lists can cause it to overflow the stack and crash.

svn path=/trunk/; revision=13643
2005-03-07 01:22:55 +00:00
Ronnie Sahlberg
7a43aeb457 minor update, add an extra parameter to a call to prepare for decryption of GSSAPI wrapped data
svn path=/trunk/; revision=13642
2005-03-06 22:52:58 +00:00
Ronnie Sahlberg
26dd060797 export decrypt_krb5_data
svn path=/trunk/; revision=13641
2005-03-06 22:34:13 +00:00
Guy Harris
722832f739 The length field in the "BACnet encoding rules" is limited to 32 bits
("Data lengths larger than 2^32-1 are not encodable using primitive
tags"), so it doesn't need to be a "guint64" - but it *can* be that big,
so we should handle the 65536-2^32-1 case.

Don't gratuitously throw away the upper 24 bits of various lengths by
casting them to guint8.

Show signed values as such.

Don't use "match_strval()" - it returns a null pointer if it doesn't
find the value in the value_string table; instead, use "val_to_str()" so
we don't blow up if the value isn't found.

svn path=/trunk/; revision=13640
2005-03-06 22:14:24 +00:00
Luis Ontanon
c57a54f3ec Add a preference for another alternate tcp port
svn path=/trunk/; revision=13638
2005-03-06 21:32:13 +00:00
Anders Broman
2f4c6bf770 Fix a minor bug with FT_BOOLEAN.
svn path=/trunk/; revision=13637
2005-03-06 20:54:01 +00:00
Guy Harris
e41c4740c9 Handle XNS IDP socket numbers.
Handle SMB-over-SPP.

svn path=/trunk/; revision=13635
2005-03-06 20:13:58 +00:00
Jörg Mayer
9432483a14 Warning fix:
packet-sdp.c:74: warning: 'reset_sdp_packet_info' declared 'static'
        but never defined


svn path=/trunk/; revision=13624
2005-03-06 09:33:44 +00:00
Guy Harris
177e6f1bc2 From Yaniv Kaul: show the protocol name in every record.
svn path=/trunk/; revision=13623
2005-03-06 04:42:51 +00:00
Guy Harris
a313c47a59 Get rid of an unused variable.
svn path=/trunk/; revision=13621
2005-03-06 04:41:00 +00:00
Guy Harris
f63c9301b2 No, the code is the numerical value, not the vendor ID.
svn path=/trunk/; revision=13618
2005-03-06 03:38:17 +00:00
Guy Harris
c9826f64d8 From Ben Turner: fix an addVendor() call.
svn path=/trunk/; revision=13617
2005-03-06 03:28:41 +00:00
Guy Harris
84f0170f07 Add a newline to the end of the file.
svn path=/trunk/; revision=13616
2005-03-06 03:25:19 +00:00
Guy Harris
b21ab2a5e0 Get rid of "unknown transport" warnings - don't spam the user just
because we haven't yet written a dissector for a particular protocol.

svn path=/trunk/; revision=13615
2005-03-06 03:19:34 +00:00
Guy Harris
2ad3b256f4 Handle the "32-bit length is > 2^31-1, so the protocol tree routines
will treat it as negative" problem by first calling
"tvb_ensure_bytes_exist()" - if the length is *that* large, it will run
past the end of the tvbuff, so the exception that
"tvb_ensure_bytes_exist()" will throw with a negative argument will be
the correct exception.

svn path=/trunk/; revision=13614
2005-03-06 03:11:24 +00:00
Guy Harris
39ad72864f No, they don't use BER for the variable portion of a PDU; update the
comment appropriately.

Make a bunch of routines static.

Don't just dissect stuff past the end of the variable portion as data -
the protocol spec doesn't appear to say there's anything after that.

Don't pass the offset to the routines to dissect the different types of
PDUs, just have them start at 0.

Use guint8 for 8-bit unsigned quantities.

Rename the routine to dissect Abort PDUs to match the other PDU
dissectors.

svn path=/trunk/; revision=13611
2005-03-06 02:24:49 +00:00
Guy Harris
476c8da086 Don't use "long" and "%l[doux]" for 64-bit quantities, use guint64 and %
followed by PRIu64.

Don't use C++/C99-style comments.

Use "tvb_reported_length()" to get packet lengths - don't use
"tvb_length()", and especially don't directly refer to the "length"
field of the tvbuff.

svn path=/trunk/; revision=13609
2005-03-06 01:53:56 +00:00
Jörg Mayer
8940beb1e2 Martin Mathieson: Add information sources
svn path=/trunk/; revision=13607
2005-03-06 01:15:29 +00:00
Guy Harris
ea23bf66f9 From Herbert Lischka: implement some (not all) tags according to BACNET
application handbook.

svn path=/trunk/; revision=13605
2005-03-06 00:17:37 +00:00