Commit Graph

109 Commits

Author SHA1 Message Date
Guy Harris 134b6b0f41 The q931_info argument to q931_calls_packet() is used. Don't mark it as
unused.

svn path=/trunk/; revision=30482
2009-10-10 22:00:07 +00:00
Guy Harris cf91fdf16b Have tap listeners specify whether the "packet" routine requires
a protocol tree;

	the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

svn path=/trunk/; revision=28645
2009-06-05 22:42:47 +00:00
Bill Meier 321506c076 (Trivial) Fix some spelling & etc in comments
svn path=/trunk/; revision=27996
2009-04-08 13:41:30 +00:00
Stig Bjørlykke 62f60df6b4 From Jakub Zawadzki (bug 3331):
g_free() is NULL safe, so we don't need check against it.

svn path=/trunk/; revision=27718
2009-03-13 22:06:48 +00:00
Stig Bjørlykke 18c5caa3d4 From Jakub Zawadzki:
Use non-formatting functions when appropriate.

svn path=/trunk/; revision=27709
2009-03-12 07:56:42 +00:00
Jaap Keuter 6acffc2357 Get the build going again on non-Windows compilers.
svn path=/trunk/; revision=27697
2009-03-11 07:35:43 +00:00
Anders Broman 564846935a From Carlos Mendioroz:
IAX2 calls statistics window ala RTP.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3217

svn path=/trunk/; revision=27696
2009-03-11 06:43:46 +00:00
Bill Meier ee908a7abd #include <epan/conversation.h> not req'd ...
svn path=/trunk/; revision=27392
2009-02-07 16:01:26 +00:00
Jaap Keuter cb80f883f7 From Carlos Mendioroz:
Enhanced the skinny dissector to expose a tap, and added SKINNY call control
protocol support to gtk/call_voip to show those calls.

svn path=/trunk/; revision=27332
2009-01-30 21:25:52 +00:00
Jaap Keuter 0c7d516955 Cleanup sourcecode.
svn path=/trunk/; revision=27059
2008-12-19 11:30:50 +00:00
Tomas Kukosa 3c6f280db4 - export tvb_memeql()
- update callsinfo->call_comment in VoIP Calls

svn path=/trunk/; revision=26844
2008-11-25 14:21:04 +00:00
Jaap Keuter ec03288647 Fix for bug 3079:
Remove memory leaks from allocated labels by making full use of graph helper functions, and 
from unneeded address copies. 
Avoid GLIb warning on empty dynamic RTP payload type hash table.

svn path=/trunk/; revision=26841
2008-11-25 08:21:53 +00:00
Stig Bjørlykke 8608c8f1de Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26641
2008-10-31 09:53:56 +00:00
Jeff Morriss dd6a15e1c7 Don't put (non-extern'd) prototypes for protect_thread_critical_region() and
unprotect_thread_critical_region() in every module in gtk/: instead have those
modules include main.h (which has the properly extern'd prototype).

This should fix the link error on HP-UX described in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2702

svn path=/trunk/; revision=25933
2008-08-05 17:33:14 +00:00
Anders Broman 1cc7c72db6 Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25261
2008-05-09 11:59:44 +00:00
Anders Broman b6454e76ac Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25244
2008-05-06 05:50:31 +00:00
Ulf Lamping 644a474c95 sort #includes by directories
svn path=/trunk/; revision=24969
2008-04-13 03:32:24 +00:00
Anders Broman c973aa3830 Remove:
#ifdef NEED_G_ASCII_STRCASECMP_H
#include "g_ascii_strcasecmp.h"
#endif

svn path=/trunk/; revision=24868
2008-04-09 19:39:58 +00:00
Stephen Fisher 726a1caaf1 - Remove GLIB1 code
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION
- Remove ws_strsplit files because we no longer need to borrow GLIB2's
  g_strsplit code for the no longer supported GLIB1 builds


svn path=/trunk/; revision=24829
2008-04-07 05:22:54 +00:00
Stephen Fisher 2000fa9fcf Remove more GTK1 code and related xpm files.
svn path=/trunk/; revision=24795
2008-04-05 19:23:07 +00:00
Stephen Fisher 9463667692 Fix for bug #2017: VoIP trace crashes Wireshark when specific RTP Player
buttons are clicked


svn path=/trunk/; revision=24073
2008-01-13 04:24:24 +00:00
Stephen Fisher 430866e511 To ease troubleshooting of bug #2017 and for code clarity in the future, use
two different variables for types voip_rtp_stream_info_t (strinfo) and
voip_calls_info_t (callsinfo) instead of using strinfo for both.


svn path=/trunk/; revision=24038
2008-01-09 08:34:58 +00:00
Ronnie Sahlberg e6ed260aca some more path fixes for g_ascii_strcasecmp.h
svn path=/trunk/; revision=23638
2007-11-28 01:31:23 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Tomas Kukosa 9b3c5f9f03 display SRTP isntead of RTP if stream is established like a SRTP
svn path=/trunk/; revision=23337
2007-11-02 07:43:49 +00:00
Tomas Kukosa d3a00ff8bf do not update call_state if new call_state == VOIP_NO_STATE
svn path=/trunk/; revision=23271
2007-10-25 12:24:01 +00:00
Tomas Kukosa 97dde57b7e fix voip_calls.c:126: warning: missing initializer
svn path=/trunk/; revision=23263
2007-10-24 09:10:43 +00:00
Tomas Kukosa 28cb460c25 add common VoIP TAP listener "voip" which can be used in arbitrary experimental/proprietary protocol (implemented e.g. in plugin) and allows it to make graphs and replay streams
svn path=/trunk/; revision=23262
2007-10-24 08:30:46 +00:00
Tomas Kukosa 44800d2c5a H.460 new dissector implemented (H.460.2-H.460.22)
H.225
 - change RysMessage_vals to h225_Rasmessage_vals
 - use #.PDU directive for H323-UserInformation and RasMessage instead of implementing it by hands
 - register RasMessage_PDU as "h225.ras" dissector for calling it from H.460
asn2wrs make PDUs exportable

svn path=/trunk/; revision=23226
2007-10-18 13:35:57 +00:00
Anders Broman fcbc9389d6 Change mgcp include.
svn path=/trunk/; revision=23197
2007-10-15 22:20:53 +00:00
Jaap Keuter b7d63247ad Get rid of the last warning.
svn path=/trunk/; revision=22930
2007-09-24 06:42:59 +00:00
Jaap Keuter f2c1b7e8f0 From Chad Singer:
I fixed a bug in packet_unistim.c which was causing a 'malformed packet' to
appear when an open stream command is read with no endpoint ip (as is sometimes
done) I added a simple msg_len check to avoid this. 
I also added UFTP to the unistim dissector and adjusted the unistim call-detection 
in voip-info.c to start on an open stream as well as keypresses..

svn path=/trunk/; revision=22929
2007-09-24 06:19:56 +00:00
Jaap Keuter e1541263e4 From Chad Singer:
UNISTIM Tap interface plus call grapher.

svn path=/trunk/; revision=22834
2007-09-10 07:21:27 +00:00
Stephen Fisher 2745f06d96 From Lars Ruoff:
find attached several trivial diffs for viewing RTP SSRC values in Hex
rather than Dec at various places in the UI.
Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP
and RTCP dissector header fields.


svn path=/trunk/; revision=22017
2007-05-31 18:41:25 +00:00
Sebastien Tandel d3d3f9bc68 fix warnings for gcc 4.2
svn path=/trunk/; revision=21974
2007-05-29 02:29:38 +00:00
Tomas Kukosa cfa43d6daa generate T.38 dissector from ASN.1 source
svn path=/trunk/; revision=21676
2007-05-04 07:10:15 +00:00
Guy Harris f13901ef1c memmove() is needed only if the source and destination might overlap.
svn path=/trunk/; revision=21592
2007-04-26 05:47:34 +00:00
Luis Ontanon 359c840dfb do not avoid redrawing the tap
make sure we do not pass a null pointer to add_to_graph()


svn path=/trunk/; revision=21251
2007-03-28 19:31:54 +00:00
Luis Ontanon 9dbe9adf50 Another iteration over sctp calls (RANAP/BSSAP) a step towards TCAP/(MAP/IMAP/CAMEL)
- Fix SUA calls (I would need some more traces to test this)


svn path=/trunk/; revision=21235
2007-03-27 23:00:55 +00:00
Luis Ontanon 25dbb9216f add Megaco to the "VoIP Calls" tap
svn path=/trunk/; revision=21213
2007-03-26 21:12:24 +00:00
Luis Ontanon 7233064c5a rename h248_* to gcp_* according to changes in epan.
svn path=/trunk/; revision=21190
2007-03-25 21:56:08 +00:00
Ulf Lamping 0aaacb0088 fix new warnings
svn path=/trunk/; revision=21131
2007-03-22 23:29:55 +00:00
Luis Ontanon 7f3e4fea48 Mine:
* add SUA to the "VoIP Calls" tap.
* propagate changes to packet-sccp.h to other dissectors

From Neil Piercy:
* add SLR, DLR and CAUSE to COL_INFO

svn path=/trunk/; revision=21126
2007-03-22 22:59:20 +00:00
Ulf Lamping 13825debb0 fix another three MSVC 8.0 warnings
svn path=/trunk/; revision=21089
2007-03-21 12:37:39 +00:00
Ulf Lamping 407d0aeab0 fix all warnings in gtk dir & set the "treat all warnings as errors" MSVC flag
svn path=/trunk/; revision=21080
2007-03-21 03:26:26 +00:00
Luis Ontanon 16f4a91dfc Add the sccp tap to the "VoIP Calls" Tap (which by now should be renamed to just "Calls") but that's for later.
Now it does H323, SIP, MGCP, ISUP/BICC, RANAP, BSSAP, H.248  and others...

svn path=/trunk/; revision=21077
2007-03-21 00:59:00 +00:00
Luis Ontanon 529c65f713 voip_calls.c:
- instead of wrongly using the h248 call counter use tapinfo's counter

graph_analysis.c:
- beautify  the code (I was trying to the bug that got fixed by bzeroing m3ua tap data however this looks better!).

svn path=/trunk/; revision=21063
2007-03-19 00:36:42 +00:00
Luis Ontanon ef24b97061 have voip_calls using the m3ua tap
svn path=/trunk/; revision=21060
2007-03-18 23:16:54 +00:00
Luis Ontanon cd824a3f67 squelch some warnings
svn path=/trunk/; revision=21057
2007-03-18 22:26:08 +00:00
Luis Ontanon 627f57b351 add h248 to VoIP Calls
svn path=/trunk/; revision=21056
2007-03-18 22:14:12 +00:00