Commit Graph

9369 Commits

Author SHA1 Message Date
Guy Harris 3074ff6a82 At least as I read the Teredo draft, the nonce value is just an opaque
8-byte value.

svn path=/trunk/; revision=9466
2003-12-29 00:19:00 +00:00
Guy Harris 56af440bfa In calls to "dcerpc_init_uuid()" only the *major* version number of the
interface is supplied; by virtue of 1.1 being truncated to 1, and by
virtue of the putative major and minor version numbers in 1.1 both being
1, a version number initialized to 1.1 presumably happened to work for
RPRIV and RS_REPADM, but we might as well do it right.

svn path=/trunk/; revision=9465
2003-12-28 23:50:31 +00:00
Richard Sharpe e29be9a141 Add more code to handle the recent_files_count_max as a preference ...
Here we can read and write it from and to the preferences file. I only have
to add code to allow it to be set in the Edit->Preferences area,

svn path=/trunk/; revision=9464
2003-12-28 23:20:08 +00:00
Richard Sharpe 015681b24e Connect the recent_file_count_max variable to the prefs.gui_recent_file_count_max variable entry, and fix a small spelling/grammar mistake.
Now all we need is some enterprising individual to write the small amount of
preferences code to actually allow it to be changed etc, but I have to go to
Costco, so, later...

svn path=/trunk/; revision=9463
2003-12-28 21:10:26 +00:00
Richard Sharpe 0a44e7c145 Add a preferences item for the recent file count max so we can tie it to
the edit preferences dialog box and then use it in the code that handles
recent files.

svn path=/trunk/; revision=9462
2003-12-28 20:36:59 +00:00
Ulf Lamping 35e5ba4edd all libs now relative to a base dir, use compiler warning level 2
svn path=/trunk/; revision=9461
2003-12-28 18:31:14 +00:00
Ulf Lamping 0f2765c1f8 removed some MSVC warnings (warning level 2)
svn path=/trunk/; revision=9460
2003-12-28 12:50:42 +00:00
Ulf Lamping cb2658031d removed some MSVC warnings (warning level 2)
svn path=/trunk/; revision=9459
2003-12-28 12:43:40 +00:00
Guy Harris c6852ab625 If we've seen an HTTP request or response or header line, and the line
we're looking at looks as if it could be the beginning of a header line
but stops at the end of the tvbuff before we see the colon for the
header line, throw an exception rather than treating it as "not HTTP".

svn path=/trunk/; revision=9458
2003-12-28 08:39:10 +00:00
Guy Harris 901a5a6160 Properly handle 1xx, 204, and 304 responses, which don't contain a
message body.

svn path=/trunk/; revision=9457
2003-12-27 18:45:48 +00:00
Ulf Lamping cce063356e added/changed some comments
svn path=/trunk/; revision=9456
2003-12-27 13:19:06 +00:00
Guy Harris a777dd9394 Fix some comments.
svn path=/trunk/; revision=9455
2003-12-27 08:35:08 +00:00
Guy Harris 821fd8405b Don't create a protocol tree entry for the body of an NDMP request or
reply if there isn't a body, just a header, so that we don't throw an
exception and mark the frame as malformed if the request or reply isn't
supposed to have a body.

svn path=/trunk/; revision=9454
2003-12-27 04:01:17 +00:00
Guy Harris 46ce3ac2fa There might not be any AFS payload in an AFS reply; for fields in the
reply that don't come from the packet, use an offset and length of 0, so
that we don't throw an exception if the purported data at that offset
with that length doesn't exist.

svn path=/trunk/; revision=9453
2003-12-27 03:45:45 +00:00
Guy Harris 83887ebd3a Don't defragment packets that aren't fragmented.
Note that we've seen weird sequence numbers for login packets.

svn path=/trunk/; revision=9452
2003-12-27 02:17:22 +00:00
Guy Harris 935b5e5329 Note that this is another client for reassembly using connection
sequence numbers.

svn path=/trunk/; revision=9451
2003-12-27 02:01:13 +00:00
Guy Harris d8358e41fc When testing the first line of HTTP data, process what data we have -
don't give up if we don't have the full line.

svn path=/trunk/; revision=9450
2003-12-27 01:42:56 +00:00
Guy Harris 2e2946db8e Check that the length of an AVP is >= 6, not just that it's non-zero.
svn path=/trunk/; revision=9449
2003-12-26 23:33:25 +00:00
Ulf Lamping f849df17e6 conditionally use modern UI for NSIS installer
svn path=/trunk/; revision=9448
2003-12-26 12:27:47 +00:00
Ulf Lamping b6092e26fd conditionally use modern UI for NSIS installer
svn path=/trunk/; revision=9447
2003-12-26 11:37:58 +00:00
Ulf Lamping 1f959ea4bd bugfix: uninstall also the help textfiles
svn path=/trunk/; revision=9446
2003-12-26 11:36:43 +00:00
Guy Harris 20788302e3 In "alloc_field_info()", handle the case where the offset is past the
byte past the end of the tvbuff.

svn path=/trunk/; revision=9445
2003-12-24 23:37:28 +00:00
Guy Harris 129de02c79 In "tvb_ensure_bytes_remaining()", throw ReportedBoundsError, not
BoundsError, if the offset is just past the end of the reported data
(because we're ensuring that there actually *is* a byte there, and,
even according to the reported length, it isn't).

svn path=/trunk/; revision=9444
2003-12-24 23:28:17 +00:00
Jörg Mayer 982b7a3f2b Add -pedantic to --with-extra-gcc-checks
svn path=/trunk/; revision=9443
2003-12-24 14:45:48 +00:00
Jörg Mayer 3f0ed2487d Add -pedantic to --with-extra-gcc-checks
svn path=/trunk/; revision=9442
2003-12-24 14:06:36 +00:00
Olivier Biot 5663e71bc6 Fix highlighting of Image record (forgot one fixed header byte).
Add comments on computation of fixed header.

svn path=/trunk/; revision=9441
2003-12-24 12:46:57 +00:00
Guy Harris cde3ec1e33 Let FT_PROTOCOL fields, if the length specified is -1, have a length of
0 - now that "tvb_ensure_length_remaining()" ensures that there's at
least one byte of data, we should use "tvb_length_remaining()" for
FT_PROTOCOL fields.

svn path=/trunk/; revision=9440
2003-12-24 11:07:03 +00:00
Guy Harris 274520160a Don't display TFTP data if there isn't any to display.
svn path=/trunk/; revision=9439
2003-12-24 10:48:13 +00:00
Guy Harris 3f05338503 In the loop that processes lines in HTTP requests and replies, loop as
long as there's reported data, don't just loop through the data in the
tvbuff.

Fix some problems with short frames.

svn path=/trunk/; revision=9438
2003-12-24 09:50:54 +00:00
Olivier Biot 83b4a6158f Add support for GIF image dissection.
NOTE: I propose to use packet-MIME-TREE for future media types that will be
added to Ethereal (E.g., packet-image-png.c).

svn path=/trunk/; revision=9437
2003-12-24 02:06:26 +00:00
Guy Harris f941ab7b7d Do the "isprint()" hack for GTK+ 2.x or 1.3[.x], whether on UNIX or
Windows - the problem is that GTK+ 1.3[.x] and later assume strings
handed to them are UTF-8 strings, not, for example, ISO 8859/x strings.

In packet-radius.c, re-define "isprint()" rather than #ifdeffing its use
(the old code was also incorrectly treating 0x7f as a printable).

svn path=/trunk/; revision=9436
2003-12-24 01:21:32 +00:00
Guy Harris e6f433d884 Do the "isprint()" hack for GTK+ 2.x or 1.3[.x], whether on UNIX or
Windows - the problem is that GTK+ 1.3[.x] and later assume strings
handed to them are UTF-8 strings, not, for example, ISO 8859/x strings.

In packet-radius.c, re-define "isprint()" rather than #ifdeffing its use
(the old code was also incorrectly treating 0x7f as a printable).

svn path=/trunk/; revision=9435
2003-12-24 01:12:17 +00:00
Guy Harris 839ce07c9a Handle the move of "smpp" preferences to "smpp-gsm-sms".
svn path=/trunk/; revision=9434
2003-12-23 21:29:25 +00:00
Guy Harris 821baa3d48 Have "tvb_ensure_length_remaining()" throw the appropriate exception if
there's no data remaining - its callers largely depend on it doing so.

That means that the BEEP dissector doesn't have to check for it
returning 0.

svn path=/trunk/; revision=9433
2003-12-23 21:22:00 +00:00
Guy Harris 8afbfc0c60 Handle the case where "ssh_dissect_protocol()", for the first packet,
didn't determine the version number.

svn path=/trunk/; revision=9432
2003-12-23 21:16:27 +00:00
Olivier Biot 2a6e130e10 Move the GSM SMS dissection to a dedicated subdissector (currently still within
packet-smpp.c).

Now the higher-level protocols show up without the need of unfolding the SMPP
dissector tree.

Add a new address type AT_STRINGZ, and use it for GSM SMS message reassembly.

Get rid of the different UDH IE subtrees, and replace them with one subtree
for all UDH IEs.

Add debug logging to SMPP and SMPP GSM SMS dissectors.

Move the Short Message reassembly from the SMPP dissector to the SMPP GSM SMS
dissector. Fix duplicated "reassembled in" header fields.

Rename header fields that are now part of SMPP GSM SMS (including the dissector
table name, so it has also been updated in packet-wsp.c and packet-wtp.c).

Add an explicit "if (!tree) return" in the WSP add_headers() method.

NOTE: it would be great if we were able to merge the existing packet-gsm_sms.c
and the SMPP GSM SMS dissector.

svn path=/trunk/; revision=9431
2003-12-23 12:07:14 +00:00
Ulf Lamping 16cb58be9a removed COMMON_FILES_GNU from path,
use the directories xy_DIR from the settings above

svn path=/trunk/; revision=9430
2003-12-23 11:57:26 +00:00
Ulf Lamping bf729e3e15 calling tethereal in it's place, to prevent problems with dll loading
svn path=/trunk/; revision=9429
2003-12-23 11:53:25 +00:00
Guy Harris 75d6b95de1 Not all headers in HTTP, RTSP, SIP, etc. are entity headers; rename some
files, routines, data structures, etc..

svn path=/trunk/; revision=9428
2003-12-23 02:29:11 +00:00
Guy Harris f75e257cbd In HTTP-over-TCP, handle more than one HTTP message in a TCP segment.
Don't do that for HTTP-over-UDP, however.

svn path=/trunk/; revision=9427
2003-12-23 02:02:09 +00:00
Guy Harris b7b8245ea5 Process the content length.
svn path=/trunk/; revision=9426
2003-12-23 01:42:48 +00:00
Guy Harris 054f12a950 Note that we should do the same sort of entity header processing that
HTTP does.

Note that the RTSP RFC talks about packets with no content length,
although it also says they shouldn't exist.

Update a comment now that we *do* handle data that crosses TCP segment
boundaries.

Handle the payload length a bit differently, to make it a bit clearer
what's going on.

svn path=/trunk/; revision=9425
2003-12-23 01:25:23 +00:00
Guy Harris 5b3d2e36e4 Note that we should handle the Content-Length entity header.
svn path=/trunk/; revision=9424
2003-12-23 01:22:52 +00:00
Guy Harris b136fc7512 Base the count of selected packets on whether there's a
currently-selected packet.

Use "cfile.count" as the total number of packets in the capture.

Use "plurality" to display "packet" vs. "packets".

svn path=/trunk/; revision=9423
2003-12-23 00:32:45 +00:00
Ulf Lamping 467c05b3ea removed some MSVC warnings (conversions between double/float and int)
svn path=/trunk/; revision=9422
2003-12-23 00:16:46 +00:00
Guy Harris 447e29ec36 From Anders Broman: add the alternate TCP port.
svn path=/trunk/; revision=9421
2003-12-23 00:01:07 +00:00
Guy Harris c530cd35db Call subdissectors even if we're not building a protocol tree.
In the loop that processes TCP segment data, loop over the full reported
length of the segment, so that we throw an exception if the frame was
short.

svn path=/trunk/; revision=9420
2003-12-22 23:43:35 +00:00
Guy Harris e969b8d3ba Do reassembly of interleaved binary data.
svn path=/trunk/; revision=9419
2003-12-22 23:37:02 +00:00
Olivier Biot f4451d312b Move SIR to a dedicated subdissector.
Question: should we define "media type" subdissectors as special?

svn path=/trunk/; revision=9418
2003-12-22 22:57:09 +00:00
Guy Harris a7d9018c1f Have a "toc" file in the help directory, which gives a list of help
topic titles and help file names.

svn path=/trunk/; revision=9417
2003-12-22 22:17:30 +00:00