Commit Graph

21108 Commits

Author SHA1 Message Date
Bill Meier 2c346d9a3c Use correct install target: 'make ..._install (and not 'make 'install_...')
svn path=/trunk/; revision=21545
2007-04-24 02:17:35 +00:00
Guy Harris 1b2cecda53 Need to include <epan/pint.h> to get pletohl() defined.
svn path=/trunk/; revision=21544
2007-04-23 22:34:31 +00:00
Anders Broman c0dc340d5d From Florent DROUIN:
I have made some changes to the final patch to have the operation code decoded
as ForwardSM. A change for TCAP is included too, to be sure that the
application context is not overwritten by the User Info OID (this was the case,
when a MAP open dialog was included in the request).
Fix bug:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1498

svn path=/trunk/; revision=21543
2007-04-23 21:26:27 +00:00
Guy Harris d6fc852779 byteReverse assumes its argument is aligned on a 32-bit boundary; make
it a pointer to a guint32.  Also, use pletohl() to fetch a 32-bit
little-endian quantity.

svn path=/trunk/; revision=21542
2007-04-23 21:23:30 +00:00
Guy Harris 5a4771d9cb The "in" array in an MD5 context is expected to be aligned on a 4-byte
boundary; make it an array of 16 guint32's rather than 64 guint8's, to
ensure that, and add now-necessary casts and remove now-unnecessary
casts.

(Missed on the previous checkin.)

svn path=/trunk/; revision=21541
2007-04-23 21:12:04 +00:00
Guy Harris 0acc6bc5b8 The "in" array in an MD5 context is expected to be aligned on a 4-byte
boundary; make it an array of 16 guint32's rather than 64 guint8's, to
ensure that, and add now-necessary casts and remove now-unnecessary
casts.

svn path=/trunk/; revision=21540
2007-04-23 20:47:07 +00:00
Anders Broman cd66fcfe16 Remove a relic from experimental code.
svn path=/trunk/; revision=21539
2007-04-23 20:30:31 +00:00
Anders Broman b65e5b390a TCAP: Fix up indentation a bit.
GSM MAP: Add returnResultNotLast from TCAP to the included ROS stuff.

svn path=/trunk/; revision=21538
2007-04-23 20:21:31 +00:00
Anders Broman d07a92f8bc TCAP: Fix up indentation a bit.
GSM MAP: Add returnResultNotLast from TCAP to the included ROS stuff.

svn path=/trunk/; revision=21537
2007-04-23 20:20:46 +00:00
Guy Harris 8e32c1e739 Get rid of no-longer-needed, and warning-generated, casts.
svn path=/trunk/; revision=21536
2007-04-23 18:30:29 +00:00
Guy Harris adcccbcdee More const cleanup.
svn path=/trunk/; revision=21535
2007-04-23 18:18:08 +00:00
Guy Harris cdb59eed63 Make Mk16_le() work on both big-endian and little-endian processors and
on processors that don't support unaligned loads - just use pletohs().

svn path=/trunk/; revision=21534
2007-04-23 18:11:12 +00:00
Guy Harris 6f4a938c64 Dissector table names should be pointed to by const pointers.
svn path=/trunk/; revision=21533
2007-04-23 17:40:33 +00:00
Guy Harris 0e7e1ba0aa Fix type cast to match target of assignment.
svn path=/trunk/; revision=21532
2007-04-23 17:38:56 +00:00
Guy Harris 56fcbf41be The "needles" argument of guint8_pbrk() needs to be const, as that's
what's passed to it.

svn path=/trunk/; revision=21531
2007-04-23 17:37:36 +00:00
Guy Harris 877db595ff Don't assume byte pointers can be safely cast to more aligned pointers;
the compiler now warns of that.

svn path=/trunk/; revision=21530
2007-04-23 17:33:29 +00:00
Guy Harris f010b46419 decode_as_dt's argument points to a dissector table name, so it should be
a const pointer.

svn path=/trunk/; revision=21529
2007-04-23 16:49:24 +00:00
Guy Harris 552fff182e Don't assume a pointer to UCHAR is necessarily aligned; that now
generates a warning.

svn path=/trunk/; revision=21528
2007-04-23 16:41:31 +00:00
Stephen Fisher 90f8b1a080 From Paolo Abeni:
(from -dev list)
On Sun, 2007-04-22 at 23:06 +0200, Joerg Mayer wrote:
> Can someone please have a look at uand fix the following warning:
>
> cc1: warnings being treated as errors
> packet-ssl.c: In function 'ssl_parse':
> packet-ssl.c:334: warning: ignoring return value of 'fread', declared
> with attribute warn_unused_result

The attached patch fix the issue. It also try to fix a bit the
indentation.

Me: Move size_t nbytes up to top of function and fix typo expeted->expected


svn path=/trunk/; revision=21527
2007-04-23 16:22:34 +00:00
Guy Harris 1bc049906a Add some GCC warnings to the standard set, and add some others to the
--enable-extra-gcc-checks set.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

Constify a bunch of stuff, and make some other changes, to get rid of
warnings.

Clean up some indentation.

svn path=/trunk/; revision=21526
2007-04-23 10:59:26 +00:00
Guy Harris 7dc9df5f26 Just use -1 to go to the end of a tvbuff.
svn path=/trunk/; revision=21525
2007-04-23 10:57:34 +00:00
Jeff Morriss 20a3a52951 Mark all the items for TCAP statistics as generated
svn path=/trunk/; revision=21524
2007-04-23 10:45:00 +00:00
Ronnie Sahlberg c84eda3a80 add request/response matching for ctdb
svn path=/trunk/; revision=21523
2007-04-23 09:44:13 +00:00
Anders Broman 117eaaf948 and the missing files ...
svn path=/trunk/; revision=21522
2007-04-23 06:50:07 +00:00
Anders Broman 9344195101 Formating changes and align a bit to spec.
svn path=/trunk/; revision=21521
2007-04-23 06:24:39 +00:00
Guy Harris e7931530dd Grr. Flex. Can't make warnings errors yet - we'd have to keep that
from being done on Flex-generated files, or fix the problems that pop up
on some platforms.

svn path=/trunk/; revision=21520
2007-04-23 03:09:23 +00:00
Guy Harris f5b1131374 Make warnings errors when possible.
svn path=/trunk/; revision=21519
2007-04-23 02:48:40 +00:00
Guy Harris c5beaef29e "call_ber_syntax_callback()" isn't used outside packet-ber.c, isn't
declared in any header file, and isn't in epan/libwireshark.def; make it
static, to squelch compiler warnings.

svn path=/trunk/; revision=21518
2007-04-23 00:32:04 +00:00
Bill Meier f48fd4700d Restore the casts from svn 21080 (presumably) inadvertantly removed in svn 21495.
so windows build doesn't get warnings.

svn path=/trunk/; revision=21517
2007-04-23 00:31:57 +00:00
Guy Harris 8093569ebe Add a couple more warnings to the standard set.
svn path=/trunk/; revision=21516
2007-04-23 00:28:50 +00:00
Guy Harris 3b884cb0df Propagate Joerg's fix to make --enable-extra-gcc-checks turn off
--enable-warnings-as-errors (if any tests enabled by
--enable-extra-gcc-checks are safe to treat as errors, they're safe to
turn on by default).

svn path=/trunk/; revision=21515
2007-04-22 23:52:38 +00:00
Guy Harris aff8dc680d Turn on almost all warnings for Wiretap - if any of them cause problems
on some platforms due to unfixable problems (e.g., crappy vendor
headers), we can move them back to the "extra" list.

Put those warnings in the order in which they appear in the GCC man page
on my machine.

If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.

svn path=/trunk/; revision=21514
2007-04-22 23:47:56 +00:00
Jörg Mayer 8ff9801ec1 Fix regression: Automatically disable -Werror in case of extra gcc flags.
svn path=/trunk/; revision=21513
2007-04-22 23:01:49 +00:00
Bill Meier cb92dd7019 Another fix to allow gtk1 to compile w/o warnings....
svn path=/trunk/; revision=21512
2007-04-22 22:23:19 +00:00
Sebastien Tandel da8eba288d set #ifndef __USE_XOPEN instead of only #ifndef
should fix rev21508

svn path=/trunk/; revision=21511
2007-04-22 21:55:39 +00:00
Guy Harris 82583f9697 "struct sack_chunk_header" is presumably just a SACK chunk header
followed by zero or more gap start/end pairs; fix up the previous fix to
handle that correctly.

svn path=/trunk/; revision=21510
2007-04-22 20:43:01 +00:00
Guy Harris a346e923b7 Don't play type-punning games - they cause compiler warnings (not that
anybody appears to ever *set* sack_header->gaps).

svn path=/trunk/; revision=21509
2007-04-22 20:29:31 +00:00
Jörg Mayer b16106f89f Only #deinfe __USE_XOPEN if not already defined. On my Suse 10.2 it was
already #defined to 1, so this would create a warning/error.


svn path=/trunk/; revision=21508
2007-04-22 20:04:34 +00:00
Guy Harris 065be642f4 Get rid of some const warnings.
Use the "pnto" macros to fetch 16-bit quantities from a buffer - not
only do they have the right casts to avoid const warnings, they also
work even on platforms (such as SPARC) where you can't dereference
unaligned pointers without a trap.

Similarly, compare a possibly-unaligned (we make no alignment guarantees
in Wireshark) 16-bit quantity against 0 a byte at a time.

svn path=/trunk/; revision=21507
2007-04-22 18:26:45 +00:00
Guy Harris 6327554e6c Check the GLib version number, not the GTK+ version number; it's GLib we
care about, and this code doesn't use GTK+, so it doesn't include any
GTK+ headers and therefore doesn't get the GTK+ version number defined.

svn path=/trunk/; revision=21506
2007-04-22 18:04:52 +00:00
Ronnie Sahlberg a4ae600125 move some headers so that the compile works on gtk1
svn path=/trunk/; revision=21505
2007-04-22 16:44:36 +00:00
Ronnie Sahlberg a1131be153 move include of a few headers down a few lines so the compile works on
gtk1

svn path=/trunk/; revision=21504
2007-04-22 16:40:34 +00:00
Ronnie Sahlberg 40c806f54b compile fix for gtk1
svn path=/trunk/; revision=21503
2007-04-22 15:49:29 +00:00
Ronnie Sahlberg 416a353ee7 fix compiler warning for gtk1 builds
svn path=/trunk/; revision=21502
2007-04-22 15:48:18 +00:00
Ronnie Sahlberg 26ee9ac8ea dont include these headers under gtk1
svn path=/trunk/; revision=21501
2007-04-22 15:45:34 +00:00
Ronnie Sahlberg 872398a417 some updates to allow gtk1 to compile without warnings
svn path=/trunk/; revision=21500
2007-04-22 15:43:01 +00:00
Ronnie Sahlberg 7a97135752 GString.len has changed signednedd between gtk1 and gtk2
this will hopefully again compile under both gtk1 and 2


svn path=/trunk/; revision=21499
2007-04-22 15:22:53 +00:00
Sebastien Tandel a265df648d update of AC_WIRESHARK_PCAP_CHECK to detect if pcap header version is
corresponding to the library version for pcap_breakloop. Issue a warning if the
pcap_breakloop is present but not usable.


svn path=/trunk/; revision=21498
2007-04-22 13:38:50 +00:00
Jörg Mayer 7b20d35047 Fix a signedness warning.
svn path=/trunk/; revision=21497
2007-04-22 11:51:36 +00:00
Jaap Keuter 647446dadf Fix for bug 1541. Adjust offset for long longs by 8, not by 4.
svn path=/trunk/; revision=21496
2007-04-22 10:29:47 +00:00