Commit Graph

5 Commits

Author SHA1 Message Date
Stephen Fisher f4fcd1b146 Fix TiVoConnect dissector, seemingly broken since rev 18415.
svn path=/trunk/; revision=23807
2007-12-08 09:15:23 +00:00
Guy Harris 9c89cdaaa3 strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delenda
est.  Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).

In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.

We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot.  This causes strings that should
match not to match.

This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.

svn path=/trunk/; revision=23623
2007-11-27 18:52:51 +00:00
Guy Harris a85199af18 Make dissect_tivoconnect() a proper "new-style" dissector, and register
it as such.

Use "tvb_strncaseeql()" to do the check for "tivoconnect" at the
beginning of the packet.

svn path=/trunk/; revision=18415
2006-06-09 23:06:38 +00:00
Gerald Combs d5da1670f1 Update the download link in the help dialog. More Ethereal -> Wireshark.
svn path=/trunk/; revision=18391
2006-06-07 22:57:54 +00:00
Jörg Mayer 3e3dc39b29 The actual file packet-tivoconnect.c was missing
svn path=/trunk/; revision=18314
2006-06-02 07:11:11 +00:00