Commit Graph

29 Commits

Author SHA1 Message Date
Anders Broman 90753a169e Apply yet another set of the optimization patches:
When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length().
non heuristic dissectors

svn path=/trunk/; revision=23405
2007-11-08 22:40:20 +00:00
Jaap Keuter 4c22ba92f9 Flag error
svn path=/trunk/; revision=23218
2007-10-17 18:25:01 +00:00
Jörg Mayer 6bb9369681 "fix" some warnings about "might be used uninitialized" variables
svn path=/trunk/; revision=22983
2007-09-26 07:09:51 +00:00
Ronnie Sahlberg a944d1a3e8 since the fid dissector helper now adds a lot of extra info to the tree
we must now pass it a (semi-)valid tvb.


svn path=/trunk/; revision=21783
2007-05-15 09:48:02 +00:00
Ronnie Sahlberg e5e23150ab prettify dissection of FIDs,
put the filename, if known, on the fid expansion line

also place a "generated" fid in failed ntcreateandx so it is easier to 
quickly see which file the ntcreateandx failed for


svn path=/trunk/; revision=21739
2007-05-10 02:34:06 +00:00
Stephen Fisher 763a80f5bb Fix more warnings
svn path=/trunk/; revision=21286
2007-03-30 21:20:57 +00:00
Ulf Lamping 411249419d fix some more warnings (type casts)
svn path=/trunk/; revision=21141
2007-03-23 00:51:21 +00:00
Ronnie Sahlberg 5c2232dc22 replace a rotating buffer in smb with ep allocated memory
dont try dcerpc reassembly of fragments if we dont have the entire pdu

only call the heuristical dissectors once from smb/pipe as per guy(?)s comments about idempotence.
when doing reassembly, the dcerpc dissector is indeed not idempotent any more.



svn path=/trunk/; revision=19304
2006-09-23 13:21:54 +00:00
Ronnie Sahlberg d76b58cbfb track smb FIDFs when tehy are opened and closed.
add an expansion to the fid that display which frame itr was opened in and when it was closed.



someone may want to add tracking of actual filenames here as well.   i am not sure i need that feature myself   so ...



svn path=/trunk/; revision=18512
2006-06-18 05:45:40 +00:00
Ronnie Sahlberg a5db166102 rename add_fid() to dissect_smb_fid() as a firsdt step towards adding tracking of filename/openedframe/closedframe tracking for smb fids
svn path=/trunk/; revision=18506
2006-06-18 01:58:34 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Gerald Combs 40be5362b6 Coverity CID 48 is still complaining about a NULL dereference. Hopefully
this will fix it.

svn path=/trunk/; revision=17708
2006-03-23 18:22:42 +00:00
Ronnie Sahlberg 2f37e2de15 coverity bug 44
svn path=/trunk/; revision=17621
2006-03-14 05:38:47 +00:00
Ronnie Sahlberg b1a11016ec remove a redundant if statement
this if statement always evaluate to true since it is called from a single place that is only entered if the very same expression is also true there.




svn path=/trunk/; revision=17524
2006-03-08 10:51:33 +00:00
Ronnie Sahlberg 806a5c8d95 for really really weird malformed lanman packets it is theoretically possible
that trp is uniunitialized.



coverity bug 46



svn path=/trunk/; revision=17523
2006-03-08 10:36:28 +00:00
Ronnie Sahlberg 06d73310c9 fix a potential null dereference
found in coverity cid:48


svn path=/trunk/; revision=17509
2006-03-07 20:47:20 +00:00
Guy Harris f6ef22c553 Have show_exception() take a "const char *" as its exception message,
and not free the string to which it points.  Pass to
REPORT_DISSECTOR_BUG() strings allocated with ep_strdup_printf(), so
that they're freed automatically.

svn path=/trunk/; revision=16039
2005-09-28 16:16:37 +00:00
Guy Harris ab2dca9114 Move some headers for stuff defined by a dissector into epan/dissectors
- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file.

svn path=/trunk/; revision=15845
2005-09-17 00:31:15 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Ulf Lamping fdb5b1af02 just to get things straight: a dissector should *never* do any g_assert() calls!
in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED()

this will replace application crash by showing a dissector bug, which is the desired behaviour

there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too

one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain.

svn path=/trunk/; revision=14608
2005-06-10 18:28:22 +00:00
Ulf Lamping e2c3b60280 add a generated toplevel line between the TCP protocol and the desegmented content, to better understand what's going on while desegmenting.
We'll have to add similar mechanisms for other protocols as well...

svn path=/trunk/; revision=14527
2005-06-02 18:52:55 +00:00
Gerald Combs c64e5e59f6 Make a field type check more strict. Remove some unnecessary code.
svn path=/trunk/; revision=14338
2005-05-10 03:10:09 +00:00
Gerald Combs b41f8bfb2a Make sure we don't pass an invalid length to proto_tree_add_item(). Found
during fuzz testing.

svn path=/trunk/; revision=14237
2005-04-30 04:09:28 +00:00
Gerald Combs 38db8769c9 In dissect_pipe_lanman(), return FALSE if p_tvb is null, no matter what.
Fixes bug 132.

svn path=/trunk/; revision=14221
2005-04-28 18:34:02 +00:00
Gerald Combs 83f3aa6e08 Add an extra_info_type field to smb_extra_info_t so that we can make
sure we're not referencing a fid when we think we're referencing an
smb_nt_transact_info_t pointer.  (A fuzzed capture I have triggers
this behavior).


svn path=/trunk/; revision=14107
2005-04-16 21:54:32 +00:00
Ronnie Sahlberg 4a338216da pinfo->private_data was a quite subptimal idea
change the decodeas for dcerpc so that it actually works again for dcerpc over smb



svn path=/trunk/; revision=13515
2005-02-25 10:30:21 +00:00
Lars Roland ec9ca01616 Move the following files from /trunk to /trunk/epan:
asn1.[ch]
follow.[ch]
ptvcursor.[ch]
reassemble.[ch]
xmlstub.[ch]

fix #include statements accordingly.

svn path=/trunk/; revision=13366
2005-02-09 23:38:00 +00:00
Guy Harris 13bb12c4f1 Move a bunch of stuff that's more Windows-related than SMB-related to
"packet-windows-common.[ch]".

svn path=/trunk/; revision=11592
2004-08-03 02:28:49 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00