Commit Graph

968 Commits

Author SHA1 Message Date
Stephen Fisher 2896811274 Fix about 150 warnings new to gcc 4.0 in the error on warning directories.
Comment out -Werror in plugins/asn1/ until warnings can be fixed.


svn path=/trunk/; revision=21158
2007-03-23 22:49:23 +00:00
Stephen Fisher 8973617e4b From Sebastien Tandel:
First patch fixes warning of profinet and megaco plugins to compile
again with gcc-4.1.2.


svn path=/trunk/; revision=21155
2007-03-23 18:16:53 +00:00
Stephen Fisher 62f88a4a04 From Sebastien Tandel:
(Temporarily disable the warnings as errors default on Unix to get
to get the buildbots and people with gcc40 going again until those
additional warnings gcc40 generates can be fixed-I'm working on it
ASAP)

   Patch for configure.in which disables by default the treatment of
warnings as errors.
It can be enabled with './configure --with-warnings-as-errors'.
The macro will test first if GCC is present. If it's the case,
HAVE_WARNINGS_AS_ERRORS is defined. All the USING_GCC have been replaced
by HAVE_WARNINGS_AS_ERRORS.
With this switch, people won't suffer from unexpected warnings when
downloading svn sources during the transition time ;)


svn path=/trunk/; revision=21153
2007-03-23 17:49:59 +00:00
Stephen Fisher cdf47e536b Add -Werror when using GCC only to the Makefile.am of the base
directory and most of the plugins to match the same command 
put in the Makefile.nmake files for Windows compliations.  Fix
a few warnings when compiling under gcc 3.4.4 on FreeBSD.  Create
new automake file variable called USING_GCC in configure.in and
wiretap/configure.in to acomplish the above -Werror addition. 


svn path=/trunk/; revision=21127
2007-03-22 23:03:39 +00:00
Ulf Lamping 1bbf0a0de3 leave out the mate plugin for now, so buildbot might compile again ...
svn path=/trunk/; revision=21118
2007-03-22 13:57:02 +00:00
Ulf Lamping af10d352aa fix a warning, set CFLAGS to block new warnings
svn path=/trunk/; revision=21103
2007-03-22 00:11:55 +00:00
Ulf Lamping af9ae7eebb set CFLAGS to block new warnings for all plugins (except for giop and h223, which has remaining issues - for now)
svn path=/trunk/; revision=21102
2007-03-21 23:59:41 +00:00
Ulf Lamping 1de801962f fix two MSVC warnings
svn path=/trunk/; revision=21101
2007-03-21 23:58:14 +00:00
Ulf Lamping c3bf838051 as Jeff made empty field names "illegal", he changed the way PN-IO and PN-PTCP showed their blocks in an unwanted way - fix it
svn path=/trunk/; revision=21019
2007-03-11 12:07:43 +00:00
Jeff Morriss 62596bffb3 Fix bug 552:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552

by enforcing that header fields have names of length > 0.  This should fix
the display of those fields and also make them filterable (which was the
subject of the bug).  Abbreviations are (still) optional: if they are empty
then the field is not filterable.

Update README.developer with this information.

Add header field names in several dissectors where they were missing.

In packet-arp.c give "packet-storm-detected" a name (as above) but also set it
as _GENERATED.

Also remove trailing white space from all the files checked in.

svn path=/trunk/; revision=21018
2007-03-11 06:16:00 +00:00
Ulf Lamping e30640be45 PROFINET RT frames can also be transported over UDP Port 0x8892 - to be routable
svn path=/trunk/; revision=20985
2007-03-06 21:54:53 +00:00
Ulf Lamping 00335ac48e fix read handling of index 0x8051 and 0xe00c
svn path=/trunk/; revision=20963
2007-03-03 09:33:02 +00:00
Anders Broman c637027427 From Richard van der Hoff:
- Registers H.223 as a dissector for RTP CLEARMODE payloads -
and makes some other modifications to the H.223 dissector to make this
work correctly.

-Allows a standalone binary, epan/reassemble_test, to be built; this can be run from the commandline and should end up printing out "success" 
if all goes well.

svn path=/trunk/; revision=20935
2007-02-27 06:25:07 +00:00
Jaap Keuter cf13f56dc8 -Add the compiler version to the plugin resource
-Remove the SPECIAL_BUILD tag
-Set to OS type to NT_WINDOWS32

svn path=/trunk/; revision=20934
2007-02-26 20:39:38 +00:00
Ulf Lamping cd08e6448f fix the padding in the read/write headers, some other minor changes
svn path=/trunk/; revision=20927
2007-02-25 15:50:40 +00:00
Ulf Lamping 7887d478cc add a new function dissect_dcom_HRESULT_item() for some more flexibility, use it in the CBA-ACCO dissector - as the value_strings from dcom can't be used in hf_register_info from a plugin
svn path=/trunk/; revision=20926
2007-02-25 15:48:43 +00:00
Luis Ontanon 5b9457a104 have megaco handing over to h248 in case it does not recognize the buffer as text encoded megaco
svn path=/trunk/; revision=20907
2007-02-23 20:04:09 +00:00
Jaap Keuter a8fb7d24d0 Properly introduce packet-pn.c as a helper
svn path=/trunk/; revision=20903
2007-02-23 19:37:01 +00:00
Anders Broman 33910c713f From Richard van der Hoff:
Along with this bug, identified by Mark, there is another problem, in that one of the chunks of my earlier patch seemed to get missed off when Anders committed it. This won't break anything yet, as the H.223-over-RTP dissection hasn't landed on trunk yet, but it will cause all sorts of nasties when it does.

Here is a new patch, against current trunk, which should fix Mark's bug, my bug, and a comment typo.

And a patch wich improves the general robustness of the h.223 dissector (making it less likely to crash on malformed data).

Hopefully this also fixes a bug raised by Fabio Sguanci a few weeks ago. 
Fabio: I think a better way to fix the problem is to stop the dissector crashing when it finds a malformed PDU, so that it just treats the first pdu as malformed; there is then no need to special-case it.

svn path=/trunk/; revision=20898
2007-02-22 20:40:19 +00:00
Anders Broman a1e273b325 From Richard van der Hoff:
The H.223 dissector contains code to deal with "bitswapped" captures - ie, where all of the bytes have their bits backwards. It seems that this is much better handled as a separate dissector entry point, so that the right one can be chosen when the dissector is registered, rather than the current dubious heuristics.

svn path=/trunk/; revision=20893
2007-02-21 07:26:33 +00:00
Guy Harris c127df0bc8 Include <string.h> to declare memcpy().
svn path=/trunk/; revision=20842
2007-02-19 00:56:22 +00:00
Ulf Lamping 822bb2e489 fix an error added lately
svn path=/trunk/; revision=20832
2007-02-17 11:13:24 +00:00
Ulf Lamping 2172e293d6 some more compiler warnings removed
svn path=/trunk/; revision=20829
2007-02-17 09:42:38 +00:00
Ulf Lamping 16aa7c17db squelch some compiler warnings
svn path=/trunk/; revision=20828
2007-02-17 08:08:40 +00:00
Ulf Lamping d6e22b2d9a major code cleanup:
- move dcom-cba and pn-rt files into profinet plugin (where they really belong)
- move some common pn functionality into new packet-pn.c/h instead of having duplicate code

svn path=/trunk/; revision=20825
2007-02-16 21:53:36 +00:00
Stephen Fisher 0ebc01dc03 From Sebastien Tandel:
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override
the buggy g_strsplit() function when compiling for GTK1.  Include this
work-around function (ws_strsplit) in libwireshark.def.  Add notes on usage
to README.developer.  Include epan/ws_strsplit.h in all files that use
g_strsplit().


svn path=/trunk/; revision=20804
2007-02-13 20:57:22 +00:00
Ulf Lamping aad5a4e6b1 add remaining TLV blocks (complete now?)
add a lot of missing index values
fix some minor bugs

svn path=/trunk/; revision=20795
2007-02-12 19:01:20 +00:00
Ulf Lamping 44ee701ba6 remove some warnings
svn path=/trunk/; revision=20785
2007-02-11 04:12:07 +00:00
Ulf Lamping 59a86ae3e9 remove a g_warning left over from debugging
svn path=/trunk/; revision=20784
2007-02-11 03:45:21 +00:00
Ulf Lamping b04c53a23c add a lot more TLV block decodes, some code cleanup, ...
svn path=/trunk/; revision=20763
2007-02-10 08:03:47 +00:00
Jaap Keuter 2532bc2a1a Source code cleanup.
svn path=/trunk/; revision=20755
2007-02-09 14:43:24 +00:00
Ulf Lamping 98f2412a6f various major enhancements to the PROFINET-IO dissector (including some new TLV blocks)
svn path=/trunk/; revision=20751
2007-02-08 18:29:47 +00:00
Ulf Lamping 8559a25d23 - add dissection for "I&M0" block
- enhance dissection or ErrorDecode2 (ErrorCode1 rta_err_cls_protocol specific) - a lot more of ErrorCode1/ErrorCode2 combinations still to go ...

svn path=/trunk/; revision=20724
2007-02-06 01:37:32 +00:00
Jaap Keuter 8a543e99df Modification of version resource.
- FILEFLAGS should not contain VS_FF_SPECIAL_BUILD
- FILEOS changed to VOS_NT_WINDOWS32 since we no longer support pre-NT platforms
- Adding Comments string to include compiler, based on MSVC_VARIANT symbol

svn path=/trunk/; revision=20554
2007-01-25 07:42:10 +00:00
Ulf Lamping 2cbce84d41 Win32: MSVC > 6 doesn't work well with Unicode filenames!
fix this, by providing required functions in the new file file_util.c - it's mostly copied from GLib (g_open alike - that take UTF8 as filename format but don't use msvcrt.dll V6 for this as the glib files do) 

"link" to these functions in file_util.h: #define eth_open eth_stdio_open

revert changes (from SVN 20282) throughout the code related to these file functions which were introduced with the first tries of MSVC 2005 ...

Hopefully I've done everything right with the new file_util.c ...

svn path=/trunk/; revision=20402
2007-01-12 03:05:28 +00:00
Jaap Keuter d2d3148e00 Trying to get buildbot Ubuntu-5.10-x86 distcheck to build again.
Adding asn1.[ch] to the correct makefile symbols.

svn path=/trunk/; revision=20379
2007-01-10 20:19:16 +00:00
Tomas Kukosa a68f0224c3 move asn1.c/.h files into plugins/asn1 directory as just this plugin uses it now
svn path=/trunk/; revision=20372
2007-01-10 07:09:30 +00:00
Stephen Fisher f5ea4ee657 From Mike Davies:
There was a change in Corrigendum 1 (03/2004) to H.248.1 which allows an
empty {} to be omitted from the Signal Descriptor.  Currently (SVN 20346)
this causes Wireshark to report [Packet size limited during capture] as
shown in the attached example outputs.

I have attached a possible patch to solve this.


svn path=/trunk/; revision=20360
2007-01-09 22:32:23 +00:00
Ulf Lamping 39956903b5 PropagationDelayFactor -> LineDelay
svn path=/trunk/; revision=20348
2007-01-08 22:11:56 +00:00
Ulf Lamping cc164653a0 add experimental support for some more of the MSVC_VARIANTs:
- Microsoft .Net Framework SDK Version 1.1
- Microsoft .Net Framework 2.0 SDK
... which seems to work fine now (except for the open problems like zlib) :-)

Some of the plugins need different linker flags depending on the MSVC. I've set a "define" in config.nmake (PLUGIN_LDFLAGS) and used it in the affected plugins/.../Makefile.nmake. Maybe we should generally change the plugins that way.

btw: The "Microsoft Visual C++ Toolkit 2003" (mentioned some time ago on the list) doesn't work as some important files are missing - and we have much easier alternatives now :-)

svn path=/trunk/; revision=20332
2007-01-06 01:05:59 +00:00
Jaap Keuter ad44a5cdfb Serious source code cleanup.
svn path=/trunk/; revision=20308
2007-01-04 14:23:56 +00:00
Guy Harris 6e022db16c Call the handoff registration routine proto_reg_handoff_irsir() to avoid
collisions with the WSP dissector's proto_reg_handoff_sir() - and don't
call it in the proto_register_irsir(); handoff registration routines are
supposed to be called after *all* registration routines are called.

svn path=/trunk/; revision=20303
2007-01-04 12:05:17 +00:00
Ulf Lamping d53f947b16 clean should also remove generated plugin.c and manifest files
svn path=/trunk/; revision=20291
2007-01-03 06:06:53 +00:00
Bill Meier 444602bf97 Oops: wireshark.com --> wireshark.org
Also: 1 additional Ethereal --> Wireshark

svn path=/trunk/; revision=20272
2007-01-02 17:19:25 +00:00
Jaap Keuter b0c9345ace Align build target names.
svn path=/trunk/; revision=20269
2007-01-02 13:46:06 +00:00
Jaap Keuter b871e65adb More Ethereal -> Wireshark renaming.
svn path=/trunk/; revision=20268
2007-01-02 13:36:45 +00:00
Jaap Keuter 3cb8c5a7cf More Ethereal -> Wireshark renaming
svn path=/trunk/; revision=20267
2007-01-02 13:34:05 +00:00
Anders Broman 25862eff23 Use the correct function to translate to hex.
svn path=/trunk/; revision=20226
2006-12-27 22:24:22 +00:00
Jaap Keuter 293586906a Adding moduleinfo.nmake to the distribution
svn path=/trunk/; revision=20224
2006-12-27 12:21:30 +00:00
Jaap Keuter 5800f59d15 Bump micro version number, like in moduleinfo.h
svn path=/trunk/; revision=20178
2006-12-20 10:07:20 +00:00