27598e20a2
fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8806
...
assign the return values of decode_...() functions to a signed int
check for negative return values
svn path=/trunk/; revision=49963
2013-06-16 15:29:14 +00:00
d0fb6aca01
Simplify the tree code slightly - just don't call the transform function
...
if it's NULL, meaning we don't need to define an identity callback.
svn path=/trunk/; revision=49962
2013-06-16 15:17:53 +00:00
f4b3cb0917
Clarify interface/test for DL HARQ id, and remove a trailing comma from
...
an enum.
svn path=/trunk/; revision=49961
2013-06-16 15:11:21 +00:00
562a126ddc
Improve the way PDCP status PDUs are shown.
...
For the bitmap, present and missing SNs are both
interesting, but only until the last received SN
(i.e. the last byte of the bitmap will be padded
out with zero bits).
It would be possible to use existing sequence analysis
info, where available, to decide if any zeros beyond the last
received SN are interesting...
svn path=/trunk/; revision=49959
2013-06-16 14:24:47 +00:00
f2db1cd3e5
[Automatic manuf, services and enterprise-numbers update for 2013-06-16]
...
svn path=/trunk/; revision=49957
2013-06-16 14:03:36 +00:00
98268eb59b
some minor fixes
...
svn path=/trunk/; revision=49956
2013-06-16 04:34:38 +00:00
69f08fd281
display some more box names
...
svn path=/trunk/; revision=49955
2013-06-16 02:52:01 +00:00
860b920383
Make the B->A graph label show as A<-B to be consistent with the column
...
heading.
svn path=/trunk/; revision=49954
2013-06-16 02:35:51 +00:00
b3ac3506e8
Add some comments around looking up names for port numbers.
...
(calling getservbyname() is really slow, but only called once per port
number...)
svn path=/trunk/; revision=49953
2013-06-16 01:53:43 +00:00
82a13484b3
Add warning comment to tree autoreset function about allocator
...
destruction order, and note that it may need thinking about.
svn path=/trunk/; revision=49952
2013-06-16 01:47:43 +00:00
28dafa414a
Fix occasional wmem_test failure, allocator destruction order matters
...
(should it?)
svn path=/trunk/; revision=49951
2013-06-16 01:44:09 +00:00
ca0f8ee6da
Make the libwiretap Buffer routines usable from C++, and fix the C++ UI
...
code to handle the API changes for the seek-read routines.
svn path=/trunk/; revision=49950
2013-06-16 01:40:04 +00:00
8c9edf1280
Have the seek-read routines take a Buffer rather than a guint8 pointer
...
as the "where to put the packet data" argument.
This lets more of the libwiretap code be common between the read and
seek-read code paths, and also allows for more flexibility in the "fill
in the data" path - we can expand the buffer as needed in both cases.
svn path=/trunk/; revision=49949
2013-06-16 00:20:00 +00:00
3846abe34d
Replace if-else-if with switch statements
...
svn path=/trunk/; revision=49948
2013-06-16 00:14:07 +00:00
f715a8bbbc
Further iteration
...
svn path=/trunk/; revision=49947
2013-06-15 21:28:43 +00:00
2c71f23d1e
Make use of text metrics and devmode data to properly format a page for printing. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7543
...
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=49946
2013-06-15 12:57:32 +00:00
6fd601bc3b
Most of a red-black tree implementation for wmem, based heavily on the emem
...
version.
One plane trip's worth of work.
svn path=/trunk/; revision=49945
2013-06-15 10:40:56 +00:00
2b3891fa3b
Pull some of the code to set the struct wtap_pkthdr into
...
parse_netscreen_hex_dump().
svn path=/trunk/; revision=49944
2013-06-15 09:05:04 +00:00
2b5344666a
Fill in at least some of the struct wtap_pkthdr in both the read and
...
seek-read routines.
svn path=/trunk/; revision=49943
2013-06-15 01:51:21 +00:00
25d9d55cef
Rename radcom_process_rec_header() to radcom_process_rec_header() and
...
move the code to file in a struct wtap_pkthdr there.
svn path=/trunk/; revision=49942
2013-06-14 23:59:04 +00:00
f42e5bc9c0
Remove check_col() and the occasional tree.
...
This leaves just the Pidl dissectors remaining for removal of check_col() in the dissectors directory. A small handful of check_col() calls remain outside of the dissectors.
svn path=/trunk/; revision=49941
2013-06-14 19:46:54 +00:00
c5d092ec3a
Final draft for the epan working child API
...
svn path=/trunk/; revision=49940
2013-06-14 19:19:29 +00:00
dd7b71e384
Fix IEEE802a OUI lookups.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3123
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=49939
2013-06-14 17:57:08 +00:00
de68fd6eea
Removed check_col() and the occasional tree.
...
svn path=/trunk/; revision=49938
2013-06-14 17:49:53 +00:00
14b65f91a4
Ensure that Wireshark isn't obscured by the system taskbar or by any other desktop toolbars. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3034
...
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=49937
2013-06-14 17:47:54 +00:00
48dccb60ad
remove some unnecessary check_col() calls
...
svn path=/trunk/; revision=49936
2013-06-14 15:53:52 +00:00
2de0e97d65
add editor modelines
...
svn path=/trunk/; revision=49935
2013-06-14 15:50:20 +00:00
3fe6a50c03
new dissector for the MP4/ISOBMFF file format
...
svn path=/trunk/; revision=49934
2013-06-14 15:33:58 +00:00
b19c7d5537
make line endings consistent
...
add svn properties
svn path=/trunk/; revision=49933
2013-06-14 15:08:10 +00:00
101af7fa2d
Mark unused params as such.
...
svn path=/trunk/; revision=49932
2013-06-14 14:56:00 +00:00
66f10eec2e
Add Common Address Redundancy Protocol (CARP) dissector, bug 8633 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8633 )
...
From Uli Heilmeier
CARP shares the same protocol ID as VRRP (and VRRP's is IANA registered), so heuristics are provided. VRRP and CARP are very similar, so I'm not sure having heuristics for both dissectors will help CARP.
svn path=/trunk/; revision=49931
2013-06-14 14:35:34 +00:00
cfc133ddb6
Add heuristic capabilities to the IP dissector. The motivating factor was the CARP dissector, bug 8633 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8633 )
...
This should allow the ugly IPIP/TAPA hack to be replaced with a proper heuristic, but I don't see any sample TAPA traces to feel confident in making the change myself.
svn path=/trunk/; revision=49930
2013-06-14 14:13:28 +00:00
9c26c32645
Add parentheses around assignment used as truth value.
...
svn path=/trunk/; revision=49929
2013-06-14 13:20:41 +00:00
84352845d9
From Anders: add some commands, AVPs, and application IDs.
...
From me: fix up some white space/indentation.
svn path=/trunk/; revision=49928
2013-06-14 13:08:45 +00:00
2dbf6c59a2
Remove check_col() from ASN.1 dissectors
...
svn path=/trunk/; revision=49927
2013-06-14 12:44:50 +00:00
875040ec1e
And back it out again, just like the Makefile.am
...
svn path=/trunk/; revision=49926
2013-06-14 11:44:19 +00:00
5e974e8f45
Copy over
...
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=49865
to cmake
svn path=/trunk/; revision=49925
2013-06-14 11:42:40 +00:00
0d6110e2a4
try_val_to_str() may return NULL
...
although this is nearly impossible here,
use val_to_str_const() anyway to be on the safe side
svn path=/trunk/; revision=49924
2013-06-14 04:01:21 +00:00
dfa2156e30
Remove check_col() and the occasional tree.
...
svn path=/trunk/; revision=49923
2013-06-14 02:50:46 +00:00
e9a5b16a09
From Katrina Zhang via Anders (manually applied by me): dissect node features.
...
From me: remove some tabs and trailing white space.
svn path=/trunk/; revision=49922
2013-06-14 02:44:15 +00:00
fa5b45834b
Remove check_col() and the occasional tree.
...
svn path=/trunk/; revision=49921
2013-06-14 01:56:28 +00:00
0f0c111119
Remove check_col() and the occasional tree.
...
svn path=/trunk/; revision=49920
2013-06-14 01:02:11 +00:00
af02ac36ac
On OS X set the toolbar icon size to match our current icons.
...
svn path=/trunk/; revision=49919
2013-06-13 18:58:29 +00:00
285bc53826
Fix typo error
...
svn path=/trunk/; revision=49918
2013-06-13 14:20:20 +00:00
53c658bb19
Add basic dissection of Prefix Exclude option
...
svn path=/trunk/; revision=49917
2013-06-13 14:18:10 +00:00
5fa16b2008
From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8794 :
...
Display the value of unknown sense descriptor codes in the tree item.
Also fix the length of the subtree.
svn path=/trunk/; revision=49916
2013-06-13 13:51:19 +00:00
32bec58892
From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8791 :
...
Improve dissection of GSM SIM payloads in USB CCID packets
svn path=/trunk/; revision=49915
2013-06-13 10:52:34 +00:00
e1b7a26463
Adding support of BGP flow spec RFC 5575.
...
From Matt Texier, bug 8691 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8691 )
svn path=/trunk/; revision=49914
2013-06-13 02:35:23 +00:00
53290ee17c
Updated the rsync dissector to make it able to parse the newer variants of the protocol, treat binary data consistently and clearly differentiate packets of the client and the server.
...
From Benoit Daloze, bug 8743 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8743 )
svn path=/trunk/; revision=49913
2013-06-13 01:06:31 +00:00
3dbf3b975a
Give somewhat more precise names for character encodings ("Unicode"
...
doesn't specify a single way to encode characters in an octet stream -
there's UTF-8 and UTF-16BE/LE, as well as UCS-2BE/LE for a subset of
Unicode, and "Latin" really means "ISO 8859-1" a/k/a "ISO Latin 1".
svn path=/trunk/; revision=49912
2013-06-12 18:17:15 +00:00
Martin Kaiser