osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
41,670 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

114 Commits

Author SHA1 Message Date
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Bill Meier 6fbb09d50b General Cleanup including: 
- Remove unneeded #include <stdlib.h>;
- Remove "README.developer" comments;
- Reformat hf[] entries;
- Remove unneeded variable initialization;
- "localize" some variables;
- Whitespace/indentation/long lines/formatting
- (In one case) proto_tree_add_uint returns a proto_item* (not a proto_tree *);

svn path=/trunk/; revision=42678
 2012-05-17 14:35:11 +00:00
Anders Broman 3b0c9892a0 From Steve Magnani: 
Add decoding of fields within endpoint descriptor wMaxPacketSize

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7206

svn path=/trunk/; revision=42286
 2012-04-27 08:44:36 +00:00
Alexis La Goutte cba02e0a50 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=42165
 2012-04-20 15:33:23 +00:00
pascal e0e5b02bca From Johannes Stezenbach: 
Use right value for SET_FEATURE request code
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7058

svn path=/trunk/; revision=42009
 2012-04-10 16:05:52 +00:00
Jakub Zawadzki 80445e5a99 Fix off by one shift errors introduced in r39530 where it seemed proper[1] 
[1] I'm unsure of packet-dtpt, so I haven't patch it.

svn path=/trunk/; revision=41873
 2012-03-31 20:57:15 +00:00
Jeff Morriss 5629a3fa00 Fix fuzz failure reported in 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6976 :

Don't assume that all responses have conversations to find.

svn path=/trunk/; revision=41726
 2012-03-21 21:21:58 +00:00
Anders Broman b971f1b1a0 From Steve Magnani: 
USB: incorrect generated bInterfaceClass for composite device CONTROL transactions.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6964

svn path=/trunk/; revision=41715
 2012-03-21 08:40:19 +00:00
Jeff Morriss 7bc574b776 From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6963 : 
Conversation address generation during processing of endpoint descriptors
is not being done in a manner consistent with that of general USB
packet dissection. I am not aware of any observable manifestation of this
bug.

svn path=/trunk/; revision=41634
 2012-03-17 23:46:39 +00:00
Anders Broman c00ca87104 From Steve Magnani: knock URB Setup out from under USB URB https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6934 
svn path=/trunk/; revision=41492
 2012-03-11 22:31:18 +00:00
Anders Broman 970272235d From martijn: subdissectors for URB_INTERRUPT. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6929 
svn path=/trunk/; revision=41459
 2012-03-10 16:16:07 +00:00
Anders Broman f030f799bd From Steve Magnani: USB: centralize some common dissection code for class reuse. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6930 
svn path=/trunk/; revision=41458
 2012-03-10 16:09:28 +00:00
Anders Broman 9581065b3f USB: unknown GET DESCRIPTOR response triggers assert failure https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6826 
svn path=/trunk/; revision=41388
 2012-03-07 09:35:44 +00:00
Anders Broman 064276f53b From Steve Magnani: USB: incorrect decoding of Endpoint-targeted class-specific SETUP https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6910 
svn path=/trunk/; revision=41371
 2012-03-06 09:25:53 +00:00
Jeff Morriss 4289f6d7be Don't add an FT_BYTES with proto_tree_add_uint(). 
svn path=/trunk/; revision=41325
 2012-03-02 22:24:12 +00:00
Alexis La Goutte 28f4c55b5b From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6873 
USB: SETUP information can be added to incorrect tree

svn path=/trunk/; revision=41210
 2012-02-27 16:48:29 +00:00
Anders Broman 416117f63a From Steve Magnani: 
USB: Add dissection for Interface Association descriptor.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6842

svn path=/trunk/; revision=41157
 2012-02-23 11:20:52 +00:00
Anders Broman c36b0f1b03 From Steve Magnani: 
USB: add infrastructure for dissecting class-specific descriptors.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6825

svn path=/trunk/; revision=40979
 2012-02-12 07:18:05 +00:00
Anders Broman 75de89cd1b From Steve Magnani: 
USB: support filtering of isochronous packets via usb.bInterfaceClass.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6824

svn path=/trunk/; revision=40973
 2012-02-11 16:59:38 +00:00
Anders Broman 5da72b4d78 From Steve Magnani: 
USB: Endpoint bmAttributes not decoded correctly.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6814

svn path=/trunk/; revision=40939
 2012-02-08 20:21:44 +00:00
Chris Maynard faf9175665 Add support for dissecting AT commands in USB URB_CONTROL packets. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6037 
svn path=/trunk/; revision=40247
 2011-12-19 23:44:01 +00:00
Bill Meier 54b72021bb Fix encoding arg for various fcn calls: 
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
 2011-10-24 19:57:53 +00:00
Bill Meier d7a1840204 Replace use of tvb_get_ephemeral_faked_unicode() by use of tvb_get_ephemeral_unicode_string(); 
Fix encoding arg as needed.

svn path=/trunk/; revision=39530
 2011-10-23 22:58:45 +00:00
Jeff Morriss 431332092d From Daniel via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6461 : 
Register the USB dissector by name.

svn path=/trunk/; revision=39453
 2011-10-18 01:05:57 +00:00
Bill Meier 67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
 2011-10-10 00:39:31 +00:00
Bill Meier 4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
 2011-10-06 03:35:44 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Chris Maynard 3037a852a8 No need to check that usb_trans_info is not NULL here. The only way it could have been NULL is if se_alloc0() returned NULL, but then it would have already been dereferenced before now. Fixes Coverity CID 612, "REVERSE INULL". 
svn path=/trunk/; revision=38417
 2011-08-08 20:08:24 +00:00
Chris Maynard 261875b924 Allow both PPP and ISO/IEC 13818-1 over USB to be dissected using heuristics. 
Resolves bug 4814.

svn path=/trunk/; revision=37039
 2011-05-10 14:22:17 +00:00
Bill Meier 513a5f5154 Add #include <ctype.h> before #include "isprint.h"; 
Remove an unneeded line of code;
Do some indentation & whitespace cleanup.

svn path=/trunk/; revision=36785
 2011-04-21 22:42:32 +00:00
Alexis La Goutte 0b097292d2 Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=36765
 2011-04-21 13:45:14 +00:00
Alexis La Goutte 7e979f95aa Fix Dead Store (Dead nested assignment) Warning found by Clang 
svn path=/trunk/; revision=36761
 2011-04-21 13:34:43 +00:00
Chris Maynard 28ef67fb39 Change urb_type from FT_STRING to FT_UINT8. This fixes the display filtering 
for this field.  This change was prompted because of the following query:
    http://ask.wireshark.org/questions/3113/usburb_type-values

Also, remove 2 unused fields found by running tools/checkhf.pl.

svn path=/trunk/; revision=36331
 2011-03-25 18:51:12 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Chris Maynard 6003c15d6f From Marton Nemeth via bug #5490: Cleanup USB endpoint direction display. 
svn path=/trunk/; revision=35182
 2010-12-13 15:59:14 +00:00
Chris Maynard dbe63e9730 Add support for USB isochronous. From Marton Nemeth via bug #5370. 
svn path=/trunk/; revision=35025
 2010-11-24 17:33:58 +00:00
Bill Meier e52c685b2a Use value_string_ext fcns to access a value_string array; 
Sort value_string array to be in ascending order by value;
Minor whitespace cleanup.

svn path=/trunk/; revision=34729
 2010-10-30 20:03:58 +00:00
Guy Harris 149ccb3b68 Attempt to handle isochronous descriptors between the 64-byte header and 
the payload.  Should fix bug 4401.

svn path=/trunk/; revision=32828
 2010-05-16 03:19:40 +00:00
Bill Meier 10ffd14b8f Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces) 
svn path=/trunk/; revision=32735
 2010-05-10 15:54:57 +00:00
Guy Harris 21a210b777 From Chris Maynard: 
Support PPP-over-USB.

	Don't remove the USB pseudo-header from the packet data for
	Linux USB packets, just byte-swap it if necessary and have the
	USB dissector fetch the pseudo-header from the raw packet data.

	Update USB language ID values.

svn path=/trunk/; revision=32534
 2010-04-21 20:51:22 +00:00
Bill Meier 055dd62063 #include <string.h> not needed. 
svn path=/trunk/; revision=32410
 2010-04-06 21:14:01 +00:00
Bill Meier 73eb16d678 Fix some gcc -Wshadow warnings 
svn path=/trunk/; revision=31623
 2010-01-22 17:41:47 +00:00
Anders Broman c4dd31cd87 From Didier Gautheron: 
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
 2010-01-13 20:25:10 +00:00
Jaap Keuter 134e77034e From Márton Németh: 
When an unknown requests arrives try to parse it using the usual request format.

svn path=/trunk/; revision=30775
 2009-10-30 22:46:30 +00:00
Stig Bjørlykke 1e20ff2638 From Marton Nemeth via bug 4181: 
Take the USB descriptor length from packet.

svn path=/trunk/; revision=30763
 2009-10-29 21:51:20 +00:00
Stig Bjørlykke 373fff9846 From Marton Nemeth via bug 4173: 
Move bmRequestType field constants to header file.

svn path=/trunk/; revision=30761
 2009-10-29 21:32:21 +00:00
Stig Bjørlykke 337896f4c6 From Marton Nemeth via bug 4163: 
Add support for input URBs.

svn path=/trunk/; revision=30690
 2009-10-25 10:45:15 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining() 
svn path=/trunk/; revision=29446
 2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Guy Harris f846e15d40 Fix indentation, get rid of a comment that might no longer apply (dump 
*what* as hex?  The stuff we now display as generic fields?).

svn path=/trunk/; revision=29257
 2009-07-31 23:38:02 +00:00