Commit Graph

15 Commits

Author SHA1 Message Date
Jakub Zawadzki b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Bill Meier 57c6467b81 Fix some bugs & do extensive cleanup;
Bugs fixed:
 - Calling col_...() fcns or dissectors under 'if (tree)'
 - Potential buffer overflows (if bad data)
 - Misc incorrect data display issues
Cleanup including;
 - Remove unneeded #includes
 - Fix excessive use of value_strings
 - Use extended value_strings & val_to_str_(ext_)const as appropriate
 - Optimize repeated fetches of the same data from a tvb
 - Do general code simplification
 - Remove or #if 0 unused code;
 - Add XXX comments for code which may be incorrect
 - Remove unneeded prefs callback to proto_reg_handoff...()
 - Remove unneeded use of check_col()
 - Define several functions as static
 - Move proto_reg_handoff...() to the end of the file
 - Fix whitespace (including "4 space tabs")
 - ...

svn path=/trunk/; revision=43129
2012-06-06 04:54:47 +00:00
Anders Broman d8d9450a4f From Lars Ruoff:
Dissector for Alcatel-Lucent Enterprise Universal Alcatel- and NOE protocol, take II.
families.
Meant as a replacement for existing UA-dissector in trunk because of better
feature set:
- latest protocol specifiaction
- more detailed dissection and filtering possibilities on subprotocols
- RTP stream setup
- NOE over SIP

Lars Ruoff
On behalf of Alcatel-Lucent Enterprise

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844

svn path=/trunk/; revision=41266
2012-03-01 15:23:05 +00:00
Alexis La Goutte d9a4d939b3 Reverse Revision 41134 (Need to fix error/warning before...)
svn path=/trunk/; revision=41135
2012-02-22 09:18:30 +00:00
Anders Broman ad360ce0dd From Lars Ruoff:
Dissector for Alcatel-Lucent Enterprise Universal Alcatel- and NOE protocol
families.
Meant as a replacement for existing UA-dissector in trunk because of better
feature set:
- latest protocol specifiaction
- more detailed dissection and filtering possibilities on subprotocols
- RTP stream setup
- NOE over SIP

Lars Ruoff
On behalf of Alcatel-Lucent Enterprise

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844

svn path=/trunk/; revision=41134
2012-02-22 08:37:46 +00:00
Alexis La Goutte 65ce72e3a3 From mtwire via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6722
Small corrections in the Alcatel UA dissector

The most important change is to add a condition in dissector for TLV with ID equal to 104 as in the case of the 120. No condition causing 'malformed packet'.

svn path=/trunk/; revision=40424
2012-01-10 15:12:13 +00:00
Chris Maynard 5debb5c5e3 Fix memory leaks involving tvb_get_string[z]().
svn path=/trunk/; revision=40312
2011-12-28 16:36:57 +00:00
Bill Meier c4ace59928 Various Minor cleanup:
- Remove unneeded #includes;
- Use val_to_str_const() in several places;
- Reformat long lines;
- Fix whitepace and indentation.

svn path=/trunk/; revision=40016
2011-11-27 15:34:07 +00:00
Bill Meier 5f73d64e50 'guint8=tvb_get_guint8() + 2' can wrap. Use 'gint=...' instead. ditto for 'gint16=...'
Also:
 - remove unneeded #include;
 - Remove unneeded check_col();
 - use val_to_str_const() in several cases.

svn path=/trunk/; revision=39835
2011-11-14 19:58:12 +00:00
Guy Harris 833908d49b The sum of a guint16 and 2 does not necessarily fit in a guint16. Put
it into a gint, instead.  This should fix bug 6572, by preventing an
infinite loop if the sum in question is 0 modulo 2^16.

svn path=/trunk/; revision=39817
2011-11-13 01:38:46 +00:00
Alexis La Goutte 4ea690d66e From Marek Tews via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6060
Enhance Universal Alcatel Protocol

Several fixes and heuristic version. You can also specify the ports (as in the previous version), if the heuristic version is not working properly.

svn path=/trunk/; revision=39691
2011-10-31 17:26:02 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Alexis La Goutte da7e08a4d9 From mtwire via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6060
New dissectors: (UA) Universal Alcatel Protocol and transport UAUDP

From me :
* Prefer proto_tree_add_item (when is possible)
* Use 4-space indenting
* Add Modeline information
* Fix Clang Warning

svn path=/trunk/; revision=39167
2011-09-27 18:21:57 +00:00