Commit Graph

33 Commits

Author SHA1 Message Date
Jakub Zawadzki b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Bill Meier 2bf572bc41 Remove unneeded #includes: proto.h,tvbuff.h,value_string.h,stdlib.h,...
svn path=/trunk/; revision=38413
2011-08-08 17:59:32 +00:00
Alexis La Goutte a513ad55ba From Colin O'Flynn & Robert Craige via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6109
Add support for PANA Relay

svn path=/trunk/; revision=38257
2011-07-29 13:19:16 +00:00
Bill Meier d2269ce7d5 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
svn path=/trunk/; revision=37716
2011-06-19 18:47:35 +00:00
Bill Meier 32ef48510d From Yasuyuki Tanaka: Fix PANA (RFC 5191) packets are dissected incorrectly.
(AVP length as being interpreted incorrectly).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5183

From me: General dissector code cleanup & bug fixing:
 - Show/dissect AVP "value" for non-vendor-specific AVPs;
 - Tighten & cleanup heuristic;
 - Fix some potential overflow issues;
 - #include <stdio.h>  #include <stdlib.h> not req'd;
 - Fix some whitespace & formatting;

svn path=/trunk/; revision=34366
2010-10-04 16:46:39 +00:00
Jeff Morriss 729de1a635 As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html
(as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 :

Write a new convenience routine for finding a conversation and, if it is not
found, create it.  The frame number and addresses are taken from pinfo (as is
the common case).

Use this function in a bunch of dissectors.

svn path=/trunk/; revision=32790
2010-05-13 18:28:34 +00:00
Bill Meier 055dd62063 #include <string.h> not needed.
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Anders Broman c4dd31cd87 From Didier Gautheron:
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
2010-01-13 20:25:10 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Anders Broman b4aeb97ed5 tvb_new_real_data -> tvb_new_child_real_data
svn path=/trunk/; revision=28517
2009-05-29 06:16:43 +00:00
Gerald Combs 6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Bill Meier 09bef39f3d Minor cleanup related to proto_register, proto_reg_handoff
svn path=/trunk/; revision=26307
2008-09-30 14:46:48 +00:00
Guy Harris 266b212aad The right length to use when scanning all the data in a packet is the
*reported* length, so that if the packet was cut short by a snapshot
length, we get an exception because we run past the end, and the packet
is marked as having been cut short.

Do not use DISSECTOR_ASSERT() to check for the validity of packet data;
dissectors should try to handle even malformed packets, they shouldn't
report malformed packets as dissector bugs (if DISSECTOR_ASSERT(), that
is *ipso facto* evidence of a dissector bug, *even if the packet is
malformed*).

Update the offset when scanning the packet even if we *aren't* building
the protocol tree.

svn path=/trunk/; revision=25068
2008-04-16 07:18:08 +00:00
Stig Bjørlykke 04eb913d71 Call DISSECTOR_ASSERT instead of g_assert in dissector code.
This fixes bug 2464.

svn path=/trunk/; revision=25039
2008-04-15 06:57:56 +00:00
Jeff Morriss 689e8bd855 From http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1539 :
Hexadecimal and octal are unsigned.  Don't let dissectors register signed
fields (FT_INT*) to be displayed in hexadecimal (including HEX_DEC and DEC_HEX)
or octal.  Fix dissectors that do that mostly by changing the fields to
unsigned though in PANA it appears the fields are meant to be signed so
change those fields to be displayed in decimal.

This fixes an assertion crash in hfinfo_numeric_format() if/when someone tries
to create a filter using one of these mixed signed/unsigned fields (because
that routine does not know how to present the user with a signed value in
hex).

Also add FT_*INT64 to the "make sure it's not BASE_NONE" check.

svn path=/trunk/; revision=24643
2008-03-15 22:41:57 +00:00
Jeff Morriss bb323055b2 match_strval() may return NULL so don't blindly pass its return value into col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead.
svn path=/trunk/; revision=24557
2008-03-04 21:05:21 +00:00
Jeff Morriss eb9620376a Fix bug 1908: strengthen the PANA new-style-dissector heuristics by checking that the length of the first AVP is less than the length of the message.
svn path=/trunk/; revision=23167
2007-10-12 21:31:58 +00:00
Jaap Keuter a4f2082eb8 The reserved field is now 16 bits. Treat it as such.
svn path=/trunk/; revision=22585
2007-08-22 13:58:39 +00:00
Jaap Keuter 4533ff34a0 From Victor Fajardo:
Updated patches to support draft-ietf-pana-pana-18.txt.

svn path=/trunk/; revision=22583
2007-08-22 06:59:28 +00:00
Jaap Keuter a9ed13c1d1 Fix reserved bits bitmask.
svn path=/trunk/; revision=22282
2007-07-10 05:15:45 +00:00
Jaap Keuter 0de9abe808 From Victor Fajardo:
Attached is a patch file for the PANA protocol dissector. The changes updates the packet-pana.c dissector to support draft-ietf-pana-pana-15.txt.

svn path=/trunk/; revision=22098
2007-06-14 07:09:07 +00:00
Stephen Fisher 937b925cf5 From Victor Fajardo:
The packet-pana.c dissector I have submitted previously [SVN rev 21447]
had a minor issue. The following are the fixes:
 
Change packet-pana.c, Line 823:

                       { "Ping","pana.flags.e",
 
to:
 
                       { "Error","pana.flags.e",
 

svn path=/trunk/; revision=21731
2007-05-08 19:33:24 +00:00
Jeff Morriss ee73a2aff2 Don't use DISSECTOR_ASSERT to (essentially) verify packet data. Instead
add an expert info entry if the AVP length is 0 and just return after
dissecting that AVP.

svn path=/trunk/; revision=21465
2007-04-18 07:06:56 +00:00
Jeff Morriss 80c7330166 Replace g_assert() with DISSECTOR_ASSERT()
svn path=/trunk/; revision=21448
2007-04-16 09:03:11 +00:00
Jeff Morriss aaf6cfb252 From Victor Fajardo: update the PANA dissector to draft-15a
svn path=/trunk/; revision=21447
2007-04-16 08:53:33 +00:00
Sebastien Tandel 68ad2f4b9b fix MacOSX gcc-3.3 warnings about unused tfs/value_string variables
most have been tagged unused (few have been deleted if dissector has not been
modified since a long time)

move packet-ssl-utils.c to DISSECTOR_SRC


svn path=/trunk/; revision=21431
2007-04-14 14:01:53 +00:00
Jeff Morriss 7e2cb04ebf Fix bug 1511:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1511

by replacing g_assert() with DISSECTOR_ASSERT().


svn path=/trunk/; revision=21366
2007-04-10 14:31:09 +00:00
Ronnie Sahlberg 8ce8e719e0 rename some structures and defines from the se_tree to the emem_tree prefix
svn path=/trunk/; revision=18894
2006-08-14 08:29:29 +00:00
Ronnie Sahlberg b048bbcfe7 add request response tracking and response times
svn path=/trunk/; revision=18738
2006-07-14 23:04:35 +00:00
Ronnie Sahlberg ce5366cc43 dont dissect reserved bits in a bitmap
svn path=/trunk/; revision=18734
2006-07-14 09:40:10 +00:00
Ronnie Sahlberg 48dab097e5 new protocol PANA from
Peter Racz



svn path=/trunk/; revision=18733
2006-07-14 09:17:11 +00:00