b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
7364abf0bc
Typo
...
svn path=/trunk/; revision=43365
2012-06-19 14:46:21 +00:00
85aad38347
Add proto_tree_add_unicode_string() to add UTF-8 string to tree.
...
Convert some proto_tree_add_string_format_value(..., val, "%s", val); to use new function.
svn path=/trunk/; revision=43363
2012-06-19 14:32:24 +00:00
7c59ac0280
Fix bug #7378 : Wireshark 1.8.0rc1: gsm_a_dtap SMS 7-bit default alphabet regression w.r.t. 1.6.8
...
proto_item_add_string() can be only used with ASCII strings.
svn path=/trunk/; revision=43362
2012-06-19 14:25:50 +00:00
a6deef666c
Fix a typo
...
svn path=/trunk/; revision=42805
2012-05-23 06:26:46 +00:00
0ba1ab2909
Display Element ID in hexadecimal (like in 3GPP specs)
...
Display EPS bearer ID in decimal
svn path=/trunk/; revision=42755
2012-05-21 19:27:38 +00:00
d12d5a606c
AFAICT sys/types.h & netinet/in.h #includes are not needed for these files.
...
(Let's see if any of the buildbots give any errors).
Also: remove trailing whitespace on lines.
svn path=/trunk/; revision=42429
2012-05-04 21:29:00 +00:00
5df9055044
Fix a few clang warnings
...
svn path=/trunk/; revision=42343
2012-04-30 08:38:26 +00:00
6163bcfa89
Just use a Boring Old ASCII Dash for hex ranges.
...
svn path=/trunk/; revision=42272
2012-04-26 16:58:30 +00:00
0820e375b0
Prepare to use value_string or range_string.
...
svn path=/trunk/; revision=42267
2012-04-26 16:11:34 +00:00
81c1371d5d
From Evan Huus:
...
Add missing break
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7201
svn path=/trunk/; revision=42265
2012-04-26 15:44:01 +00:00
4a530904f8
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7131 :
...
Always store UDL/length in hash table and check pointer coming from lookup before using it
svn path=/trunk/; revision=42111
2012-04-17 13:17:39 +00:00
a01bf60abf
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6202 :
...
Stop applying a specific treatment when receiving a SMS-DELIVER packet with an unknown direction (no such treatment is done for SMS-SUBMIT).
Store SMS fragment length in hash table to avoid mangling the output when displaying the reassembled SMS.
svn path=/trunk/; revision=42064
2012-04-14 11:56:12 +00:00
f2f11f4a2b
GUINT_TO_POINTER() causes warnings when passed something *shorter* than
...
a guint; cast the argument to guint.
svn path=/trunk/; revision=42051
2012-04-13 19:40:57 +00:00
01b2867f4e
Clean up white space.
...
svn path=/trunk/; revision=42050
2012-04-13 19:36:44 +00:00
25178510bd
Try to fix OSX builds.
...
svn path=/trunk/; revision=42049
2012-04-13 18:27:51 +00:00
6f91bcc65a
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6477 :
...
Use T-User-Data-Length to define the string size decoded with the 7 bits alphabet
svn path=/trunk/; revision=42041
2012-04-13 10:01:38 +00:00
80445e5a99
Fix off by one shift errors introduced in r39530 where it seemed proper[1]
...
[1] I'm unsure of packet-dtpt, so I haven't patch it.
svn path=/trunk/; revision=41873
2012-03-31 20:57:15 +00:00
d7a1840204
Replace use of tvb_get_ephemeral_faked_unicode() by use of tvb_get_ephemeral_unicode_string();
...
Fix encoding arg as needed.
svn path=/trunk/; revision=39530
2011-10-23 22:58:45 +00:00
151acb8fa1
Fix for bug 6469:
...
Retrieve the fill bits in the correct amount and from the correct place.
svn path=/trunk/; revision=39494
2011-10-20 17:49:19 +00:00
5eaad4ecd3
Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
...
svn path=/trunk/; revision=38386
2011-08-07 14:36:19 +00:00
7ad71a2d78
Treat TVBs as opaque: use the accessor functions instead of accessing the fields
...
directly.
svn path=/trunk/; revision=37420
2011-05-27 01:57:33 +00:00
b9a1e3fb2a
Do PROTO_ITEM_SET_GENERATED for two 'proto_item *': Fixes Coverity 914 & 915 [UNUSED]
...
svn path=/trunk/; revision=37245
2011-05-18 17:17:08 +00:00
8ae09e055c
Mark a parameter unused.
...
svn path=/trunk/; revision=35845
2011-02-07 18:05:26 +00:00
47cc39a0bb
Use value_string_ext and ENC_BIG_ENDIAN.
...
svn path=/trunk/; revision=35844
2011-02-07 17:45:49 +00:00
84bc28bd6a
Introduce "Fragment count" filter element for all protocols doing reassembly.
...
svn path=/trunk/; revision=35705
2011-01-30 21:01:07 +00:00
f86b14d820
Replace 2 switch()es with duplicated values (but missing most of the case statements--leading the Sun compiler to complain about most of the statements not being reached) with a value_string and a couple of val_to_str() calls. Also some minor reformatting of the function in question.
...
svn path=/trunk/; revision=35386
2011-01-05 22:17:33 +00:00
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
df48a37c2e
Use correct abbrev for fragment entries.
...
svn path=/trunk/; revision=34547
2010-10-17 18:33:50 +00:00
93b94a23ca
Define some fcns & vars as static; Some #includes not req'd; packet-mikey.h not req'd.
...
svn path=/trunk/; revision=34464
2010-10-10 23:28:40 +00:00
e62b60be7c
Rework SMS reassembly:
...
- Take out the if(tree) because for reassembly to work we need to do the
reassembly on the first pass.
- Remove the (confusing) "try_dissect_message_fragment" preference (which
caused us to dissect the message fragments) and replace it with a "reassembly"
preference. Dissect the message fragments regardless of whether reassembly is
enabled or not (it's just SMS). This solves the user confusion reported in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4232 .
- Add the text of the SMS using proto_tree_add_string*() so that we an filter on
the text.
svn path=/trunk/; revision=32812
2010-05-14 19:27:11 +00:00
10ffd14b8f
Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
...
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
2f9306d05a
GSM SMS PDU TPVPF wrong interpretation.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4524
svn path=/trunk/; revision=31985
2010-02-24 12:41:01 +00:00
539b558f8c
Renamed some reassembled data texts.
...
Removed some check_col().
svn path=/trunk/; revision=31809
2010-02-06 18:20:21 +00:00
88b72356ad
Introduce "Reassembled length" filter element for all protocols doing
...
reassembly.
svn path=/trunk/; revision=31767
2010-02-02 16:01:52 +00:00
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
68cf37f81b
Replace gsm_sms_char_ascii_decode() with gsm_sms_chars_to_utf8(), which
...
returns an ep_allocated string (and whose name reflects that what you
get out is UTF-8, not just ASCII).
svn path=/trunk/; revision=31376
2009-12-28 21:58:43 +00:00
30b31a46bb
Initialize variables which may be used uninitialized.
...
svn path=/trunk/; revision=30536
2009-10-12 14:29:48 +00:00
00810ff199
* Prefer col_append_str instead of col_append_fstr for constant strings
...
* Remove check_col guards
svn path=/trunk/; revision=30127
2009-09-24 20:21:23 +00:00
6c545e0d79
Save some memory: Don't statically allocate ett[] arrays used "dynamically".
...
svn path=/trunk/; revision=29929
2009-09-15 17:37:54 +00:00
17c9803cac
Sanitize epan includes
...
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
8b515e9340
Switch a bunch of dissectors over to using tvb_new_subset_remaining()
...
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
b228488bc0
From Kovarththanan Rajaratnam via bug 3548:
...
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
8611ec5f5e
More size_t casts.
...
svn path=/trunk/; revision=27879
2009-03-29 12:07:30 +00:00
62f60df6b4
From Jakub Zawadzki (bug 3331):
...
g_free() is NULL safe, so we don't need check against it.
svn path=/trunk/; revision=27718
2009-03-13 22:06:48 +00:00
1a5114edf9
Removed an unused variable 'str'.
...
Removed some unused hf_ variables.
svn path=/trunk/; revision=26957
2008-12-10 08:44:13 +00:00
573bdfa36a
From Abhik Sarkar:
...
More HF support for TPDU parameters in the GSM SMS dissector.
svn path=/trunk/; revision=26956
2008-12-10 07:52:27 +00:00
bd08ae7ee6
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26647
2008-10-31 15:11:57 +00:00
95f8f924ca
From Abhik Sarkar:
...
GSM SMS dissector doesn't support filtering based on TPDU parameters.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3012
svn path=/trunk/; revision=26628
2008-10-30 19:50:32 +00:00
Jakub Zawadzki