Commit graph

2130 commits

Author SHA1 Message Date
Jeff Morriss
9be16e49c4 From Stefan Metzmacher and Gregor Beck via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5850 :
The smallest LDAP PDU is 7 bytes, not 4.

svn path=/trunk/; revision=36777
2011-04-21 19:51:05 +00:00
Alexis La Goutte
ec7709406e Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=36771
2011-04-21 16:00:38 +00:00
Alexis La Goutte
7239db18ec Fix Dead Store (Dead nested assignment) Warning found by Clang
svn path=/trunk/; revision=36760
2011-04-21 13:34:22 +00:00
Stephen Fisher
fcfcfa347c Rollback r36614 and change dissect_SMUX_PDUs_PDU() to use previously
unused smux_tree instead of tree.  Per suggestion from Stig on -dev.


svn path=/trunk/; revision=36624
2011-04-13 15:48:24 +00:00
Stephen Fisher
4b416d92d0 Fix Coverity 524: NEGATIVE_RETURNS
Coverity sees that two calls to tvb_length_remaining() with an offset
of 0 may return -1 (for an "out of bounds" condition), which would lead
to an assignment of -1 to an unsigned variable and then passing it
to functions further down that cannot accept negative values.

Use tvb_ensure_length_remaining() to throw an exception in a case of
out of bounds access (though unlikely with an offset of 0) instead of
tvb_length_remaining(), which would return -1.


svn path=/trunk/; revision=36615
2011-04-12 22:23:03 +00:00
Stephen Fisher
ce2eea5b95 Fix Coverity 1047: UNUSED_VALUE in dissect_smux
svn path=/trunk/; revision=36614
2011-04-12 22:12:05 +00:00
Gerald Combs
ca01b3a876 Add x509if_frame_end() which is passed to register_frame_end_routine()
and which resets our global variables. Remove a boolean which was used
to track a char *; just check if the pointer is NULL instead. Fixes bugs
5754 and 5793, hopefully without breaking anything.

svn path=/trunk/; revision=36608
2011-04-12 20:39:48 +00:00
Stig Bjørlykke
b862371815 Removed some unused variables.
svn path=/trunk/; revision=36602
2011-04-12 19:06:51 +00:00
Stig Bjørlykke
42f41ddf0b Corrected switch-case flow.
Coverity 1184.

svn path=/trunk/; revision=36579
2011-04-12 09:05:43 +00:00
Guy Harris
4fdcc5c180 Rename ws_stat to ws_stat64, and make it take a pointer to a ws_statb64
as an argument, along the lines of ws_fstat64, and, on Windows, make it
use _wstati64, to handle 64-bit file sizes.

svn path=/trunk/; revision=36547
2011-04-10 20:59:10 +00:00
Anders Broman
842d4ff53e From Pascal Quantin:
A patch adding the missing hunks (it looks like extract_asn1_from_spec.pl script is mixing Windows and Linux line endings).

svn path=/trunk/; revision=36524
2011-04-08 19:54:07 +00:00
Anders Broman
da3f7673db From Pascal Quantin:
Upgrade LTE RRC ASN.1 description to V9.6.0

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5815

svn path=/trunk/; revision=36520
2011-04-08 17:36:53 +00:00
Gerald Combs
f989235a87 Use a unique variable name. Fixes Coverity CID 593.
svn path=/trunk/; revision=36512
2011-04-07 23:52:37 +00:00
Anders Broman
c039f9f8a8 Add a comment
svn path=/trunk/; revision=36490
2011-04-06 06:24:19 +00:00
Anders Broman
cb0e7f80da Missing decoding for CalledPartyBCD number in CAMEL
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5788

svn path=/trunk/; revision=36488
2011-04-06 06:20:32 +00:00
Stig Bjørlykke
c13f84b345 Compile fix: camel_obj_id -> obj_id.
svn path=/trunk/; revision=36475
2011-04-05 15:49:56 +00:00
Anders Broman
909a166343 Actually get the oid string ...
svn path=/trunk/; revision=36474
2011-04-05 15:43:15 +00:00
Anders Broman
8d6ca293dc Change the signature of elem_fcn():ns to include pinfo.
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
e645e3c4d0 -Whitespace fix in gsm_map-template(no need to regenerate).
- Fix dissection of extensions in INAP it should now be possible to add
an "OID dissector" for extensions.
Should fix BUG
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5799

svn path=/trunk/; revision=36435
2011-04-02 09:18:18 +00:00
Anders Broman
129f07a949 Added FALLTHRU comment to avoid a "missing break" warning.
svn path=/trunk/; revision=36365
2011-03-27 14:02:42 +00:00
Jeff Morriss
cc6fc23812 From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors.
(The SSL dissector was already updated in one of two spots with bug 4535/rev
32456.)

A couple of the patches had to be manually applied.

From me: Fix the comments to match the change (including in the TCP and SSL
dissectors.)

svn path=/trunk/; revision=36332
2011-03-25 19:02:18 +00:00
Gerald Combs
670d38ec71 Properly initialize our filter counters.
svn path=/trunk/; revision=36190
2011-03-14 16:00:51 +00:00
Anders Broman
675d79871e Export SONtransferRequestContaine, SONtransferResponseContainerand and Global-ENB-ID
svn path=/trunk/; revision=36130
2011-03-03 07:20:34 +00:00
Tomas Kukosa
16bdcb2fbe QSIG: decoding of PSS1InformationElement
svn path=/trunk/; revision=36108
2011-03-01 13:01:26 +00:00
Gerald Combs
91fe31c9b4 If we encounter an excessively long filter string or one with too many
elements, add an expert item and throw a ReportedBoundsError. We may
want to handle this more cleanly in the future but this avoids
allocating a huge amount of memory.

svn path=/trunk/; revision=36101
2011-03-01 00:50:17 +00:00
Anders Broman
8ec8d3fcc3 Export:
SONtransferRequestContainer
SONtransferResponseContainer
SONtransferCause

svn path=/trunk/; revision=36086
2011-02-27 21:55:35 +00:00
Anders Broman
23e6582724 Add miisng file from
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=36079

svn path=/trunk/; revision=36085
2011-02-27 19:41:34 +00:00
Anders Broman
da8918838e Add dissection of SonTransfer-IEs.
svn path=/trunk/; revision=36084
2011-02-27 19:40:30 +00:00
Anders Broman
a1e94e7e68 Export SourceCellID.
svn path=/trunk/; revision=36083
2011-02-27 19:39:07 +00:00
Anders Broman
527942b05a Add exports.
svn path=/trunk/; revision=36049
2011-02-24 15:06:16 +00:00
Gerald Combs
4783795690 Split get_dns_name() into get_dns_name() and expand_dns_name().
In dissect_ms_compressed_string() dissect_mscldap_string() simply call
expand_dns_name() instead of using duplicate (and insecure) code. This
*might* break CLDAP and SMB dissection. If that's the case we should
probably revert get_dns_name() and simplify expand_dns_name().

Fixes infinite recursion errors found by joernchen of Phenoelit.

svn path=/trunk/; revision=36029
2011-02-23 00:51:02 +00:00
Stig Bjørlykke
d9ef8f9ad1 Ensure we always have a valid top_tree for p1.content. This fixes a problem
with other dissectors using p1.content, such as p7.

Reset global content_type_id so this will be correct in more cases.
This is still not a good solution, because ContentType and Content are
generic objects which may occur individual in P7.

Indicate when to report invalid content-type.

svn path=/trunk/; revision=36025
2011-02-22 10:23:44 +00:00
Stig Bjørlykke
5868c7d026 Renamed x411 to p1, x420 to p22 and s4406 to p772 to be consistent
on the naming policy for X.400 protocols.

svn path=/trunk/; revision=36013
2011-02-20 17:03:29 +00:00
Stig Bjørlykke
2025f2e5f5 Add changes in r35546 to template and conformation file.
svn path=/trunk/; revision=36010
2011-02-20 15:05:21 +00:00
Stig Bjørlykke
632dcd0d77 Add changes in r35384 to template file.
svn path=/trunk/; revision=36009
2011-02-20 15:03:09 +00:00
Stig Bjørlykke
d3051fa55d Generate correct type (FT_OID) for "x420.compression_algorithm_id".
I suspect this should have been fixed in asn2wrs...

svn path=/trunk/; revision=35965
2011-02-16 11:04:28 +00:00
Jeff Morriss
21cf6ff3ce Remove an unused ett_ variable.
svn path=/trunk/; revision=35927
2011-02-12 03:51:12 +00:00
Chris Maynard
8d47cebd00 Declare ett's as gint, not guint.
svn path=/trunk/; revision=35902
2011-02-10 20:55:26 +00:00
Stig Bjørlykke
1ba57f4c04 Added a dissector table for AttributeId localForm.
Use correct object identifier in ModificationList.

svn path=/trunk/; revision=35894
2011-02-10 10:11:38 +00:00
Anders Broman
553cf70a68 Dissect V1 version , found in trace from:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637

svn path=/trunk/; revision=35843
2011-02-07 17:44:34 +00:00
Anders Broman
55f45d5266 Add a missing IE found in trace from https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5637
svn path=/trunk/; revision=35842
2011-02-07 17:43:26 +00:00
Anders Broman
01ef9f73ef Remove debug printouts.
svn path=/trunk/; revision=35834
2011-02-05 14:37:52 +00:00
Anders Broman
b723ccb30c Introduce preferences to set the strictness of Invoke/response
tracking.

svn path=/trunk/; revision=35822
2011-02-04 16:12:59 +00:00
Anders Broman
06e619bf42 If ENBname is text, append the text.
svn path=/trunk/; revision=35808
2011-02-04 09:38:36 +00:00
Anders Broman
6b38bce9c6 Hope fully this will be the correct set of files - finally.
svn path=/trunk/; revision=35781
2011-02-03 16:17:10 +00:00
Anders Broman
9b0adb69e6 Add a forgotten file
svn path=/trunk/; revision=35778
2011-02-03 08:06:54 +00:00
Anders Broman
77333de278 Start to prettify TimeStamp(to be continued).
svn path=/trunk/; revision=35773
2011-02-02 23:12:34 +00:00
Anders Broman
f02c4d6685 Warning: packet-tetra.c does not have an SVN Id tag.
Error: the blurb for field "Carrier Number" ("tetra.carrier") matches the field name in packet-tetra.c
Error: the blurb for field "PDU" ("tetra.pdu") matches the field name in packet-tetra.c
Error: Found deprecated APIs in packet-tetra.c: dissector_add

svn path=/trunk/; revision=35769
2011-02-02 21:06:51 +00:00
Anders Broman
2395973d17 Integrate and build the tetra dissector.
svn path=/trunk/; revision=35766
2011-02-02 20:11:02 +00:00
Anders Broman
a5d4b6c73b Add gsmcdr to the makefiles.
svn path=/trunk/; revision=35758
2011-02-02 17:10:31 +00:00