Commit Graph

13648 Commits

Author SHA1 Message Date
Anders Broman 23ec82fae9 From Reinhard Speyerer: Adding support for LINKTYPE_PPP_ETHER/DLT_PPP_ETHER
svn path=/trunk/; revision=41256
2012-03-01 07:39:54 +00:00
Anders Broman b28516dc00 From Mike Morrin: A small patch to correct the name of the function proto_tree_add_split_bits_item_ret_val()
svn path=/trunk/; revision=41255
2012-03-01 07:01:15 +00:00
Jeff Morriss 7c55e4513a From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6890 :
The attached patch for the DVB-CI dissector creates a circuit for each DVB-CI
session, using the session number as circuit id.

The DVB-CI session commands are:

- open_session_request(resource_id)
- session_opened(resource_id, newly assigned session number)
- payload transfer(session_number, payload data)
- close session(session_number)

For now, the circuit will store the resource id and make it available (as a
generated item) to subsequent packets that contain only the session number.
Doing this, the resource id (which is like a tcp/udp port) can be used for
filtering.

svn path=/trunk/; revision=41253
2012-03-01 02:50:16 +00:00
Anders Broman 872c2094c4 From Mike Morrin:
The attached patches add the uses
proto_tree_add_split_bits_ret_val()
proto_tree_add_split_bits_crumb()

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6885

svn path=/trunk/; revision=41249
2012-02-29 20:38:39 +00:00
Anders Broman 501216eb8a From Pascal Quantin:
[NAS EPS] Fix description of EPS Attach information element.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6886

svn path=/trunk/; revision=41245
2012-02-29 17:01:57 +00:00
Alexis La Goutte cb90bc1f6b Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41244
2012-02-29 16:55:08 +00:00
Martin Mathieson d5f0b50647 Show number of extensions in header root.
svn path=/trunk/; revision=41229
2012-02-28 19:01:24 +00:00
Anders Broman c503c241c0 Removed one variable to much.
svn path=/trunk/; revision=41222
2012-02-28 08:45:03 +00:00
Anders Broman 2cddd1f72e From Mijo Safradin:
Add ECP VDP TLV dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6849

Fixed encoding arguments, removed unused variables checkapi errors
etc.

svn path=/trunk/; revision=41221
2012-02-28 08:04:24 +00:00
Anders Broman f7deada32b From Sean Bright:
IAX2 trunk packets display misleading call information.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6818

svn path=/trunk/; revision=41220
2012-02-28 07:32:19 +00:00
Anders Broman 9aa9246324 From Josip Medved: EAP-SIM and EAP-AKA are missing some attributes. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6877
svn path=/trunk/; revision=41217
2012-02-28 06:04:02 +00:00
Jeff Morriss 89cfdc3559 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 -
make Save-As/Displayed/All-Packets save not only the displayed packets but
also any other packets needed (e.g., for reassembly) to fully dissect the
displayed packets.

This works only for the "All packets" case; choosing only the Selected packet,
the Marked packets, or a range of packets would require actually storing which
packets depend on which (too much memory) or going through the packet list many
times (too slow).  Also, this behavior is always the case: you can't save the
displayed packets without their dependencies (I don't see why this would be
desirable).

So far this is done for SCTP and things using the reassembly routines (TCP has
been tested).

The Win32 dialog was modified but hasn't been tested yet.

One confusing aspect of the UI is that the Displayed count in the Save-As
dialog does not match the number of displayed packets.  (I tried renaming the
button "Displayed + Dependencies" but it looked too big.)  The tooltip tries
to explain this and the fact that this works only in the All-Packets case;
suggestions for improvement are welcome.


Implementation details:

Dissectors (or the reassembly code) can list frames which were needed to
build the current frame's tree.  If the current frame passes the display
filter then each listed frame is marked as "depended upon" (this takes up the
last free frame_data flag).

When performing a Save-As/Displayed/All-Packets then choose packets which
passed the dfilter _or_ are depended upon.

svn path=/trunk/; revision=41216
2012-02-28 03:19:49 +00:00
Guy Harris 577e286d82 And more details.
svn path=/trunk/; revision=41214
2012-02-27 21:34:59 +00:00
Guy Harris a53d24b480 Give more details in comments.
svn path=/trunk/; revision=41213
2012-02-27 21:33:53 +00:00
Alexis La Goutte 95cc98f92c Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41211
2012-02-27 16:50:27 +00:00
Alexis La Goutte 28f4c55b5b From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6873
USB: SETUP information can be added to incorrect tree

svn path=/trunk/; revision=41210
2012-02-27 16:48:29 +00:00
Alexis La Goutte d97f729ae3 From Alex Rodikov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6871
TPNCP (proprietary Audiocodes) protocol dessector - wrong guint8 value presentation

The presentation of unsigned 8-bit integer is wrong. The (signed) gint8 is used which is displayed as unsigned integer (by proto_tree_add_uint) afterwards.
That causes wrong presentation of valus which bigger than 127.
Solution: New guint8 is introduced to present unsigned 8 bit integer value.

svn path=/trunk/; revision=41209
2012-02-27 16:43:18 +00:00
Anders Broman 210331411a More Warning fixes.
svn path=/trunk/; revision=41207
2012-02-27 12:48:08 +00:00
Anders Broman 8ad3109708 More warning fixes.
svn path=/trunk/; revision=41206
2012-02-27 12:13:06 +00:00
Anders Broman 6734e90b9c Try to fix warning: comparison between signed and unsigned.
svn path=/trunk/; revision=41205
2012-02-27 11:48:38 +00:00
Anders Broman cb46002a19 Fix some unused parameter warnings etc.
svn path=/trunk/; revision=41204
2012-02-27 11:44:19 +00:00
Anders Broman 4811ac8227 Error: Found deprecated APIs in packet-ssl-utils.c: dissector_add
svn path=/trunk/; revision=41203
2012-02-27 10:05:22 +00:00
Anders Broman d272635904 packet-applemidi.c:296:33: error: unused variable ‘p_conv_data’
svn path=/trunk/; revision=41202
2012-02-27 09:49:20 +00:00
Anders Broman 6b2b82d213 From Michael Mann:
a dissector for the ODVA protocol: CIP Safety. More information
about the protocol can be found here: 

http://www.odva.org/Home/ODVATECHNOLOGIES/CIP/CIPTechnologyOverview/CIPSafety/CIPSafetyOverview/tabid/131/lng/en-US/Default.aspx

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6862

svn path=/trunk/; revision=41201
2012-02-27 09:30:26 +00:00
Anders Broman 06cee2dfe3 From Tobias Erichsen:
RTP-MIDI - dissector for transmission of MIDI-commands via RTP (RFC 4695).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5451

svn path=/trunk/; revision=41200
2012-02-27 09:18:53 +00:00
Michael Tüxen f71f3decb6 Dissect SSH over SCTP when using the IANA assigned SCTP port 22.
svn path=/trunk/; revision=41197
2012-02-26 17:54:32 +00:00
Jörg Mayer 1e61547b45 Harald Welte <laforge@gnumonks.org>
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6792

This is a new dissector for the non-standard Ericsson OM2000 protocol, as it is
used for the OML on A-bis of Ericsson RBS 2xxx BTSs.

It also includes a dissector for a shim-layer protocol that Ericsson uses for
IP-based A-bis like the RBS 2409.  As the protocol is not publicly documented,
I have invented the name "EHDLC" (Ericsson HLDC) for it.


svn path=/trunk/; revision=41195
2012-02-26 17:30:38 +00:00
Anders Broman f97ad44031 Add entry for TPDU in the tree
svn path=/trunk/; revision=41194
2012-02-26 17:10:40 +00:00
Michael Tüxen e929fdfdee From Robin Seggelmann: Add support for RFC 6520.
From me: Some cleanup
Initial work was done by Denis Jaeger and
Lukas Scharlau, but the code got rewritten by Robin.

svn path=/trunk/; revision=41189
2012-02-26 13:50:52 +00:00
Guy Harris b6ff142f60 Add a presence flag field to the packet information structure filled in
by Wiretap, to indicate whether certain fields in that structure
actually have data in them.

Use the "time stamp present" flag to omit showing time stamp information
for packets (and "packets") that don't have time stamps; don't bother
working very hard to "fake" a time stamp for data files.

Use the "interface ID present" flag to omit the interface ID for packets
that don't have an interface ID.

We don't use the "captured length, separate from packet length, present"
flag to omit the captured length; that flag might be present but equal
to the packet length, and if you want to know if a packet was cut short
by a snapshot length, comparing the values would be the way to do that.

More work is needed to have wiretap/pcapng.c properly report the flags,
e.g. reporting no time stamp being present for a Simple Packet Block.

svn path=/trunk/; revision=41185
2012-02-25 23:24:34 +00:00
Bill Meier 605dea0486 CVARSDLL hasn't been used (is undefined) for a while....
svn path=/trunk/; revision=41180
2012-02-24 16:23:38 +00:00
Anders Broman 2b815454e7 From Martin Kaiser:
Get rid of an unused variable.

svn path=/trunk/; revision=41177
2012-02-24 14:40:31 +00:00
Alexis La Goutte c45a941597 From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6838
Support HDCP version 1 over I2c

the attached patch adds support for HDCP version 1. This is the authentication that runs between your DVD/Bluray player and your TV when they're connected via an HDMI cable.

svn path=/trunk/; revision=41173
2012-02-24 08:18:30 +00:00
Alexis La Goutte fc88f5558a From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6838
Support HDCP version 1 over I2c

the attached patch adds support for HDCP version 1. This is the authentication that runs between your DVD/Bluray player and your TV when they're connected via an HDMI cable.

svn path=/trunk/; revision=41172
2012-02-24 07:57:48 +00:00
Anders Broman 1b6a35348b From Robert Shade: Mobile IP NVSE (RFC3115) Decoding https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6868
svn path=/trunk/; revision=41171
2012-02-24 05:50:47 +00:00
Anders Broman a062fb34bd From Pascal Quantin [NAS EPS] Update Configuration Protocol description in PCO IE https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6865
svn path=/trunk/; revision=41166
2012-02-23 20:24:40 +00:00
Anders Broman 59ce037134 Fix a 3GPP specification error.
svn path=/trunk/; revision=41161
2012-02-23 13:10:59 +00:00
Anders Broman 416117f63a From Steve Magnani:
USB: Add dissection for Interface Association descriptor.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6842

svn path=/trunk/; revision=41157
2012-02-23 11:20:52 +00:00
Anders Broman 9d545467ef From Tyson Key:
Clean up redundant Data handlers in the CCID dissector.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6860

svn path=/trunk/; revision=41156
2012-02-23 11:14:57 +00:00
Martin Mathieson 51c31cd7bd Move 'static' qualifier before 'const' in a couple of places. I didn't
know it mattered, but gcc warns.

svn path=/trunk/; revision=41155
2012-02-23 11:03:30 +00:00
Martin Mathieson 774be29de0 Mark some unused parameters. Still getting other warnings...
svn path=/trunk/; revision=41154
2012-02-23 10:55:57 +00:00
Anders Broman 1a42f455a5 From Tyson Key:
Support for switching USB CCID PC_to_RDR_XfrBlock payload dissectors

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6853

svn path=/trunk/; revision=41151
2012-02-23 09:12:30 +00:00
Anders Broman f77e059a2e From Yaniv Kaul:
Enhance the Spice dissector - small additional dissections.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6857

svn path=/trunk/; revision=41150
2012-02-23 09:06:33 +00:00
Anders Broman dea5452b95 From Lei Chen:
a patch to support decode FDD_CELL_INFORMATION of "UTRAN FDD Description" in packet-gsm_rlcmac.c

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6856

svn path=/trunk/; revision=41149
2012-02-23 08:57:40 +00:00
Anders Broman 2a35f59066 From Jeff Morriss:
H223: Buildbot crash output: fuzz-2012-01-25-22599.pcap

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6768

svn path=/trunk/; revision=41148
2012-02-23 08:40:23 +00:00
Bill Meier 81d3b58f02 Whitespace cleanup: Convert 4 space tabs to spaces ...
svn path=/trunk/; revision=41139
2012-02-22 15:47:30 +00:00
Bill Meier 397d29e83b Rename some enumeration constants; Do some minor code simplification & reformatting.
svn path=/trunk/; revision=41138
2012-02-22 15:42:50 +00:00
Alexis La Goutte d9a4d939b3 Reverse Revision 41134 (Need to fix error/warning before...)
svn path=/trunk/; revision=41135
2012-02-22 09:18:30 +00:00
Anders Broman ad360ce0dd From Lars Ruoff:
Dissector for Alcatel-Lucent Enterprise Universal Alcatel- and NOE protocol
families.
Meant as a replacement for existing UA-dissector in trunk because of better
feature set:
- latest protocol specifiaction
- more detailed dissection and filtering possibilities on subprotocols
- RTP stream setup
- NOE over SIP

Lars Ruoff
On behalf of Alcatel-Lucent Enterprise

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6844

svn path=/trunk/; revision=41134
2012-02-22 08:37:46 +00:00
Anders Broman 5bc3ad3cf7 From Lori Tribble:
BACnet: Allow vendor specified network layer messages.'

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6852

svn path=/trunk/; revision=41120
2012-02-21 16:43:20 +00:00