the fuzz bot (see https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6898 and
all of its duplicates--and the bugs marked as duplicates of those duplicates).
Halving the packet size seems to work for most of the captures I've tried;
we'll see if the buildbot agrees.
If someone can figure out a good way to control the memory usage of this
dissector then the limit could be increased again.
svn path=/trunk/; revision=49321
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).
Use a consistent coding style, and make proper use of the WS_DLL_* defines.
Group the functions appropriately in the header.
I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
svn path=/trunk/; revision=48634
as handling the application/x-amf media type.
Add support for dissecting AMF3.
Dissect AMF0 dates as milliseconds-since-the-Epoch.
Dissect AMF0 typed objects.
Add URLs for various Adobe specs for RTMP, AMF0 and AMF3.
svn path=/trunk/; revision=46047
In some cases:
Use val_to_str_const() instead of val_to_str();
Reformat long lines;
Do some general whitespace changes.
svn path=/trunk/; revision=41587
1. If there's no character encoding (ENC_ASCII, ...) specified
then use ENC_ASCII.
2. For all but FT_UINT_STRING, always use ENC_NA
(replacing any existing True/1/FALSE/0
/ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).
svn path=/trunk/; revision=39426
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
"
The [...] variable rtmpt_audio_codecs should be enhanced.
According to [Flash Developer's Guide]
10 = HE-AAC and 11 = Speex are missing.
There is also [Adobe "RTMP Specification V1.0]
which additionally lists 3 = INTEL (not used), 7 = G711A, 8 = G711U
and 9 = NellyMoser 16kHz.
"
From me: All but 'Intel (not used)' added to the list of audio codecs
svn path=/trunk/; revision=36073
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
Improve RTMP dissection:
* Handle multi-byte csids
* Handle extended timestamps
* Better timestamp defaulting/calculations
* Dechunking should now cope with any clean high quality capture without
error (still loses sync on missing/out of order packets, but that's
very hard to deal with)
* Dissect tunnelled RTMPT
* Dissect more packet types
* Dissect more AMF0 data types
* Dissect audio/video control information
* Use official packet/type names
* Several new fields
* Function call/response frame linking
* Push several useful bits of data up the dissection tree or into the
info column for ease of use
svn path=/trunk/; revision=34720
Chunks handled individually rather than as complete messages which have
the risk of being fragmented and unrecognizable.
Added FLV data type.
Allow simultaneous RTMP streams to be handled independently.
svn path=/trunk/; revision=29069
Jakub Zawadzki