Commit Graph

56 Commits

Author SHA1 Message Date
Jakub Zawadzki 1899903f69 Include <epan/to_str.h> only when needed.
svn path=/trunk/; revision=53189
2013-11-09 13:41:10 +00:00
Bill Meier 9874da2fcb #if 0 numerous "unused const variables" (mostly value-string-arrays);
Also; fix a few "set but not used" warnings.

svn path=/trunk/; revision=52780
2013-10-23 06:29:11 +00:00
Chris Maynard ac7ecb10d2 More dissector table name related changes (a continuation of r51904).
svn path=/trunk/; revision=51982
2013-09-12 20:34:19 +00:00
Alexis La Goutte e48f3cd707 Use 2 Spaces indent and add modelines info
svn path=/trunk/; revision=50624
2013-07-15 18:04:53 +00:00
Alexis La Goutte 2aa451859a Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=50619
2013-07-15 18:04:03 +00:00
Guy Harris b125950d9a Fix typo found by a compiler warning.
svn path=/trunk/; revision=50514
2013-07-11 21:53:19 +00:00
Anders Broman 5dec6b5603 From Tommy Wu:
Add 3gpp2_cvse.

svn path=/trunk/; revision=50512
2013-07-11 21:12:31 +00:00
Anders Broman ed0861abaa Add 3gpp2_type16.
svn path=/trunk/; revision=49147
2013-05-03 17:34:49 +00:00
Alexis La Goutte a376f3b5d1 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=48897
2013-04-17 19:36:49 +00:00
Anders Broman 8e1b0ac304 Register a dissector table for Normal Vendor/Organization Specific Extension(NVSE) and use it for 3GPP2.
svn path=/trunk/; revision=48623
2013-03-28 16:55:06 +00:00
Bill Meier 959ae3d687 Use '#if 0 ... #endif' rather than /** ... **/ to comment out
unused hf[] entries (which I should have done in the first place).


svn path=/trunk/; revision=47391
2013-01-31 18:35:06 +00:00
Bill Meier c929e42eb4 Fix various instances of unused hf[] entries found
by checkhf.

svn path=/trunk/; revision=47312
2013-01-26 22:43:34 +00:00
Chris Maynard a753eaaea0 Use tvb_reported_length to skip past all the bytes in the tvb.
svn path=/trunk/; revision=45777
2012-10-24 20:31:09 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II.
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Bill Meier d53320919a Remove unneeded #includes (stdlib, stdio, ctypes, time);
In a few cases: do some whitespace, indentation cleanup & reformatting.

svn path=/trunk/; revision=42632
2012-05-15 19:23:35 +00:00
Jakub Zawadzki e2c680b245 Fix some "conflicting" value_string warnings.
copy & paste errors, not 0-terminated value_string arrays, etc.

svn path=/trunk/; revision=42260
2012-04-26 14:41:37 +00:00
Anders Broman 2b815454e7 From Martin Kaiser:
Get rid of an unused variable.

svn path=/trunk/; revision=41177
2012-02-24 14:40:31 +00:00
Anders Broman 1b6a35348b From Robert Shade: Mobile IP NVSE (RFC3115) Decoding https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6868
svn path=/trunk/; revision=41171
2012-02-24 05:50:47 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier 17c47d3078 Fix several cases wherein proto_tree_add_uint() was intended iso proto_tree_add_item();
One case would have caused display of a FT_UINT16 field with the wrong endianness.

svn path=/trunk/; revision=39358
2011-10-11 14:49:09 +00:00
Bill Meier 0a94d852e4 Revert SVN #39347; There's a better way.
svn path=/trunk/; revision=39357
2011-10-11 14:31:01 +00:00
Bill Meier f96f3faf27 Fix additiuonal bugs in some proto_tree_add_item() 'encoding' args;
Two of the bugs would appear to have caused display of a FT_UINT16 field with
 the wrong endianness.

svn path=/trunk/; revision=39347
2011-10-10 21:46:19 +00:00
Bill Meier f2ee4a9303 Fix benign bug in some proto_tree_add_item() 'encoding' args;
Use consistent indentation.

svn path=/trunk/; revision=39346
2011-10-10 21:29:10 +00:00
Bill Meier 67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
2011-10-10 00:39:31 +00:00
Bill Meier 4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Jeff Morriss 045037dc71 Add NTP times using proto_tree_add_item().
svn path=/trunk/; revision=35876
2011-02-08 03:16:35 +00:00
Jeff Morriss 6cfdeed280 Replace ip_to_str((tvb_get_ptr(...)) with tvb_ip_to_str().
Replace ip6_to_str((tvb_get_ptr(...)) with tvb_ip6_to_str().

There's no need to pass the result of tvb_get_ptr() as the 'value' in
proto_tree_add_*(): just use proto_tree_add_item().

Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s.

Replace some memcpy()+tvb_get_ptr() with tvb_memcpy().

svn path=/trunk/; revision=35529
2011-01-14 03:44:58 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Bill Meier 7219ee2a49 Use val_to_str_ext() & friends to access sminmpec_values[];
Also: packet-nhrp.c: #include sminmpec.h not req'd;

svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
Bill Meier 055dd62063 #include <string.h> not needed.
svn path=/trunk/; revision=32410
2010-04-06 21:14:01 +00:00
Bill Meier 09764dd969 Remove unneeded #include <stdio.h>
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Guy Harris deccd41b15 No need for cvse_reserved as a variable; getting rid of it squelches a
compiler warning.

svn path=/trunk/; revision=31854
2010-02-10 08:20:55 +00:00
Anders Broman 8f5b2d749b Define VENDOR_VERIZON in sminmpec.h
svn path=/trunk/; revision=31853
2010-02-10 07:21:51 +00:00
Anders Broman 047f688a5c From yi ren:
CVSE fields for MIP protocol is not correctly decoded.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4477
From me:
- Fixed hf blurbs.
- FT_BYTES, BASE_NONE
- Updated value_strings from IANA registery.

svn path=/trunk/; revision=31852
2010-02-10 06:59:26 +00:00
Jaap Keuter 3cb9c84da1 From Martin Willi:
The attached patch fixes the check for types with the long extension format and re-enables it.

svn path=/trunk/; revision=31244
2009-12-11 17:18:00 +00:00
Anders Broman 4d2e653901 From Didier Gautheron:
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107

svn path=/trunk/; revision=30415
2009-10-09 07:24:33 +00:00
Kovarththanan Rajaratnam 8b515e9340 Switch a bunch of dissectors over to using tvb_new_subset_remaining()
svn path=/trunk/; revision=29446
2009-08-16 12:36:22 +00:00
Kovarththanan Rajaratnam 0a5b014cec Don't guard col_clear with col_check
svn path=/trunk/; revision=29344
2009-08-09 07:36:13 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29340
2009-08-09 06:26:46 +00:00
Jörg Mayer 5cd78e2625 OK, nobody cared about the waring, so just remove the
test for now.

svn path=/trunk/; revision=28958
2009-07-06 17:44:02 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier d6a5a7c761 P64 changes: Fix some cases for which size_t is not required
svn path=/trunk/; revision=27822
2009-03-22 20:55:31 +00:00
Anders Broman bd72a48963 From Munenori Ohuchi:
Enhacement to support 'WiMAX Forum/3GPP2 Proxy Mobile IPv4'.

svn path=/trunk/; revision=27770
2009-03-18 07:36:53 +00:00
Bill Meier c0e92cbc04 Fix various typos and spelling errors (mostly in text strings)
svn path=/trunk/; revision=27065
2008-12-20 00:09:02 +00:00
Gerald Combs 6d04f793f0 Back out r27047 and r27053.
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs fc71188963 Update calls to proto_tree_add_bytes_format to reflect r27047.
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Sebastien Tandel 028a7cf638 From Ville Nuorvala :
adds support for the following RFCs (and RFC-to-be):
  - RFC 3519 Mobile IP Traversal of Network Address Translation (NAT) Devices
  - RFC 3543 Registration Revocation in Mobile IPv4
  - RFC 4433 Mobile IPv4 Dynamic Home Agent (HA) Assignment (including the not
      yet published errata about the message extension using the short message
      extension format)
  - draft-ietf-mip4-message-string-ext Mobile IPv4 Message String Extension


svn path=/trunk/; revision=21948
2007-05-26 01:01:27 +00:00