Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that?
Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one.
svn path=/trunk/; revision=53198
The original intent was to just deal with struct tcpinfo data, but after finding it was unnecessary (and somewhat limited dissection in COL_INFO), I took the cleanup a little farther. Sample traces from wiki and bug 5956 were very helpful in proving I didn't break anything.
svn path=/trunk/; revision=53025
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
packet-knet.c:466:5: error: '@return' command used in a comment that is attached
to a function returning void [-Werror,-Wdocumentation]
* @return void
~^~~~~~~~~~~
packet-knet.c:518:5: error: '@return' command used in a comment that is attached
to a function returning void [-Werror,-Wdocumentation]
* @return void
~^~~~~~~~~~~
packet-knet.c:677:5: error: '@return' command used in a comment that is attached
to a function returning void [-Werror,-Wdocumentation]
* @return void
~^~~~~~~~~~~
packet-knet.c:697:5: error: '@return' command used in a comment that is attached
to a function returning void [-Werror,-Wdocumentation]
* @return void
~^~~~~~~~~~~
packet-knet.c:717:5: error: '@return' command used in a comment that is attached
to a function returning void [-Werror,-Wdocumentation]
* @return void
~^~~~~~~~~~~
packet-knet.c:731:5: error: '@return' command used in a comment that is attached
to a function returning void [-Werror,-Wdocumentation]
* @return void
~^~~~~~~~~~~
svn path=/trunk/; revision=51269
- Remove unneeded #includes;
- Use val_to_str_const() in several places;
- Reformat long lines;
- Fix whitepace and indentation.
svn path=/trunk/; revision=40016
kNet (KristalliNet) dissector for Wireshark
kNet is a connection-oriented network protocol for transmitting arbitrary application-specific messages between network hosts. It is designed primarily for applications that require a method for rapid space-efficient real-time communication. kNet is an application-level protocol which can be ran either over UDP, TCP or SCTP transports.
From me :
* Add Modelines information and fix trailing whitespace
* Merge packet-knet.h in packet-knet.c
* Make Checkhf happy
* Fix Clang/GCC Warning about unused variable
* Add Authors info & CMakeList.txt
svn path=/trunk/; revision=40010